ndepend
report summary
application nameeShopOnWeb v2019 (v1.0.0.0)report build date10-17-2019 11:27:59analysis duration00:11ndepend
version
2019.3.0 Professional Developer/Build-Machine Editionbaseline for comparisonCompare with project {eShopOnWeb v2018} most recent analysis result (analysis result obtained on 2019 October - 17 Thursday 11:06)code coverage data
Loaded! Code Coverage metrics, Queries and Rules relative to code Coverage, can be used.
Get started.Quick tips.Back to NDepend.
The present HTML report is a summary of data gathered by the analysis.
It is recommended to use the NDepend interactive UI capabilities
to make the most of NDepend by mastering all aspects of your code.
It is recommended to use the NDepend interactive UI capabilities
to make the most of NDepend by mastering all aspects of your code.
Diagrams
Application Metrics
Note: Further Application Statistics are available.
|
Quality Gates summary
317
Some Quality Gates fail. The buildcan be stopped upon quality gate
failure. Online documentation.
Quality Gates that measure diff cannotbe run on the baseline. Hence they
have blank trend and baseline value.
| Name | Trend | Baseline Value | Value | Group | |||
|---|---|---|---|---|---|---|---|
|  |  15.95 % | 32.67 % | Project Rules \ Quality Gates | |||
| 47.31 % | Project Rules \ Quality Gates | |||||
| 44.65 % | Project Rules \ Quality Gates | |||||
|  |  0 issues | 0 issues | Project Rules \ Quality Gates | |||
| | 0 issues | 0 issues | Project Rules \ Quality Gates | |||
| 121 issues | Project Rules \ Quality Gates | |||||
|  | 2 rules | 6 rules | Project Rules \ Quality Gates | |||
| | 19.61 % |  23.09 % | Project Rules \ Quality Gates | |||
| -1.32 man-days | Project Rules \ Quality Gates | |||||
| | 13 namespaces | 13 namespaces | Project Rules \ Quality Gates | |||
| 4.54 man-days | Project Rules \ Quality Gates |
Rules summary
114326- Number of Rules or Queries with Error (syntax error, exception thrown, time-out): 0
- Number of Rules violated: 38
Rules can be checked live atdevelopment-time, from within Visual
Studio. Online documentation.
Rules that rely on diff cannot berun on the baseline. Hence they
have blank # Issues Fixed or Added.
| Name | # Issues | Added | Fixed | Elements | Group | |||
|---|---|---|---|---|---|---|---|---|
| 1 | 0 | 0 | type | Project Rules \ Code Smells | |||
| 15 | types | Project Rules \ Code Smells Regression | |||||
| 2 | methods | Project Rules \ Code Smells Regression | |||||
| 4 | types | Project Rules \ Code Smells Regression | |||||
| 2 | 1 | 0 | types | Project Rules \ Object Oriented Design | |||
| 10 | 4 | 2 | methods | Project Rules \ Object Oriented Design | |||
| 2 | 1 | 0 | methods | Project Rules \ Object Oriented Design | |||
| 1 | 0 | 0 | type | Project Rules \ Object Oriented Design | |||
| 13 | 5 | 3 | namespaces | Project Rules \ Design | |||
| 1 | 1 | 12 | type | Project Rules \ Design | |||
| 2 | 1 | 0 | types | Project Rules \ Architecture | |||
| 2 | 1 | 0 | namespaces | Project Rules \ Architecture | |||
| 1 | 0 | 1 | assembly | Project Rules \ Architecture | |||
| 9 | types | Project Rules \ API Breaking Changes | |||||
| 15 | methods | Project Rules \ API Breaking Changes | |||||
| 1 | field | Project Rules \ API Breaking Changes | |||||
| 3 | types | Project Rules \ API Breaking Changes | |||||
| 238 | 50 | 350 | methods | Project Rules \ Code Coverage | |||
| 40 | methods | Project Rules \ Code Coverage | |||||
| 4 | methods | Project Rules \ Code Coverage | |||||
| 21 | 7 | 7 | code elements parent | Project Rules \ Code Coverage | |||
| 2 | 1 | 0 | types | Project Rules \ Code Coverage | |||
| 1 | 1 | 0 | namespace | Project Rules \ Code Coverage | |||
| 27 | 14 | 1 | types | Project Rules \ Code Coverage | |||
| 4 | 1 | 3 | methods | Project Rules \ Code Coverage | |||
| 4 | 0 | 0 | methods | Project Rules \ Dead Code | |||
| 3 | 2 | 3 | fields | Project Rules \ Visibility | |||
| 1 | 0 | 0 | field | Project Rules \ Immutability | |||
| 1 | 0 | 0 | field | Project Rules \ Immutability | |||
| 4 | 4 | 8 | fields | Project Rules \ Naming Conventions | |||
| 1 | 0 | 1 | type | Project Rules \ Naming Conventions | |||
| 4 | 3 | 1 | types | Project Rules \ Naming Conventions | |||
| 2 | 1 | 3 | types | Project Rules \ Naming Conventions | |||
| 4 | 0 | 2 | types | Project Rules \ Source Files Organization | |||
| 2 | 0 | 0 | namespaces | Project Rules \ Source Files Organization | |||
| 1 | 0 | 0 | namespace | Project Rules \ Source Files Organization | |||
| 21 | 21 | 0 | methods | Project Rules \ .NET Framework Usage \ System | |||
| 3 | 1 | 0 | methods | Project Rules \ .NET Framework Usage \ System.Collections |
Application Statistics
| Stat | # Occurences | Avg | StdDev | Max |
|---|---|---|---|---|
| Properties on interfaces | 12 interfaces | 0.67 | 2.21 | 8 properties on Microsoft.eShopWeb.ApplicationCore.Interfaces.ISpecification<T> |
| Methods on interfaces | 12 interfaces | 2.58 | 2.53 | 8 methods on Microsoft.eShopWeb.ApplicationCore.Interfaces.ISpecification<T> |
| Arguments on methods on interfaces | 31 methods | 1.06 | 1.11 | 4 arguments on Microsoft.eShopWeb.ApplicationCore.Interfaces.IBasketService.AddItemToBasket(Int32,Int32,Decimal,Int32) |
| Public properties on classes | 109 Classes | 2.13 | 2.55 | 15 public properties on <>f__AnonymousType7<<Id>j__TPar,<AccessFailedCount>j__TPar,<ConcurrencyStamp>j__TPar,<Email>j__TPar,<EmailConfirmed>j__TPar,<LockoutEnabled>j__TPar,<LockoutEnd>j__TPar,<NormalizedEmail>j__TPar,<NormalizedUserName>j__TPar,<PasswordHash>j__TPar,<PhoneNumber>j__TPar,<PhoneNumberConfirmed>j__TPar,<SecurityStamp>j__TPar,<TwoFactorEnabled>j__TPar,<UserName>j__TPar> |
| Public methods on classes | 109 classes | 5.59 | 4.26 | 22 public methods on Microsoft.eShopWeb.Web.Controllers.ManageController |
| Arguments on public methods on classes | 609 methods | 0.68 | 1.21 | 15 arguments on <>f__AnonymousType7<<Id>j__TPar,<AccessFailedCount>j__TPar,<ConcurrencyStamp>j__TPar,<Email>j__TPar,<EmailConfirmed>j__TPar,<LockoutEnabled>j__TPar,<LockoutEnd>j__TPar,<NormalizedEmail>j__TPar,<NormalizedUserName>j__TPar,<PasswordHash>j__TPar,<PhoneNumber>j__TPar,<PhoneNumberConfirmed>j__TPar,<SecurityStamp>j__TPar,<TwoFactorEnabled>j__TPar,<UserName>j__TPar>..ctor(<Id>j__TPar,<AccessFailedCount>j__TPar,<ConcurrencyStamp>j__TPar,<Email>j__TPar,<EmailConfirmed>j__TPar,<LockoutEnabled>j__TPar,<LockoutEnd>j__TPar,<NormalizedEmail>j__TPar,<NormalizedUserName>j__TPar,<PasswordHash>j__TPar,<PhoneNumber>j__TPar,<PhoneNumberConfirmed>j__TPar,<SecurityStamp>j__TPar,<TwoFactorEnabled>j__TPar,<UserName>j__TPar) |
| IL instructions in non-abstract methods | 689 methods | 41.88 | 108.54 | 1332 IL instructions in Microsoft.eShopWeb.Infrastructure.Identity.Migrations.InitialIdentityModel.Up(MigrationBuilder) |
| Cyclomatic complexity on non abstract Methods | 689 Methods | 3.13 | 5.41 | CC = 31 for <>f__AnonymousType7<<Id>j__TPar,<AccessFailedCount>j__TPar,<ConcurrencyStamp>j__TPar,<Email>j__TPar,<EmailConfirmed>j__TPar,<LockoutEnabled>j__TPar,<LockoutEnd>j__TPar,<NormalizedEmail>j__TPar,<NormalizedUserName>j__TPar,<PasswordHash>j__TPar,<PhoneNumber>j__TPar,<PhoneNumberConfirmed>j__TPar,<SecurityStamp>j__TPar,<TwoFactorEnabled>j__TPar,<UserName>j__TPar>.ToString() |
Assemblies Metrics
If you wish to define thresholds on assemblies' Code Metrics, consider writing some Rules.
Clicking column header arrows sorts values.
Clicking column header title text redirect to the online Code Metric definition.
Clicking column header arrows sorts values.
Clicking column header title text redirect to the online Code Metric definition.
| Assemblies | # lines of code | # IL instruction | # Types | # Abstract Types | # lines of comment | % Comment | % Coverage | Afferent Coupling | Efferent Coupling | Relational Cohesion | Instability | Abstractness | Distance |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| ApplicationCore v1.0.0.0 | 228 | 2417 | 35 | 11 | 21 | 8.43 | 69.3 | 17 | 15 | 1.91 | 0.47 | 0.31 | 0.15 |
| Infrastructure v1.0.0.0 | 575 | 12342 | 33 | 0 | 20 | 3.36 | 15.48 | 8 | 94 | 0.79 | 0.92 | 0 | 0.06 |
| Web v1.0.0.0 | 804 | 14099 | 53 | 2 | 43 | 5.08 | 34.58 | 0 | 273 | 1.17 | 1 | 0.04 | 0.03 |
If you wish to define thresholds on types' Code Metrics, consider writing some Rule.
Clicking column header arrows sorts values.
Clicking column header title text redirect to the online Code Metric definition.
Types Metrics : Code Quality
| Type Name | Type Rank | # Lines Of Code | # IL Instructions | # Lines Of Comment | % Comment | Cyclomatic Complexity | IL Cyclomatic Complexity | % Coverage | Afferent Coupling | Efferent Coupling | Type Namespace |
|---|---|---|---|---|---|---|---|---|---|---|---|
| BaseEntity | 25.67 | 2 | 11 | 0 | 0 | 2 | 3 | 100 | 17 | 0 | Microsoft.eShopWeb.ApplicationCore .Entities |
| ISpecification<T> | 10.11 | - | - | - | - | - | - | - | 12 | 1 | Microsoft.eShopWeb.ApplicationCore .Interfaces |
| Address | 5.17 | 17 | 65 | 0 | 0 | 12 | 12 | 100 | 7 | 0 | Microsoft.eShopWeb.ApplicationCore .Entities.OrderAggregate |
| IEmailSender | 3.86 | - | - | - | - | - | - | - | 4 | 0 | Microsoft.eShopWeb.ApplicationCore .Interfaces |
| IAsyncRepository<T> | 2.99 | - | - | - | - | - | - | - | 9 | 1 | Microsoft.eShopWeb.ApplicationCore .Interfaces |
| CatalogItemOrdered | 2.85 | 14 | 60 | 1 | 6.67 | 8 | 8 | 100 | 4 | 3 | Microsoft.eShopWeb.ApplicationCore .Entities.OrderAggregate |
| Order | 2.71 | 26 | 110 | 9 | 25.71 | 11 | 13 | 96.15 | 6 | 7 | Microsoft.eShopWeb.ApplicationCore .Entities.OrderAggregate |
| IAggregateRoot | 2.69 | - | - | - | - | - | - | - | 3 | 0 | Microsoft.eShopWeb.ApplicationCore .Interfaces |
| IUriComposer | 2.29 | - | - | - | - | - | - | - | 7 | 0 | Microsoft.eShopWeb.ApplicationCore .Interfaces |
| Basket | 2.26 | 11 | 86 | 0 | 0 | 8 | 10 | 100 | 6 | 4 | Microsoft.eShopWeb.ApplicationCore .Entities.BasketAggregate |
| BasketItem | 2.21 | 6 | 25 | 0 | 0 | 6 | 7 | 100 | 5 | 1 | Microsoft.eShopWeb.ApplicationCore .Entities.BasketAggregate |
| CatalogType | 2 | 2 | 11 | 0 | 0 | 2 | 3 | 100 | 4 | 1 | Microsoft.eShopWeb.ApplicationCore .Entities |
| CatalogBrand | 2 | 2 | 11 | 0 | 0 | 2 | 3 | 100 | 4 | 1 | Microsoft.eShopWeb.ApplicationCore .Entities |
| OrderItem | 1.77 | 11 | 43 | 1 | 8.33 | 8 | 8 | 100 | 6 | 2 | Microsoft.eShopWeb.ApplicationCore .Entities.OrderAggregate |
| ApplicationUser | 1.77 | 0 | 4 | - | - | - | 1 | - | 10 | 2 | Microsoft.eShopWeb.Infrastructure .Identity |
| CatalogSettings | 1.77 | 2 | 11 | 0 | 0 | 2 | 3 | 100 | 2 | 0 | Microsoft.eShopWeb |
| BasketViewModel | 1.65 | 9 | 54 | 0 | 0 | 9 | 10 | 88.89 | 5 | 14 | Microsoft.eShopWeb.Web.Pages.Basket |
| CatalogItem | 1.49 | 16 | 60 | 0 | 0 | 16 | 17 | 100 | 7 | 3 | Microsoft.eShopWeb.ApplicationCore .Entities |
| BasketNotFoundException | 1.34 | 4 | 29 | 0 | 0 | 4 | 4 | 25 | 1 | 0 | Microsoft.eShopWeb.ApplicationCore .Exceptions |
| BaseSpecification<T> | 1.27 | 25 | 101 | 0 | 0 | 19 | 19 | 80 | 4 | 2 | Microsoft.eShopWeb.ApplicationCore .Specifications |
| CatalogIndexViewModel | 1.25 | 12 | 46 | 0 | 0 | 12 | 13 | 100 | 5 | 10 | Microsoft.eShopWeb.Web.ViewModels |
| CatalogContext | 0.94 | 48 | 651 | 0 | 0 | 22 | 22 | 95.83 | 5 | 36 | Microsoft.eShopWeb.Infrastructure.Data |
| IAppLogger<T> | 0.93 | - | - | - | - | - | - | - | 5 | 1 | Microsoft.eShopWeb.ApplicationCore .Interfaces |
| CatalogItemViewModel | 0.7 | 8 | 32 | 0 | 0 | 8 | 9 | 100 | 3 | 7 | Microsoft.eShopWeb.Web.ViewModels |
| PaymentMethod | 0.68 | 6 | 25 | 1 | 14.29 | 6 | 7 | 0 | 1 | 1 | Microsoft.eShopWeb.ApplicationCore .Entities.BuyerAggregate |
| ICatalogViewModelService | 0.67 | - | - | - | - | - | - | - | 5 | 6 | Microsoft.eShopWeb.Web.Services |
| BasketItemViewModel | 0.65 | 14 | 53 | 0 | 0 | 14 | 15 | 78.57 | 3 | 7 | Microsoft.eShopWeb.Web.Pages.Basket |
| PaginationInfoViewModel | 0.63 | 12 | 46 | 0 | 0 | 12 | 13 | 100 | 2 | 6 | Microsoft.eShopWeb.Web.ViewModels |
| BasketGuards | 0.61 | 2 | 11 | 0 | 0 | 2 | 2 | 50 | 2 | 3 | Ardalis.GuardClauses |
| <>f__AnonymousType2<<userId>j__TPar, <code>j__TPar> | 0.61 | 0 | 104 | - | - | - | 12 | - | 1 | 12 | |
| IBasketService | 0.59 | - | - | - | - | - | - | - | 5 | 0 | Microsoft.eShopWeb.ApplicationCore .Interfaces |
| OrderItemViewModel | 0.51 | 12 | 46 | 0 | 0 | 12 | 13 | 0 | 2 | 7 | Microsoft.eShopWeb.Web.ViewModels |
| IBasketViewModelService | 0.51 | - | - | - | - | - | - | - | 5 | 3 | Microsoft.eShopWeb.Web.Interfaces |
| IOrderService | 0.49 | - | - | - | - | - | - | - | 3 | 1 | Microsoft.eShopWeb.ApplicationCore .Interfaces |
| BasketWithItemsSpecification | 0.46 | 4 | 110 | 0 | 0 | 2 | 2 | 100 | 2 | 13 | Microsoft.eShopWeb.ApplicationCore .Specifications |
| CustomerOrdersWithItemsSpecification+<>c | 0.42 | 0 | 7 | - | - | - | 2 | - | 1 | 2 | Microsoft.eShopWeb.ApplicationCore .Specifications |
| BasketWithItemsSpecification+<>c | 0.41 | 0 | 7 | - | - | - | 2 | - | 1 | 2 | Microsoft.eShopWeb.ApplicationCore .Specifications |
| IOrderRepository | 0.41 | - | - | - | - | - | - | - | 3 | 2 | Microsoft.eShopWeb.ApplicationCore .Interfaces |
| SpecificationEvaluator<T> | 0.41 | 14 | 106 | 5 | 26.32 | 7 | 10 | 64.29 | 1 | 7 | Microsoft.eShopWeb.Infrastructure.Data |
| EfRepository<T> | 0.34 | 14 | 769 | 0 | 0 | 9 | 72 | 100 | 2 | 13 | Microsoft.eShopWeb.Infrastructure.Data |
| OrderRepository+<>c | 0.32 | 0 | 7 | - | - | - | 2 | - | 1 | 2 | Microsoft.eShopWeb.Infrastructure.Data |
| BaseApiController | 0.29 | 0 | 4 | - | - | - | 1 | - | 1 | 5 | Microsoft.eShopWeb.Web.Controllers.Api |
| CatalogViewModelService | 0.29 | 39 | 883 | 1 | 2.5 | 12 | 58 | 100 | 2 | 48 | Microsoft.eShopWeb.Web.Services |
| AppIdentityDbContextSeed | 0.26 | 2 | 110 | 0 | 0 | 1 | 11 | 100 | 1 | 4 | Microsoft.eShopWeb.Infrastructure .Identity |
| Startup | 0.26 | 101 | 952 | 22 | 17.89 | 30 | 71 | 61.39 | 1 | 150 | Microsoft.eShopWeb.Web |
| CatalogContextSeed | 0.26 | 19 | 828 | 2 | 9.52 | 9 | 33 | 63.16 | 1 | 14 | Microsoft.eShopWeb.Infrastructure.Data |
| CatalogContext+<>c | 0.26 | 0 | 7 | - | - | - | 2 | - | 1 | 2 | Microsoft.eShopWeb.Infrastructure.Data |
| <>f__AnonymousType9<<UserId>j__TPar, <LoginProvider>j__TPar,<Name>j__TPar, <Value>j__TPar> | 0.26 | 0 | 190 | - | - | - | 18 | - | 1 | 1 | |
| <>f__AnonymousType8<<Id>j__TPar, <ConcurrencyStamp>j__TPar,<Name>j__TPar, <NormalizedName>j__TPar> | 0.26 | 0 | 190 | - | - | - | 18 | - | 1 | 1 | |
| <>f__AnonymousType7<<Id>j__TPar, <AccessFailedCount>j__TPar, <ConcurrencyStamp>j__TPar,<Email>j__TPar ,<EmailConfirmed>j__TPar,<LockoutEnabled >j__TPar,<LockoutEnd>j__TPar, <NormalizedEmail>j__TPar, <NormalizedUserName>j__TPar, <PasswordHash>j__TPar,<PhoneNumber >j__TPar,<PhoneNumberConfirmed>j__TPar, <SecurityStamp>j__TPar,<TwoFactorEnabled >j__TPar,<UserName>j__TPar> | 0.26 | 0 | 663 | - | - | - | 51 | - | 1 | 1 | |
| <>f__AnonymousType14<<Id>j__TPar, <ClaimType>j__TPar,<ClaimValue>j__TPar, <RoleId>j__TPar> | 0.26 | 0 | 190 | - | - | - | 18 | - | 1 | 1 | |
| <>f__AnonymousType10<<UserId>j__TPar, <LoginProvider>j__TPar,<Name>j__TPar> | 0.26 | 0 | 147 | - | - | - | 15 | - | 1 | 1 | |
| <>f__AnonymousType13<<LoginProvider >j__TPar,<ProviderKey>j__TPar> | 0.26 | 0 | 104 | - | - | - | 12 | - | 1 | 1 | |
| <>f__AnonymousType15<<UserId>j__TPar, <RoleId>j__TPar> | 0.26 | 0 | 104 | - | - | - | 12 | - | 1 | 1 | |
| <>f__AnonymousType11<<Id>j__TPar, <ClaimType>j__TPar,<ClaimValue>j__TPar, <UserId>j__TPar> | 0.26 | 0 | 190 | - | - | - | 18 | - | 1 | 1 | |
| <>f__AnonymousType12<<LoginProvider >j__TPar,<ProviderKey>j__TPar, <ProviderDisplayName>j__TPar,<UserId >j__TPar> | 0.26 | 0 | 190 | - | - | - | 18 | - | 1 | 1 | |
| <>f__AnonymousType0<<Id>j__TPar,<BuyerId >j__TPar> | 0.25 | 0 | 104 | - | - | - | 12 | - | 1 | 1 | |
| <>f__AnonymousType3<<Id>j__TPar,<BuyerId >j__TPar,<OrderDate>j__TPar, <ShipToAddress_City>j__TPar, <ShipToAddress_Country>j__TPar, <ShipToAddress_State>j__TPar, <ShipToAddress_Street>j__TPar, <ShipToAddress_ZipCode>j__TPar> | 0.25 | 0 | 362 | - | - | - | 30 | - | 1 | 1 | |
| <>f__AnonymousType5<<Id>j__TPar, <CatalogBrandId>j__TPar,<CatalogTypeId >j__TPar,<Description>j__TPar,<Name >j__TPar,<PictureUri>j__TPar,<Price >j__TPar> | 0.25 | 0 | 319 | - | - | - | 27 | - | 1 | 1 | |
| <>f__AnonymousType4<<Id>j__TPar, <BasketId>j__TPar,<CatalogItemId>j__TPar ,<Quantity>j__TPar,<UnitPrice>j__TPar> | 0.25 | 0 | 233 | - | - | - | 21 | - | 1 | 1 | |
| <>f__AnonymousType6<<Id>j__TPar,<OrderId >j__TPar,<UnitPrice>j__TPar,<Units >j__TPar,<ItemOrdered_CatalogItemId >j__TPar,<ItemOrdered_PictureUri>j__TPar ,<ItemOrdered_ProductName>j__TPar> | 0.25 | 0 | 319 | - | - | - | 27 | - | 1 | 1 | |
| <>f__AnonymousType1<<Id>j__TPar,<Brand >j__TPar> | 0.25 | 0 | 104 | - | - | - | 12 | - | 1 | 1 | |
| <>f__AnonymousType2<<Id>j__TPar,<Type >j__TPar> | 0.25 | 0 | 104 | - | - | - | 12 | - | 1 | 1 | |
| BasketComponentViewModel | 0.24 | 2 | 11 | 0 | 0 | 2 | 3 | 100 | 1 | 5 | Microsoft.eShopWeb.Web.ViewModels |
| CustomerOrdersWithItemsSpecification | 0.22 | 3 | 59 | 0 | 0 | 1 | 1 | 0 | 1 | 12 | Microsoft.eShopWeb.ApplicationCore .Specifications |
| OrderViewModel | 0.22 | 13 | 49 | 0 | 0 | 13 | 13 | 0 | 1 | 11 | Microsoft.eShopWeb.Web.ViewModels |
| LoginModel+InputModel | 0.22 | 6 | 25 | 0 | 0 | 6 | 7 | 0 | 1 | 10 | Microsoft.eShopWeb.Web.Areas.Identity .Pages.Account |
| <>f__AnonymousType0<<ReturnUrl>j__TPar, <RememberMe>j__TPar> | 0.22 | 0 | 104 | - | - | - | 12 | - | 1 | 12 | |
| CatalogFilterPaginatedSpecification | 0.22 | 2 | 91 | 0 | 0 | 1 | 1 | 100 | 1 | 11 | Microsoft.eShopWeb.ApplicationCore .Specifications |
| CatalogFilterSpecification | 0.22 | 1 | 86 | 0 | 0 | 1 | 1 | 100 | 1 | 11 | Microsoft.eShopWeb.ApplicationCore .Specifications |
| LoginViewModel | 0.2 | 6 | 25 | 0 | 0 | 6 | 7 | 83.33 | 1 | 10 | Microsoft.eShopWeb.Web.ViewModels .Account |
| ResetPasswordViewModel | 0.2 | 8 | 32 | 0 | 0 | 8 | 9 | 0 | 1 | 11 | Microsoft.eShopWeb.Web.ViewModels .Account |
| LoginWith2faViewModel | 0.2 | 6 | 25 | 0 | 0 | 6 | 7 | 0 | 1 | 10 | Microsoft.eShopWeb.Web.ViewModels .Account |
| <>f__AnonymousType1<<returnUrl>j__TPar, <RememberMe>j__TPar> | 0.2 | 0 | 104 | - | - | - | 12 | - | 1 | 12 | |
| RegisterViewModel | 0.2 | 6 | 25 | 0 | 0 | 6 | 7 | 0 | 1 | 11 | Microsoft.eShopWeb.Web.ViewModels .Account |
| ExternalLoginsViewModel | 0.19 | 8 | 32 | 0 | 0 | 8 | 9 | 0 | 1 | 9 | Microsoft.eShopWeb.Web.ViewModels.Manage |
| ChangePasswordViewModel | 0.19 | 8 | 32 | 0 | 0 | 8 | 9 | 0 | 1 | 10 | Microsoft.eShopWeb.Web.ViewModels.Manage |
| EmailSenderExtensions | 0.19 | 1 | 15 | 0 | 0 | 1 | 1 | 0 | 1 | 7 | Microsoft.eShopWeb.Web.Services |
| EnableAuthenticatorViewModel | 0.19 | 6 | 25 | 0 | 0 | 6 | 7 | 0 | 1 | 10 | Microsoft.eShopWeb.Web.ViewModels.Manage |
| SetPasswordViewModel | 0.19 | 6 | 25 | 0 | 0 | 6 | 7 | 0 | 1 | 10 | Microsoft.eShopWeb.Web.ViewModels.Manage |
| TwoFactorAuthenticationViewModel | 0.19 | 6 | 25 | 0 | 0 | 6 | 7 | 0 | 1 | 6 | Microsoft.eShopWeb.Web.ViewModels.Manage |
| RemoveLoginViewModel | 0.19 | 4 | 18 | 0 | 0 | 4 | 5 | 0 | 1 | 5 | Microsoft.eShopWeb.Web.ViewModels.Manage |
| GenerateRecoveryCodesViewModel | 0.19 | 2 | 11 | 0 | 0 | 2 | 3 | 0 | 1 | 6 | Microsoft.eShopWeb.Web.ViewModels.Manage |
| IndexViewModel | 0.19 | 10 | 39 | 0 | 0 | 10 | 11 | 0 | 1 | 10 | Microsoft.eShopWeb.Web.ViewModels.Manage |
| UrlHelperExtensions | 0.19 | 2 | 26 | 0 | 0 | 2 | 2 | 0 | 1 | 7 | Microsoft.AspNetCore.Mvc |
| <>f__AnonymousType3<<status>j__TPar, <errors>j__TPar> | 0.17 | 0 | 104 | - | - | - | 12 | - | 1 | 12 | |
| OrderRepository | 0.17 | 2 | 68 | 0 | 0 | 2 | 2 | 100 | 1 | 19 | Microsoft.eShopWeb.Infrastructure.Data |
| ApiHealthCheck | 0.17 | 12 | 233 | 0 | 0 | 3 | 15 | 0 | 1 | 31 | Microsoft.eShopWeb.Web.HealthChecks |
| <>f__AnonymousType4<<key>j__TPar,<value >j__TPar> | 0.17 | 0 | 104 | - | - | - | 12 | - | 1 | 12 | |
| OrderService | 0.17 | 17 | 319 | 0 | 0 | 3 | 24 | 0 | 1 | 13 | Microsoft.eShopWeb.ApplicationCore .Services |
| BasketService | 0.17 | 44 | 1028 | 0 | 0 | 12 | 82 | 40.91 | 1 | 15 | Microsoft.eShopWeb.ApplicationCore .Services |
| HomePageHealthCheck | 0.17 | 10 | 212 | 0 | 0 | 3 | 15 | 0 | 1 | 26 | Microsoft.eShopWeb.Web.HealthChecks |
| CachedCatalogViewModelService | 0.17 | 17 | 743 | 0 | 0 | 8 | 63 | 64.71 | 1 | 28 | Microsoft.eShopWeb.Web.Services |
| BasketViewModelService | 0.17 | 28 | 702 | 0 | 0 | 7 | 55 | 100 | 1 | 34 | Microsoft.eShopWeb.Web.Services |
| EmailSender | 0.17 | 1 | 10 | 1 | 50 | 1 | 2 | 0 | 1 | 1 | Microsoft.eShopWeb.Infrastructure .Services |
| AppIdentityDbContext | 0.17 | 2 | 12 | 3 | 60 | 2 | 2 | 100 | 1 | 12 | Microsoft.eShopWeb.Infrastructure .Identity |
| LoggerAdapter<T> | 0.17 | 4 | 25 | 0 | 0 | 3 | 3 | 50 | 1 | 7 | Microsoft.eShopWeb.Infrastructure .Logging |
| SlugifyParameterTransformer | 0.17 | 3 | 25 | 1 | 25 | 2 | 4 | 66.67 | 1 | 7 | Microsoft.eShopWeb.Web |
| UriComposer | 0.17 | 3 | 18 | 0 | 0 | 2 | 2 | 100 | 1 | 2 | Microsoft.eShopWeb.ApplicationCore .Services |
| CatalogController | 0.15 | 5 | 136 | 0 | 0 | 3 | 11 | 100 | 0 | 22 | Microsoft.eShopWeb.Web.Controllers.Api |
| IdentityHostingStartup | 0.15 | 1 | 20 | 0 | 0 | 2 | 4 | 100 | 0 | 9 | Microsoft.eShopWeb.Web.Areas.Identity |
| Buyer | 0.15 | 8 | 33 | 1 | 11.11 | 5 | 5 | 0 | 0 | 6 | Microsoft.eShopWeb.ApplicationCore .Entities.BuyerAggregate |
| IIdentityParser<T> | 0.15 | - | - | - | - | - | - | - | 0 | 1 | Microsoft.eShopWeb.ApplicationCore .Interfaces |
| ManageController | 0.15 | 189 | 4642 | 4 | 2.07 | 69 | 325 | 0 | 0 | 78 | Microsoft.eShopWeb.Web.Controllers |
| OrderController | 0.15 | 15 | 457 | 0 | 0 | 8 | 32 | 0 | 0 | 45 | Microsoft.eShopWeb.Web.Controllers |
| LoginModel | 0.15 | 31 | 446 | 4 | 11.43 | 18 | 39 | 41.94 | 0 | 46 | Microsoft.eShopWeb.Web.Areas.Identity .Pages.Account |
| AccountController | 0.15 | 77 | 1478 | 4 | 4.94 | 33 | 115 | 18.18 | 0 | 63 | Microsoft.eShopWeb.Web.Controllers |
| Constants | 0.15 | 0 | 0 | - | - | - | 0 | - | 0 | 3 | Microsoft.eShopWeb.Web |
| ErrorModel | 0.15 | 4 | 35 | 0 | 0 | 5 | 8 | 0 | 0 | 9 | Microsoft.eShopWeb.Web.Pages |
| IndexModel | 0.15 | 6 | 137 | 0 | 0 | 5 | 13 | 100 | 0 | 19 | Microsoft.eShopWeb.Web.Pages |
| Program | 0.15 | 13 | 69 | 0 | 0 | 3 | 6 | 7.69 | 0 | 29 | Microsoft.eShopWeb.Web |
| InitialIdentityModel | 0.15 | 115 | 1983 | 0 | 0 | 28 | 54 | 0 | 0 | 30 | Microsoft.eShopWeb.Infrastructure .Identity.Migrations |
| ManageNavPages | 0.15 | 12 | 51 | 0 | 0 | 12 | 13 | 0 | 0 | 8 | Microsoft.eShopWeb.Web.Views.Manage |
| AppIdentityDbContextModelSnapshot | 0.15 | 75 | 614 | 0 | 0 | 12 | 24 | 0 | 0 | 11 | Microsoft.eShopWeb.Infrastructure .Identity.Migrations |
| CheckoutModel | 0.15 | 27 | 519 | 0 | 0 | 10 | 42 | 0 | 0 | 42 | Microsoft.eShopWeb.Web.Pages.Basket |
| IndexModel | 0.15 | 31 | 761 | 0 | 0 | 12 | 67 | 77.42 | 0 | 42 | Microsoft.eShopWeb.Web.Pages.Basket |
| CatalogContextModelSnapshot | 0.15 | 75 | 682 | 0 | 0 | 14 | 28 | 0 | 0 | 12 | Microsoft.eShopWeb.Infrastructure.Data .Migrations |
| AddExtraConstraints | 0.15 | 87 | 1130 | 0 | 0 | 16 | 30 | 0 | 0 | 16 | Microsoft.eShopWeb.Infrastructure.Data .Migrations |
| PrivacyModel | 0.15 | 0 | 6 | 0 | - | 1 | 2 | 0 | 0 | 2 | Microsoft.eShopWeb.Web.Pages |
| Basket | 0.15 | 16 | 351 | 0 | 0 | 8 | 31 | 87.5 | 0 | 34 | Microsoft.eShopWeb.Web.Pages.Shared .Components.BasketComponent |
| Initial | 0.15 | 117 | 1823 | 0 | 0 | 30 | 58 | 0 | 0 | 31 | Microsoft.eShopWeb.Infrastructure.Data .Migrations |
Types Metrics : Code Members and Inheritance
| Type Name | # Instance Methods | Nb Static Methods | Nb Properties | # Fields | # Children Classes | Depth Of Inheritance Tree | Type Namespace |
|---|---|---|---|---|---|---|---|
| BaseEntity | 3 | 0 | 1 | 1 | 9 | 0 | Microsoft.eShopWeb.ApplicationCore .Entities |
| ISpecification<T> | 8 | 0 | 8 | 0 | - | - | Microsoft.eShopWeb.ApplicationCore .Interfaces |
| Address | 12 | 0 | 5 | 5 | 0 | 0 | Microsoft.eShopWeb.ApplicationCore .Entities.OrderAggregate |
| IEmailSender | 1 | 0 | 0 | 0 | - | - | Microsoft.eShopWeb.ApplicationCore .Interfaces |
| IAsyncRepository<T> | 7 | 0 | 0 | 0 | - | - | Microsoft.eShopWeb.ApplicationCore .Interfaces |
| CatalogItemOrdered | 8 | 0 | 3 | 3 | 0 | 0 | Microsoft.eShopWeb.ApplicationCore .Entities.OrderAggregate |
| Order | 10 | 0 | 4 | 4 | 0 | 1 | Microsoft.eShopWeb.ApplicationCore .Entities.OrderAggregate |
| IAggregateRoot | 0 | 0 | 0 | 0 | - | - | Microsoft.eShopWeb.ApplicationCore .Interfaces |
| IUriComposer | 1 | 0 | 0 | 0 | - | - | Microsoft.eShopWeb.ApplicationCore .Interfaces |
| Basket | 5 | 0 | 2 | 2 | 0 | 1 | Microsoft.eShopWeb.ApplicationCore .Entities.BasketAggregate |
| BasketItem | 7 | 0 | 3 | 3 | 0 | 1 | Microsoft.eShopWeb.ApplicationCore .Entities.BasketAggregate |
| CatalogType | 3 | 0 | 1 | 1 | 0 | 1 | Microsoft.eShopWeb.ApplicationCore .Entities |
| CatalogBrand | 3 | 0 | 1 | 1 | 0 | 1 | Microsoft.eShopWeb.ApplicationCore .Entities |
| OrderItem | 8 | 0 | 3 | 3 | 0 | 1 | Microsoft.eShopWeb.ApplicationCore .Entities.OrderAggregate |
| ApplicationUser | 1 | 0 | 0 | 0 | 0 | 2 | Microsoft.eShopWeb.Infrastructure .Identity |
| CatalogSettings | 3 | 0 | 1 | 1 | 0 | 0 | Microsoft.eShopWeb |
| BasketViewModel | 8 | 0 | 3 | 3 | 0 | 1 | Microsoft.eShopWeb.Web.Pages.Basket |
| CatalogItem | 17 | 0 | 8 | 8 | 0 | 1 | Microsoft.eShopWeb.ApplicationCore .Entities |
| BasketNotFoundException | 4 | 0 | 0 | 0 | 0 | 0 | Microsoft.eShopWeb.ApplicationCore .Exceptions |
| BaseSpecification<T> | 19 | 0 | 8 | 8 | 4 | 0 | Microsoft.eShopWeb.ApplicationCore .Specifications |
| CatalogIndexViewModel | 13 | 0 | 6 | 6 | 0 | 1 | Microsoft.eShopWeb.Web.ViewModels |
| CatalogContext | 22 | 0 | 6 | 6 | 0 | 1 | Microsoft.eShopWeb.Infrastructure.Data |
| IAppLogger<T> | 2 | 0 | 0 | 0 | - | - | Microsoft.eShopWeb.ApplicationCore .Interfaces |
| CatalogItemViewModel | 9 | 0 | 4 | 4 | 0 | 1 | Microsoft.eShopWeb.Web.ViewModels |
| PaymentMethod | 7 | 0 | 3 | 3 | 0 | 1 | Microsoft.eShopWeb.ApplicationCore .Entities.BuyerAggregate |
| ICatalogViewModelService | 3 | 0 | 0 | 0 | - | - | Microsoft.eShopWeb.Web.Services |
| BasketItemViewModel | 15 | 0 | 7 | 7 | 0 | 1 | Microsoft.eShopWeb.Web.Pages.Basket |
| PaginationInfoViewModel | 13 | 0 | 6 | 6 | 0 | 1 | Microsoft.eShopWeb.Web.ViewModels |
| BasketGuards | 0 | 1 | 0 | 0 | 0 | 0 | Ardalis.GuardClauses |
| <>f__AnonymousType2<<userId>j__TPar, <code>j__TPar> | 6 | 0 | 2 | 2 | 0 | 1 | |
| IBasketService | 5 | 0 | 0 | 0 | - | - | Microsoft.eShopWeb.ApplicationCore .Interfaces |
| OrderItemViewModel | 13 | 0 | 6 | 6 | 0 | 1 | Microsoft.eShopWeb.Web.ViewModels |
| IBasketViewModelService | 1 | 0 | 0 | 0 | - | - | Microsoft.eShopWeb.Web.Interfaces |
| IOrderService | 1 | 0 | 0 | 0 | - | - | Microsoft.eShopWeb.ApplicationCore .Interfaces |
| BasketWithItemsSpecification | 2 | 0 | 0 | 0 | 0 | 1 | Microsoft.eShopWeb.ApplicationCore .Specifications |
| CustomerOrdersWithItemsSpecification+<>c | 1 | 1 | 0 | 1 | 0 | 0 | Microsoft.eShopWeb.ApplicationCore .Specifications |
| BasketWithItemsSpecification+<>c | 1 | 1 | 0 | 1 | 0 | 0 | Microsoft.eShopWeb.ApplicationCore .Specifications |
| IOrderRepository | 1 | 0 | 0 | 0 | - | - | Microsoft.eShopWeb.ApplicationCore .Interfaces |
| SpecificationEvaluator<T> | 1 | 1 | 0 | 0 | 0 | 0 | Microsoft.eShopWeb.Infrastructure.Data |
| EfRepository<T> | 9 | 0 | 0 | 1 | 1 | 0 | Microsoft.eShopWeb.Infrastructure.Data |
| OrderRepository+<>c | 1 | 1 | 0 | 1 | 0 | 0 | Microsoft.eShopWeb.Infrastructure.Data |
| BaseApiController | 1 | 0 | 0 | 0 | 1 | 2 | Microsoft.eShopWeb.Web.Controllers.Api |
| CatalogViewModelService | 4 | 0 | 0 | 5 | 0 | 1 | Microsoft.eShopWeb.Web.Services |
| AppIdentityDbContextSeed | 1 | 1 | 0 | 0 | 0 | 0 | Microsoft.eShopWeb.Infrastructure .Identity |
| Startup | 8 | 2 | 1 | 2 | 0 | 1 | Microsoft.eShopWeb.Web |
| CatalogContextSeed | 1 | 4 | 0 | 0 | 0 | 0 | Microsoft.eShopWeb.Infrastructure.Data |
| CatalogContext+<>c | 1 | 1 | 0 | 1 | 0 | 0 | Microsoft.eShopWeb.Infrastructure.Data |
| <>f__AnonymousType9<<UserId>j__TPar, <LoginProvider>j__TPar,<Name>j__TPar, <Value>j__TPar> | 8 | 0 | 4 | 4 | 0 | 0 | |
| <>f__AnonymousType8<<Id>j__TPar, <ConcurrencyStamp>j__TPar,<Name>j__TPar, <NormalizedName>j__TPar> | 8 | 0 | 4 | 4 | 0 | 0 | |
| <>f__AnonymousType7<<Id>j__TPar, <AccessFailedCount>j__TPar, <ConcurrencyStamp>j__TPar,<Email>j__TPar ,<EmailConfirmed>j__TPar,<LockoutEnabled >j__TPar,<LockoutEnd>j__TPar, <NormalizedEmail>j__TPar, <NormalizedUserName>j__TPar, <PasswordHash>j__TPar,<PhoneNumber >j__TPar,<PhoneNumberConfirmed>j__TPar, <SecurityStamp>j__TPar,<TwoFactorEnabled >j__TPar,<UserName>j__TPar> | 19 | 0 | 15 | 15 | 0 | 0 | |
| <>f__AnonymousType14<<Id>j__TPar, <ClaimType>j__TPar,<ClaimValue>j__TPar, <RoleId>j__TPar> | 8 | 0 | 4 | 4 | 0 | 0 | |
| <>f__AnonymousType10<<UserId>j__TPar, <LoginProvider>j__TPar,<Name>j__TPar> | 7 | 0 | 3 | 3 | 0 | 0 | |
| <>f__AnonymousType13<<LoginProvider >j__TPar,<ProviderKey>j__TPar> | 6 | 0 | 2 | 2 | 0 | 0 | |
| <>f__AnonymousType15<<UserId>j__TPar, <RoleId>j__TPar> | 6 | 0 | 2 | 2 | 0 | 0 | |
| <>f__AnonymousType11<<Id>j__TPar, <ClaimType>j__TPar,<ClaimValue>j__TPar, <UserId>j__TPar> | 8 | 0 | 4 | 4 | 0 | 0 | |
| <>f__AnonymousType12<<LoginProvider >j__TPar,<ProviderKey>j__TPar, <ProviderDisplayName>j__TPar,<UserId >j__TPar> | 8 | 0 | 4 | 4 | 0 | 0 | |
| <>f__AnonymousType0<<Id>j__TPar,<BuyerId >j__TPar> | 6 | 0 | 2 | 2 | 0 | 0 | |
| <>f__AnonymousType3<<Id>j__TPar,<BuyerId >j__TPar,<OrderDate>j__TPar, <ShipToAddress_City>j__TPar, <ShipToAddress_Country>j__TPar, <ShipToAddress_State>j__TPar, <ShipToAddress_Street>j__TPar, <ShipToAddress_ZipCode>j__TPar> | 12 | 0 | 8 | 8 | 0 | 0 | |
| <>f__AnonymousType5<<Id>j__TPar, <CatalogBrandId>j__TPar,<CatalogTypeId >j__TPar,<Description>j__TPar,<Name >j__TPar,<PictureUri>j__TPar,<Price >j__TPar> | 11 | 0 | 7 | 7 | 0 | 0 | |
| <>f__AnonymousType4<<Id>j__TPar, <BasketId>j__TPar,<CatalogItemId>j__TPar ,<Quantity>j__TPar,<UnitPrice>j__TPar> | 9 | 0 | 5 | 5 | 0 | 0 | |
| <>f__AnonymousType6<<Id>j__TPar,<OrderId >j__TPar,<UnitPrice>j__TPar,<Units >j__TPar,<ItemOrdered_CatalogItemId >j__TPar,<ItemOrdered_PictureUri>j__TPar ,<ItemOrdered_ProductName>j__TPar> | 11 | 0 | 7 | 7 | 0 | 0 | |
| <>f__AnonymousType1<<Id>j__TPar,<Brand >j__TPar> | 6 | 0 | 2 | 2 | 0 | 0 | |
| <>f__AnonymousType2<<Id>j__TPar,<Type >j__TPar> | 6 | 0 | 2 | 2 | 0 | 0 | |
| BasketComponentViewModel | 3 | 0 | 1 | 1 | 0 | 1 | Microsoft.eShopWeb.Web.ViewModels |
| CustomerOrdersWithItemsSpecification | 1 | 0 | 0 | 0 | 0 | 1 | Microsoft.eShopWeb.ApplicationCore .Specifications |
| OrderViewModel | 13 | 0 | 6 | 6 | 0 | 1 | Microsoft.eShopWeb.Web.ViewModels |
| LoginModel+InputModel | 7 | 0 | 3 | 3 | 0 | 1 | Microsoft.eShopWeb.Web.Areas.Identity .Pages.Account |
| <>f__AnonymousType0<<ReturnUrl>j__TPar, <RememberMe>j__TPar> | 6 | 0 | 2 | 2 | 0 | 1 | |
| CatalogFilterPaginatedSpecification | 1 | 0 | 0 | 0 | 0 | 1 | Microsoft.eShopWeb.ApplicationCore .Specifications |
| CatalogFilterSpecification | 1 | 0 | 0 | 0 | 0 | 1 | Microsoft.eShopWeb.ApplicationCore .Specifications |
| LoginViewModel | 7 | 0 | 3 | 3 | 0 | 1 | Microsoft.eShopWeb.Web.ViewModels .Account |
| ResetPasswordViewModel | 9 | 0 | 4 | 4 | 0 | 1 | Microsoft.eShopWeb.Web.ViewModels .Account |
| LoginWith2faViewModel | 7 | 0 | 3 | 3 | 0 | 1 | Microsoft.eShopWeb.Web.ViewModels .Account |
| <>f__AnonymousType1<<returnUrl>j__TPar, <RememberMe>j__TPar> | 6 | 0 | 2 | 2 | 0 | 1 | |
| RegisterViewModel | 7 | 0 | 3 | 3 | 0 | 1 | Microsoft.eShopWeb.Web.ViewModels .Account |
| ExternalLoginsViewModel | 9 | 0 | 4 | 4 | 0 | 1 | Microsoft.eShopWeb.Web.ViewModels.Manage |
| ChangePasswordViewModel | 9 | 0 | 4 | 4 | 0 | 1 | Microsoft.eShopWeb.Web.ViewModels.Manage |
| EmailSenderExtensions | 0 | 1 | 0 | 0 | 0 | 1 | Microsoft.eShopWeb.Web.Services |
| EnableAuthenticatorViewModel | 7 | 0 | 3 | 3 | 0 | 1 | Microsoft.eShopWeb.Web.ViewModels.Manage |
| SetPasswordViewModel | 7 | 0 | 3 | 3 | 0 | 1 | Microsoft.eShopWeb.Web.ViewModels.Manage |
| TwoFactorAuthenticationViewModel | 7 | 0 | 3 | 3 | 0 | 1 | Microsoft.eShopWeb.Web.ViewModels.Manage |
| RemoveLoginViewModel | 5 | 0 | 2 | 2 | 0 | 1 | Microsoft.eShopWeb.Web.ViewModels.Manage |
| GenerateRecoveryCodesViewModel | 3 | 0 | 1 | 1 | 0 | 1 | Microsoft.eShopWeb.Web.ViewModels.Manage |
| IndexViewModel | 11 | 0 | 5 | 5 | 0 | 1 | Microsoft.eShopWeb.Web.ViewModels.Manage |
| UrlHelperExtensions | 0 | 2 | 0 | 0 | 0 | 1 | Microsoft.AspNetCore.Mvc |
| <>f__AnonymousType3<<status>j__TPar, <errors>j__TPar> | 6 | 0 | 2 | 2 | 0 | 1 | |
| OrderRepository | 2 | 0 | 0 | 0 | 0 | 1 | Microsoft.eShopWeb.Infrastructure.Data |
| ApiHealthCheck | 2 | 0 | 0 | 2 | 0 | 1 | Microsoft.eShopWeb.Web.HealthChecks |
| <>f__AnonymousType4<<key>j__TPar,<value >j__TPar> | 6 | 0 | 2 | 2 | 0 | 1 | |
| OrderService | 2 | 0 | 0 | 3 | 0 | 0 | Microsoft.eShopWeb.ApplicationCore .Services |
| BasketService | 6 | 0 | 0 | 4 | 0 | 0 | Microsoft.eShopWeb.ApplicationCore .Services |
| HomePageHealthCheck | 2 | 0 | 0 | 1 | 0 | 1 | Microsoft.eShopWeb.Web.HealthChecks |
| CachedCatalogViewModelService | 4 | 1 | 0 | 6 | 0 | 1 | Microsoft.eShopWeb.Web.Services |
| BasketViewModelService | 5 | 0 | 0 | 3 | 0 | 1 | Microsoft.eShopWeb.Web.Services |
| EmailSender | 2 | 0 | 0 | 0 | 0 | 0 | Microsoft.eShopWeb.Infrastructure .Services |
| AppIdentityDbContext | 2 | 0 | 0 | 0 | 0 | 1 | Microsoft.eShopWeb.Infrastructure .Identity |
| LoggerAdapter<T> | 3 | 0 | 0 | 1 | 0 | 0 | Microsoft.eShopWeb.Infrastructure .Logging |
| SlugifyParameterTransformer | 2 | 0 | 0 | 0 | 0 | 1 | Microsoft.eShopWeb.Web |
| UriComposer | 2 | 0 | 0 | 1 | 0 | 0 | Microsoft.eShopWeb.ApplicationCore .Services |
| CatalogController | 2 | 0 | 0 | 1 | 0 | 3 | Microsoft.eShopWeb.Web.Controllers.Api |
| IdentityHostingStartup | 2 | 0 | 0 | 0 | 0 | 1 | Microsoft.eShopWeb.Web.Areas.Identity |
| Buyer | 5 | 0 | 2 | 2 | 0 | 1 | Microsoft.eShopWeb.ApplicationCore .Entities.BuyerAggregate |
| IIdentityParser<T> | 1 | 0 | 0 | 0 | - | - | Microsoft.eShopWeb.ApplicationCore .Interfaces |
| ManageController | 25 | 0 | 1 | 7 | 0 | 2 | Microsoft.eShopWeb.Web.Controllers |
| OrderController | 3 | 0 | 0 | 1 | 0 | 2 | Microsoft.eShopWeb.Web.Controllers |
| LoginModel | 11 | 0 | 4 | 6 | 0 | 1 | Microsoft.eShopWeb.Web.Areas.Identity .Pages.Account |
| AccountController | 13 | 0 | 0 | 4 | 0 | 2 | Microsoft.eShopWeb.Web.Controllers |
| Constants | 0 | 0 | 0 | 3 | 0 | 1 | Microsoft.eShopWeb.Web |
| ErrorModel | 5 | 0 | 2 | 1 | 0 | 1 | Microsoft.eShopWeb.Web.Pages |
| IndexModel | 4 | 0 | 1 | 2 | 0 | 1 | Microsoft.eShopWeb.Web.Pages |
| Program | 1 | 2 | 0 | 0 | 0 | 1 | Microsoft.eShopWeb.Web |
| InitialIdentityModel | 4 | 0 | 0 | 0 | 0 | 1 | Microsoft.eShopWeb.Infrastructure .Identity.Migrations |
| ManageNavPages | 0 | 11 | 5 | 0 | 0 | 1 | Microsoft.eShopWeb.Web.Views.Manage |
| AppIdentityDbContextModelSnapshot | 2 | 0 | 0 | 0 | 0 | 1 | Microsoft.eShopWeb.Infrastructure .Identity.Migrations |
| CheckoutModel | 7 | 0 | 1 | 7 | 0 | 1 | Microsoft.eShopWeb.Web.Pages.Basket |
| IndexModel | 8 | 0 | 1 | 7 | 0 | 1 | Microsoft.eShopWeb.Web.Pages.Basket |
| CatalogContextModelSnapshot | 2 | 0 | 0 | 0 | 0 | 1 | Microsoft.eShopWeb.Infrastructure.Data .Migrations |
| AddExtraConstraints | 4 | 0 | 0 | 0 | 0 | 1 | Microsoft.eShopWeb.Infrastructure.Data .Migrations |
| PrivacyModel | 2 | 0 | 0 | 0 | 0 | 1 | Microsoft.eShopWeb.Web.Pages |
| Basket | 4 | 0 | 0 | 2 | 0 | 1 | Microsoft.eShopWeb.Web.Pages.Shared .Components.BasketComponent |
| Initial | 4 | 0 | 0 | 0 | 0 | 1 | Microsoft.eShopWeb.Infrastructure.Data .Migrations |
Types Metrics : Lack Of Cohesion Of Methods and Association Between Classes
| Type Name | Lack Of Cohesion Of Methods | Lack Of Cohesion Of Methods HS | Association Between Classes | Type Namespace |
|---|---|---|---|---|
| BaseEntity | 0 | 0 | 0 | Microsoft.eShopWeb.ApplicationCore .Entities |
| ISpecification<T> | - | - | 0 | Microsoft.eShopWeb.ApplicationCore .Interfaces |
| Address | 0 | 0 | 0 | Microsoft.eShopWeb.ApplicationCore .Entities.OrderAggregate |
| IEmailSender | - | - | 0 | Microsoft.eShopWeb.ApplicationCore .Interfaces |
| IAsyncRepository<T> | - | - | 0 | Microsoft.eShopWeb.ApplicationCore .Interfaces |
| CatalogItemOrdered | 0 | 0 | 3 | Microsoft.eShopWeb.ApplicationCore .Entities.OrderAggregate |
| Order | 0 | 0 | 6 | Microsoft.eShopWeb.ApplicationCore .Entities.OrderAggregate |
| IAggregateRoot | - | - | 0 | Microsoft.eShopWeb.ApplicationCore .Interfaces |
| IUriComposer | - | - | 0 | Microsoft.eShopWeb.ApplicationCore .Interfaces |
| Basket | 0 | 0 | 9 | Microsoft.eShopWeb.ApplicationCore .Entities.BasketAggregate |
| BasketItem | 0 | 0 | 1 | Microsoft.eShopWeb.ApplicationCore .Entities.BasketAggregate |
| CatalogType | 0 | 0 | 1 | Microsoft.eShopWeb.ApplicationCore .Entities |
| CatalogBrand | 0 | 0 | 1 | Microsoft.eShopWeb.ApplicationCore .Entities |
| OrderItem | 0 | 0 | 1 | Microsoft.eShopWeb.ApplicationCore .Entities.OrderAggregate |
| ApplicationUser | 0 | 0 | 1 | Microsoft.eShopWeb.Infrastructure .Identity |
| CatalogSettings | 0 | 0 | 0 | Microsoft.eShopWeb |
| BasketViewModel | 0 | 0 | 9 | Microsoft.eShopWeb.Web.Pages.Basket |
| CatalogItem | 0 | 0 | 1 | Microsoft.eShopWeb.ApplicationCore .Entities |
| BasketNotFoundException | 0 | 0 | 0 | Microsoft.eShopWeb.ApplicationCore .Exceptions |
| BaseSpecification<T> | 0 | 0 | 0 | Microsoft.eShopWeb.ApplicationCore .Specifications |
| CatalogIndexViewModel | 0 | 0 | 1 | Microsoft.eShopWeb.Web.ViewModels |
| CatalogContext | 0 | 0 | 38 | Microsoft.eShopWeb.Infrastructure.Data |
| IAppLogger<T> | - | - | 0 | Microsoft.eShopWeb.ApplicationCore .Interfaces |
| CatalogItemViewModel | 0 | 0 | 1 | Microsoft.eShopWeb.Web.ViewModels |
| PaymentMethod | 0 | 0 | 1 | Microsoft.eShopWeb.ApplicationCore .Entities.BuyerAggregate |
| ICatalogViewModelService | - | - | 0 | Microsoft.eShopWeb.Web.Services |
| BasketItemViewModel | 0 | 0 | 1 | Microsoft.eShopWeb.Web.Pages.Basket |
| PaginationInfoViewModel | 0 | 0 | 1 | Microsoft.eShopWeb.Web.ViewModels |
| BasketGuards | 0 | 0 | 1 | Ardalis.GuardClauses |
| <>f__AnonymousType2<<userId>j__TPar, <code>j__TPar> | 0 | 0 | 6 | |
| IBasketService | - | - | 0 | Microsoft.eShopWeb.ApplicationCore .Interfaces |
| OrderItemViewModel | 0 | 0 | 1 | Microsoft.eShopWeb.Web.ViewModels |
| IBasketViewModelService | - | - | 0 | Microsoft.eShopWeb.Web.Interfaces |
| IOrderService | - | - | 0 | Microsoft.eShopWeb.ApplicationCore .Interfaces |
| BasketWithItemsSpecification | 0 | 0 | 11 | Microsoft.eShopWeb.ApplicationCore .Specifications |
| CustomerOrdersWithItemsSpecification+<>c | 0 | 0 | 0 | Microsoft.eShopWeb.ApplicationCore .Specifications |
| BasketWithItemsSpecification+<>c | 0 | 0 | 0 | Microsoft.eShopWeb.ApplicationCore .Specifications |
| IOrderRepository | - | - | 0 | Microsoft.eShopWeb.ApplicationCore .Interfaces |
| SpecificationEvaluator<T> | 0 | 0 | 16 | Microsoft.eShopWeb.Infrastructure.Data |
| EfRepository<T> | 0.22 | 0.25 | 12 | Microsoft.eShopWeb.Infrastructure.Data |
| OrderRepository+<>c | 0 | 0 | 0 | Microsoft.eShopWeb.Infrastructure.Data |
| BaseApiController | 0 | 0 | 1 | Microsoft.eShopWeb.Web.Controllers.Api |
| CatalogViewModelService | 0.4 | 0.53 | 69 | Microsoft.eShopWeb.Web.Services |
| AppIdentityDbContextSeed | 0 | 0 | 4 | Microsoft.eShopWeb.Infrastructure .Identity |
| Startup | 0.78 | 0.88 | 123 | Microsoft.eShopWeb.Web |
| CatalogContextSeed | 0 | 0 | 19 | Microsoft.eShopWeb.Infrastructure.Data |
| CatalogContext+<>c | 0 | 0 | 0 | Microsoft.eShopWeb.Infrastructure.Data |
| <>f__AnonymousType9<<UserId>j__TPar, <LoginProvider>j__TPar,<Name>j__TPar, <Value>j__TPar> | 0 | 0 | 0 | |
| <>f__AnonymousType8<<Id>j__TPar, <ConcurrencyStamp>j__TPar,<Name>j__TPar, <NormalizedName>j__TPar> | 0 | 0 | 0 | |
| <>f__AnonymousType7<<Id>j__TPar, <AccessFailedCount>j__TPar, <ConcurrencyStamp>j__TPar,<Email>j__TPar ,<EmailConfirmed>j__TPar,<LockoutEnabled >j__TPar,<LockoutEnd>j__TPar, <NormalizedEmail>j__TPar, <NormalizedUserName>j__TPar, <PasswordHash>j__TPar,<PhoneNumber >j__TPar,<PhoneNumberConfirmed>j__TPar, <SecurityStamp>j__TPar,<TwoFactorEnabled >j__TPar,<UserName>j__TPar> | 0 | 0 | 0 | |
| <>f__AnonymousType14<<Id>j__TPar, <ClaimType>j__TPar,<ClaimValue>j__TPar, <RoleId>j__TPar> | 0 | 0 | 0 | |
| <>f__AnonymousType10<<UserId>j__TPar, <LoginProvider>j__TPar,<Name>j__TPar> | 0 | 0 | 0 | |
| <>f__AnonymousType13<<LoginProvider >j__TPar,<ProviderKey>j__TPar> | 0 | 0 | 0 | |
| <>f__AnonymousType15<<UserId>j__TPar, <RoleId>j__TPar> | 0 | 0 | 0 | |
| <>f__AnonymousType11<<Id>j__TPar, <ClaimType>j__TPar,<ClaimValue>j__TPar, <UserId>j__TPar> | 0 | 0 | 0 | |
| <>f__AnonymousType12<<LoginProvider >j__TPar,<ProviderKey>j__TPar, <ProviderDisplayName>j__TPar,<UserId >j__TPar> | 0 | 0 | 0 | |
| <>f__AnonymousType0<<Id>j__TPar,<BuyerId >j__TPar> | 0 | 0 | 0 | |
| <>f__AnonymousType3<<Id>j__TPar,<BuyerId >j__TPar,<OrderDate>j__TPar, <ShipToAddress_City>j__TPar, <ShipToAddress_Country>j__TPar, <ShipToAddress_State>j__TPar, <ShipToAddress_Street>j__TPar, <ShipToAddress_ZipCode>j__TPar> | 0 | 0 | 0 | |
| <>f__AnonymousType5<<Id>j__TPar, <CatalogBrandId>j__TPar,<CatalogTypeId >j__TPar,<Description>j__TPar,<Name >j__TPar,<PictureUri>j__TPar,<Price >j__TPar> | 0 | 0 | 0 | |
| <>f__AnonymousType4<<Id>j__TPar, <BasketId>j__TPar,<CatalogItemId>j__TPar ,<Quantity>j__TPar,<UnitPrice>j__TPar> | 0 | 0 | 0 | |
| <>f__AnonymousType6<<Id>j__TPar,<OrderId >j__TPar,<UnitPrice>j__TPar,<Units >j__TPar,<ItemOrdered_CatalogItemId >j__TPar,<ItemOrdered_PictureUri>j__TPar ,<ItemOrdered_ProductName>j__TPar> | 0 | 0 | 0 | |
| <>f__AnonymousType1<<Id>j__TPar,<Brand >j__TPar> | 0 | 0 | 0 | |
| <>f__AnonymousType2<<Id>j__TPar,<Type >j__TPar> | 0 | 0 | 0 | |
| BasketComponentViewModel | 0 | 0 | 1 | Microsoft.eShopWeb.Web.ViewModels |
| CustomerOrdersWithItemsSpecification | 0 | 0 | 11 | Microsoft.eShopWeb.ApplicationCore .Specifications |
| OrderViewModel | 0 | 0 | 2 | Microsoft.eShopWeb.Web.ViewModels |
| LoginModel+InputModel | 0 | 0 | 1 | Microsoft.eShopWeb.Web.Areas.Identity .Pages.Account |
| <>f__AnonymousType0<<ReturnUrl>j__TPar, <RememberMe>j__TPar> | 0 | 0 | 6 | |
| CatalogFilterPaginatedSpecification | 0 | 0 | 14 | Microsoft.eShopWeb.ApplicationCore .Specifications |
| CatalogFilterSpecification | 0 | 0 | 13 | Microsoft.eShopWeb.ApplicationCore .Specifications |
| LoginViewModel | 0 | 0 | 1 | Microsoft.eShopWeb.Web.ViewModels .Account |
| ResetPasswordViewModel | 0 | 0 | 1 | Microsoft.eShopWeb.Web.ViewModels .Account |
| LoginWith2faViewModel | 0 | 0 | 1 | Microsoft.eShopWeb.Web.ViewModels .Account |
| <>f__AnonymousType1<<returnUrl>j__TPar, <RememberMe>j__TPar> | 0 | 0 | 6 | |
| RegisterViewModel | 0 | 0 | 1 | Microsoft.eShopWeb.Web.ViewModels .Account |
| ExternalLoginsViewModel | 0 | 0 | 1 | Microsoft.eShopWeb.Web.ViewModels.Manage |
| ChangePasswordViewModel | 0 | 0 | 1 | Microsoft.eShopWeb.Web.ViewModels.Manage |
| EmailSenderExtensions | 0 | 0 | 4 | Microsoft.eShopWeb.Web.Services |
| EnableAuthenticatorViewModel | 0 | 0 | 1 | Microsoft.eShopWeb.Web.ViewModels.Manage |
| SetPasswordViewModel | 0 | 0 | 1 | Microsoft.eShopWeb.Web.ViewModels.Manage |
| TwoFactorAuthenticationViewModel | 0 | 0 | 1 | Microsoft.eShopWeb.Web.ViewModels.Manage |
| RemoveLoginViewModel | 0 | 0 | 1 | Microsoft.eShopWeb.Web.ViewModels.Manage |
| GenerateRecoveryCodesViewModel | 0 | 0 | 1 | Microsoft.eShopWeb.Web.ViewModels.Manage |
| IndexViewModel | 0 | 0 | 1 | Microsoft.eShopWeb.Web.ViewModels.Manage |
| UrlHelperExtensions | 0 | 0 | 2 | Microsoft.AspNetCore.Mvc |
| <>f__AnonymousType3<<status>j__TPar, <errors>j__TPar> | 0 | 0 | 6 | |
| OrderRepository | 0 | 0 | 14 | Microsoft.eShopWeb.Infrastructure.Data |
| ApiHealthCheck | 0 | 0 | 24 | Microsoft.eShopWeb.Web.HealthChecks |
| <>f__AnonymousType4<<key>j__TPar,<value >j__TPar> | 0 | 0 | 6 | |
| OrderService | 0 | 0 | 15 | Microsoft.eShopWeb.ApplicationCore .Services |
| BasketService | 0.5 | 0.6 | 19 | Microsoft.eShopWeb.ApplicationCore .Services |
| HomePageHealthCheck | 0 | 0 | 23 | Microsoft.eShopWeb.Web.HealthChecks |
| CachedCatalogViewModelService | 0.2 | 0.25 | 19 | Microsoft.eShopWeb.Web.Services |
| BasketViewModelService | 0.53 | 0.67 | 43 | Microsoft.eShopWeb.Web.Services |
| EmailSender | 0 | 0 | 0 | Microsoft.eShopWeb.Infrastructure .Services |
| AppIdentityDbContext | 0 | 0 | 2 | Microsoft.eShopWeb.Infrastructure .Identity |
| LoggerAdapter<T> | 0 | 0 | 3 | Microsoft.eShopWeb.Infrastructure .Logging |
| SlugifyParameterTransformer | 0 | 0 | 4 | Microsoft.eShopWeb.Web |
| UriComposer | 0 | 0 | 1 | Microsoft.eShopWeb.ApplicationCore .Services |
| CatalogController | 0 | 0 | 14 | Microsoft.eShopWeb.Web.Controllers.Api |
| IdentityHostingStartup | 0 | 0 | 3 | Microsoft.eShopWeb.Web.Areas.Identity |
| Buyer | 0.33 | 0.5 | 3 | Microsoft.eShopWeb.ApplicationCore .Entities.BuyerAggregate |
| IIdentityParser<T> | - | - | 0 | Microsoft.eShopWeb.ApplicationCore .Interfaces |
| ManageController | 0.69 | 0.72 | 126 | Microsoft.eShopWeb.Web.Controllers |
| OrderController | 0 | 0 | 48 | Microsoft.eShopWeb.Web.Controllers |
| LoginModel | 0.17 | 0.25 | 47 | Microsoft.eShopWeb.Web.Areas.Identity .Pages.Account |
| AccountController | 0.73 | 0.79 | 83 | Microsoft.eShopWeb.Web.Controllers |
| Constants | 0 | 0 | 0 | Microsoft.eShopWeb.Web |
| ErrorModel | 0 | 0 | 6 | Microsoft.eShopWeb.Web.Pages |
| IndexModel | 0 | 0 | 16 | Microsoft.eShopWeb.Web.Pages |
| Program | 0 | 0 | 17 | Microsoft.eShopWeb.Web |
| InitialIdentityModel | 0 | 0 | 58 | Microsoft.eShopWeb.Infrastructure .Identity.Migrations |
| ManageNavPages | 0 | 0 | 5 | Microsoft.eShopWeb.Web.Views.Manage |
| AppIdentityDbContextModelSnapshot | 0 | 0 | 18 | Microsoft.eShopWeb.Infrastructure .Identity.Migrations |
| CheckoutModel | 0.6 | 0.75 | 49 | Microsoft.eShopWeb.Web.Pages.Basket |
| IndexModel | 0.63 | 0.76 | 51 | Microsoft.eShopWeb.Web.Pages.Basket |
| CatalogContextModelSnapshot | 0 | 0 | 23 | Microsoft.eShopWeb.Infrastructure.Data .Migrations |
| AddExtraConstraints | 0 | 0 | 24 | Microsoft.eShopWeb.Infrastructure.Data .Migrations |
| PrivacyModel | 0 | 0 | 1 | Microsoft.eShopWeb.Web.Pages |
| Basket | 0.5 | 0.67 | 30 | Microsoft.eShopWeb.Web.Pages.Shared .Components.BasketComponent |
| Initial | 0 | 0 | 54 | Microsoft.eShopWeb.Infrastructure.Data .Migrations |
Namespaces Metrics
If you wish to define thresholds on namespaces' Code Metrics, consider writing some Code Rules.
Clicking column header arrows sorts values.
Clicking column header title text redirect to the online Code Metric definition.
Clicking column header arrows sorts values.
Clicking column header title text redirect to the online Code Metric definition.
| Namespaces | # lines of code | # IL instruction | # Types | # lines of comment | % Comment | % Coverage | Afferent Coupling | Efferent Coupling |
|---|---|---|---|---|---|---|---|---|
| ApplicationCore.dll::Ardalis .GuardClauses | 2 | 11 | 1 | 0 | 0 | 50 | 1 | 3 |
| Microsoft.eShopWeb | 2 | 11 | 1 | 0 | 0 | 100 | 2 | 0 |
| Microsoft.eShopWeb.ApplicationCore .Specifications | 35 | 461 | 7 | 0 | 0 | 77.14 | 3 | 7 |
| Microsoft.eShopWeb.ApplicationCore .Services | 64 | 1365 | 3 | 0 | 0 | 32.81 | 1 | 11 |
| Microsoft.eShopWeb.ApplicationCore .Interfaces | 0 | 0 | 10 | - | - | - | 12 | 4 |
| Microsoft.eShopWeb.ApplicationCore .Exceptions | 4 | 29 | 1 | 0 | 0 | 25 | 1 | 0 |
| Microsoft.eShopWeb.ApplicationCore .Entities | 22 | 93 | 4 | 2 | 8.33 | 100 | 8 | 0 |
| Microsoft.eShopWeb.ApplicationCore .Entities.OrderAggregate | 68 | 278 | 4 | 17 | 20 | 98.53 | 7 | 3 |
| Microsoft.eShopWeb.ApplicationCore .Entities.BuyerAggregate | 14 | 58 | 2 | 2 | 12.5 | - | 0 | 3 |
| Microsoft.eShopWeb.ApplicationCore .Entities.BasketAggregate | 17 | 111 | 2 | 0 | 0 | 100 | 5 | 3 |
| Infrastructure.dll:: | 0 | 3513 | 16 | - | - | - | 2 | 1 |
| Microsoft.eShopWeb.Infrastructure .Services | 1 | 10 | 1 | 3 | 75 | - | 1 | 1 |
| Microsoft.eShopWeb.Infrastructure .Logging | 4 | 25 | 1 | 0 | 0 | 50 | 1 | 3 |
| Microsoft.eShopWeb.Infrastructure .Identity | 4 | 126 | 3 | 3 | 42.86 | 100 | 5 | 4 |
| Microsoft.eShopWeb.Infrastructure .Identity.Migrations | 190 | 2597 | 2 | 0 | 0 | - | 0 | 12 |
| Microsoft.eShopWeb.Infrastructure.Data | 97 | 2436 | 7 | 12 | 11.01 | 85.57 | 1 | 16 |
| Microsoft.eShopWeb.Infrastructure.Data .Migrations | 279 | 3635 | 3 | 0 | 0 | - | 0 | 12 |
| Web.dll:: | 0 | 520 | 5 | - | - | - | 4 | 5 |
| Web.dll::Microsoft.AspNetCore.Mvc | 2 | 26 | 1 | 0 | 0 | - | 1 | 5 |
| Microsoft.eShopWeb.Web | 117 | 1046 | 4 | 23 | 16.43 | 55.56 | 0 | 83 |
| Microsoft.eShopWeb.Web.Interfaces | 0 | 0 | 1 | - | - | - | 4 | 3 |
| Microsoft.eShopWeb.Web.HealthChecks | 22 | 445 | 2 | 0 | 0 | - | 1 | 12 |
| Microsoft.eShopWeb.Web.Services | 85 | 2343 | 5 | 5 | 5.56 | 91.76 | 4 | 22 |
| Microsoft.eShopWeb.Web.Views.Manage | 12 | 51 | 1 | 0 | 0 | - | 0 | 4 |
| Microsoft.eShopWeb.Web.ViewModels | 59 | 230 | 6 | 0 | 0 | 57.63 | 6 | 7 |
| Microsoft.eShopWeb.Web.ViewModels.Manage | 50 | 207 | 8 | 0 | 0 | - | 1 | 9 |
| Microsoft.eShopWeb.Web.ViewModels .Account | 26 | 107 | 4 | 0 | 0 | 19.23 | 1 | 4 |
| Microsoft.eShopWeb.Web.Pages | 10 | 178 | 3 | 0 | 0 | 60 | 0 | 11 |
| Microsoft.eShopWeb.Web.Pages.Basket | 81 | 1387 | 4 | 0 | 0 | 53.09 | 3 | 23 |
| Microsoft.eShopWeb.Web.Pages.Shared .Components.BasketComponent | 16 | 351 | 1 | 0 | 0 | 87.5 | 0 | 20 |
| Microsoft.eShopWeb.Web.Controllers | 281 | 6577 | 3 | 11 | 3.77 | 4.98 | 0 | 37 |
| Microsoft.eShopWeb.Web.Controllers.Api | 5 | 140 | 2 | 0 | 0 | 100 | 0 | 10 |
| Microsoft.eShopWeb.Web.Areas.Identity | 1 | 20 | 1 | 0 | 0 | 100 | 0 | 5 |
| Microsoft.eShopWeb.Web.Areas.Identity .Pages.Account | 37 | 471 | 2 | 4 | 9.76 | 35.14 | 0 | 23 |
| Quality Gates 317 |
|
 | Quality Gate Fail: Percentage Coverage |
• Quality Gate Description:
Code coverage is a measure used to describe the degree to which the source code of a program is tested by a particular test suite. A program with high code coverage, measured as a percentage, has had more of its source code executed during testing which suggests it has a lower chance of containing undetected software bugs compared to a program with low code coverage.
Code coverage is certainly the most important quality code metric. But coverage is not enough the team needs to ensure that results are checked at test-time. These checks can be done both in test code, and in application code through assertions. The important part is that a test must fail explicitely when a check gets unvalidated during the test execution.
This quality gate define a warn threshold (70%) and a fail threshold (80%). These are indicative thresholds and in practice the more the better. To achieve high coverage and low risk, make sure that new and refactored classes gets 100% covered by tests and that the application and test code contains as many checks/assertions as possible.
Scalar Result: 32.67 %
| Quality Gate Fail: Percentage Coverage on New Code |
• Quality Gate Description:
New Code is defined as methods added since the baseline.
To achieve high code coverage it is essential that new code gets properly tested and covered by tests. It is advised that all non-UI new classes gets 100% covered.
Typically 90% of a class is easy to cover by tests and 10% is hard to reach through tests. It means that this 10% remaining is not easily testable, which means it is not well designed, which often means that this code is especially error-prone. This is the reason why it is important to reach 100% coverage for a class, to make sure that potentially error-prone code gets tested.
Scalar Result: 47.31 %
| Quality Gate Fail: Percentage Coverage on Refactored Code |
• Quality Gate Description:
Refactored Code is defined as methods where code was changed since the baseline.
Comment changes and formatting changes are not considerd as refactoring.
To achieve high code coverage it is essential that refactored code gets properly tested and covered by tests. It is advised that when refactoring a class or a method, it is important to also write tests to make sure it gets 100% covered.
Typically 90% of a class is easy to cover by tests and 10% is hard to reach through tests. It means that this 10% remaining is not easily testable, which means it is not well designed, which often means that this code is especially error-prone. This is the reason why it is important to reach 100% coverage for a class, to make sure that potentially error-prone code gets tested.
Scalar Result: 44.65 %
 | Quality Gate Pass: Blocker Issues |
• Quality Gate Description:
An issue with the severity Blocker cannot move to production, it must be fixed.
The severity of an issue is either defined explicitely in the rule source code, either inferred from the issue annual interest and thresholds defined in the NDepend Project Properties > Issue and Debt.
No issue matched
| Quality Gate Pass: Critical Issues |
• Quality Gate Description:
An issue with a severity level Critical shouldn't move to production. It still can for business imperative needs purposes, but at worst it must be fixed during the next iterations.
The severity of an issue is either defined explicitely in the rule source code, either inferred from the issue annual interest and thresholds defined in the NDepend Project Properties > Issue and Debt.
No issue matched
| Quality Gate Fail: New Blocker / Critical / High Issues |
• Quality Gate Description:
An issue with the severity Blocker cannot move to production, it must be fixed.
An issue with a severity level Critical shouldn't move to production. It still can for business imperative needs purposes, but at worth it must be fixed during the next iterations.
An issue with a severity level High should be fixed quickly, but can wait until the next scheduled interval.
The severity of an issue is either defined explicitely in the rule source code, either inferred from the issue annual interest and thresholds defined in the NDepend Project Properties > Issue and Debt.
121 issues matched
| 121 issues | Severity | Debt | Annual Interest | Full Name |
|---|---|---|---|---|
| High issue on: Microsoft.eShopWeb.Infrastructure.Data .SpecificationEvaluator<T> | High | 10min | 1h 0min | Rule violated: From now, all types added should be 100% covered by tests |
| High issue on: Microsoft.eShopWeb .Infrastructure.Data.Migrations .AddExtraConstraints | High | 10min | 1h 0min | Rule violated: From now, all types added should be 100% covered by tests |
| High issue on: Microsoft.eShopWeb.Web .SlugifyParameterTransformer | High | 10min | 1h 0min | Rule violated: From now, all types added should be 100% covered by tests |
| High issue on: Microsoft.eShopWeb.Web .HealthChecks.ApiHealthCheck | High | 10min | 1h 0min | Rule violated: From now, all types added should be 100% covered by tests |
| High issue on: Microsoft.eShopWeb.Web .HealthChecks.HomePageHealthCheck | High | 10min | 1h 0min | Rule violated: From now, all types added should be 100% covered by tests |
| High issue on: Microsoft.eShopWeb.Web .Services.CachedCatalogViewModelService | High | 10min | 1h 0min | Rule violated: From now, all types added should be 100% covered by tests |
| High issue on: Microsoft.eShopWeb.Web.Pages.ErrorModel | High | 10min | 1h 0min | Rule violated: From now, all types added should be 100% covered by tests |
| High issue on: Microsoft.eShopWeb.Web .Pages.PrivacyModel | High | 10min | 1h 0min | Rule violated: From now, all types added should be 100% covered by tests |
| High issue on: Microsoft.eShopWeb.Web .Pages.Basket.BasketItemViewModel | High | 10min | 1h 0min | Rule violated: From now, all types added should be 100% covered by tests |
| High issue on: Microsoft.eShopWeb.Web .Pages.Basket.BasketViewModel | High | 10min | 1h 0min | Rule violated: From now, all types added should be 100% covered by tests |
| High issue on: Microsoft.eShopWeb.Web .Pages.Basket.CheckoutModel | High | 10min | 1h 0min | Rule violated: From now, all types added should be 100% covered by tests |
| High issue on: Microsoft.eShopWeb.Web .Pages.Basket.IndexModel | High | 10min | 1h 0min | Rule violated: From now, all types added should be 100% covered by tests |
| High issue on: Microsoft.eShopWeb.Web .Pages.Shared.Components.BasketComponent .Basket | High | 10min | 1h 0min | Rule violated: From now, all types added should be 100% covered by tests |
| High issue on: Microsoft.eShopWeb.Web .Areas.Identity.Pages.Account.LoginModel | High | 10min | 1h 0min | Rule violated: From now, all types added should be 100% covered by tests |
| High issue on: Microsoft.eShopWeb.Web .Areas.Identity.Pages.Account .LoginModel+InputModel | High | 10min | 1h 0min | Rule violated: From now, all types added should be 100% covered by tests |
| High issue on: Microsoft.eShopWeb .Infrastructure.Data.Migrations .AddExtraConstraints.Up(MigrationBuilder ) | High | 5min | 1h 0min | Rule violated: From now, all methods added should respect basic quality principles |
| High issue on: Microsoft.eShopWeb .Infrastructure.Data.Migrations .AddExtraConstraints.Down (MigrationBuilder) | High | 5min | 1h 0min | Rule violated: From now, all methods added should respect basic quality principles |
| High issue on: Microsoft.eShopWeb .ApplicationCore.Specifications .BaseSpecification<T> | High | 1h 0min | 20min | Rule violated: Avoid transforming an immutable type into a mutable one |
| High issue on: Microsoft.eShopWeb .ApplicationCore.Specifications .BasketWithItemsSpecification | High | 10min | 20min | Rule violated: Avoid transforming an immutable type into a mutable one |
| High issue on: Microsoft.eShopWeb .ApplicationCore.Specifications .CatalogFilterSpecification | High | 10min | 20min | Rule violated: Avoid transforming an immutable type into a mutable one |
| High issue on: Microsoft.eShopWeb .ApplicationCore.Specifications .CustomerOrdersWithItemsSpecification | High | 10min | 20min | Rule violated: Avoid transforming an immutable type into a mutable one |
| High issue on: Microsoft.eShopWeb .ApplicationCore.Specifications .CatalogFilterPaginatedSpecification. .ctor(Int32,Int32,Nullable<Int32> ,Nullable<Int32>) | High | 6min | 20min | Rule violated: Constructor should not call a virtual method |
| High issue on: Microsoft.eShopWeb.Web .Interfaces.IBasketViewModelService | High | 15min | 1h 1min | Rule violated: Avoid namespaces mutually dependent |
| High issue on: Microsoft.eShopWeb.Web.Interfaces | High | 2h 0min | 20min | Rule violated: Avoid namespaces dependency cycles |
| High issue on: Microsoft.eShopWeb .ApplicationCore.Interfaces.IRepository <T> | High | 20min | 20min | Rule violated: API Breaking Changes: Types |
| High issue on: Microsoft.eShopWeb.Web .ViewComponents.Basket | High | 20min | 20min | Rule violated: API Breaking Changes: Types |
| High issue on: Microsoft.eShopWeb.Web .Services.ICatalogService | High | 20min | 20min | Rule violated: API Breaking Changes: Types |
| High issue on: Microsoft.eShopWeb.Web .Services.CachedCatalogService | High | 20min | 20min | Rule violated: API Breaking Changes: Types |
| High issue on: Microsoft.eShopWeb.Web .Services.CatalogService | High | 20min | 20min | Rule violated: API Breaking Changes: Types |
| High issue on: Microsoft.eShopWeb.Web .ViewModels.BasketItemViewModel | High | 20min | 20min | Rule violated: API Breaking Changes: Types |
| High issue on: Microsoft.eShopWeb.Web .ViewModels.BasketViewModel | High | 20min | 20min | Rule violated: API Breaking Changes: Types |
| High issue on: Microsoft.eShopWeb.Web .Controllers.BasketController | High | 20min | 20min | Rule violated: API Breaking Changes: Types |
| High issue on: Microsoft.eShopWeb.Web .Controllers.CatalogController | High | 20min | 20min | Rule violated: API Breaking Changes: Types |
| High issue on: Microsoft.eShopWeb .ApplicationCore.Services.BasketService. .ctor(IAsyncRepository<Basket> ,IRepository<CatalogItem>,IUriComposer ,IAppLogger<BasketService>) | High | 10min | 20min | Rule violated: API Breaking Changes: Methods |
| High issue on: Microsoft.eShopWeb .ApplicationCore.Interfaces .IOrderRepository.GetByIdWithItems(Int32 ) | High | 10min | 20min | Rule violated: API Breaking Changes: Methods |
| High issue on: Microsoft.eShopWeb .Infrastructure.Data.EfRepository<T> .GetById(Int32) | High | 10min | 20min | Rule violated: API Breaking Changes: Methods |
| High issue on: Microsoft.eShopWeb .Infrastructure.Data.EfRepository<T> .GetSingleBySpec(ISpecification<T>) | High | 10min | 20min | Rule violated: API Breaking Changes: Methods |
| High issue on: Microsoft.eShopWeb .Infrastructure.Data.EfRepository<T> .ListAll() | High | 10min | 20min | Rule violated: API Breaking Changes: Methods |
| High issue on: Microsoft.eShopWeb .Infrastructure.Data.EfRepository<T> .List(ISpecification<T>) | High | 10min | 20min | Rule violated: API Breaking Changes: Methods |
| High issue on: Microsoft.eShopWeb .Infrastructure.Data.EfRepository<T>.Add (T) | High | 10min | 20min | Rule violated: API Breaking Changes: Methods |
| High issue on: Microsoft.eShopWeb .Infrastructure.Data.EfRepository<T> .Update(T) | High | 10min | 20min | Rule violated: API Breaking Changes: Methods |
| High issue on: Microsoft.eShopWeb .Infrastructure.Data.EfRepository<T> .Delete(T) | High | 10min | 20min | Rule violated: API Breaking Changes: Methods |
| High issue on: Microsoft.eShopWeb .Infrastructure.Data.OrderRepository .GetByIdWithItems(Int32) | High | 10min | 20min | Rule violated: API Breaking Changes: Methods |
| High issue on: Microsoft.eShopWeb.Web .Startup.Configure(IApplicationBuilder ,IHostingEnvironment) | High | 10min | 20min | Rule violated: API Breaking Changes: Methods |
| High issue on: Microsoft.eShopWeb.Web .Services.BasketViewModelService..ctor (IAsyncRepository<Basket>,IRepository <CatalogItem>,IUriComposer) | High | 10min | 20min | Rule violated: API Breaking Changes: Methods |
| High issue on: Microsoft.eShopWeb.Web .Controllers.ManageController.Index() | High | 10min | 20min | Rule violated: API Breaking Changes: Methods |
| High issue on: Microsoft.eShopWeb.Web .Controllers.OrderController.Index() | High | 10min | 20min | Rule violated: API Breaking Changes: Methods |
| High issue on: Microsoft.eShopWeb.Web .Controllers.Api.CatalogController..ctor (ICatalogService) | High | 10min | 20min | Rule violated: API Breaking Changes: Methods |
| High issue on: Microsoft.eShopWeb.Web .Services.BasketViewModelService ._itemRepository | High | 10min | 20min | Rule violated: API Breaking Changes: Fields |
| High issue on: Microsoft.eShopWeb .ApplicationCore.Interfaces .IAsyncRepository<T> | High | 10min | 20min | Rule violated: API Breaking Changes: Interfaces and Abstract Classes |
| High issue on: Microsoft.eShopWeb .ApplicationCore.Interfaces .IOrderRepository | High | 10min | 20min | Rule violated: API Breaking Changes: Interfaces and Abstract Classes |
| High issue on: Microsoft.eShopWeb .ApplicationCore.Interfaces .ISpecification<T> | High | 10min | 20min | Rule violated: API Breaking Changes: Interfaces and Abstract Classes |
| High issue on: Microsoft.eShopWeb .Infrastructure.Data.Migrations .AddExtraConstraints.BuildTargetModel (ModelBuilder) | High | 10min | 20min | Rule violated: New Methods should be tested |
| High issue on: Microsoft.eShopWeb.Web .Startup.ListAllRegisteredServices (IApplicationBuilder,LinkGenerator) | High | 10min | 20min | Rule violated: New Methods should be tested |
| High issue on: Microsoft.eShopWeb.Web .Areas.Identity.Pages.Account.LoginModel .OnPostAsync(String) | High | 10min | 20min | Rule violated: New Methods should be tested |
| High issue on: Microsoft.eShopWeb.Web .HealthChecks.ApiHealthCheck .CheckHealthAsync(HealthCheckContext ,CancellationToken) | High | 9min | 20min | Rule violated: New Methods should be tested |
| High issue on: Microsoft.eShopWeb.Web .HealthChecks.HomePageHealthCheck .CheckHealthAsync(HealthCheckContext ,CancellationToken) | High | 8min | 20min | Rule violated: New Methods should be tested |
| High issue on: Microsoft.eShopWeb.Web .Pages.Basket.CheckoutModel..ctor (IBasketService,IBasketViewModelService ,IUriComposer,SignInManager <ApplicationUser>,IOrderService) | High | 8min | 20min | Rule violated: New Methods should be tested |
| High issue on: Microsoft.eShopWeb.Web .Pages.Basket.CheckoutModel .GetOrSetBasketCookieAndUserName() | High | 8min | 20min | Rule violated: New Methods should be tested |
| High issue on: Microsoft.eShopWeb .Infrastructure.Data.Migrations .AddExtraConstraints.Up(MigrationBuilder ) | High | 6min | 20min | Rule violated: New Methods should be tested |
| High issue on: Microsoft.eShopWeb .Infrastructure.Data.Migrations .AddExtraConstraints.Down (MigrationBuilder) | High | 6min | 20min | Rule violated: New Methods should be tested |
| High issue on: Microsoft.eShopWeb.Web .Pages.Basket.CheckoutModel.OnPost (Dictionary<String,Int32>) | High | 5min | 20min | Rule violated: New Methods should be tested |
| High issue on: Microsoft.eShopWeb.Web .Controllers.ManageController.MyAccount( ) | High | 5min | 20min | Rule violated: New Methods should be tested |
| High issue on: Microsoft.eShopWeb.Web .Controllers.OrderController.MyOrders() | High | 5min | 20min | Rule violated: New Methods should be tested |
| High issue on: Microsoft.eShopWeb.Web .Pages.Basket.CheckoutModel .SetBasketModelAsync() | High | 4min 40s | 20min | Rule violated: New Methods should be tested |
| High issue on: Microsoft.eShopWeb.Web .HealthChecks.ApiHealthCheck..ctor (IHttpContextAccessor,LinkGenerator) | High | 3min 46s | 20min | Rule violated: New Methods should be tested |
| High issue on: Microsoft.eShopWeb.Web .Services.CachedCatalogViewModelService .GetBrands() | High | 3min 46s | 20min | Rule violated: New Methods should be tested |
| High issue on: Microsoft.eShopWeb.Web .Services.CachedCatalogViewModelService .GetTypes() | High | 3min 46s | 20min | Rule violated: New Methods should be tested |
| High issue on: Microsoft.eShopWeb.Web .Pages.Basket.IndexModel.OnPostUpdate (Dictionary<String,Int32>) | High | 3min 46s | 20min | Rule violated: New Methods should be tested |
| High issue on: Microsoft.eShopWeb.Web .HealthChecks.HomePageHealthCheck..ctor (IHttpContextAccessor) | High | 2min 53s | 20min | Rule violated: New Methods should be tested |
| High issue on: Microsoft.eShopWeb .ApplicationCore.Specifications .BaseSpecification<T>.set_OrderBy (Expression<Func<T,Object>>) | High | 2min 0s | 20min | Rule violated: New Methods should be tested |
| High issue on: Microsoft.eShopWeb .ApplicationCore.Specifications .BaseSpecification<T> .set_OrderByDescending(Expression<Func<T ,Object>>) | High | 2min 0s | 20min | Rule violated: New Methods should be tested |
| High issue on: Microsoft.eShopWeb .ApplicationCore.Specifications .BaseSpecification<T>.ApplyOrderBy (Expression<Func<T,Object>>) | High | 2min 0s | 20min | Rule violated: New Methods should be tested |
| High issue on: Microsoft.eShopWeb .ApplicationCore.Specifications .BaseSpecification<T> .ApplyOrderByDescending(Expression<Func <T,Object>>) | High | 2min 0s | 20min | Rule violated: New Methods should be tested |
| High issue on: Microsoft.eShopWeb.Web .Pages.ErrorModel.get_RequestId() | High | 2min 0s | 20min | Rule violated: New Methods should be tested |
| High issue on: Microsoft.eShopWeb.Web .Pages.ErrorModel.set_RequestId(String) | High | 2min 0s | 20min | Rule violated: New Methods should be tested |
| High issue on: Microsoft.eShopWeb.Web .Pages.ErrorModel.get_ShowRequestId() | High | 2min 0s | 20min | Rule violated: New Methods should be tested |
| High issue on: Microsoft.eShopWeb.Web .Pages.ErrorModel.OnGet() | High | 2min 0s | 20min | Rule violated: New Methods should be tested |
| High issue on: Microsoft.eShopWeb.Web .Pages.Basket.BasketItemViewModel .get_CatalogItemId() | High | 2min 0s | 20min | Rule violated: New Methods should be tested |
| High issue on: Microsoft.eShopWeb.Web .Pages.Basket.BasketItemViewModel .get_OldUnitPrice() | High | 2min 0s | 20min | Rule violated: New Methods should be tested |
| High issue on: Microsoft.eShopWeb.Web .Pages.Basket.BasketItemViewModel .set_OldUnitPrice(Decimal) | High | 2min 0s | 20min | Rule violated: New Methods should be tested |
| High issue on: Microsoft.eShopWeb.Web .Pages.Basket.BasketViewModel .get_BuyerId() | High | 2min 0s | 20min | Rule violated: New Methods should be tested |
| High issue on: Microsoft.eShopWeb.Web .Pages.Basket.CheckoutModel .get_BasketModel() | High | 2min 0s | 20min | Rule violated: New Methods should be tested |
| High issue on: Microsoft.eShopWeb.Web .Pages.Basket.CheckoutModel .set_BasketModel(BasketViewModel) | High | 2min 0s | 20min | Rule violated: New Methods should be tested |
| High issue on: Microsoft.eShopWeb.Web .Areas.Identity.Pages.Account.LoginModel .set_Input(LoginModel+InputModel) | High | 2min 0s | 20min | Rule violated: New Methods should be tested |
| High issue on: Microsoft.eShopWeb.Web .Areas.Identity.Pages.Account.LoginModel .get_ExternalLogins() | High | 2min 0s | 20min | Rule violated: New Methods should be tested |
| High issue on: Microsoft.eShopWeb.Web .Areas.Identity.Pages.Account .LoginModel+InputModel.get_Email() | High | 2min 0s | 20min | Rule violated: New Methods should be tested |
| High issue on: Microsoft.eShopWeb.Web .Areas.Identity.Pages.Account .LoginModel+InputModel.set_Email(String) | High | 2min 0s | 20min | Rule violated: New Methods should be tested |
| High issue on: Microsoft.eShopWeb.Web .Areas.Identity.Pages.Account .LoginModel+InputModel.get_Password() | High | 2min 0s | 20min | Rule violated: New Methods should be tested |
| High issue on: Microsoft.eShopWeb.Web .Areas.Identity.Pages.Account .LoginModel+InputModel.set_Password (String) | High | 2min 0s | 20min | Rule violated: New Methods should be tested |
| High issue on: Microsoft.eShopWeb.Web .Areas.Identity.Pages.Account .LoginModel+InputModel.get_RememberMe() | High | 2min 0s | 20min | Rule violated: New Methods should be tested |
| High issue on: Microsoft.eShopWeb.Web .Areas.Identity.Pages.Account .LoginModel+InputModel.set_RememberMe (Boolean) | High | 2min 0s | 20min | Rule violated: New Methods should be tested |
| High issue on: Microsoft.eShopWeb .Infrastructure.Data.Migrations .CatalogContextModelSnapshot.BuildModel (ModelBuilder) | High | 10min | 20min | Rule violated: Methods refactored should be tested |
| High issue on: Microsoft.eShopWeb.Web .Controllers.AccountController .ConfirmEmail(String,String) | High | 7min | 20min | Rule violated: Methods refactored should be tested |
| High issue on: Microsoft.eShopWeb .ApplicationCore.Specifications .CustomerOrdersWithItemsSpecification. .ctor(String) | High | 3min 46s | 20min | Rule violated: Methods refactored should be tested |
| High issue on: Microsoft.eShopWeb.Web .Controllers.AccountController.SignOut() | High | 2min 53s | 20min | Rule violated: Methods refactored should be tested |
| High issue on: Microsoft.eShopWeb .ApplicationCore.Entities.OrderAggregate .Order | High | 2min 0s | 20min | Rule violated: Types almost 100% tested should be 100% tested |
| High issue on: Microsoft.eShopWeb .ApplicationCore.Entities.OrderAggregate | High | 2min 0s | 20min | Rule violated: Namespaces almost 100% tested should be 100% tested |
| High issue on: Microsoft.eShopWeb.Web .Areas.Identity.Pages.Account.LoginModel .OnPostAsync(String) | High | 10min | 20min | Rule violated: Methods should have a low C.R.A.P score |
| High issue on: Microsoft.eShopWeb.Web .Pages.Shared.Components.BasketComponent .Basket | High | 12min | 20min | Rule violated: Avoid naming types and namespaces with the same identifier |
Statistics
| Stat | Severity | Debt | Annual Interest |
|---|---|---|---|
| Sum: | - | 2d 7h | 6d 4h |
| Average: | - | 11min | 25min |
| Minimum: | - | 2min 0s | 20min |
| Maximum: | - | 2h 0min | 1h 1min |
| Standard deviation: | - | 12min | 14min |
| Variance: | - | 20d | 25d |
| Quality Gate Fail: Critical Rules Violated |
• Quality Gate Description:
The concept of critical rule is useful to pinpoint certain rules that should not be violated.
A rule can be made critical just by checking the Critical button in the rule edition control and then saving the rule.
This quality gate fails if any critical rule gets any violations.
When no baseline is available, rules that rely on diff are not counted. If you observe that this quality gate count slightly decreases with no apparent reason, the reason is certainly that rules that rely on diff are not counted because the baseline is not defined.
6 rules matched
| 6 rules | issues | Full Name |
|---|---|---|
| Avoid namespaces mutually dependent | 2 issues | Rule |
| API Breaking Changes: Types | 9 issues | Rule |
| API Breaking Changes: Methods | 15 issues | Rule |
| API Breaking Changes: Fields | 1 issue | Rule |
| API Breaking Changes: Interfaces and Abstract Classes | 3 issues | Rule |
| Avoid having different types with same name | 1 issue | Rule |
Statistics
| Stat | issues |
|---|---|
| Sum: | 31 |
| Average: | 5.17 |
| Minimum: | 1 |
| Maximum: | 15 |
| Standard deviation: | 5.18 |
| Variance: | 26.81 |
 | Quality Gate Warn: Percentage Debt |
• Quality Gate Description:
% Debt total is defined as a percentage on:
• the estimated total effort to develop the code base
• and the the estimated total time to fix all issues (the Debt)
Estimated total effort to develop the code base is inferred from # lines of code of the code base and from the Estimated number of man-day to develop 1000 logicial lines of code setting found in NDepend Project Properties > Issue and Debt.
Debt documentation: https://www.ndepend.com/docs/technical-debt#Debt
This quality gates fails if the estimated debt is more than 30% of the estimated effort to develop the code base, and warns if the estimated debt is more than 20% of the estimated effort to develop the code base
Scalar Result: 23.09 %
| Quality Gate Pass: New Debt since Baseline |
• Quality Gate Description:
This Quality Gate fails if the estimated effort to fix new or worsened issues (what is called the New Debt since Baseline) is higher than 2 man-days.
This Quality Gate warns if this estimated effort is positive.
Debt documentation: https://www.ndepend.com/docs/technical-debt#Debt
Scalar Result: -1.32 man-days
| Quality Gate Fail: Debt Rating per Namespace |
• Quality Gate Description:
Forbid namespaces with a poor Debt Rating equals to E or D.
The Debt Rating for a code element is estimated by the value of the Debt Ratio and from the various rating thresholds defined in this project Debt Settings.
The Debt Ratio of a code element is a percentage of Debt Amount (in floating man-days) compared to the estimated effort to develop the code element (also in floating man-days).
The estimated effort to develop the code element is inferred from the code elements number of lines of code, and from the project Debt Settings parameters estimated number of man-days to develop 1000 logical lines of code.
The logical lines of code corresponds to the number of debug breakpoints in a method and doesn't depend on code formatting nor comments.
The Quality Gate can be modified to match assemblies, types or methods with a poor Debt Rating, instead of matching namespaces.
13 namespaces matched
| 13 namespaces | debtRating | debtRatio | devTimeInManDay | debtInManDay | issues | Full Name |
|---|---|---|---|---|---|---|
| Ardalis.GuardClauses | D | 42.49 | 43min | 18min | 4 issues | Ardalis.GuardClauses |
| Microsoft.eShopWeb.ApplicationCore .Specifications | D | 21.81 | 1d 3h | 2h 32min | 21 issues | Microsoft.eShopWeb.ApplicationCore .Specifications |
| Microsoft.eShopWeb.ApplicationCore .Interfaces | E | 60.61 | 5h 28min | 3h 19min | 7 issues | Microsoft.eShopWeb.ApplicationCore .Interfaces |
| Microsoft.eShopWeb.Infrastructure .Identity.Migrations | D | 38.78 | 3d 4h | 1d 3h | 6 issues | Microsoft.eShopWeb.Infrastructure .Identity.Migrations |
| Microsoft.eShopWeb.Infrastructure.Data .Migrations | D | 37 | 5d 2h | 1d 7h | 16 issues | Microsoft.eShopWeb.Infrastructure.Data .Migrations |
| Microsoft.AspNetCore.Mvc | D | 45.52 | 51min | 23min | 6 issues | Microsoft.AspNetCore.Mvc |
| Microsoft.eShopWeb.Web.Interfaces | E | 520.83 | 25min | 2h 15min | 2 issues | Microsoft.eShopWeb.Web.Interfaces |
| Microsoft.eShopWeb.Web.HealthChecks | D | 37.46 | 4h 36min | 1h 43min | 12 issues | Microsoft.eShopWeb.Web.HealthChecks |
| Microsoft.eShopWeb.Web.Views.Manage | D | 20.23 | 3h 36min | 43min | 13 issues | Microsoft.eShopWeb.Web.Views.Manage |
| Microsoft.eShopWeb.Web.Pages | D | 22.27 | 4h 1min | 53min | 15 issues | Microsoft.eShopWeb.Web.Pages |
| Microsoft.eShopWeb.Web.Controllers | E | 54.49 | 6d 0h | 3d 2h | 73 issues | Microsoft.eShopWeb.Web.Controllers |
| Microsoft.eShopWeb.Web.Areas.Identity | D | 30.09 | 43min | 13min | 2 issues | Microsoft.eShopWeb.Web.Areas.Identity |
| Microsoft.eShopWeb.Web.Areas.Identity .Pages.Account | D | 32.93 | 1d 1h | 3h 10min | 26 issues | Microsoft.eShopWeb.Web.Areas.Identity .Pages.Account |
Statistics
| Stat | debtRating | debtRatio | devTimeInManDay | debtInManDay | issues |
|---|---|---|---|---|---|
| Sum: | - | 964.52 | 20d | 8d 4h | 203 |
| Average: | - | 74.19 | 1d 4h | 5h 17min | 15.62 |
| Minimum: | - | 20.23 | 25min | 13min | 2 |
| Maximum: | - | 520.83 | 6d 0h | 3d 2h | 73 |
| Standard deviation: | - | 129.46 | 1d 7h | 7h 33min | 18.01 |
| Variance: | - | 16 759 | 113 570d | 25 748d | 324.24 |
| Quality Gate Fail: New Annual Interest since Baseline |
• Quality Gate Description:
This Quality Gate fails if the estimated annual cost to leave all issues unfixed, increased from more than 2 man-days since the baseline.
This Quality Gate warns if this estimated annual cost is positive.
This estimated annual cost is named the Annual-Interest.
Each rule can either provide a formula to compute the Annual-Interest per issue, or assign a Severity level for each issue. Some thresholds defined in Project Properties > Issue and Debt > Annual Interest are used to infer an Annual-Interest value from a Severity level. Annual Interest documentation: https://www.ndepend.com/docs/technical-debt#AnnualInterest
Scalar Result: 4.54 man-days
| Hot Spots 000 |
| Code Smells 000 |
| Code Smells Regression 000 |
| Object Oriented Design 000 |
| Design 000 |
| Architecture 000 |
| API Breaking Changes 000 |
| Code Coverage 000 |
| Dead Code 000 |
| Security 000 |
| Visibility 000 |
| Immutability 000 |
| Naming Conventions 000 |
| Source Files Organization 000 |
| .NET Framework Usage 000 |
| Defining JustMyCode 000 |
| Trend Metrics 000 |
| Code Diff Summary 000 |
| Rules extracted from Source Code 000 |
| Code Smells 710 |
|
 | Rule Violated: Avoid types with too many methods |
• Rule Description:
This rule matches types with more than 20 methods. Such type might be hard to understand and maintain.
Notice that methods like constructors or property and event accessors are not taken account.
Having many methods for a type might be a symptom of too many responsibilities implemented.
Maybe you are facing the God Class phenomenon: A God Class is a class that controls way too many other classes in the system and has grown beyond all logic to become The Class That Does Everything.
• How to Fix Issues of this Rule: To refactor properly a God Class please read HowToFix advices from the default rule Types to Big. // The estimated Debt, which means the effort to fix such issue, varies linearly from 1 hour for a type with 20 methods, up to 10 hours for a type with 200 or more methods. In Debt and Interest computation, this rule takes account of the fact that static types with no mutable fields are just a collection of static methods that can be easily splitted and moved from one type to another.
• How to Suppress an Issue of this Rule: In source code, tag the concerned code element with this attribute: [SuppressMessage("NDepend", "ND1001:AvoidTypesWithTooManyMethods", Justification="...")] This attribute requires the compilation symbol CODE_ANALYSIS to be set on each Visual Studio project relying on it. Without CODE_ANALYSIS symbol defined, the attribute is not compiled and the issues are not suppressed.
• How to Fix Issues of this Rule: To refactor properly a God Class please read HowToFix advices from the default rule Types to Big. // The estimated Debt, which means the effort to fix such issue, varies linearly from 1 hour for a type with 20 methods, up to 10 hours for a type with 200 or more methods. In Debt and Interest computation, this rule takes account of the fact that static types with no mutable fields are just a collection of static methods that can be easily splitted and moved from one type to another.
• How to Suppress an Issue of this Rule: In source code, tag the concerned code element with this attribute: [SuppressMessage("NDepend", "ND1001:AvoidTypesWithTooManyMethods", Justification="...")] This attribute requires the compilation symbol CODE_ANALYSIS to be set on each Visual Studio project relying on it. Without CODE_ANALYSIS symbol defined, the attribute is not compiled and the issues are not suppressed.
1 type matched
-
Formatting: bold means added, underlined means code was changed,
strike-boldmeans removed (since baseline)
| 1 type | nbMethods | instanceMethods | staticMethods | # lines of code (LOC) | Debt | Annual Interest | Full Name |
|---|---|---|---|---|---|---|---|
| ManageController | 22 | 22 methods | no method | 189 | 1h 6min | 3min 18s | Microsoft.eShopWeb.Web.Controllers .ManageController |
| Code Smells Regression 630 |
| Rule Violated: From now, all types added should be 100% covered by tests |
• Rule Description:
This rule is executed only if a baseline for comparison is defined (diff mode). This rule operates only on types added since baseline.
This rule can be easily modified to also match types refactored since baseline, that are not 100% covered by tests.
This rule is executed only if some code coverage data is imported from some code coverage files.
Often covering 10% of remaining uncovered code of a class, requires as much work as covering the first 90%. For this reason, typically teams estimate that 90% coverage is enough. However untestable code usually means poorly written code which usually leads to error prone code. So it might be worth refactoring and making sure to cover the 10% remaining code because most tricky bugs might come from this small portion of hard-to-test code.
Not all classes should be 100% covered by tests (like UI code can be hard to test) but you should make sure that most of the logic of your application is defined in some easy-to-test classes, 100% covered by tests.
In this context, this rule warns when a type added or refactored since the baseline, is not fully covered by tests.
• How to Fix Issues of this Rule: Write more unit-tests dedicated to cover code not covered yet. If you find some hard-to-test code, it is certainly a sign that this code is not well designed and hence, needs refactoring. You'll find code impossible to cover by unit-tests, like calls to MessageBox.Show(). An infrastructure must be defined to be able to mock such code at test-time. Issues of this rule have a constant 10 minutes Debt, because the Debt, which means the effort to write tests for the culprit type, is already estimated for issues in the category Code Coverage. However issues of this rule have a High severity, with even more interests for issues on new types since baseline, because the proper time to write tests for these types is now, before they get commited in the next production release.
• How to Suppress an Issue of this Rule: In source code, tag the concerned code element with this attribute: [SuppressMessage("NDepend", "ND1101:FromNowAllTypesAddedShouldBe100PercentCoveredByTests", Justification="...")] This attribute requires the compilation symbol CODE_ANALYSIS to be set on each Visual Studio project relying on it. Without CODE_ANALYSIS symbol defined, the attribute is not compiled and the issues are not suppressed.
• How to Fix Issues of this Rule: Write more unit-tests dedicated to cover code not covered yet. If you find some hard-to-test code, it is certainly a sign that this code is not well designed and hence, needs refactoring. You'll find code impossible to cover by unit-tests, like calls to MessageBox.Show(). An infrastructure must be defined to be able to mock such code at test-time. Issues of this rule have a constant 10 minutes Debt, because the Debt, which means the effort to write tests for the culprit type, is already estimated for issues in the category Code Coverage. However issues of this rule have a High severity, with even more interests for issues on new types since baseline, because the proper time to write tests for these types is now, before they get commited in the next production release.
• How to Suppress an Issue of this Rule: In source code, tag the concerned code element with this attribute: [SuppressMessage("NDepend", "ND1101:FromNowAllTypesAddedShouldBe100PercentCoveredByTests", Justification="...")] This attribute requires the compilation symbol CODE_ANALYSIS to be set on each Visual Studio project relying on it. Without CODE_ANALYSIS symbol defined, the attribute is not compiled and the issues are not suppressed.
15 types matched
-
Formatting: bold means added, underlined means code was changed,
strike-boldmeans removed (since baseline)
| 15 types | Percentage Coverage | methodsCulprit | # lines of code (LOC) | Debt | Annual Interest | Full Name |
|---|---|---|---|---|---|---|
| SpecificationEvaluator<T> | 64.29% | 1 method | 14 | 10min | 1h 0min | Microsoft.eShopWeb.Infrastructure.Data .SpecificationEvaluator<T> |
| AddExtraConstraints | 0% | 3 methods | 87 | 10min | 1h 0min | Microsoft.eShopWeb.Infrastructure.Data .Migrations.AddExtraConstraints |
| SlugifyParameterTransformer | 66.67% | 1 method | 3 | 10min | 1h 0min | Microsoft.eShopWeb.Web .SlugifyParameterTransformer |
| ApiHealthCheck | 0% | 1 method | 12 | 10min | 1h 0min | Microsoft.eShopWeb.Web.HealthChecks .ApiHealthCheck |
| HomePageHealthCheck | 0% | 1 method | 10 | 10min | 1h 0min | Microsoft.eShopWeb.Web.HealthChecks .HomePageHealthCheck |
| CachedCatalogViewModelService | 64.71% | 2 methods | 17 | 10min | 1h 0min | Microsoft.eShopWeb.Web.Services .CachedCatalogViewModelService |
| ErrorModel | 0% | 4 methods | 4 | 10min | 1h 0min | Microsoft.eShopWeb.Web.Pages.ErrorModel |
| PrivacyModel | 0% | 1 method | 0 | 10min | 1h 0min | Microsoft.eShopWeb.Web.Pages .PrivacyModel |
| BasketItemViewModel | 78.57% | 3 methods | 14 | 10min | 1h 0min | Microsoft.eShopWeb.Web.Pages.Basket .BasketItemViewModel |
| BasketViewModel | 88.89% | 1 method | 9 | 10min | 1h 0min | Microsoft.eShopWeb.Web.Pages.Basket .BasketViewModel |
| CheckoutModel | 0% | 6 methods | 27 | 10min | 1h 0min | Microsoft.eShopWeb.Web.Pages.Basket .CheckoutModel |
| IndexModel | 77.42% | 3 methods | 31 | 10min | 1h 0min | Microsoft.eShopWeb.Web.Pages.Basket .IndexModel |
| Basket | 87.5% | 1 method | 16 | 10min | 1h 0min | Microsoft.eShopWeb.Web.Pages.Shared .Components.BasketComponent.Basket |
| LoginModel | 41.94% | 4 methods | 31 | 10min | 1h 0min | Microsoft.eShopWeb.Web.Areas.Identity .Pages.Account.LoginModel |
| LoginModel+InputModel | 0% | 6 methods | 6 | 10min | 1h 0min | Microsoft.eShopWeb.Web.Areas.Identity .Pages.Account.LoginModel+InputModel |
| Rule Violated: From now, all methods added should respect basic quality principles |
• Rule Description:
This rule is executed only if a baseline for comparison is defined (diff mode). This rule operates only on methods added or refactored since the baseline.
This rule can be easily modified to also match methods refactored since baseline, that don't satisfy all quality criterions.
Methods matched by this rule not only have been recently added or refactored, but also somehow violate one or several basic quality principles, whether it is too large (too many lines of code), too complex (too many if, switch case, loops…) has too many variables, too many parameters or has too many overloads.
• How to Fix Issues of this Rule: To refactor such method and increase code quality and maintainability, certainly you'll have to split the method into several smaller methods or even create one or several classes to implement the logic. During this process it is important to question the scope of each variable local to the method. This can be an indication if such local variable will become an instance field of the newly created class(es). Large switch…case structures might be refactored through the help of a set of types that implement a common interface, the interface polymorphism playing the role of the switch cases tests. Unit Tests can help: write tests for each method before extracting it to ensure you don't break functionality. Issues of this rule have a constant 5 minutes Debt, because the Debt, which means the effort to fix such issue, is already estimated for issues of rules in the category Code Smells. However issues of this rule have a High severity, with even more interests for issues on new methods since baseline, because the proper time to increase the quality of these methods is now, before they get commited in the next production release.
• How to Suppress an Issue of this Rule: In source code, tag the concerned code element with this attribute: [SuppressMessage("NDepend", "ND1102:FromNowAllMethodsAddedShouldRespectBasicQualityPrinciples", Justification="...")] This attribute requires the compilation symbol CODE_ANALYSIS to be set on each Visual Studio project relying on it. Without CODE_ANALYSIS symbol defined, the attribute is not compiled and the issues are not suppressed.
• How to Fix Issues of this Rule: To refactor such method and increase code quality and maintainability, certainly you'll have to split the method into several smaller methods or even create one or several classes to implement the logic. During this process it is important to question the scope of each variable local to the method. This can be an indication if such local variable will become an instance field of the newly created class(es). Large switch…case structures might be refactored through the help of a set of types that implement a common interface, the interface polymorphism playing the role of the switch cases tests. Unit Tests can help: write tests for each method before extracting it to ensure you don't break functionality. Issues of this rule have a constant 5 minutes Debt, because the Debt, which means the effort to fix such issue, is already estimated for issues of rules in the category Code Smells. However issues of this rule have a High severity, with even more interests for issues on new methods since baseline, because the proper time to increase the quality of these methods is now, before they get commited in the next production release.
• How to Suppress an Issue of this Rule: In source code, tag the concerned code element with this attribute: [SuppressMessage("NDepend", "ND1102:FromNowAllMethodsAddedShouldRespectBasicQualityPrinciples", Justification="...")] This attribute requires the compilation symbol CODE_ANALYSIS to be set on each Visual Studio project relying on it. Without CODE_ANALYSIS symbol defined, the attribute is not compiled and the issues are not suppressed.
2 methods matched
-
Formatting: bold means added, underlined means code was changed,
strike-boldmeans removed (since baseline)
| 2 methods | # lines of code (LOC) | # IL instructions | Cyclomatic Complexity (CC) | IL Cyclomatic Complexity (ILCC) | IL Nesting Depth | # Parameters | # Variables | # Overloads | Debt | Annual Interest | Full Name |
|---|---|---|---|---|---|---|---|---|---|---|---|
| Up(MigrationBuilder) | 6 | 224 | 1 | 1 | 0 | 1 | 2 | 1 | 5min | 1h 0min | Microsoft.eShopWeb.Infrastructure.Data .Migrations.AddExtraConstraints.Up (MigrationBuilder) |
| Down(MigrationBuilder) | 6 | 224 | 1 | 1 | 0 | 1 | 2 | 1 | 5min | 1h 0min | Microsoft.eShopWeb.Infrastructure.Data .Migrations.AddExtraConstraints.Down (MigrationBuilder) |
| Rule Violated: Avoid transforming an immutable type into a mutable one |
• Rule Description:
This rule is executed only if a baseline for comparison is defined (diff mode).
A type is considered as immutable if its instance fields cannot be modified once an instance has been built by a constructor.
Being immutable has several fortunate consequences for a type. For example its instance objects can be used concurrently from several threads without the need to synchronize accesses.
Hence users of such type often rely on the fact that the type is immutable. If an immutable type becomes mutable, there are chances that this will break users code.
This is why this rule warns about such immutable type that become mutable.
The estimated Debt, which means the effort to fix such issue, is equal to 2 minutes per instance field that became mutable.
• How to Fix Issues of this Rule: If being immutable is an important property for a matched type, then the code must be refactored to preserve immutability. The estimated Debt, which means the effort to fix such issue, is equal to 10 minutes plus 10 minutes per instance fields of the matched type that is now mutable. Issues of this rule have a High severity, because it is important to focus on these issues now, before such code gets released in production.
• How to Suppress an Issue of this Rule: In source code, tag the concerned code element with this attribute: [SuppressMessage("NDepend", "ND1108:AvoidTransformingAnImmutableTypeIntoAMutableOne", Justification="...")] This attribute requires the compilation symbol CODE_ANALYSIS to be set on each Visual Studio project relying on it. Without CODE_ANALYSIS symbol defined, the attribute is not compiled and the issues are not suppressed.
• How to Fix Issues of this Rule: If being immutable is an important property for a matched type, then the code must be refactored to preserve immutability. The estimated Debt, which means the effort to fix such issue, is equal to 10 minutes plus 10 minutes per instance fields of the matched type that is now mutable. Issues of this rule have a High severity, because it is important to focus on these issues now, before such code gets released in production.
• How to Suppress an Issue of this Rule: In source code, tag the concerned code element with this attribute: [SuppressMessage("NDepend", "ND1108:AvoidTransformingAnImmutableTypeIntoAMutableOne", Justification="...")] This attribute requires the compilation symbol CODE_ANALYSIS to be set on each Visual Studio project relying on it. Without CODE_ANALYSIS symbol defined, the attribute is not compiled and the issues are not suppressed.
4 types matched
-
Formatting: bold means added, underlined means code was changed,
strike-boldmeans removed (since baseline)
| 4 types | culpritFields | Debt | Severity | Full Name |
|---|---|---|---|---|
| BaseSpecification<T> | 5 fields | 1h 0min | High | Microsoft.eShopWeb.ApplicationCore .Specifications.BaseSpecification<T> |
| BasketWithItemsSpecification | no field | 10min | High | Microsoft.eShopWeb.ApplicationCore .Specifications .BasketWithItemsSpecification |
| CatalogFilterSpecification | no field | 10min | High | Microsoft.eShopWeb.ApplicationCore .Specifications .CatalogFilterSpecification |
| CustomerOrdersWithItemsSpecification | no field | 10min | High | Microsoft.eShopWeb.ApplicationCore .Specifications .CustomerOrdersWithItemsSpecification |
| Object Oriented Design 1040 |
| Rule Violated: Non-static classes should be instantiated or turned to static |
• Rule Description:
If the constructors of a class are never called, the class is never instantiated, and should be defined as a static class.
However this rule doesn't match instantiation through reflection. As a consequence, plug-in root classes, instantiated through reflection via IoC frameworks, can be false positives for this rule.
This rule doesn't match also classes instantiated by the ASP.NET infrastructure, ASP.NET view model classes and Entity Framework ModelSnapshot, DbContext and Migration classes.
Notice that by default this rule matches also public class. If you are developing a framework with classes that are intended to be instantiated by your clients, just uncomment the line !t.IsPublic.
• How to Fix Issues of this Rule: First it is important to investigate why the class is never instantiated. If the reason is the class hosts only static methods then the class can be safely declared as static. Others reasons like, the class is meant to be instantiated via reflection, or is meant to be instantiated only by client code should lead to adapt this rule code to avoid these matches.
• How to Suppress an Issue of this Rule: In source code, tag the concerned code element with this attribute: [SuppressMessage("NDepend", "ND1207:NonStaticClassesShouldBeInstantiatedOrTurnedToStatic", Justification="...")] This attribute requires the compilation symbol CODE_ANALYSIS to be set on each Visual Studio project relying on it. Without CODE_ANALYSIS symbol defined, the attribute is not compiled and the issues are not suppressed.
• How to Fix Issues of this Rule: First it is important to investigate why the class is never instantiated. If the reason is the class hosts only static methods then the class can be safely declared as static. Others reasons like, the class is meant to be instantiated via reflection, or is meant to be instantiated only by client code should lead to adapt this rule code to avoid these matches.
• How to Suppress an Issue of this Rule: In source code, tag the concerned code element with this attribute: [SuppressMessage("NDepend", "ND1207:NonStaticClassesShouldBeInstantiatedOrTurnedToStatic", Justification="...")] This attribute requires the compilation symbol CODE_ANALYSIS to be set on each Visual Studio project relying on it. Without CODE_ANALYSIS symbol defined, the attribute is not compiled and the issues are not suppressed.
2 types matched
-
Formatting: bold means added, underlined means code was changed,
strike-boldmeans removed (since baseline)
| 2 types | Visibility | Debt | Severity | Full Name |
|---|---|---|---|---|
SpecificationEvaluator<T> | Public | 2min 0s | Medium | Microsoft.eShopWeb.Infrastructure.Data .SpecificationEvaluator<T> |
| PaymentMethod | Public | 2min 0s | Medium | Microsoft.eShopWeb.ApplicationCore .Entities.BuyerAggregate.PaymentMethod |
| Rule Violated: Methods should be declared static if possible |
• Rule Description:
When an instance method can be safely declared as static you should declare it as static.
Whenever you write a method, you fulfill a contract in a given scope. The narrower the scope is, the smaller the chance is that you write a bug.
When a method is static, you can't access non-static members; hence, your scope is narrower. So, if you don't need and will never need (even in subclasses) instance fields to fulfill your contract, why give access to these fields to your method? Declaring the method static in this case will let the compiler check that you don't use members that you do not intend to use.
Declaring a method as static if possible is also good practice because clients can tell from the method signature that calling the method can't alter the object's state.
Doing so, is also a micro performance optimization, since a static method is a bit cheaper to invoke than an instance method, because the this reference* doesn't need anymore to be passed.
Notice that if a matched method is a handler, bound to an event through code generated by a designer, declaring it as static might break the designer generated code, if the generated code use the this invocation syntax, (like this.Method()).
• How to Fix Issues of this Rule: Declare matched methods as static. Since such method doesn't use any instance fields and methods of its type and base-types, you should consider if it makes sense, to move such a method to a static utility class.
• How to Suppress an Issue of this Rule: In source code, tag the concerned code element with this attribute: [SuppressMessage("NDepend", "ND1208:MethodsShouldBeDeclaredStaticIfPossible", Justification="...")] This attribute requires the compilation symbol CODE_ANALYSIS to be set on each Visual Studio project relying on it. Without CODE_ANALYSIS symbol defined, the attribute is not compiled and the issues are not suppressed.
• How to Fix Issues of this Rule: Declare matched methods as static. Since such method doesn't use any instance fields and methods of its type and base-types, you should consider if it makes sense, to move such a method to a static utility class.
• How to Suppress an Issue of this Rule: In source code, tag the concerned code element with this attribute: [SuppressMessage("NDepend", "ND1208:MethodsShouldBeDeclaredStaticIfPossible", Justification="...")] This attribute requires the compilation symbol CODE_ANALYSIS to be set on each Visual Studio project relying on it. Without CODE_ANALYSIS symbol defined, the attribute is not compiled and the issues are not suppressed.
10 methods matched
-
Formatting: bold means added, underlined means code was changed,
strike-boldmeans removed (since baseline)
| 10 methods | staticFieldsUsed | methodsCallingMe | Debt | Severity | Full Name |
|---|---|---|---|---|---|
| ConfigurateCatalogItemOrdered (EntityTypeBuilder<CatalogItemOrdered>) | no field | 1 method | 1min 0s | Medium | Microsoft.eShopWeb.Infrastructure.Data .CatalogContext .ConfigurateCatalogItemOrdered (EntityTypeBuilder<CatalogItemOrdered>) |
| ConfigureAddress(EntityTypeBuilder <Address>) | no field | 1 method | 1min 0s | Medium | Microsoft.eShopWeb.Infrastructure.Data .CatalogContext.ConfigureAddress (EntityTypeBuilder<Address>) |
| OnGet() | no field | no method | 0min 30s | Medium | Microsoft.eShopWeb.Web.Pages .PrivacyModel.OnGet() |
| OnGet() | no field | no method | 0min 30s | Medium | Microsoft.eShopWeb.Web.Pages.Basket .CheckoutModel.OnGet() |
| ConfigureBasket(EntityTypeBuilder<Basket >) | no field | 1 method | 1min 0s | Medium | Microsoft.eShopWeb.Infrastructure.Data .CatalogContext.ConfigureBasket (EntityTypeBuilder<Basket>) |
| ConfigureCatalogItem(EntityTypeBuilder <CatalogItem>) | no field | 1 method | 1min 0s | Medium | Microsoft.eShopWeb.Infrastructure.Data .CatalogContext.ConfigureCatalogItem (EntityTypeBuilder<CatalogItem>) |
| ConfigureCatalogBrand(EntityTypeBuilder <CatalogBrand>) | no field | 1 method | 1min 0s | Medium | Microsoft.eShopWeb.Infrastructure.Data .CatalogContext.ConfigureCatalogBrand (EntityTypeBuilder<CatalogBrand>) |
| ConfigureCatalogType(EntityTypeBuilder <CatalogType>) | no field | 1 method | 1min 0s | Medium | Microsoft.eShopWeb.Infrastructure.Data .CatalogContext.ConfigureCatalogType (EntityTypeBuilder<CatalogType>) |
| ConfigureOrder(EntityTypeBuilder<Order>) | no field | 1 method | 1min 0s | Medium | Microsoft.eShopWeb.Infrastructure.Data .CatalogContext.ConfigureOrder (EntityTypeBuilder<Order>) |
| ConfigureOrderItem(EntityTypeBuilder <OrderItem>) | no field | 1 method | 1min 0s | Medium | Microsoft.eShopWeb.Infrastructure.Data .CatalogContext.ConfigureOrderItem (EntityTypeBuilder<OrderItem>) |
| Rule Violated: Constructor should not call a virtual method |
• Rule Description:
This rule matches constructors of a non-sealed class that call one or several virtual methods.
When an object written in C# is constructed, what happens is that constructors run in order from the base class to the most derived class.
Also objects do not change type as they are constructed, but start out as the most derived type, with the method table being for the most derived type. This means that virtual method calls always run on the most derived type, even when calls are made from the constructor.
When you combine these two facts you are left with the problem that if you make a virtual method call in a constructor, and it is not the most derived type in its inheritance hierarchy, then it will be called on a class whose constructor has not been run, and therefore may not be in a suitable state to have that method called.
Hence this situation makes the class fragile to derive from.
• How to Fix Issues of this Rule: Violations reported can be solved by re-designing object initialisation or by declaring the parent class as sealed, if possible.
• How to Suppress an Issue of this Rule: In source code, tag the concerned code element with this attribute: [SuppressMessage("NDepend", "ND1209:ConstructorShouldNotCallAVirtualMethod", Justification="...")] This attribute requires the compilation symbol CODE_ANALYSIS to be set on each Visual Studio project relying on it. Without CODE_ANALYSIS symbol defined, the attribute is not compiled and the issues are not suppressed.
• How to Fix Issues of this Rule: Violations reported can be solved by re-designing object initialisation or by declaring the parent class as sealed, if possible.
• How to Suppress an Issue of this Rule: In source code, tag the concerned code element with this attribute: [SuppressMessage("NDepend", "ND1209:ConstructorShouldNotCallAVirtualMethod", Justification="...")] This attribute requires the compilation symbol CODE_ANALYSIS to be set on each Visual Studio project relying on it. Without CODE_ANALYSIS symbol defined, the attribute is not compiled and the issues are not suppressed.
2 methods matched
-
Formatting: bold means added, underlined means code was changed,
strike-boldmeans removed (since baseline)
| 2 methods | virtualMethodsCalled | DerivedTypes | Debt | Severity | Full Name |
|---|---|---|---|---|---|
| .ctor(Int32,Int32,Nullable<Int32> ,Nullable<Int32>) | 1 method | no type | 6min | High | Microsoft.eShopWeb.ApplicationCore .Specifications .CatalogFilterPaginatedSpecification. .ctor(Int32,Int32,Nullable<Int32> ,Nullable<Int32>) |
| .ctor(String) | 2 methods | no type | 12min | High | Microsoft.eShopWeb.ApplicationCore .Specifications .CustomerOrdersWithItemsSpecification. .ctor(String) |
| Rule Violated: Avoid empty interfaces |
• Rule Description:
Interfaces define members that provide a behavior or usage contract. The functionality that is described by the interface can be adopted by any type, regardless of where the type appears in the inheritance hierarchy. A type implements an interface by providing implementations for the members of the interface. An empty interface does not define any members. Therefore, it does not define a contract that can be implemented.
If your design includes empty interfaces that types are expected to implement, you are probably using an interface as a marker or a way to identify a group of types. If this identification will occur at run time, the correct way to accomplish this is to use a custom attribute. Use the presence or absence of the attribute, or the properties of the attribute, to identify the target types. If the identification must occur at compile time, then it is acceptable to use an empty interface.
Note that if an interface is empty but implements at least one other interface, it won't be matched by this rule. Such interface can be considered as not empty, since implementing it means that sub-interfaces members must be implemented.
• How to Fix Issues of this Rule: Remove the interface or add members to it. If the empty interface is being used to label a set of types, replace the interface with a custom attribute. The estimated Debt, which means the effort to fix such issue, is equal to 10 minutes to discard an empty interface plus 3 minutes per type implementing an empty interface.
• How to Suppress an Issue of this Rule: In source code, tag the concerned code element with this attribute: [SuppressMessage("NDepend", "ND1212:AvoidEmptyInterfaces", Justification="...")] This attribute requires the compilation symbol CODE_ANALYSIS to be set on each Visual Studio project relying on it. Without CODE_ANALYSIS symbol defined, the attribute is not compiled and the issues are not suppressed.
• How to Fix Issues of this Rule: Remove the interface or add members to it. If the empty interface is being used to label a set of types, replace the interface with a custom attribute. The estimated Debt, which means the effort to fix such issue, is equal to 10 minutes to discard an empty interface plus 3 minutes per type implementing an empty interface.
• How to Suppress an Issue of this Rule: In source code, tag the concerned code element with this attribute: [SuppressMessage("NDepend", "ND1212:AvoidEmptyInterfaces", Justification="...")] This attribute requires the compilation symbol CODE_ANALYSIS to be set on each Visual Studio project relying on it. Without CODE_ANALYSIS symbol defined, the attribute is not compiled and the issues are not suppressed.
1 type matched
-
Formatting: bold means added, underlined means code was changed,
strike-boldmeans removed (since baseline)
| 1 type | TypesThatImplementMe | Debt | Severity | Full Name |
|---|---|---|---|---|
| IAggregateRoot | 3 types | 19min | Medium | Microsoft.eShopWeb.ApplicationCore .Interfaces.IAggregateRoot |
| Design 1020 |
|
| Rule Violated: Avoid namespaces with few types |
• Rule Description:
This rule warns about namespaces other than the global namespace that contain less than five types.
Make sure that each of your namespaces has a logical organization and that a valid reason exists to put types in a sparsely populated namespace.
Namespaces should contain types that are used together in most scenarios. When their applications are mutually exclusive, types should be located in separate namespaces. For example, the System.Web.UI namespace contains types that are used in Web applications, and the System.Windows.Forms namespace contains types that are used in Windows-based applications. Even though both namespaces have types that control aspects of the user interface, these types are not designed for use in the same application. Therefore, they are located in separate namespaces.
Careful namespace organization can also be helpful because it increases the discoverability of a feature. By examining the namespace hierarchy, library consumers should be able to locate the types that implement a feature.
Notice that this rule source code contains a list of common infrastructure namespace names that you can complete. Namespaces with ending name component in this list are not matched.
• How to Fix Issues of this Rule: To fix a violation of this rule, try to combine namespaces that contain just a few types into a single namespace.
• How to Suppress an Issue of this Rule: In source code, tag the concerned code element with this attribute: [SuppressMessage("NDepend", "ND1305:AvoidNamespacesWithFewTypes", Justification="...")] This attribute requires the compilation symbol CODE_ANALYSIS to be set on each Visual Studio project relying on it. Without CODE_ANALYSIS symbol defined, the attribute is not compiled and the issues are not suppressed.
• How to Fix Issues of this Rule: To fix a violation of this rule, try to combine namespaces that contain just a few types into a single namespace.
• How to Suppress an Issue of this Rule: In source code, tag the concerned code element with this attribute: [SuppressMessage("NDepend", "ND1305:AvoidNamespacesWithFewTypes", Justification="...")] This attribute requires the compilation symbol CODE_ANALYSIS to be set on each Visual Studio project relying on it. Without CODE_ANALYSIS symbol defined, the attribute is not compiled and the issues are not suppressed.
13 namespaces matched
-
Formatting: bold means added, underlined means code was changed,
strike-boldmeans removed (since baseline)
| 13 namespaces | types | Debt | Severity | Full Name |
|---|---|---|---|---|
| Microsoft.eShopWeb.Web.Pages.Shared .Components.BasketComponent | 1 type | 5min | Low | Microsoft.eShopWeb.Web.Pages.Shared .Components.BasketComponent |
| Microsoft.eShopWeb.Web.HealthChecks | 2 types | 5min | Low | Microsoft.eShopWeb.Web.HealthChecks |
| Microsoft.eShopWeb.Web.Areas.Identity .Pages.Account | 2 types | 5min | Low | Microsoft.eShopWeb.Web.Areas.Identity .Pages.Account |
| Microsoft.eShopWeb.Web.Pages | 3 types | 5min | Low | Microsoft.eShopWeb.Web.Pages |
| Microsoft.eShopWeb.Web.Pages.Basket | 4 types | 5min | Low | Microsoft.eShopWeb.Web.Pages.Basket |
| Ardalis.GuardClauses | 1 type | 5min | Low | Ardalis.GuardClauses |
| Microsoft.eShopWeb | 1 type | 5min | Low | Microsoft.eShopWeb |
| Microsoft.AspNetCore.Mvc | 1 type | 5min | Low | Microsoft.AspNetCore.Mvc |
| Microsoft.eShopWeb.ApplicationCore .Entities.BuyerAggregate | 2 types | 5min | Low | Microsoft.eShopWeb.ApplicationCore .Entities.BuyerAggregate |
| Microsoft.eShopWeb.ApplicationCore .Entities.BasketAggregate | 2 types | 5min | Low | Microsoft.eShopWeb.ApplicationCore .Entities.BasketAggregate |
| Microsoft.eShopWeb.Web.Controllers.Api | 2 types | 5min | Low | Microsoft.eShopWeb.Web.Controllers.Api |
| Microsoft.eShopWeb.ApplicationCore .Entities.OrderAggregate | 4 types | 5min | Low | Microsoft.eShopWeb.ApplicationCore .Entities.OrderAggregate |
| Microsoft.eShopWeb.Web.ViewModels .Account | 4 types | 5min | Low | Microsoft.eShopWeb.Web.ViewModels .Account |
| Rule Violated: Nested types should not be visible |
• Rule Description:
This rule warns about nested types not declared as private.
A nested type is a type declared within the scope of another type. Nested types are useful for encapsulating private implementation details of the containing type. Used for this purpose, nested types should not be externally visible.
Do not use externally visible nested types for logical grouping or to avoid name collisions; instead use namespaces.
Nested types include the notion of member accessibility, which some programmers do not understand clearly.
Protected types can be used in subclasses and nested types in advanced customization scenarios.
• How to Fix Issues of this Rule: If you do not intend the nested type to be externally visible, change the type's accessibility. Otherwise, remove the nested type from its parent and make it non-nested. If the purpose of the nesting is to group some nested types, use a namespace to create the hierarchy instead. The estimated Debt, which means the effort to fix such issue, is 2 minutes per nested type plus 4 minutes per outter type using such nesting type.
• How to Suppress an Issue of this Rule: In source code, tag the concerned code element with this attribute: [SuppressMessage("NDepend", "ND1306:NestedTypesShouldNotBeVisible", Justification="...")] This attribute requires the compilation symbol CODE_ANALYSIS to be set on each Visual Studio project relying on it. Without CODE_ANALYSIS symbol defined, the attribute is not compiled and the issues are not suppressed.
• How to Fix Issues of this Rule: If you do not intend the nested type to be externally visible, change the type's accessibility. Otherwise, remove the nested type from its parent and make it non-nested. If the purpose of the nesting is to group some nested types, use a namespace to create the hierarchy instead. The estimated Debt, which means the effort to fix such issue, is 2 minutes per nested type plus 4 minutes per outter type using such nesting type.
• How to Suppress an Issue of this Rule: In source code, tag the concerned code element with this attribute: [SuppressMessage("NDepend", "ND1306:NestedTypesShouldNotBeVisible", Justification="...")] This attribute requires the compilation symbol CODE_ANALYSIS to be set on each Visual Studio project relying on it. Without CODE_ANALYSIS symbol defined, the attribute is not compiled and the issues are not suppressed.
1 type matched
-
Formatting: bold means added, underlined means code was changed,
strike-boldmeans removed (since baseline)
| 1 type | Visibility | typesUser | Debt | Severity | Full Name |
|---|---|---|---|---|---|
| LoginModel+InputModel | Public | no type | 2min 0s | Medium | Microsoft.eShopWeb.Web.Areas.Identity .Pages.Account.LoginModel+InputModel |
| Architecture 521 |
|
 | Critical Rule Violated: Avoid namespaces mutually dependent |
• Rule Description:
This rule lists types and methods from a low-level namespace that use types and methods from higher-level namespace.
The pair of low and high level namespaces is made of two namespaces that use each other.
For each pair of namespaces, to infer which one is low-level and which one is high-level, the rule computes the two coupling [from A to B] and [from B to A] in terms of number of types, methods and fields involved in the coupling. Typically the coupling from low-level to high-level namespace is significantly lower than the other legitimate coupling.
Following this rule is useful to avoid namespaces dependency cycles. This will get the code architecture close to a layered architecture, where low-level code is not allowed to use high-level code.
In other words, abiding by this rule will help significantly getting rid of what is often called spaghetti code: Entangled code that is not properly layered and structured.
More on this in our white books relative to partitioning code. https://www.ndepend.com/docs/white-books
• How to Fix Issues of this Rule: Refactor the code to make sure that the low-level namespace doesn't use the high-level namespace. The rule lists in detail which low-level types and methods shouldn't use which high-level types and methods. The refactoring patterns that help getting rid of each listed dependency include: • Moving one or several types from the low-level namespaces to the high-level one, or do the opposite. • Use Inversion of Control (IoC): http://en.wikipedia.org/wiki/Inversion_of_control This consists in creating new interfaces in the low-level namespace, implemented by classes in the high-level namespace. This way low-level code can consume high-level code through interfaces, without using directly high-level implementations. Interfaces can be passed to low-level code through the high-level namespace code, or through even higher-level code. In related documentations you can see these interfaces named as callbacks, and the overall pattern is also known as Dependency Injection (DI): http://en.wikipedia.org/wiki/Dependency_injection That rule might not be applicable for frameworks that present public namespaces mutually dependent. In such situation the cost to break the API can be higher than the cost to let the code entangled. - The estimated Debt, which means the effort to fix such issue to make sure that the first namespace doesn't rely anymore on the second one, depends on the number of types and methods used. Because both namespace are now forming a super-component that cannot be partitioned in smaller components, the cost to unfix each issue is proportional to the size of this super-component. As a consequence, the estimated Annual Interest, which means the annual cost to let both namespaces mutually dependend, is equal to an hour plus a number of minutes proportional to the size (in lines of code) of both namespaces. The obtained Annual Interest value is then divided by the number of detailled issues listed. Often the estimated Annual Interest for each listed issue is higher than the Debt, which means that leaving such issue unfixed for a year costs more than taking the time to fix issue once. -- To explore the coupling between the two namespaces mutually dependent: 1) from the becauseNamespace right-click menu choose Copy to Matrix Columns to export this low-level namespace to the horizontal header of the dependency matrix. 2) from the shouldntUseNamespace right-click menu choose Copy to Matrix Rows to export this high-level namespace to the vertical header of the dependency matrix. 3) double-click the black matrix cell (it is black because of the mutual dependency). 4) in the matrix command bar, click the button: Remove empty Row(s) and Column(s). At this point, the dependency matrix shows types involved into the coupling. • Blue cells represent types from low-level namespace using types from high-level namespace • Green cells represent types from high-level namespace using types from low-level namespace • Black cells represent types from low-level and high-level namespaces that use each other. There are more green cells than blue and black cells because green cell represents correct coupling from high-level to low-level. The goal is to eliminate incorrect dependencies represented by blue and black cells.
• How to Suppress an Issue of this Rule: In source code, tag the concerned code element with this attribute: [SuppressMessage("NDepend", "ND1400:AvoidNamespacesMutuallyDependent", Justification="...")] This attribute requires the compilation symbol CODE_ANALYSIS to be set on each Visual Studio project relying on it. Without CODE_ANALYSIS symbol defined, the attribute is not compiled and the issues are not suppressed.
• How to Fix Issues of this Rule: Refactor the code to make sure that the low-level namespace doesn't use the high-level namespace. The rule lists in detail which low-level types and methods shouldn't use which high-level types and methods. The refactoring patterns that help getting rid of each listed dependency include: • Moving one or several types from the low-level namespaces to the high-level one, or do the opposite. • Use Inversion of Control (IoC): http://en.wikipedia.org/wiki/Inversion_of_control This consists in creating new interfaces in the low-level namespace, implemented by classes in the high-level namespace. This way low-level code can consume high-level code through interfaces, without using directly high-level implementations. Interfaces can be passed to low-level code through the high-level namespace code, or through even higher-level code. In related documentations you can see these interfaces named as callbacks, and the overall pattern is also known as Dependency Injection (DI): http://en.wikipedia.org/wiki/Dependency_injection That rule might not be applicable for frameworks that present public namespaces mutually dependent. In such situation the cost to break the API can be higher than the cost to let the code entangled. - The estimated Debt, which means the effort to fix such issue to make sure that the first namespace doesn't rely anymore on the second one, depends on the number of types and methods used. Because both namespace are now forming a super-component that cannot be partitioned in smaller components, the cost to unfix each issue is proportional to the size of this super-component. As a consequence, the estimated Annual Interest, which means the annual cost to let both namespaces mutually dependend, is equal to an hour plus a number of minutes proportional to the size (in lines of code) of both namespaces. The obtained Annual Interest value is then divided by the number of detailled issues listed. Often the estimated Annual Interest for each listed issue is higher than the Debt, which means that leaving such issue unfixed for a year costs more than taking the time to fix issue once. -- To explore the coupling between the two namespaces mutually dependent: 1) from the becauseNamespace right-click menu choose Copy to Matrix Columns to export this low-level namespace to the horizontal header of the dependency matrix. 2) from the shouldntUseNamespace right-click menu choose Copy to Matrix Rows to export this high-level namespace to the vertical header of the dependency matrix. 3) double-click the black matrix cell (it is black because of the mutual dependency). 4) in the matrix command bar, click the button: Remove empty Row(s) and Column(s). At this point, the dependency matrix shows types involved into the coupling. • Blue cells represent types from low-level namespace using types from high-level namespace • Green cells represent types from high-level namespace using types from low-level namespace • Black cells represent types from low-level and high-level namespaces that use each other. There are more green cells than blue and black cells because green cell represents correct coupling from high-level to low-level. The goal is to eliminate incorrect dependencies represented by blue and black cells.
• How to Suppress an Issue of this Rule: In source code, tag the concerned code element with this attribute: [SuppressMessage("NDepend", "ND1400:AvoidNamespacesMutuallyDependent", Justification="...")] This attribute requires the compilation symbol CODE_ANALYSIS to be set on each Visual Studio project relying on it. Without CODE_ANALYSIS symbol defined, the attribute is not compiled and the issues are not suppressed.
2 types matched
-
Formatting: bold means added, underlined means code was changed,
strike-boldmeans removed (since baseline)
| 2 types | shouldntUse | becauseNamespace | shouldntUseNamespace | Debt | Annual Interest | Full Name |
|---|---|---|---|---|---|---|
| IBasketViewModelService | 1 type | Microsoft.eShopWeb.Web.Interfaces | Microsoft.eShopWeb.Web.Pages.Basket | 15min | 1h 1min | Microsoft.eShopWeb.Web.Interfaces .IBasketViewModelService |
| Order | 1 type | Microsoft.eShopWeb.ApplicationCore.Entities.OrderAggregate | Microsoft.eShopWeb.ApplicationCore.Interfaces | 15min | 1h 1min | Microsoft.eShopWeb.ApplicationCore .Entities.OrderAggregate.Order |
| Rule Violated: Avoid namespaces dependency cycles |
• Rule Description:
This rule lists all application namespace dependency cycles. Each row shows a different cycle, indexed with one of the namespace entangled in the cycle.
To browse a cycle on the dependency graph or the dependency matrix, right click a cycle cell and export the matched namespaces to the dependency graph or matrix.
In the matrix, dependency cycles are represented with red squares and black cells. To easily browse dependency cycles, the dependency matrix comes with an option: Display Direct and Indirect Dependencies
Read our white books relative to partitioning code, to know more about namespaces dependency cycles, and why avoiding them is a simple yet efficient solution to clean the architecture of a code base. https://www.ndepend.com/docs/white-books
• How to Fix Issues of this Rule: Removing first pairs of mutually dependent namespaces will eliminate most namespaces dependency cycles. This is why it is recommended focusing on matches of the default rule Avoid namespaces mutually dependent before dealing with the present rule. Once solving all mutually dependent namespaces, remaining cycles matched by the present rule necessarily involve 3 or more namespaces like in: A is using B is using C is using A. Such cycle can be broken by identifying which namespace should be at the lower-level. For example if B should be at the lower-level, then it means C should be at the higher-level and to break the cycle, you just have to remove the dependency from B to C, with a pattern described in the HowToFix section of the rule Avoid namespaces mutually dependent. The estimated Debt, which means the effort to fix such issue, doesn't depend on the cycle length. First because fixing the rule Avoid namespaces mutually dependent will fix most cycle reported here, second because even a long cycle can be broken by removing a few dependency.
• How to Suppress an Issue of this Rule: In source code, tag the concerned code element with this attribute: [SuppressMessage("NDepend", "ND1401:AvoidNamespacesDependencyCycles", Justification="...")] This attribute requires the compilation symbol CODE_ANALYSIS to be set on each Visual Studio project relying on it. Without CODE_ANALYSIS symbol defined, the attribute is not compiled and the issues are not suppressed.
• How to Fix Issues of this Rule: Removing first pairs of mutually dependent namespaces will eliminate most namespaces dependency cycles. This is why it is recommended focusing on matches of the default rule Avoid namespaces mutually dependent before dealing with the present rule. Once solving all mutually dependent namespaces, remaining cycles matched by the present rule necessarily involve 3 or more namespaces like in: A is using B is using C is using A. Such cycle can be broken by identifying which namespace should be at the lower-level. For example if B should be at the lower-level, then it means C should be at the higher-level and to break the cycle, you just have to remove the dependency from B to C, with a pattern described in the HowToFix section of the rule Avoid namespaces mutually dependent. The estimated Debt, which means the effort to fix such issue, doesn't depend on the cycle length. First because fixing the rule Avoid namespaces mutually dependent will fix most cycle reported here, second because even a long cycle can be broken by removing a few dependency.
• How to Suppress an Issue of this Rule: In source code, tag the concerned code element with this attribute: [SuppressMessage("NDepend", "ND1401:AvoidNamespacesDependencyCycles", Justification="...")] This attribute requires the compilation symbol CODE_ANALYSIS to be set on each Visual Studio project relying on it. Without CODE_ANALYSIS symbol defined, the attribute is not compiled and the issues are not suppressed.
2 namespaces matched
-
Formatting: bold means added, underlined means code was changed,
strike-boldmeans removed (since baseline)
| 2 namespaces | cycle | Debt | Severity | Full Name |
|---|---|---|---|---|
| Microsoft.eShopWeb.Web.Interfaces | 2 namespaces | 2h 0min | High | Microsoft.eShopWeb.Web.Interfaces |
| Microsoft.eShopWeb.ApplicationCore .Interfaces | 2 namespaces | 2h 0min | High | Microsoft.eShopWeb.ApplicationCore .Interfaces |
| Rule Violated: Assemblies with poor cohesion (RelationalCohesion) |
• Rule Description:
This rule computes the Relational Cohesion metric for the application assemblies, and warns about wrong values.
The Relational Cohesion for an assembly, is the total number of relationship between types of the assemblies, divided by the number of types. In other words it is the average number of types in the assembly used by a type in the assembly.
As classes inside an assembly should be strongly related, the cohesion should be high. On the other hand, a value which is too high may indicate over-coupling. A good range for Relational Cohesion is 1.5 to 4.0.
Notice that assemblies with less than 20 types are ignored.
• How to Fix Issues of this Rule: Matches of this present rule might reveal either assemblies with specific coding constraints (like code generated that have particular structure) either issues in design. In the second case, large refactoring can be planned not to respect this rule in particular, but to increase the overall design and code maintainability. The severity of issues of this rule is Low because the code metric Relational Cohesion is an information about the code structure state but is not actionable, it doesn't tell precisely what to do obtain a better score. Fixing actionable issues of others Architecture and Code Smells default rules will necessarily increase the Relational Cohesion scores.
• How to Suppress an Issue of this Rule: In source code, tag the concerned code element with this attribute: [SuppressMessage("NDepend", "ND1405:AssembliesWithPoorRelationalCohesion", Justification="...")] This attribute requires the compilation symbol CODE_ANALYSIS to be set on each Visual Studio project relying on it. Without CODE_ANALYSIS symbol defined, the attribute is not compiled and the issues are not suppressed.
• How to Fix Issues of this Rule: Matches of this present rule might reveal either assemblies with specific coding constraints (like code generated that have particular structure) either issues in design. In the second case, large refactoring can be planned not to respect this rule in particular, but to increase the overall design and code maintainability. The severity of issues of this rule is Low because the code metric Relational Cohesion is an information about the code structure state but is not actionable, it doesn't tell precisely what to do obtain a better score. Fixing actionable issues of others Architecture and Code Smells default rules will necessarily increase the Relational Cohesion scores.
• How to Suppress an Issue of this Rule: In source code, tag the concerned code element with this attribute: [SuppressMessage("NDepend", "ND1405:AssembliesWithPoorRelationalCohesion", Justification="...")] This attribute requires the compilation symbol CODE_ANALYSIS to be set on each Visual Studio project relying on it. Without CODE_ANALYSIS symbol defined, the attribute is not compiled and the issues are not suppressed.
1 assembly matched
-
Formatting: bold means added, underlined means code was changed,
strike-boldmeans removed (since baseline)
| 1 assembly | ChildTypes | relationalCohesion | Relational cohesion | Debt | Severity | Full Name |
|---|---|---|---|---|---|---|
| Web | 53 types | 1 | 1.17 | 10min | Low | Web |
| API Breaking Changes 204 |
| Critical Rule Violated: API Breaking Changes: Types |
• Rule Description:
This rule is executed only if a baseline for comparison is defined (diff mode).
This rule warns if a type publicly visible in the baseline, is not publicly visible anymore or if it has been removed. Clients code using such type will be broken.
• How to Fix Issues of this Rule: Make sure that public types that used to be presented to clients, still remain public now, and in the future. If a public type must really be removed, you can tag it with System.ObsoleteAttribute with a workaround message during a few public releases, until it gets removed definitely. Notice that this rule doesn't match types removed that were tagged as obsolete. Issues of this rule have a severity equal to High because an API Breaking change can provoque significant friction with consumers of the API.
• How to Suppress an Issue of this Rule: In source code, tag the concerned code element with this attribute: [SuppressMessage("NDepend", "ND1500:APIBreakingChangesTypes", Justification="...")] This attribute requires the compilation symbol CODE_ANALYSIS to be set on each Visual Studio project relying on it. Without CODE_ANALYSIS symbol defined, the attribute is not compiled and the issues are not suppressed.
• How to Fix Issues of this Rule: Make sure that public types that used to be presented to clients, still remain public now, and in the future. If a public type must really be removed, you can tag it with System.ObsoleteAttribute with a workaround message during a few public releases, until it gets removed definitely. Notice that this rule doesn't match types removed that were tagged as obsolete. Issues of this rule have a severity equal to High because an API Breaking change can provoque significant friction with consumers of the API.
• How to Suppress an Issue of this Rule: In source code, tag the concerned code element with this attribute: [SuppressMessage("NDepend", "ND1500:APIBreakingChangesTypes", Justification="...")] This attribute requires the compilation symbol CODE_ANALYSIS to be set on each Visual Studio project relying on it. Without CODE_ANALYSIS symbol defined, the attribute is not compiled and the issues are not suppressed.
9 types matched
-
Formatting: bold means added, underlined means code was changed,
strike-boldmeans removed (since baseline)
| 9 types | NewVisibility | Debt | Severity | Full Name |
|---|---|---|---|---|
| 20min | High | Microsoft.eShopWeb.ApplicationCore .Interfaces.IRepository<T> | ||
| 20min | High | Microsoft.eShopWeb.Web.ViewComponents .Basket | ||
| 20min | High | Microsoft.eShopWeb.Web.Services .ICatalogService | ||
| 20min | High | Microsoft.eShopWeb.Web.Services .CachedCatalogService | ||
| 20min | High | Microsoft.eShopWeb.Web.Services .CatalogService | ||
| 20min | High | Microsoft.eShopWeb.Web.ViewModels .BasketItemViewModel | ||
| 20min | High | Microsoft.eShopWeb.Web.ViewModels .BasketViewModel | ||
| 20min | High | Microsoft.eShopWeb.Web.Controllers .BasketController | ||
| 20min | High | Microsoft.eShopWeb.Web.Controllers .CatalogController |
| Critical Rule Violated: API Breaking Changes: Methods |
• Rule Description:
This rule is executed only if a baseline for comparison is defined (diff mode).
This rule warns if a method publicly visible in the baseline, is not publicly visible anymore or if it has been removed. Clients code using such method will be broken.
• How to Fix Issues of this Rule: Make sure that public methods that used to be presented to clients, still remain public now, and in the future. If a public method must really be removed, you can tag it with System.ObsoleteAttribute with a workaround message during a few public releases, until it gets removed definitely. Notice that this rule doesn't match methods removed that were tagged as obsolete. Issues of this rule have a severity equal to High because an API Breaking change can provoque significant friction with consumers of the API.
• How to Suppress an Issue of this Rule: In source code, tag the concerned code element with this attribute: [SuppressMessage("NDepend", "ND1501:APIBreakingChangesMethods", Justification="...")] This attribute requires the compilation symbol CODE_ANALYSIS to be set on each Visual Studio project relying on it. Without CODE_ANALYSIS symbol defined, the attribute is not compiled and the issues are not suppressed.
• How to Fix Issues of this Rule: Make sure that public methods that used to be presented to clients, still remain public now, and in the future. If a public method must really be removed, you can tag it with System.ObsoleteAttribute with a workaround message during a few public releases, until it gets removed definitely. Notice that this rule doesn't match methods removed that were tagged as obsolete. Issues of this rule have a severity equal to High because an API Breaking change can provoque significant friction with consumers of the API.
• How to Suppress an Issue of this Rule: In source code, tag the concerned code element with this attribute: [SuppressMessage("NDepend", "ND1501:APIBreakingChangesMethods", Justification="...")] This attribute requires the compilation symbol CODE_ANALYSIS to be set on each Visual Studio project relying on it. Without CODE_ANALYSIS symbol defined, the attribute is not compiled and the issues are not suppressed.
15 methods matched
-
Formatting: bold means added, underlined means code was changed,
strike-boldmeans removed (since baseline)
| 15 methods | NewVisibility | Debt | Severity | Full Name |
|---|---|---|---|---|
| 10min | High | Microsoft.eShopWeb.ApplicationCore .Services.BasketService..ctor (IAsyncRepository<Basket>,IRepository <CatalogItem>,IUriComposer,IAppLogger <BasketService>) | ||
| 10min | High | Microsoft.eShopWeb.ApplicationCore .Interfaces.IOrderRepository .GetByIdWithItems(Int32) | ||
| 10min | High | Microsoft.eShopWeb.Infrastructure.Data .EfRepository<T>.GetById(Int32) | ||
| 10min | High | Microsoft.eShopWeb.Infrastructure.Data .EfRepository<T>.GetSingleBySpec (ISpecification<T>) | ||
| 10min | High | Microsoft.eShopWeb.Infrastructure.Data .EfRepository<T>.ListAll() | ||
| 10min | High | Microsoft.eShopWeb.Infrastructure.Data .EfRepository<T>.List(ISpecification<T>) | ||
| 10min | High | Microsoft.eShopWeb.Infrastructure.Data .EfRepository<T>.Add(T) | ||
| 10min | High | Microsoft.eShopWeb.Infrastructure.Data .EfRepository<T>.Update(T) | ||
| 10min | High | Microsoft.eShopWeb.Infrastructure.Data .EfRepository<T>.Delete(T) | ||
| 10min | High | Microsoft.eShopWeb.Infrastructure.Data .OrderRepository.GetByIdWithItems(Int32) | ||
| 10min | High | Microsoft.eShopWeb.Web.Startup.Configure (IApplicationBuilder,IHostingEnvironment ) | ||
| 10min | High | Microsoft.eShopWeb.Web.Services .BasketViewModelService..ctor (IAsyncRepository<Basket>,IRepository <CatalogItem>,IUriComposer) | ||
| 10min | High | Microsoft.eShopWeb.Web.Controllers .ManageController.Index() | ||
| 10min | High | Microsoft.eShopWeb.Web.Controllers .OrderController.Index() | ||
| 10min | High | Microsoft.eShopWeb.Web.Controllers.Api .CatalogController..ctor(ICatalogService ) |
| Critical Rule Violated: API Breaking Changes: Fields |
• Rule Description:
This rule is executed only if a baseline for comparison is defined (diff mode).
This rule warns if a field publicly visible in the baseline, is not publicly visible anymore or if it has been removed. Clients code using such field will be broken.
• How to Fix Issues of this Rule: Make sure that public fields that used to be presented to clients, still remain public now, and in the future. If a public field must really be removed, you can tag it with System.ObsoleteAttribute with a workaround message during a few public releases, until it gets removed definitely. Notice that this rule doesn't match fields removed that were tagged as obsolete. Issues of this rule have a severity equal to High because an API Breaking change can provoque significant friction with consumers of the API.
• How to Suppress an Issue of this Rule: In source code, tag the concerned code element with this attribute: [SuppressMessage("NDepend", "ND1502:APIBreakingChangesFields", Justification="...")] This attribute requires the compilation symbol CODE_ANALYSIS to be set on each Visual Studio project relying on it. Without CODE_ANALYSIS symbol defined, the attribute is not compiled and the issues are not suppressed.
• How to Fix Issues of this Rule: Make sure that public fields that used to be presented to clients, still remain public now, and in the future. If a public field must really be removed, you can tag it with System.ObsoleteAttribute with a workaround message during a few public releases, until it gets removed definitely. Notice that this rule doesn't match fields removed that were tagged as obsolete. Issues of this rule have a severity equal to High because an API Breaking change can provoque significant friction with consumers of the API.
• How to Suppress an Issue of this Rule: In source code, tag the concerned code element with this attribute: [SuppressMessage("NDepend", "ND1502:APIBreakingChangesFields", Justification="...")] This attribute requires the compilation symbol CODE_ANALYSIS to be set on each Visual Studio project relying on it. Without CODE_ANALYSIS symbol defined, the attribute is not compiled and the issues are not suppressed.
1 field matched
-
Formatting: bold means added, underlined means code was changed,
strike-boldmeans removed (since baseline)
| 1 field | NewVisibility | Debt | Severity | Full Name |
|---|---|---|---|---|
| _itemRepository | Private | 10min | High | Microsoft.eShopWeb.Web.Services .BasketViewModelService._itemRepository |
| Critical Rule Violated: API Breaking Changes: Interfaces and Abstract Classes |
• Rule Description:
This rule is executed only if a baseline for comparison is defined (diff mode).
This rule warns if a publicly visible interface or abstract class has been changed and contains new abstract methods or if some abstract methods have been removed.
Clients code that implement such interface or derive from such abstract class will be broken.
• How to Fix Issues of this Rule: Make sure that the public contracts of interfaces and abstract classes that used to be presented to clients, remain stable now, and in the future. If a public contract must really be changed, you can tag abstract methods that will be removed with System.ObsoleteAttribute with a workaround message during a few public releases, until it gets removed definitely. Issues of this rule have a severity equal to High because an API Breaking change can provoque significant friction with consummers of the API. The severity is not set to Critical because an interface is not necessarily meant to be implemented by the consummer of the API.
• How to Suppress an Issue of this Rule: In source code, tag the concerned code element with this attribute: [SuppressMessage("NDepend", "ND1503:APIBreakingChangesInterfacesAndAbstractClasses", Justification="...")] This attribute requires the compilation symbol CODE_ANALYSIS to be set on each Visual Studio project relying on it. Without CODE_ANALYSIS symbol defined, the attribute is not compiled and the issues are not suppressed.
• How to Fix Issues of this Rule: Make sure that the public contracts of interfaces and abstract classes that used to be presented to clients, remain stable now, and in the future. If a public contract must really be changed, you can tag abstract methods that will be removed with System.ObsoleteAttribute with a workaround message during a few public releases, until it gets removed definitely. Issues of this rule have a severity equal to High because an API Breaking change can provoque significant friction with consummers of the API. The severity is not set to Critical because an interface is not necessarily meant to be implemented by the consummer of the API.
• How to Suppress an Issue of this Rule: In source code, tag the concerned code element with this attribute: [SuppressMessage("NDepend", "ND1503:APIBreakingChangesInterfacesAndAbstractClasses", Justification="...")] This attribute requires the compilation symbol CODE_ANALYSIS to be set on each Visual Studio project relying on it. Without CODE_ANALYSIS symbol defined, the attribute is not compiled and the issues are not suppressed.
3 types matched
-
Formatting: bold means added, underlined means code was changed,
strike-boldmeans removed (since baseline)
| 3 types | methodsAdded | methodsRemoved | Debt | Severity | Full Name |
|---|---|---|---|---|---|
| IAsyncRepository<T> | 1 method | no method | 10min | High | Microsoft.eShopWeb.ApplicationCore .Interfaces.IAsyncRepository<T> |
| IOrderRepository | no method | 1 method | 10min | High | Microsoft.eShopWeb.ApplicationCore .Interfaces.IOrderRepository |
| ISpecification<T> | 5 methods | no method | 10min | High | Microsoft.eShopWeb.ApplicationCore .Interfaces.ISpecification<T> |
| Code Coverage 280 |
| Rule Violated: Code should be tested |
• Rule Description:
This rule lists methods not covered at all by test or partially covered by tests.
For each match, the rules estimates the technical debt, i.e the effort to write unit and integration tests for the method. The estimation is based on the effort to develop the code element multiplied by factors in the range ]0,1.3] based on
• the method code size and complexity
• the actual percentage coverage
• the abstractness of types used, because relying on classes instead of interfaces makes the code more difficult to test
• the method visibility because testing private or protected methods is more difficult than testing public and internal ones
• the fields used by the method, because is is more complicated to write tests for methods that read mutable static fields whose changing state is shared across tests executions.
• whether the method is considered JustMyCode or not because NotMyCode is often generated easier to get tested since tests can be generated as well.
This rule is necessarily a large source of technical debt, since the code left untested is by definition part of the technical debt.
This rule also estimates the annual interest, i.e the annual cost to let the code uncovered, based on the effort to develop the code element, multiplied by factors based on usage of the code element.
• How to Fix Issues of this Rule: Write unit tests to test and cover the methods and their parent classes matched by this rule.
• How to Suppress an Issue of this Rule: In source code, tag the concerned code element with this attribute: [SuppressMessage("NDepend", "ND1600:CodeShouldBeTested", Justification="...")] This attribute requires the compilation symbol CODE_ANALYSIS to be set on each Visual Studio project relying on it. Without CODE_ANALYSIS symbol defined, the attribute is not compiled and the issues are not suppressed.
• How to Fix Issues of this Rule: Write unit tests to test and cover the methods and their parent classes matched by this rule.
• How to Suppress an Issue of this Rule: In source code, tag the concerned code element with this attribute: [SuppressMessage("NDepend", "ND1600:CodeShouldBeTested", Justification="...")] This attribute requires the compilation symbol CODE_ANALYSIS to be set on each Visual Studio project relying on it. Without CODE_ANALYSIS symbol defined, the attribute is not compiled and the issues are not suppressed.
238 methods matched
- The following list of methods is truncated and contains only the first 100 methods of the 238 methods matched.
-
Formatting: bold means added, underlined means code was changed,
strike-boldmeans removed (since baseline)
| 238 methods | Percentage Coverage | # lines of code (LOC) | # lines of code not covered | Cyclomatic Complexity (CC) | Debt | Annual Interest | Full Name |
|---|---|---|---|---|---|---|---|
| GetQuery(IQueryable<T>,ISpecification<T> ) | 64.29% | 14 | 5 | 7 | 26min | 16min | Microsoft.eShopWeb.Infrastructure.Data .SpecificationEvaluator<T>.GetQuery (IQueryable<T>,ISpecification<T>) |
| BuildTargetModel(ModelBuilder) | 0% | 75 | 75 | 14 | 3h 22min | 9min | Microsoft.eShopWeb.Infrastructure.Data .Migrations.AddExtraConstraints .BuildTargetModel(ModelBuilder) |
| set_OrderBy(Expression<Func<T,Object>>) | 0% | 1 | 1 | 1 | 2min 45s | 9min | Microsoft.eShopWeb.ApplicationCore .Specifications.BaseSpecification<T> .set_OrderBy(Expression<Func<T,Object>>) |
| set_OrderByDescending(Expression<Func<T ,Object>>) | 0% | 1 | 1 | 1 | 2min 45s | 9min | Microsoft.eShopWeb.ApplicationCore .Specifications.BaseSpecification<T> .set_OrderByDescending(Expression<Func<T ,Object>>) |
| get_RequestId() | 0% | 1 | 1 | 1 | 2min 17s | 6min | Microsoft.eShopWeb.Web.Pages.ErrorModel .get_RequestId() |
| GetOrSetBasketCookieAndUserName() | 0% | 8 | 8 | 3 | 30min | 6min | Microsoft.eShopWeb.Web.Pages.Basket .CheckoutModel .GetOrSetBasketCookieAndUserName() |
| ListAllRegisteredServices (IApplicationBuilder,LinkGenerator) | 11.54% | 26 | 23 | 4 | 38min | 4min 46s | Microsoft.eShopWeb.Web.Startup .ListAllRegisteredServices (IApplicationBuilder,LinkGenerator) |
| SetBasketModelAsync() | 50% | 4 | 2 | 2 | 6min | 4min 42s | Microsoft.eShopWeb.Web.Pages.Basket .IndexModel.SetBasketModelAsync() |
| OnPostAsync(String) | 0% | 14 | 14 | 6 | 1h 26min | 4min 41s | Microsoft.eShopWeb.Web.Areas.Identity .Pages.Account.LoginModel.OnPostAsync (String) |
| SetBasketModelAsync() | 0% | 4 | 4 | 2 | 13min | 3min 44s | Microsoft.eShopWeb.Web.Pages.Basket .CheckoutModel.SetBasketModelAsync() |
| set_RequestId(String) | 0% | 1 | 1 | 1 | 2min 17s | 3min 38s | Microsoft.eShopWeb.Web.Pages.ErrorModel .set_RequestId(String) |
| CheckHealthAsync(HealthCheckContext ,CancellationToken) | 0% | 9 | 9 | 2 | 22min | 3min 7s | Microsoft.eShopWeb.Web.HealthChecks .ApiHealthCheck.CheckHealthAsync (HealthCheckContext,CancellationToken) |
| CheckHealthAsync(HealthCheckContext ,CancellationToken) | 0% | 8 | 8 | 2 | 20min | 2min 48s | Microsoft.eShopWeb.Web.HealthChecks .HomePageHealthCheck.CheckHealthAsync (HealthCheckContext,CancellationToken) |
| .ctor(IBasketService ,IBasketViewModelService,IUriComposer ,SignInManager<ApplicationUser> ,IOrderService) | 0% | 8 | 8 | 1 | 10min | 2min 48s | Microsoft.eShopWeb.Web.Pages.Basket .CheckoutModel..ctor(IBasketService ,IBasketViewModelService,IUriComposer ,SignInManager<ApplicationUser> ,IOrderService) |
| Up(MigrationBuilder) | 0% | 6 | 6 | 1 | 8min | 2min 11s | Microsoft.eShopWeb.Infrastructure.Data .Migrations.AddExtraConstraints.Up (MigrationBuilder) |
| Down(MigrationBuilder) | 0% | 6 | 6 | 1 | 8min | 2min 11s | Microsoft.eShopWeb.Infrastructure.Data .Migrations.AddExtraConstraints.Down (MigrationBuilder) |
| ApplyOrderBy(Expression<Func<T,Object>>) | 0% | 1 | 1 | 1 | 2min 31s | 2min 0s | Microsoft.eShopWeb.ApplicationCore .Specifications.BaseSpecification<T> .ApplyOrderBy(Expression<Func<T,Object>> ) |
| ApplyOrderByDescending(Expression<Func<T ,Object>>) | 0% | 1 | 1 | 1 | 2min 31s | 2min 0s | Microsoft.eShopWeb.ApplicationCore .Specifications.BaseSpecification<T> .ApplyOrderByDescending(Expression<Func <T,Object>>) |
| TransformOutbound(Object) | 66.67% | 3 | 1 | 2 | 2min 59s | 2min 0s | Microsoft.eShopWeb.Web .SlugifyParameterTransformer .TransformOutbound(Object) |
| CreateIdentityIfNotCreated (IServiceCollection) | 60% | 5 | 2 | 2 | 3min 12s | 2min 0s | Microsoft.eShopWeb.Web.Startup .CreateIdentityIfNotCreated (IServiceCollection) |
| Configure(IApplicationBuilder ,IHostingEnvironment,LinkGenerator) | 66.67% | 21 | 7 | 6 | 12min | 2min 0s | Microsoft.eShopWeb.Web.Startup.Configure (IApplicationBuilder,IHostingEnvironment ,LinkGenerator) |
| .ctor(IHttpContextAccessor,LinkGenerator ) | 0% | 3 | 3 | 1 | 4min 35s | 2min 0s | Microsoft.eShopWeb.Web.HealthChecks .ApiHealthCheck..ctor (IHttpContextAccessor,LinkGenerator) |
| .ctor(IHttpContextAccessor) | 0% | 2 | 2 | 1 | 3min 26s | 2min 0s | Microsoft.eShopWeb.Web.HealthChecks .HomePageHealthCheck..ctor (IHttpContextAccessor) |
| GetBrands() | 0% | 3 | 3 | 2 | 8min | 2min 0s | Microsoft.eShopWeb.Web.Services .CachedCatalogViewModelService.GetBrands () |
| GetTypes() | 0% | 3 | 3 | 2 | 8min | 2min 0s | Microsoft.eShopWeb.Web.Services .CachedCatalogViewModelService.GetTypes( ) |
| get_ShowRequestId() | 0% | 1 | 1 | 1 | 2min 17s | 2min 0s | Microsoft.eShopWeb.Web.Pages.ErrorModel .get_ShowRequestId() |
| OnGet() | 0% | 1 | 1 | 2 | 4min 28s | 2min 0s | Microsoft.eShopWeb.Web.Pages.ErrorModel .OnGet() |
| OnGet() | 0% | 0 | 0 | 1 | 2min 0s | 2min 0s | Microsoft.eShopWeb.Web.Pages .PrivacyModel.OnGet() |
| get_CatalogItemId() | 0% | 1 | 1 | 1 | 2min 17s | 2min 0s | Microsoft.eShopWeb.Web.Pages.Basket .BasketItemViewModel.get_CatalogItemId() |
| get_OldUnitPrice() | 0% | 1 | 1 | 1 | 2min 17s | 2min 0s | Microsoft.eShopWeb.Web.Pages.Basket .BasketItemViewModel.get_OldUnitPrice() |
| set_OldUnitPrice(Decimal) | 0% | 1 | 1 | 1 | 2min 17s | 2min 0s | Microsoft.eShopWeb.Web.Pages.Basket .BasketItemViewModel.set_OldUnitPrice (Decimal) |
| get_BuyerId() | 0% | 1 | 1 | 1 | 2min 17s | 2min 0s | Microsoft.eShopWeb.Web.Pages.Basket .BasketViewModel.get_BuyerId() |
| get_BasketModel() | 0% | 1 | 1 | 1 | 2min 17s | 2min 0s | Microsoft.eShopWeb.Web.Pages.Basket .CheckoutModel.get_BasketModel() |
| set_BasketModel(BasketViewModel) | 0% | 1 | 1 | 1 | 2min 17s | 2min 0s | Microsoft.eShopWeb.Web.Pages.Basket .CheckoutModel.set_BasketModel (BasketViewModel) |
| OnGet() | 0% | 0 | 0 | 1 | 2min 0s | 2min 0s | Microsoft.eShopWeb.Web.Pages.Basket .CheckoutModel.OnGet() |
| OnPost(Dictionary<String,Int32>) | 0% | 5 | 5 | 1 | 10min | 2min 0s | Microsoft.eShopWeb.Web.Pages.Basket .CheckoutModel.OnPost(Dictionary<String ,Int32>) |
| OnPost(CatalogItemViewModel) | 66.67% | 6 | 2 | 2 | 5min | 2min 0s | Microsoft.eShopWeb.Web.Pages.Basket .IndexModel.OnPost(CatalogItemViewModel) |
| OnPostUpdate(Dictionary<String,Int32>) | 0% | 3 | 3 | 1 | 6min | 2min 0s | Microsoft.eShopWeb.Web.Pages.Basket .IndexModel.OnPostUpdate(Dictionary <String,Int32>) |
| GetBasketViewModelAsync() | 66.67% | 6 | 2 | 3 | 7min | 2min 0s | Microsoft.eShopWeb.Web.Pages.Shared .Components.BasketComponent.Basket .GetBasketViewModelAsync() |
| MyAccount() | 0% | 5 | 5 | 2 | 13min | 2min 0s | Microsoft.eShopWeb.Web.Controllers .ManageController.MyAccount() |
| MyOrders() | 0% | 5 | 5 | 3 | 21min | 2min 0s | Microsoft.eShopWeb.Web.Controllers .OrderController.MyOrders() |
| set_Input(LoginModel+InputModel) | 0% | 1 | 1 | 1 | 2min 17s | 2min 0s | Microsoft.eShopWeb.Web.Areas.Identity .Pages.Account.LoginModel.set_Input (LoginModel+InputModel) |
| get_ExternalLogins() | 0% | 1 | 1 | 1 | 2min 17s | 2min 0s | Microsoft.eShopWeb.Web.Areas.Identity .Pages.Account.LoginModel .get_ExternalLogins() |
| OnGetAsync(String) | 66.67% | 6 | 2 | 3 | 8min | 2min 0s | Microsoft.eShopWeb.Web.Areas.Identity .Pages.Account.LoginModel.OnGetAsync (String) |
| get_Email() | 0% | 1 | 1 | 1 | 2min 17s | 2min 0s | Microsoft.eShopWeb.Web.Areas.Identity .Pages.Account.LoginModel+InputModel .get_Email() |
| set_Email(String) | 0% | 1 | 1 | 1 | 2min 17s | 2min 0s | Microsoft.eShopWeb.Web.Areas.Identity .Pages.Account.LoginModel+InputModel .set_Email(String) |
| get_Password() | 0% | 1 | 1 | 1 | 2min 17s | 2min 0s | Microsoft.eShopWeb.Web.Areas.Identity .Pages.Account.LoginModel+InputModel .get_Password() |
| set_Password(String) | 0% | 1 | 1 | 1 | 2min 17s | 2min 0s | Microsoft.eShopWeb.Web.Areas.Identity .Pages.Account.LoginModel+InputModel .set_Password(String) |
| get_RememberMe() | 0% | 1 | 1 | 1 | 2min 17s | 2min 0s | Microsoft.eShopWeb.Web.Areas.Identity .Pages.Account.LoginModel+InputModel .get_RememberMe() |
| set_RememberMe(Boolean) | 0% | 1 | 1 | 1 | 2min 17s | 2min 0s | Microsoft.eShopWeb.Web.Areas.Identity .Pages.Account.LoginModel+InputModel .set_RememberMe(Boolean) |
| PageNavClass(ViewContext,String) | 0% | 2 | 2 | 2 | 6min | 18min | Microsoft.eShopWeb.Web.Views.Manage .ManageNavPages.PageNavClass(ViewContext ,String) |
| Up(MigrationBuilder) | 0% | 33 | 33 | 15 | 3h 46min | 10min | Microsoft.eShopWeb.Infrastructure .Identity.Migrations .InitialIdentityModel.Up (MigrationBuilder) |
| Up(MigrationBuilder) | 0% | 32 | 32 | 15 | 3h 39min | 10min | Microsoft.eShopWeb.Infrastructure.Data .Migrations.Initial.Up(MigrationBuilder) |
| BuildTargetModel(ModelBuilder) | 0% | 75 | 75 | 12 | 3h 22min | 9min | Microsoft.eShopWeb.Infrastructure .Identity.Migrations .InitialIdentityModel.BuildTargetModel (ModelBuilder) |
| BuildModel(ModelBuilder) | 0% | 75 | 75 | 12 | 3h 22min | 9min | Microsoft.eShopWeb.Infrastructure .Identity.Migrations .AppIdentityDbContextModelSnapshot .BuildModel(ModelBuilder) |
| BuildTargetModel(ModelBuilder) | 0% | 75 | 75 | 14 | 3h 22min | 9min | Microsoft.eShopWeb.Infrastructure.Data .Migrations.Initial.BuildTargetModel (ModelBuilder) |
| BuildModel(ModelBuilder) | 0% | 75 | 75 | 14 | 3h 22min | 9min | Microsoft.eShopWeb.Infrastructure.Data .Migrations.CatalogContextModelSnapshot .BuildModel(ModelBuilder) |
| SeedAsync(CatalogContext,ILoggerFactory ,Nullable<Int32>) | 56.25% | 16 | 7 | 6 | 32min | 6min | Microsoft.eShopWeb.Infrastructure.Data .CatalogContextSeed.SeedAsync (CatalogContext,ILoggerFactory,Nullable <Int32>) |
| get_ActivePageKey() | 0% | 1 | 1 | 1 | 2min 17s | 6min | Microsoft.eShopWeb.Web.Views.Manage .ManageNavPages.get_ActivePageKey() |
| get_Index() | 0% | 1 | 1 | 1 | 2min 17s | 6min | Microsoft.eShopWeb.Web.Views.Manage .ManageNavPages.get_Index() |
| get_ChangePassword() | 0% | 1 | 1 | 1 | 2min 17s | 6min | Microsoft.eShopWeb.Web.Views.Manage .ManageNavPages.get_ChangePassword() |
| get_ExternalLogins() | 0% | 1 | 1 | 1 | 2min 17s | 6min | Microsoft.eShopWeb.Web.Views.Manage .ManageNavPages.get_ExternalLogins() |
| get_TwoFactorAuthentication() | 0% | 1 | 1 | 1 | 2min 17s | 6min | Microsoft.eShopWeb.Web.Views.Manage .ManageNavPages .get_TwoFactorAuthentication() |
| .ctor() | 0% | 2 | 2 | 1 | 4min 8s | 6min | Microsoft.eShopWeb.ApplicationCore .Entities.BuyerAggregate.Buyer..ctor() |
| FormatKey(String) | 0% | 8 | 8 | 3 | 30min | 5min | Microsoft.eShopWeb.Web.Controllers .ManageController.FormatKey(String) |
| Index(IndexViewModel) | 0% | 17 | 17 | 7 | 1h 29min | 5min | Microsoft.eShopWeb.Web.Controllers .ManageController.Index(IndexViewModel) |
| LoginWith2fa(LoginWith2faViewModel ,Boolean,String) | 0% | 16 | 16 | 5 | 1h 25min | 5min | Microsoft.eShopWeb.Web.Controllers .AccountController.LoginWith2fa (LoginWith2faViewModel,Boolean,String) |
| AddErrors(IdentityResult) | 0% | 5 | 5 | 2 | 26min | 5min | Microsoft.eShopWeb.Web.Controllers .ManageController.AddErrors (IdentityResult) |
| ConfigureInMemoryDatabases (IServiceCollection) | 60% | 5 | 2 | 3 | 3min 12s | 4min 29s | Microsoft.eShopWeb.Web.Startup .ConfigureInMemoryDatabases (IServiceCollection) |
| CreateOrderAsync(Int32,Address) | 0% | 13 | 13 | 2 | 31min | 4min 22s | Microsoft.eShopWeb.ApplicationCore .Services.OrderService.CreateOrderAsync (Int32,Address) |
| ChangePassword(ChangePasswordViewModel) | 0% | 13 | 13 | 4 | 46min | 4min 22s | Microsoft.eShopWeb.Web.Controllers .ManageController.ChangePassword (ChangePasswordViewModel) |
| EnableAuthenticator (EnableAuthenticatorViewModel) | 0% | 13 | 13 | 4 | 1h 0min | 4min 22s | Microsoft.eShopWeb.Web.Controllers .ManageController.EnableAuthenticator (EnableAuthenticatorViewModel) |
| set_IdentityGuid(String) | 0% | 1 | 1 | 1 | 2min 45s | 4min 13s | Microsoft.eShopWeb.ApplicationCore .Entities.BuyerAggregate.Buyer .set_IdentityGuid(String) |
| set_Code(String) | 0% | 1 | 1 | 1 | 2min 17s | 4min 13s | Microsoft.eShopWeb.Web.ViewModels .Account.ResetPasswordViewModel.set_Code (String) |
| Main(String[]) | 0% | 12 | 12 | 2 | 36min | 4min 3s | Microsoft.eShopWeb.Web.Program.Main (String[]) |
| SetPassword(SetPasswordViewModel) | 0% | 12 | 12 | 4 | 43min | 4min 3s | Microsoft.eShopWeb.Web.Controllers .ManageController.SetPassword (SetPasswordViewModel) |
| LinkLoginCallback() | 0% | 12 | 12 | 4 | 56min | 4min 3s | Microsoft.eShopWeb.Web.Controllers .ManageController.LinkLoginCallback() |
| AddErrors(IdentityResult) | 0% | 5 | 5 | 2 | 20min | 3min 46s | Microsoft.eShopWeb.Web.Controllers .AccountController.AddErrors (IdentityResult) |
| SendVerificationEmail(IndexViewModel) | 0% | 11 | 11 | 3 | 33min | 3min 44s | Microsoft.eShopWeb.Web.Controllers .ManageController.SendVerificationEmail (IndexViewModel) |
| set_StatusMessage(String) | 0% | 1 | 1 | 1 | 2min 17s | 3min 35s | Microsoft.eShopWeb.Web.Controllers .ManageController.set_StatusMessage (String) |
| GetBasketItemCountAsync(String) | 0% | 10 | 10 | 3 | 30min | 3min 26s | Microsoft.eShopWeb.ApplicationCore .Services.BasketService .GetBasketItemCountAsync(String) |
| Down(MigrationBuilder) | 0% | 10 | 10 | 1 | 13min | 3min 26s | Microsoft.eShopWeb.Infrastructure.Data .Migrations.Initial.Down (MigrationBuilder) |
| ExternalLogins() | 0% | 10 | 10 | 5 | 42min | 3min 26s | Microsoft.eShopWeb.Web.Controllers .ManageController.ExternalLogins() |
| SetQuantities(Int32,Dictionary<String ,Int32>) | 9.09% | 11 | 10 | 3 | 30min | 3min 24s | Microsoft.eShopWeb.ApplicationCore .Services.BasketService.SetQuantities (Int32,Dictionary<String,Int32>) |
| RemoveLogin(RemoveLoginViewModel) | 0% | 9 | 9 | 3 | 27min | 3min 7s | Microsoft.eShopWeb.Web.Controllers .ManageController.RemoveLogin (RemoveLoginViewModel) |
| EnableAuthenticator() | 0% | 9 | 9 | 3 | 27min | 3min 7s | Microsoft.eShopWeb.Web.Controllers .ManageController.EnableAuthenticator() |
| GenerateRecoveryCodes() | 0% | 9 | 9 | 3 | 27min | 3min 7s | Microsoft.eShopWeb.Web.Controllers .ManageController.GenerateRecoveryCodes( ) |
| get_StatusMessage() | 0% | 1 | 1 | 1 | 2min 17s | 3min 3s | Microsoft.eShopWeb.Web.Controllers .ManageController.get_StatusMessage() |
| Register(RegisterViewModel,String) | 0% | 8 | 8 | 3 | 25min | 2min 48s | Microsoft.eShopWeb.Web.Controllers .AccountController.Register (RegisterViewModel,String) |
| ChangePassword() | 0% | 8 | 8 | 3 | 25min | 2min 48s | Microsoft.eShopWeb.Web.Controllers .ManageController.ChangePassword() |
| SetPassword() | 0% | 8 | 8 | 3 | 25min | 2min 48s | Microsoft.eShopWeb.Web.Controllers .ManageController.SetPassword() |
| Disable2fa() | 0% | 8 | 8 | 3 | 25min | 2min 48s | Microsoft.eShopWeb.Web.Controllers .ManageController.Disable2fa() |
| Detail(Int32) | 0% | 8 | 8 | 4 | 38min | 2min 48s | Microsoft.eShopWeb.Web.Controllers .OrderController.Detail(Int32) |
| .ctor(String) | 0% | 3 | 3 | 1 | 6min | 2min 44s | Microsoft.eShopWeb.ApplicationCore .Specifications .CustomerOrdersWithItemsSpecification. .ctor(String) |
| Down(MigrationBuilder) | 0% | 7 | 7 | 1 | 10min | 2min 29s | Microsoft.eShopWeb.Infrastructure .Identity.Migrations .InitialIdentityModel.Down (MigrationBuilder) |
| ConfirmEmail(String,String) | 0% | 7 | 7 | 5 | 30min | 2min 29s | Microsoft.eShopWeb.Web.Controllers .AccountController.ConfirmEmail(String ,String) |
| ResetAuthenticator() | 0% | 7 | 7 | 2 | 17min | 2min 29s | Microsoft.eShopWeb.Web.Controllers .ManageController.ResetAuthenticator() |
| SignIn(LoginViewModel,String) | 50% | 14 | 7 | 5 | 37min | 2min 20s | Microsoft.eShopWeb.Web.Controllers .AccountController.SignIn(LoginViewModel ,String) |
| NullBasket(IGuardClause,Int32,Basket) | 50% | 2 | 1 | 2 | 3min 21s | 2min 12s | Ardalis.GuardClauses.BasketGuards .NullBasket(IGuardClause,Int32,Basket) |
| AddInclude(String) | 0% | 1 | 1 | 1 | 2min 31s | 2min 11s | Microsoft.eShopWeb.ApplicationCore .Specifications.BaseSpecification<T> .AddInclude(String) |
Statistics
| Stat | Percentage Coverage | # lines of code (LOC) | # lines of code not covered | Cyclomatic Complexity (CC) | Debt | Annual Interest |
|---|---|---|---|---|---|---|
| Sum: | 836.17 | 1 152 | 1 082 | 449 | 7d 0h | 1d 3h |
| Average: | 3.51 | 4.84 | 4.55 | 1.89 | 14min | 2min 53s |
| Minimum: | 0 | 0 | 0 | 1 | 2min 0s | 2min 0s |
| Maximum: | 66.67 | 75 | 75 | 15 | 3h 46min | 18min |
| Standard deviation: | 13.99 | 11.34 | 11.23 | 2.35 | 36min | 2min 12s |
| Variance: | 195.66 | 128.7 | 126.07 | 5.54 | 166d | 4h 51min |
| Rule Violated: New Methods should be tested |
• Rule Description:
This rule is executed only if a baseline for comparison is defined (diff mode). This rule operates only on methods added or refactored since the baseline.
This rule is executed only if some code coverage data is imported from some code coverage files.
It is important to write code mostly covered by tests to achieve maintainable and non-error-prone code.
In real-world, many code bases are poorly covered by tests. However it is not practicable to stop the development for months to refactor and write tests to achieve high code coverage ratio.
Hence it is recommended that each time a method (or a type) gets added, the developer takes the time to write associated unit-tests to cover it.
Doing so will help to increase significantly the maintainability of the code base. You'll notice that quickly, refactoring will also be driven by testability, and as a consequence, the overall code structure and design will increase as well.
Issues of this rule have a High severity because they reflect an actual trend to not care about writing tests on refactored code.
• How to Fix Issues of this Rule: Write unit-tests to cover the code of most methods and classes added.
• How to Suppress an Issue of this Rule: In source code, tag the concerned code element with this attribute: [SuppressMessage("NDepend", "ND1601:NewMethodsShouldBeTested", Justification="...")] This attribute requires the compilation symbol CODE_ANALYSIS to be set on each Visual Studio project relying on it. Without CODE_ANALYSIS symbol defined, the attribute is not compiled and the issues are not suppressed.
• How to Fix Issues of this Rule: Write unit-tests to cover the code of most methods and classes added.
• How to Suppress an Issue of this Rule: In source code, tag the concerned code element with this attribute: [SuppressMessage("NDepend", "ND1601:NewMethodsShouldBeTested", Justification="...")] This attribute requires the compilation symbol CODE_ANALYSIS to be set on each Visual Studio project relying on it. Without CODE_ANALYSIS symbol defined, the attribute is not compiled and the issues are not suppressed.
40 methods matched
-
Formatting: bold means added, underlined means code was changed,
strike-boldmeans removed (since baseline)
| 40 methods | Percentage Coverage | # lines of code (LOC) | # lines of code not covered | Debt | Severity | Full Name |
|---|---|---|---|---|---|---|
| BuildTargetModel(ModelBuilder) | 0% | 75 | 75 | 10min | High | Microsoft.eShopWeb.Infrastructure.Data .Migrations.AddExtraConstraints .BuildTargetModel(ModelBuilder) |
| ListAllRegisteredServices (IApplicationBuilder,LinkGenerator) | 11.54% | 26 | 23 | 10min | High | Microsoft.eShopWeb.Web.Startup .ListAllRegisteredServices (IApplicationBuilder,LinkGenerator) |
| OnPostAsync(String) | 0% | 14 | 14 | 10min | High | Microsoft.eShopWeb.Web.Areas.Identity .Pages.Account.LoginModel.OnPostAsync (String) |
| CheckHealthAsync(HealthCheckContext ,CancellationToken) | 0% | 9 | 9 | 9min | High | Microsoft.eShopWeb.Web.HealthChecks .ApiHealthCheck.CheckHealthAsync (HealthCheckContext,CancellationToken) |
| CheckHealthAsync(HealthCheckContext ,CancellationToken) | 0% | 8 | 8 | 8min | High | Microsoft.eShopWeb.Web.HealthChecks .HomePageHealthCheck.CheckHealthAsync (HealthCheckContext,CancellationToken) |
| .ctor(IBasketService ,IBasketViewModelService,IUriComposer ,SignInManager<ApplicationUser> ,IOrderService) | 0% | 8 | 8 | 8min | High | Microsoft.eShopWeb.Web.Pages.Basket .CheckoutModel..ctor(IBasketService ,IBasketViewModelService,IUriComposer ,SignInManager<ApplicationUser> ,IOrderService) |
| GetOrSetBasketCookieAndUserName() | 0% | 8 | 8 | 8min | High | Microsoft.eShopWeb.Web.Pages.Basket .CheckoutModel .GetOrSetBasketCookieAndUserName() |
| Up(MigrationBuilder) | 0% | 6 | 6 | 6min | High | Microsoft.eShopWeb.Infrastructure.Data .Migrations.AddExtraConstraints.Up (MigrationBuilder) |
| Down(MigrationBuilder) | 0% | 6 | 6 | 6min | High | Microsoft.eShopWeb.Infrastructure.Data .Migrations.AddExtraConstraints.Down (MigrationBuilder) |
| OnPost(Dictionary<String,Int32>) | 0% | 5 | 5 | 5min | High | Microsoft.eShopWeb.Web.Pages.Basket .CheckoutModel.OnPost(Dictionary<String ,Int32>) |
| MyAccount() | 0% | 5 | 5 | 5min | High | Microsoft.eShopWeb.Web.Controllers .ManageController.MyAccount() |
| MyOrders() | 0% | 5 | 5 | 5min | High | Microsoft.eShopWeb.Web.Controllers .OrderController.MyOrders() |
| SetBasketModelAsync() | 0% | 4 | 4 | 4min 40s | High | Microsoft.eShopWeb.Web.Pages.Basket .CheckoutModel.SetBasketModelAsync() |
| .ctor(IHttpContextAccessor,LinkGenerator ) | 0% | 3 | 3 | 3min 46s | High | Microsoft.eShopWeb.Web.HealthChecks .ApiHealthCheck..ctor (IHttpContextAccessor,LinkGenerator) |
| GetBrands() | 0% | 3 | 3 | 3min 46s | High | Microsoft.eShopWeb.Web.Services .CachedCatalogViewModelService.GetBrands () |
| GetTypes() | 0% | 3 | 3 | 3min 46s | High | Microsoft.eShopWeb.Web.Services .CachedCatalogViewModelService.GetTypes( ) |
| OnPostUpdate(Dictionary<String,Int32>) | 0% | 3 | 3 | 3min 46s | High | Microsoft.eShopWeb.Web.Pages.Basket .IndexModel.OnPostUpdate(Dictionary <String,Int32>) |
| .ctor(IHttpContextAccessor) | 0% | 2 | 2 | 2min 53s | High | Microsoft.eShopWeb.Web.HealthChecks .HomePageHealthCheck..ctor (IHttpContextAccessor) |
| set_OrderBy(Expression<Func<T,Object>>) | 0% | 1 | 1 | 2min 0s | High | Microsoft.eShopWeb.ApplicationCore .Specifications.BaseSpecification<T> .set_OrderBy(Expression<Func<T,Object>>) |
| set_OrderByDescending(Expression<Func<T ,Object>>) | 0% | 1 | 1 | 2min 0s | High | Microsoft.eShopWeb.ApplicationCore .Specifications.BaseSpecification<T> .set_OrderByDescending(Expression<Func<T ,Object>>) |
| ApplyOrderBy(Expression<Func<T,Object>>) | 0% | 1 | 1 | 2min 0s | High | Microsoft.eShopWeb.ApplicationCore .Specifications.BaseSpecification<T> .ApplyOrderBy(Expression<Func<T,Object>> ) |
| ApplyOrderByDescending(Expression<Func<T ,Object>>) | 0% | 1 | 1 | 2min 0s | High | Microsoft.eShopWeb.ApplicationCore .Specifications.BaseSpecification<T> .ApplyOrderByDescending(Expression<Func <T,Object>>) |
| get_RequestId() | 0% | 1 | 1 | 2min 0s | High | Microsoft.eShopWeb.Web.Pages.ErrorModel .get_RequestId() |
| set_RequestId(String) | 0% | 1 | 1 | 2min 0s | High | Microsoft.eShopWeb.Web.Pages.ErrorModel .set_RequestId(String) |
| get_ShowRequestId() | 0% | 1 | 1 | 2min 0s | High | Microsoft.eShopWeb.Web.Pages.ErrorModel .get_ShowRequestId() |
| OnGet() | 0% | 1 | 1 | 2min 0s | High | Microsoft.eShopWeb.Web.Pages.ErrorModel .OnGet() |
| get_CatalogItemId() | 0% | 1 | 1 | 2min 0s | High | Microsoft.eShopWeb.Web.Pages.Basket .BasketItemViewModel.get_CatalogItemId() |
| get_OldUnitPrice() | 0% | 1 | 1 | 2min 0s | High | Microsoft.eShopWeb.Web.Pages.Basket .BasketItemViewModel.get_OldUnitPrice() |
| set_OldUnitPrice(Decimal) | 0% | 1 | 1 | 2min 0s | High | Microsoft.eShopWeb.Web.Pages.Basket .BasketItemViewModel.set_OldUnitPrice (Decimal) |
| get_BuyerId() | 0% | 1 | 1 | 2min 0s | High | Microsoft.eShopWeb.Web.Pages.Basket .BasketViewModel.get_BuyerId() |
| get_BasketModel() | 0% | 1 | 1 | 2min 0s | High | Microsoft.eShopWeb.Web.Pages.Basket .CheckoutModel.get_BasketModel() |
| set_BasketModel(BasketViewModel) | 0% | 1 | 1 | 2min 0s | High | Microsoft.eShopWeb.Web.Pages.Basket .CheckoutModel.set_BasketModel (BasketViewModel) |
| set_Input(LoginModel+InputModel) | 0% | 1 | 1 | 2min 0s | High | Microsoft.eShopWeb.Web.Areas.Identity .Pages.Account.LoginModel.set_Input (LoginModel+InputModel) |
| get_ExternalLogins() | 0% | 1 | 1 | 2min 0s | High | Microsoft.eShopWeb.Web.Areas.Identity .Pages.Account.LoginModel .get_ExternalLogins() |
| get_Email() | 0% | 1 | 1 | 2min 0s | High | Microsoft.eShopWeb.Web.Areas.Identity .Pages.Account.LoginModel+InputModel .get_Email() |
| set_Email(String) | 0% | 1 | 1 | 2min 0s | High | Microsoft.eShopWeb.Web.Areas.Identity .Pages.Account.LoginModel+InputModel .set_Email(String) |
| get_Password() | 0% | 1 | 1 | 2min 0s | High | Microsoft.eShopWeb.Web.Areas.Identity .Pages.Account.LoginModel+InputModel .get_Password() |
| set_Password(String) | 0% | 1 | 1 | 2min 0s | High | Microsoft.eShopWeb.Web.Areas.Identity .Pages.Account.LoginModel+InputModel .set_Password(String) |
| get_RememberMe() | 0% | 1 | 1 | 2min 0s | High | Microsoft.eShopWeb.Web.Areas.Identity .Pages.Account.LoginModel+InputModel .get_RememberMe() |
| set_RememberMe(Boolean) | 0% | 1 | 1 | 2min 0s | High | Microsoft.eShopWeb.Web.Areas.Identity .Pages.Account.LoginModel+InputModel .set_RememberMe(Boolean) |
| Rule Violated: Methods refactored should be tested |
• Rule Description:
This rule is executed only if a baseline for comparison is defined (diff mode). This rule operates only on methods added or refactored since the baseline.
This rule is executed only if some code coverage data is imported from some code coverage files.
It is important to write code mostly covered by tests to achieve maintainable and non-error-prone code.
In real-world, many code bases are poorly covered by tests. However it is not practicable to stop the development for months to refactor and write tests to achieve high code coverage ratio.
Hence it is recommended that each time a method (or a type) gets refactored, the developer takes the time to write associated unit-tests to cover it.
Doing so will help to increase significantly the maintainability of the code base. You'll notice that quickly, refactoring will also be driven by testability, and as a consequence, the overall code structure and design will increase as well.
Issues of this rule have a High severity because they reflect an actual trend to not care about writing tests on refactored code.
• How to Fix Issues of this Rule: Write unit-tests to cover the code of most methods and classes refactored.
• How to Suppress an Issue of this Rule: In source code, tag the concerned code element with this attribute: [SuppressMessage("NDepend", "ND1602:MethodsRefactoredShouldBeTested", Justification="...")] This attribute requires the compilation symbol CODE_ANALYSIS to be set on each Visual Studio project relying on it. Without CODE_ANALYSIS symbol defined, the attribute is not compiled and the issues are not suppressed.
• How to Fix Issues of this Rule: Write unit-tests to cover the code of most methods and classes refactored.
• How to Suppress an Issue of this Rule: In source code, tag the concerned code element with this attribute: [SuppressMessage("NDepend", "ND1602:MethodsRefactoredShouldBeTested", Justification="...")] This attribute requires the compilation symbol CODE_ANALYSIS to be set on each Visual Studio project relying on it. Without CODE_ANALYSIS symbol defined, the attribute is not compiled and the issues are not suppressed.
4 methods matched
-
Formatting: bold means added, underlined means code was changed,
strike-boldmeans removed (since baseline)
| 4 methods | Percentage Coverage | # lines of code (LOC) | # lines of code not covered | Debt | Severity | Full Name |
|---|---|---|---|---|---|---|
| BuildModel(ModelBuilder) | 0% | 75 | 75 | 10min | High | Microsoft.eShopWeb.Infrastructure.Data .Migrations.CatalogContextModelSnapshot .BuildModel(ModelBuilder) |
| ConfirmEmail(String,String) | 0% | 7 | 7 | 7min | High | Microsoft.eShopWeb.Web.Controllers .AccountController.ConfirmEmail(String ,String) |
| .ctor(String) | 0% | 3 | 3 | 3min 46s | High | Microsoft.eShopWeb.ApplicationCore .Specifications .CustomerOrdersWithItemsSpecification. .ctor(String) |
| SignOut() | 0% | 2 | 2 | 2min 53s | High | Microsoft.eShopWeb.Web.Controllers .AccountController.SignOut() |
| Rule Violated: Assemblies Namespaces and Types should be tested |
• Rule Description:
This rule lists assemblies, namespaces and types that are not covered at all by unit tests.
If a parent is matched its children are not matched. For example if a namespace is matched, its child types are not matched.
This rule goal is not to collide with the Code should be tested rule that lists uncovered code for each method and infer the effort to write unit tests (the Debt) and the annual cost to let the code untested (the Annual Interest).
This rule goal is to inform of large code elements left untested. As a consequence the Debt per issue is only 4 minutes and the severity of the issues is Low.
• How to Fix Issues of this Rule: Write unit and integration tests to cover, even partially, code elements matched by this rule. Then use issues of the rules Code should be tested, New Methods should be tested and Methods refactored should be tested to write more tests where it matters most, and eventually refactor some code to make it more testable.
• How to Suppress an Issue of this Rule: In source code, tag the concerned code element with this attribute: [SuppressMessage("NDepend", "ND1603:AssembliesNamespacesAndTypesShouldBeTested", Justification="...")] This attribute requires the compilation symbol CODE_ANALYSIS to be set on each Visual Studio project relying on it. Without CODE_ANALYSIS symbol defined, the attribute is not compiled and the issues are not suppressed.
• How to Fix Issues of this Rule: Write unit and integration tests to cover, even partially, code elements matched by this rule. Then use issues of the rules Code should be tested, New Methods should be tested and Methods refactored should be tested to write more tests where it matters most, and eventually refactor some code to make it more testable.
• How to Suppress an Issue of this Rule: In source code, tag the concerned code element with this attribute: [SuppressMessage("NDepend", "ND1603:AssembliesNamespacesAndTypesShouldBeTested", Justification="...")] This attribute requires the compilation symbol CODE_ANALYSIS to be set on each Visual Studio project relying on it. Without CODE_ANALYSIS symbol defined, the attribute is not compiled and the issues are not suppressed.
21 code elements parent matched
-
Formatting: bold means added, underlined means code was changed,
strike-boldmeans removed (since baseline)
| 21 code elements parent | # lines of code not covered | Debt | Severity | Full Name |
|---|---|---|---|---|
| CheckoutModel | 27 | 4min 0s | Low | Microsoft.eShopWeb.Web.Pages.Basket .CheckoutModel |
| Microsoft.eShopWeb.Web.HealthChecks | 22 | 4min 0s | Low | Microsoft.eShopWeb.Web.HealthChecks |
| ResetPasswordViewModel | 8 | 4min 0s | Low | Microsoft.eShopWeb.Web.ViewModels .Account.ResetPasswordViewModel |
| LoginWith2faViewModel | 6 | 4min 0s | Low | Microsoft.eShopWeb.Web.ViewModels .Account.LoginWith2faViewModel |
| RegisterViewModel | 6 | 4min 0s | Low | Microsoft.eShopWeb.Web.ViewModels .Account.RegisterViewModel |
| LoginModel+InputModel | 6 | 4min 0s | Low | Microsoft.eShopWeb.Web.Areas.Identity .Pages.Account.LoginModel+InputModel |
| ErrorModel | 4 | 4min 0s | Low | Microsoft.eShopWeb.Web.Pages.ErrorModel |
| Microsoft.eShopWeb.Infrastructure.Data .Migrations | 279 | 4min 0s | Low | Microsoft.eShopWeb.Infrastructure.Data .Migrations |
| Microsoft.eShopWeb.Infrastructure .Identity.Migrations | 190 | 4min 0s | Low | Microsoft.eShopWeb.Infrastructure .Identity.Migrations |
| ManageController | 189 | 4min 0s | Low | Microsoft.eShopWeb.Web.Controllers .ManageController |
| Microsoft.eShopWeb.Web.ViewModels.Manage | 50 | 4min 0s | Low | Microsoft.eShopWeb.Web.ViewModels.Manage |
| OrderService | 17 | 4min 0s | Low | Microsoft.eShopWeb.ApplicationCore .Services.OrderService |
| OrderController | 15 | 4min 0s | Low | Microsoft.eShopWeb.Web.Controllers .OrderController |
| Microsoft.eShopWeb.ApplicationCore .Entities.BuyerAggregate | 14 | 4min 0s | Low | Microsoft.eShopWeb.ApplicationCore .Entities.BuyerAggregate |
| OrderViewModel | 13 | 4min 0s | Low | Microsoft.eShopWeb.Web.ViewModels .OrderViewModel |
| Microsoft.eShopWeb.Web.Views.Manage | 12 | 4min 0s | Low | Microsoft.eShopWeb.Web.Views.Manage |
| OrderItemViewModel | 12 | 4min 0s | Low | Microsoft.eShopWeb.Web.ViewModels .OrderItemViewModel |
| CustomerOrdersWithItemsSpecification | 3 | 4min 0s | Low | Microsoft.eShopWeb.ApplicationCore .Specifications .CustomerOrdersWithItemsSpecification |
| Microsoft.AspNetCore.Mvc | 2 | 4min 0s | Low | Microsoft.AspNetCore.Mvc |
| Microsoft.eShopWeb.Infrastructure .Services | 1 | 4min 0s | Low | Microsoft.eShopWeb.Infrastructure .Services |
| EmailSenderExtensions | 1 | 4min 0s | Low | Microsoft.eShopWeb.Web.Services .EmailSenderExtensions |
Statistics
| Stat | # lines of code not covered | Debt | Severity |
|---|---|---|---|
| Sum: | 877 | 1h 24min | - |
| Average: | 41.76 | 4min 0s | - |
| Minimum: | 1 | 4min 0s | - |
| Maximum: | 279 | 4min 0s | - |
| Standard deviation: | 75 | 0min 0s | - |
| Variance: | 5 625 | 0min 0s | - |
| Rule Violated: Types almost 100% tested should be 100% tested |
• Rule Description:
This rule is executed only if some code coverage data is imported from some code coverage files.
Often covering the few percents of remaining uncovered code of a class, requires as much work as covering the first 90%. For this reason, often teams estimate that 90% coverage is enough. However untestable code usually means poorly written code which usually leads to error prone code. So it might be worth refactoring and making sure to cover the few uncovered lines of code because most tricky bugs might come from this small portion of hard-to-test code.
Not all classes should be 100% covered by tests (like UI code can be hard to test) but you should make sure that most of the logic of your application is defined in some easy-to-test classes, 100% covered by tests.
Issues of this rule have a High severity because as explained, such situation is bug-prone.
• How to Fix Issues of this Rule: Write more unit-tests dedicated to cover code not covered yet. If you find some hard-to-test code, it is certainly a sign that this code is not well designed and hence, needs refactoring.
• How to Suppress an Issue of this Rule: In source code, tag the concerned code element with this attribute: [SuppressMessage("NDepend", "ND1604:TypesAlmost100PercentTestedShouldBe100PercentTested", Justification="...")] This attribute requires the compilation symbol CODE_ANALYSIS to be set on each Visual Studio project relying on it. Without CODE_ANALYSIS symbol defined, the attribute is not compiled and the issues are not suppressed.
• How to Fix Issues of this Rule: Write more unit-tests dedicated to cover code not covered yet. If you find some hard-to-test code, it is certainly a sign that this code is not well designed and hence, needs refactoring.
• How to Suppress an Issue of this Rule: In source code, tag the concerned code element with this attribute: [SuppressMessage("NDepend", "ND1604:TypesAlmost100PercentTestedShouldBe100PercentTested", Justification="...")] This attribute requires the compilation symbol CODE_ANALYSIS to be set on each Visual Studio project relying on it. Without CODE_ANALYSIS symbol defined, the attribute is not compiled and the issues are not suppressed.
2 types matched
-
Formatting: bold means added, underlined means code was changed,
strike-boldmeans removed (since baseline)
| 2 types | Percentage Coverage | # lines of code (LOC) | # lines of code not covered | methodsCulprit | Debt | Severity | Full Name |
|---|---|---|---|---|---|---|---|
| Order | 96.15% | 26 | 1 | 1 method | 2min 0s | High | Microsoft.eShopWeb.ApplicationCore .Entities.OrderAggregate.Order |
| CatalogContext | 95.83% | 48 | 2 | 2 methods | 2min 56s | High | Microsoft.eShopWeb.Infrastructure.Data .CatalogContext |
| Rule Violated: Namespaces almost 100% tested should be 100% tested |
• Rule Description:
This rule is executed only if some code coverage data is imported from some code coverage files.
Often covering the few percents of remaining uncovered code of one or several classes in a namespace requires as much work as covering the first 90%. For this reason, often teams estimate that 90% coverage is enough. However untestable code usually means poorly written code which usually leads to error prone code. So it might be worth refactoring and making sure to cover the few uncovered lines of code because most tricky bugs might come from this small portion of hard-to-test code.
Not all classes should be 100% covered by tests (like UI code can be hard to test) but you should make sure that most of the logic of your application is defined in some easy-to-test classes, 100% covered by tests.
Issues of this rule have a High severity because as explained, such situation is bug-prone.
• How to Fix Issues of this Rule: Write more unit-tests dedicated to cover code not covered yet in the namespace. If you find some hard-to-test code, it is certainly a sign that this code is not well designed and hence, needs refactoring.
• How to Suppress an Issue of this Rule: In source code, tag the concerned code element with this attribute: [SuppressMessage("NDepend", "ND1605:NamespacesAlmost100PercentTestedShouldBe100PercentTested", Justification="...")] This attribute requires the compilation symbol CODE_ANALYSIS to be set on each Visual Studio project relying on it. Without CODE_ANALYSIS symbol defined, the attribute is not compiled and the issues are not suppressed.
• How to Fix Issues of this Rule: Write more unit-tests dedicated to cover code not covered yet in the namespace. If you find some hard-to-test code, it is certainly a sign that this code is not well designed and hence, needs refactoring.
• How to Suppress an Issue of this Rule: In source code, tag the concerned code element with this attribute: [SuppressMessage("NDepend", "ND1605:NamespacesAlmost100PercentTestedShouldBe100PercentTested", Justification="...")] This attribute requires the compilation symbol CODE_ANALYSIS to be set on each Visual Studio project relying on it. Without CODE_ANALYSIS symbol defined, the attribute is not compiled and the issues are not suppressed.
1 namespace matched
-
Formatting: bold means added, underlined means code was changed,
strike-boldmeans removed (since baseline)
| 1 namespace | Percentage Coverage | # lines of code (LOC) | # lines of code not covered | methodsCulprit | Debt | Severity | Full Name |
|---|---|---|---|---|---|---|---|
| Microsoft.eShopWeb.ApplicationCore .Entities.OrderAggregate | 98.53% | 68 | 1 | 1 method | 2min 0s | High | Microsoft.eShopWeb.ApplicationCore .Entities.OrderAggregate |
| Rule Violated: Types 100% covered should be tagged with FullCoveredAttribute |
• Rule Description:
This rule is executed only if some code coverage data is imported from some code coverage files.
By using a FullCoveredAttribute, you can express in source code the intention that a class is 100% covered by tests, and should remain 100% covered in the future.
Benefits of using a FullCoveredAttribute are twofold: Not only the intention is expressed in source code, but it is also continuously checked by the present rule.
Issues of this rule have an Low severity because they don't reflect a problem, but provide an advice for potential improvement.
• How to Fix Issues of this Rule: Just tag types 100% covered by tests with the FullCoveredAttribute that can be found in NDepend.API.dll, or by an attribute of yours defined in your own code (in which case this rule must be adapted).
• How to Suppress an Issue of this Rule: In source code, tag the concerned code element with this attribute: [SuppressMessage("NDepend", "ND1608:Types100PercentCoveredShouldBeTaggedWithFullCoveredAttribute", Justification="...")] This attribute requires the compilation symbol CODE_ANALYSIS to be set on each Visual Studio project relying on it. Without CODE_ANALYSIS symbol defined, the attribute is not compiled and the issues are not suppressed.
• How to Fix Issues of this Rule: Just tag types 100% covered by tests with the FullCoveredAttribute that can be found in NDepend.API.dll, or by an attribute of yours defined in your own code (in which case this rule must be adapted).
• How to Suppress an Issue of this Rule: In source code, tag the concerned code element with this attribute: [SuppressMessage("NDepend", "ND1608:Types100PercentCoveredShouldBeTaggedWithFullCoveredAttribute", Justification="...")] This attribute requires the compilation symbol CODE_ANALYSIS to be set on each Visual Studio project relying on it. Without CODE_ANALYSIS symbol defined, the attribute is not compiled and the issues are not suppressed.
27 types matched
-
Formatting: bold means added, underlined means code was changed,
strike-boldmeans removed (since baseline)
| 27 types | # lines of code (LOC) | Debt | Severity | Full Name |
|---|---|---|---|---|
| BasketWithItemsSpecification | 4 | 3min 0s | Low | Microsoft.eShopWeb.ApplicationCore .Specifications .BasketWithItemsSpecification |
| CatalogFilterPaginatedSpecification | 2 | 3min 0s | Low | Microsoft.eShopWeb.ApplicationCore .Specifications .CatalogFilterPaginatedSpecification |
| Address | 17 | 3min 0s | Low | Microsoft.eShopWeb.ApplicationCore .Entities.OrderAggregate.Address |
| CatalogItemOrdered | 14 | 3min 0s | Low | Microsoft.eShopWeb.ApplicationCore .Entities.OrderAggregate .CatalogItemOrdered |
| OrderItem | 11 | 3min 0s | Low | Microsoft.eShopWeb.ApplicationCore .Entities.OrderAggregate.OrderItem |
| Basket | 11 | 3min 0s | Low | Microsoft.eShopWeb.ApplicationCore .Entities.BasketAggregate.Basket |
| AppIdentityDbContext | 2 | 3min 0s | Low | Microsoft.eShopWeb.Infrastructure .Identity.AppIdentityDbContext |
| AppIdentityDbContextSeed | 2 | 3min 0s | Low | Microsoft.eShopWeb.Infrastructure .Identity.AppIdentityDbContextSeed |
| EfRepository<T> | 14 | 3min 0s | Low | Microsoft.eShopWeb.Infrastructure.Data .EfRepository<T> |
| OrderRepository | 2 | 3min 0s | Low | Microsoft.eShopWeb.Infrastructure.Data .OrderRepository |
| BasketViewModelService | 28 | 3min 0s | Low | Microsoft.eShopWeb.Web.Services .BasketViewModelService |
| CatalogViewModelService | 39 | 3min 0s | Low | Microsoft.eShopWeb.Web.Services .CatalogViewModelService |
| IndexModel | 6 | 3min 0s | Low | Microsoft.eShopWeb.Web.Pages.IndexModel |
| IdentityHostingStartup | 1 | 3min 0s | Low | Microsoft.eShopWeb.Web.Areas.Identity .IdentityHostingStartup |
| CatalogSettings | 2 | 3min 0s | Low | Microsoft.eShopWeb.CatalogSettings |
| CatalogFilterSpecification | 1 | 3min 0s | Low | Microsoft.eShopWeb.ApplicationCore .Specifications .CatalogFilterSpecification |
| UriComposer | 3 | 3min 0s | Low | Microsoft.eShopWeb.ApplicationCore .Services.UriComposer |
| BaseEntity | 2 | 3min 0s | Low | Microsoft.eShopWeb.ApplicationCore .Entities.BaseEntity |
| CatalogBrand | 2 | 3min 0s | Low | Microsoft.eShopWeb.ApplicationCore .Entities.CatalogBrand |
| CatalogItem | 16 | 3min 0s | Low | Microsoft.eShopWeb.ApplicationCore .Entities.CatalogItem |
| CatalogType | 2 | 3min 0s | Low | Microsoft.eShopWeb.ApplicationCore .Entities.CatalogType |
| BasketItem | 6 | 3min 0s | Low | Microsoft.eShopWeb.ApplicationCore .Entities.BasketAggregate.BasketItem |
| BasketComponentViewModel | 2 | 3min 0s | Low | Microsoft.eShopWeb.Web.ViewModels .BasketComponentViewModel |
| CatalogIndexViewModel | 12 | 3min 0s | Low | Microsoft.eShopWeb.Web.ViewModels .CatalogIndexViewModel |
| CatalogItemViewModel | 8 | 3min 0s | Low | Microsoft.eShopWeb.Web.ViewModels .CatalogItemViewModel |
| PaginationInfoViewModel | 12 | 3min 0s | Low | Microsoft.eShopWeb.Web.ViewModels .PaginationInfoViewModel |
| CatalogController | 5 | 3min 0s | Low | Microsoft.eShopWeb.Web.Controllers.Api .CatalogController |
| Rule Violated: Methods should have a low C.R.A.P score |
• Rule Description:
This rule is executed only if some code coverage data is imported from some code coverage files.
So far this rule is disabled because other code coverage rules assess properly code coverage issues.
Change Risk Analyzer and Predictor (i.e. CRAP) is a code metric that helps in pinpointing overly both complex and untested code. Is has been first defined here: http://www.artima.com/weblogs/viewpost.jsp?thread=215899
The Formula is: CRAP(m) = CC(m)^2 * (1 – cov(m)/100)^3 + CC(m)
• where CC(m) is the cyclomatic complexity of the method m
• and cov(m) is the percentage coverage by tests of the method m
Matched methods cumulates two highly error prone code smells:
• A complex method, difficult to develop and maintain.
• Non 100% covered code, difficult to refactor without introducing any regression bug.
The higher the CRAP score, the more painful to maintain and error prone is the method.
An arbitrary threshold of 30 is fixed for this code rule as suggested by inventors.
Notice that no amount of testing will keep methods with a Cyclomatic Complexity higher than 30, out of CRAP territory.
Notice that this rule doesn't match too short method with less than 10 lines of code.
• How to Fix Issues of this Rule: In such situation, it is recommended to both refactor the complex method logic into several smaller and less complex methods (that might belong to some new types especially created), and also write unit-tests to full cover the refactored logic. You'll find code impossible to cover by unit-tests, like calls to MessageBox.Show(). An infrastructure must be defined to be able to mock such code at test-time.
• How to Suppress an Issue of this Rule: In source code, tag the concerned code element with this attribute: [SuppressMessage("NDepend", "ND1609:MethodsShouldHaveALowCRAPScore", Justification="...")] This attribute requires the compilation symbol CODE_ANALYSIS to be set on each Visual Studio project relying on it. Without CODE_ANALYSIS symbol defined, the attribute is not compiled and the issues are not suppressed.
• How to Fix Issues of this Rule: In such situation, it is recommended to both refactor the complex method logic into several smaller and less complex methods (that might belong to some new types especially created), and also write unit-tests to full cover the refactored logic. You'll find code impossible to cover by unit-tests, like calls to MessageBox.Show(). An infrastructure must be defined to be able to mock such code at test-time.
• How to Suppress an Issue of this Rule: In source code, tag the concerned code element with this attribute: [SuppressMessage("NDepend", "ND1609:MethodsShouldHaveALowCRAPScore", Justification="...")] This attribute requires the compilation symbol CODE_ANALYSIS to be set on each Visual Studio project relying on it. Without CODE_ANALYSIS symbol defined, the attribute is not compiled and the issues are not suppressed.
4 methods matched
-
Formatting: bold means added, underlined means code was changed,
strike-boldmeans removed (since baseline)
| 4 methods | CRAP | CC | Percentage Coverage | # lines of code (LOC) | Debt | Severity | Full Name |
|---|---|---|---|---|---|---|---|
| OnPostAsync(String) | 42 | 6 | 0% | 14 | 10min | High | Microsoft.eShopWeb.Web.Areas.Identity .Pages.Account.LoginModel.OnPostAsync (String) |
| Up(MigrationBuilder) | 240 | 15 | 0% | 33 | 22min | High | Microsoft.eShopWeb.Infrastructure .Identity.Migrations .InitialIdentityModel.Up (MigrationBuilder) |
| Up(MigrationBuilder) | 240 | 15 | 0% | 32 | 22min | High | Microsoft.eShopWeb.Infrastructure.Data .Migrations.Initial.Up(MigrationBuilder) |
| Index(IndexViewModel) | 56 | 7 | 0% | 17 | 11min | High | Microsoft.eShopWeb.Web.Controllers .ManageController.Index(IndexViewModel) |
| Dead Code 310 |
|
| Rule Violated: Potentially Dead Methods |
• Rule Description:
This rule lists potentially dead methods. A dead method is a method that can be removed because it is never called by the program.
This rule lists not only methods not called anywhere in code, but also methods called only by methods not called anywhere in code. This is why this rule comes with a column MethodsCallingMe and this is why there is a code metric named depth:
• A depth value of 0 means the method is not called.
• A depth value of 1 means the method is called only by methods not called.
• etc…
By reading the source code of this rule, you'll see that by default, public methods are not matched, because such method might not be called by the analyzed code, but still be called by client code, not analyzed by NDepend. This default behavior can be easily changed.
• How to Fix Issues of this Rule: Static analysis cannot provide an exact list of dead methods, because there are several ways to invoke a method dynamically (like through reflection). For each method matched by this query, first investigate if the method is invoked somehow (like through reflection). If the method is really never invoked, it is important to remove it to avoid maintaining useless code. If you estimate the code of the method might be used in the future, at least comment it, and provide an explanatory comment about the future intentions. If a method is invoked somehow, but still is matched by this rule, you can tag it with the attribute IsNotDeadCodeAttribute found in NDepend.API.dll to avoid matching the method again. You can also provide your own attribute for this need, but then you'll need to adapt this code rule. Issues of this rule have a Debt equal to 10 minutes because it only takes a short while to investigate if a method can be safely discarded. On top of these 10 minutes, the depth of usage of such method adds up 3 minutes per unity because dead method only called by dead code takes a bit more time to be investigated. The Annual Interest of issues of this rule, the annual cost to not fix such issue, is proportional to the type #lines of code, because the bigger the method is, the more it slows down maintenance.
• How to Suppress an Issue of this Rule: In source code, tag the concerned code element with this attribute: [SuppressMessage("NDepend", "ND1701:PotentiallyDeadMethods", Justification="...")] This attribute requires the compilation symbol CODE_ANALYSIS to be set on each Visual Studio project relying on it. Without CODE_ANALYSIS symbol defined, the attribute is not compiled and the issues are not suppressed.
• How to Fix Issues of this Rule: Static analysis cannot provide an exact list of dead methods, because there are several ways to invoke a method dynamically (like through reflection). For each method matched by this query, first investigate if the method is invoked somehow (like through reflection). If the method is really never invoked, it is important to remove it to avoid maintaining useless code. If you estimate the code of the method might be used in the future, at least comment it, and provide an explanatory comment about the future intentions. If a method is invoked somehow, but still is matched by this rule, you can tag it with the attribute IsNotDeadCodeAttribute found in NDepend.API.dll to avoid matching the method again. You can also provide your own attribute for this need, but then you'll need to adapt this code rule. Issues of this rule have a Debt equal to 10 minutes because it only takes a short while to investigate if a method can be safely discarded. On top of these 10 minutes, the depth of usage of such method adds up 3 minutes per unity because dead method only called by dead code takes a bit more time to be investigated. The Annual Interest of issues of this rule, the annual cost to not fix such issue, is proportional to the type #lines of code, because the bigger the method is, the more it slows down maintenance.
• How to Suppress an Issue of this Rule: In source code, tag the concerned code element with this attribute: [SuppressMessage("NDepend", "ND1701:PotentiallyDeadMethods", Justification="...")] This attribute requires the compilation symbol CODE_ANALYSIS to be set on each Visual Studio project relying on it. Without CODE_ANALYSIS symbol defined, the attribute is not compiled and the issues are not suppressed.
4 methods matched
-
Formatting: bold means added, underlined means code was changed,
strike-boldmeans removed (since baseline)
| 4 methods | depth | MethodsCallingMe | Debt | Annual Interest | Full Name |
|---|---|---|---|---|---|
| .ctor() | 0 | no method | 10min | 9min | Microsoft.eShopWeb.ApplicationCore .Entities.OrderAggregate.Address..ctor() |
| .ctor() | 0 | no method | 10min | 9min | Microsoft.eShopWeb.ApplicationCore .Entities.OrderAggregate .CatalogItemOrdered..ctor() |
| .ctor() | 0 | no method | 10min | 11min | Microsoft.eShopWeb.ApplicationCore .Entities.OrderAggregate.Order..ctor() |
| .ctor() | 0 | no method | 10min | 9min | Microsoft.eShopWeb.ApplicationCore .Entities.OrderAggregate.OrderItem..ctor () |
| Visibility 910 |
|
| Rule Violated: Avoid publicly visible constant fields |
• Rule Description:
This rule warns about constant fields that are visible outside their parent assembly. Such field, when used from outside its parent assembly, has its constant value hard-coded into the client assembly. Hence, when changing the field's value, it is mandatory to recompile all assemblies that consume the field, else the program will run with different constant values in-memory. Certainly in such situation bugs are lurking.
• How to Fix Issues of this Rule: Declare matched fields as static readonly instead of constant. This way, the field value is safely changeable without the need to recompile client assemblies. Notice that enumeration value fields suffer from the same potential pitfall. But enumeration values cannot be declared as static readonly hence the rule comes with the condition && !f.IsEnumValue to avoid matching these. Unless you decide to banish public enumerations, just let the rule as is.
• How to Suppress an Issue of this Rule: In source code, tag the concerned code element with this attribute: [SuppressMessage("NDepend", "ND1804:AvoidPubliclyVisibleConstantFields", Justification="...")] This attribute requires the compilation symbol CODE_ANALYSIS to be set on each Visual Studio project relying on it. Without CODE_ANALYSIS symbol defined, the attribute is not compiled and the issues are not suppressed.
• How to Fix Issues of this Rule: Declare matched fields as static readonly instead of constant. This way, the field value is safely changeable without the need to recompile client assemblies. Notice that enumeration value fields suffer from the same potential pitfall. But enumeration values cannot be declared as static readonly hence the rule comes with the condition && !f.IsEnumValue to avoid matching these. Unless you decide to banish public enumerations, just let the rule as is.
• How to Suppress an Issue of this Rule: In source code, tag the concerned code element with this attribute: [SuppressMessage("NDepend", "ND1804:AvoidPubliclyVisibleConstantFields", Justification="...")] This attribute requires the compilation symbol CODE_ANALYSIS to be set on each Visual Studio project relying on it. Without CODE_ANALYSIS symbol defined, the attribute is not compiled and the issues are not suppressed.
3 fields matched
-
Formatting: bold means added, underlined means code was changed,
strike-boldmeans removed (since baseline)
| 3 fields | Debt | Severity | Full Name |
|---|---|---|---|
| ITEMS_PER_PAGE | 0min 30s | Medium | Microsoft.eShopWeb.Web.Constants .ITEMS_PER_PAGE |
| DEFAULT_USERNAME | 0min 30s | Medium | Microsoft.eShopWeb.Web.Constants .DEFAULT_USERNAME |
| BASKET_COOKIENAME | 0min 30s | Medium | Microsoft.eShopWeb.Web.Constants .BASKET_COOKIENAME |
| Immutability 920 |
| Rule Violated: Fields should be marked as ReadOnly when possible |
• Rule Description:
This rule warns about instance and static fields that can be declared as readonly.
This source code of this rule is based on the conditon IField.IsImmutable. https://www.ndepend.com/api/webframe.html?NDepend.API~NDepend.CodeModel.IField~IsImmutable.html
A field that matches the condition IsImmutable is a field that is assigned only by constructors of its class.
For an instance field, this means its value will remain constant through the lifetime of the object.
For a static field, this means its value will remain constant through the lifetime of the program.
• How to Fix Issues of this Rule: Declare the field with the C# readonly keyword (ReadOnly in VB.NET). This way the intention that the field value shouldn't change is made explicit.
• How to Suppress an Issue of this Rule: In source code, tag the concerned code element with this attribute: [SuppressMessage("NDepend", "ND1900:FieldsShouldBeMarkedAsReadOnlyWhenPossible", Justification="...")] This attribute requires the compilation symbol CODE_ANALYSIS to be set on each Visual Studio project relying on it. Without CODE_ANALYSIS symbol defined, the attribute is not compiled and the issues are not suppressed.
• How to Fix Issues of this Rule: Declare the field with the C# readonly keyword (ReadOnly in VB.NET). This way the intention that the field value shouldn't change is made explicit.
• How to Suppress an Issue of this Rule: In source code, tag the concerned code element with this attribute: [SuppressMessage("NDepend", "ND1900:FieldsShouldBeMarkedAsReadOnlyWhenPossible", Justification="...")] This attribute requires the compilation symbol CODE_ANALYSIS to be set on each Visual Studio project relying on it. Without CODE_ANALYSIS symbol defined, the attribute is not compiled and the issues are not suppressed.
1 field matched
-
Formatting: bold means added, underlined means code was changed,
strike-boldmeans removed (since baseline)
| 1 field | MethodsReadingMeButNotAssigningMe | MethodsAssigningMe | Debt | Severity | Full Name |
|---|---|---|---|---|---|
| _paymentMethods | 2 methods | no method | 5min | Medium | Microsoft.eShopWeb.ApplicationCore .Entities.BuyerAggregate.Buyer ._paymentMethods |
| Rule Violated: Do not declare read only mutable reference types |
• Rule Description:
This rule is violated when a public or internal type contains a public or internal read-only field whose field type is a mutable reference type.
This situation gives the false impression that the value can't change, when actually it's only the field value that can't change, but the object state can still change.
• How to Fix Issues of this Rule: To fix a violation of this rule, replace the field type with an immutable type, or declare the field as private. By default issues of this rule have a Low severity because they reflect more an advice than a problem.
• How to Suppress an Issue of this Rule: In source code, tag the concerned code element with this attribute: [SuppressMessage("NDepend", "ND1907:DoNotDeclareReadOnlyMutableReferenceTypes", Justification="...")] This attribute requires the compilation symbol CODE_ANALYSIS to be set on each Visual Studio project relying on it. Without CODE_ANALYSIS symbol defined, the attribute is not compiled and the issues are not suppressed.
• How to Fix Issues of this Rule: To fix a violation of this rule, replace the field type with an immutable type, or declare the field as private. By default issues of this rule have a Low severity because they reflect more an advice than a problem.
• How to Suppress an Issue of this Rule: In source code, tag the concerned code element with this attribute: [SuppressMessage("NDepend", "ND1907:DoNotDeclareReadOnlyMutableReferenceTypes", Justification="...")] This attribute requires the compilation symbol CODE_ANALYSIS to be set on each Visual Studio project relying on it. Without CODE_ANALYSIS symbol defined, the attribute is not compiled and the issues are not suppressed.
1 field matched
-
Formatting: bold means added, underlined means code was changed,
strike-boldmeans removed (since baseline)
| 1 field | FieldType | FieldVisibility | Debt | Severity | Full Name |
|---|---|---|---|---|---|
| _dbContext | CatalogContext | Protected | 3min 0s | Low | Microsoft.eShopWeb.Infrastructure.Data .EfRepository<T>._dbContext |
| Naming Conventions 1631 |
|
| Rule Violated: Static fields naming convention |
• Rule Description:
By default the presents rule supports the 3 most used naming conventions for static fields:
• Static field name starting with an upper-case letter
• Static field name starting with "_" followed with an upper-case letter
• Static field name starting with "s_" followed with an upper-case letter
The rule can be easily adapted to your own company naming convention.
In terms of behavior, a static field is something completely different than an instance field, so it is interesting to differentiate them at a glance through a naming convetion.
This is why it is advised to use a specific naming convention for static field like name that starts with s_.
Related discussion: http://codebetter.com/patricksmacchia/2013/09/04/on-hungarian-notation-for-instance-vs-static-fields-naming/
• How to Fix Issues of this Rule: Once the rule has been adapted to your own naming convention make sure to name all matched static fields adequately.
• How to Suppress an Issue of this Rule: In source code, tag the concerned code element with this attribute: [SuppressMessage("NDepend", "ND2001:StaticFieldsNamingConvention", Justification="...")] This attribute requires the compilation symbol CODE_ANALYSIS to be set on each Visual Studio project relying on it. Without CODE_ANALYSIS symbol defined, the attribute is not compiled and the issues are not suppressed.
• How to Fix Issues of this Rule: Once the rule has been adapted to your own naming convention make sure to name all matched static fields adequately.
• How to Suppress an Issue of this Rule: In source code, tag the concerned code element with this attribute: [SuppressMessage("NDepend", "ND2001:StaticFieldsNamingConvention", Justification="...")] This attribute requires the compilation symbol CODE_ANALYSIS to be set on each Visual Studio project relying on it. Without CODE_ANALYSIS symbol defined, the attribute is not compiled and the issues are not suppressed.
4 fields matched
-
Formatting: bold means added, underlined means code was changed,
strike-boldmeans removed (since baseline)
| 4 fields | Size of instance | Debt | Severity | Full Name |
|---|---|---|---|---|
| _brandsKey | N/A | 3min 0s | Medium | Microsoft.eShopWeb.Web.Services .CachedCatalogViewModelService ._brandsKey |
| _typesKey | N/A | 3min 0s | Medium | Microsoft.eShopWeb.Web.Services .CachedCatalogViewModelService._typesKey |
| _itemsKeyTemplate | N/A | 3min 0s | Medium | Microsoft.eShopWeb.Web.Services .CachedCatalogViewModelService ._itemsKeyTemplate |
| _defaultCacheDuration | N/A | 3min 0s | Medium | Microsoft.eShopWeb.Web.Services .CachedCatalogViewModelService ._defaultCacheDuration |
| Critical Rule Violated: Avoid having different types with same name |
• Rule Description:
This rule warns about multiple types with same name, that are defined in different application or third-party namespaces or assemblies.
Such practice create confusion and also naming collision in source files that use different types with same name.
• How to Fix Issues of this Rule: To fix a violation of this rule, rename concerned types.
• How to Suppress an Issue of this Rule: In source code, tag the concerned code element with this attribute: [SuppressMessage("NDepend", "ND2012:AvoidHavingDifferentTypesWithSameName", Justification="...")] This attribute requires the compilation symbol CODE_ANALYSIS to be set on each Visual Studio project relying on it. Without CODE_ANALYSIS symbol defined, the attribute is not compiled and the issues are not suppressed.
• How to Fix Issues of this Rule: To fix a violation of this rule, rename concerned types.
• How to Suppress an Issue of this Rule: In source code, tag the concerned code element with this attribute: [SuppressMessage("NDepend", "ND2012:AvoidHavingDifferentTypesWithSameName", Justification="...")] This attribute requires the compilation symbol CODE_ANALYSIS to be set on each Visual Studio project relying on it. Without CODE_ANALYSIS symbol defined, the attribute is not compiled and the issues are not suppressed.
1 type matched
-
Formatting: bold means added, underlined means code was changed,
strike-boldmeans removed (since baseline)
| 1 type | types | Debt | Severity | Full Name |
|---|---|---|---|---|
| Basket | 2 types | 10min | High | Microsoft.eShopWeb.ApplicationCore .Entities.BasketAggregate.Basket |
| Rule Violated: Avoid prefixing type name with parent namespace name |
• Rule Description:
This rule warns about situations where the parent namespace name is used as the prefix of a contained type.
For example a type named "RuntimeEnvironment" declared in a namespace named "Foo.Runtime" should be named "Environment".
Such situation creates naming redundancy with no readability gain.
• How to Fix Issues of this Rule: To fix a violation of this rule, remove the prefix from the type name.
• How to Suppress an Issue of this Rule: In source code, tag the concerned code element with this attribute: [SuppressMessage("NDepend", "ND2013:AvoidPrefixingTypeNameWithParentNamespaceName", Justification="...")] This attribute requires the compilation symbol CODE_ANALYSIS to be set on each Visual Studio project relying on it. Without CODE_ANALYSIS symbol defined, the attribute is not compiled and the issues are not suppressed.
• How to Fix Issues of this Rule: To fix a violation of this rule, remove the prefix from the type name.
• How to Suppress an Issue of this Rule: In source code, tag the concerned code element with this attribute: [SuppressMessage("NDepend", "ND2013:AvoidPrefixingTypeNameWithParentNamespaceName", Justification="...")] This attribute requires the compilation symbol CODE_ANALYSIS to be set on each Visual Studio project relying on it. Without CODE_ANALYSIS symbol defined, the attribute is not compiled and the issues are not suppressed.
4 types matched
-
Formatting: bold means added, underlined means code was changed,
strike-boldmeans removed (since baseline)
| 4 types | namespaceName | Debt | Severity | Full Name |
|---|---|---|---|---|
| BasketItemViewModel | Basket | 10min | Medium | Microsoft.eShopWeb.Web.Pages.Basket .BasketItemViewModel |
| BasketViewModel | Basket | 10min | Medium | Microsoft.eShopWeb.Web.Pages.Basket .BasketViewModel |
| IdentityHostingStartup | Identity | 10min | Medium | Microsoft.eShopWeb.Web.Areas.Identity .IdentityHostingStartup |
| ManageNavPages | Manage | 10min | Medium | Microsoft.eShopWeb.Web.Views.Manage .ManageNavPages |
| Rule Violated: Avoid naming types and namespaces with the same identifier |
• Rule Description:
This rule warns when a type and a namespace have the same name.
For example when a type is named Environment and a namespace is named Foo.Environment.
Such situation provokes tedious compiler resolution collision, and makes the code less readable because concepts are not concisely identified.
• How to Fix Issues of this Rule: To fix a violation of this rule, renamed the concerned type or namespace.
• How to Suppress an Issue of this Rule: In source code, tag the concerned code element with this attribute: [SuppressMessage("NDepend", "ND2014:AvoidNamingTypesAndNamespacesWithTheSameIdentifier", Justification="...")] This attribute requires the compilation symbol CODE_ANALYSIS to be set on each Visual Studio project relying on it. Without CODE_ANALYSIS symbol defined, the attribute is not compiled and the issues are not suppressed.
• How to Fix Issues of this Rule: To fix a violation of this rule, renamed the concerned type or namespace.
• How to Suppress an Issue of this Rule: In source code, tag the concerned code element with this attribute: [SuppressMessage("NDepend", "ND2014:AvoidNamingTypesAndNamespacesWithTheSameIdentifier", Justification="...")] This attribute requires the compilation symbol CODE_ANALYSIS to be set on each Visual Studio project relying on it. Without CODE_ANALYSIS symbol defined, the attribute is not compiled and the issues are not suppressed.
2 types matched
-
Formatting: bold means added, underlined means code was changed,
strike-boldmeans removed (since baseline)
| 2 types | namespaces | Debt | Severity | Full Name |
|---|---|---|---|---|
| Basket | 1 namespace | 12min | High | Microsoft.eShopWeb.Web.Pages.Shared .Components.BasketComponent.Basket |
| Basket | 1 namespace | 12min | High | Microsoft.eShopWeb.ApplicationCore .Entities.BasketAggregate.Basket |
| Source Files Organization 330 |
| Rule Violated: Namespace name should correspond to file location |
• Rule Description:
For a solid code structure and organization, do mirror the namespaces hierarchy and the directories hierarchy containing source files.
Doing so is a widely accepted convention, and not respecting this convention will lead to less maintainable and less browsable source code.
This rule matches all types in such source file, whose location doesn't correspond to the type parent namespace. If a source file contains several such types (that are not necessarily in the same namespace) each type will result in a violation.
If a type is declared in several such source files, the value for the column nbSourceDeclConcerned in the result, is greater than 1. The technical-debt per issue is proportional to nbSourceDeclConcerned.
Notice that namespaces and directories names comparison is case-sensitive. A boolean justACaseSensitiveIssue indicates if it is just a case-sensitive issue, in which case the technical-debt is divided by two.
• How to Fix Issues of this Rule: To fix a violation of this rule, make sure that the type parent namespace and the directory sub-paths that contains the type source file, are mirrored. Make sure to first check the boolean justACaseSensitiveIssue, in which case the issue is easier to fix.
• How to Suppress an Issue of this Rule: In source code, tag the concerned code element with this attribute: [SuppressMessage("NDepend", "ND2103:NamespaceNameShouldCorrespondToFileLocation", Justification="...")] This attribute requires the compilation symbol CODE_ANALYSIS to be set on each Visual Studio project relying on it. Without CODE_ANALYSIS symbol defined, the attribute is not compiled and the issues are not suppressed.
• How to Fix Issues of this Rule: To fix a violation of this rule, make sure that the type parent namespace and the directory sub-paths that contains the type source file, are mirrored. Make sure to first check the boolean justACaseSensitiveIssue, in which case the issue is easier to fix.
• How to Suppress an Issue of this Rule: In source code, tag the concerned code element with this attribute: [SuppressMessage("NDepend", "ND2103:NamespaceNameShouldCorrespondToFileLocation", Justification="...")] This attribute requires the compilation symbol CODE_ANALYSIS to be set on each Visual Studio project relying on it. Without CODE_ANALYSIS symbol defined, the attribute is not compiled and the issues are not suppressed.
4 types matched
-
Formatting: bold means added, underlined means code was changed,
strike-boldmeans removed (since baseline)
| 4 types | dirShouldContain | sourceFilePath | nbSourceDeclConcerned | justACaseSensitiveIssue | Debt | Severity | Full Name |
|---|---|---|---|---|---|---|---|
| BasketGuards | GuardClauses | C:\My\NDepend\Tests\On_eShopOnWeb\3Apr2019\src\ApplicationCore\Exceptions\GuardExtensions.cs | 1 | False | 3min 0s | Medium | Ardalis.GuardClauses.BasketGuards |
| CatalogSettings | eShopWeb | C:\My\NDepend\Tests\On_eShopOnWeb\3Apr2019\src\ApplicationCore\CatalogSettings.cs | 1 | False | 3min 0s | Medium | Microsoft.eShopWeb.CatalogSettings |
| UrlHelperExtensions | AspNetCore Mvc | C:\My\NDepend\Tests\On_eShopOnWeb\3Apr2019\src\Web\Extensions\UrlHelperExtensions.cs | 1 | False | 3min 0s | Medium | Microsoft.AspNetCore.Mvc .UrlHelperExtensions |
| EmailSenderExtensions | Web Services | C:\My\NDepend\Tests\On_eShopOnWeb\3Apr2019\src\Web\Extensions\EmailSenderExtensions.cs | 1 | False | 3min 0s | Medium | Microsoft.eShopWeb.Web.Services .EmailSenderExtensions |
| Rule Violated: Types with source files stored in the same directory, should be declared in the same namespace |
• Rule Description:
For a solid code structure and organization, do mirror the namespaces hierarchy and the directories hierarchy containing source files.
Doing so is a widely accepted convention, and not respecting this convention will lead to less maintainable and less browsable code.
Respecting this convention means that types with source files stored in the same directory, should be declared in the same namespace.
For each directory that contains several source files, where most types are declared in a namespace (what we call the main namespace) and a few types are declared out of the main namespace, this code rule matches:
• The main namespace
• typesOutOfMainNamespace: Types declared in source files in the main namespace's directory but that are not in the main namespace.
• typesInMainNamespace: And for informational purposes, types declared in source files in the main namespace's directory, and that are in the main namespace.
• How to Fix Issues of this Rule: Violations of this rule are types in the typesOutOfMainNamespace column. Typically such type … • … is contained in the wrong namespace but its source file is stored in the right directory. In such situation the type should be contained in main namespace. • … is contained in the right namespace but its source file is stored in the wrong directory In such situation the source file of the type must be moved to the proper parent namespace directory. • … is declared in multiple source files, stored in different directories. In such situation it is preferable that all source files are stored in a single directory. The estimated Debt, which means the effort to fix such issue, is equal to 2 minutes plus 5 minutes per type in typesOutOfMainNamespace.
• How to Suppress an Issue of this Rule: In source code, tag the concerned code element with this attribute: [SuppressMessage("NDepend", "ND2104:TypesWithSourceFilesStoredInTheSameDirectoryShouldBeDeclaredInTheSameNamespace", Justification="...")] This attribute requires the compilation symbol CODE_ANALYSIS to be set on each Visual Studio project relying on it. Without CODE_ANALYSIS symbol defined, the attribute is not compiled and the issues are not suppressed.
• How to Fix Issues of this Rule: Violations of this rule are types in the typesOutOfMainNamespace column. Typically such type … • … is contained in the wrong namespace but its source file is stored in the right directory. In such situation the type should be contained in main namespace. • … is contained in the right namespace but its source file is stored in the wrong directory In such situation the source file of the type must be moved to the proper parent namespace directory. • … is declared in multiple source files, stored in different directories. In such situation it is preferable that all source files are stored in a single directory. The estimated Debt, which means the effort to fix such issue, is equal to 2 minutes plus 5 minutes per type in typesOutOfMainNamespace.
• How to Suppress an Issue of this Rule: In source code, tag the concerned code element with this attribute: [SuppressMessage("NDepend", "ND2104:TypesWithSourceFilesStoredInTheSameDirectoryShouldBeDeclaredInTheSameNamespace", Justification="...")] This attribute requires the compilation symbol CODE_ANALYSIS to be set on each Visual Studio project relying on it. Without CODE_ANALYSIS symbol defined, the attribute is not compiled and the issues are not suppressed.
2 namespaces matched
-
Formatting: bold means added, underlined means code was changed,
strike-boldmeans removed (since baseline)
| 2 namespaces | typesOutOfMainNamespace | typesInMainNamespace | Debt | Severity | Full Name |
|---|---|---|---|---|---|
| Ardalis.GuardClauses | 1 type | 1 type | 7min | High | Ardalis.GuardClauses |
| Microsoft.AspNetCore.Mvc | 1 type | 1 type | 7min | High | Microsoft.AspNetCore.Mvc |
| Rule Violated: Types declared in the same namespace, should have their source files stored in the same directory |
• Rule Description:
For a solid code structure and organization, do mirror the namespaces hierarchy and the directories hierarchy containing source files.
Doing so is a widely accepted convention, and not respecting this convention will lead to less maintainable and less browsable code.
Respecting this convention means that types declared in the same namespace, should have their source files stored in the same directory.
For each namespace that contains types whose source files are declared in several directories, infer the main directory, the directory that naturally hosts source files of types, preferably the directory whose name corresponds with the namespace name. In this context, this code rule matches:
• The namespace
• typesDeclaredOutOfMainDir: types in the namespace whose source files are stored out of the main directory.
• The main directory
• typesDeclaredInMainDir: for informational purposes, types declared in the namespace, whose source files are stored in the main directory.
• How to Fix Issues of this Rule: Violations of this rule are types in the typesDeclaredOutOfMainDir column. Typically such type… • … is contained in the wrong namespace but its source file is stored in the right directory. In such situation the type should be contained in the namespace corresponding to the parent directory. • … is contained in the right namespace but its source file is stored in the wrong directory. In such situation the source file of the type must be moved to the main directory. • … is declared in multiple source files, stored in different directories. In such situation it is preferable that all source files are stored in a single directory. The estimated Debt, which means the effort to fix such issue, is equal to 2 minutes plus 5 minutes per type in typesDeclaredOutOfMainDir.
• How to Suppress an Issue of this Rule: In source code, tag the concerned code element with this attribute: [SuppressMessage("NDepend", "ND2105:TypesDeclaredInTheSameNamespaceShouldHaveTheirSourceFilesStoredInTheSameDirectory", Justification="...")] This attribute requires the compilation symbol CODE_ANALYSIS to be set on each Visual Studio project relying on it. Without CODE_ANALYSIS symbol defined, the attribute is not compiled and the issues are not suppressed.
• How to Fix Issues of this Rule: Violations of this rule are types in the typesDeclaredOutOfMainDir column. Typically such type… • … is contained in the wrong namespace but its source file is stored in the right directory. In such situation the type should be contained in the namespace corresponding to the parent directory. • … is contained in the right namespace but its source file is stored in the wrong directory. In such situation the source file of the type must be moved to the main directory. • … is declared in multiple source files, stored in different directories. In such situation it is preferable that all source files are stored in a single directory. The estimated Debt, which means the effort to fix such issue, is equal to 2 minutes plus 5 minutes per type in typesDeclaredOutOfMainDir.
• How to Suppress an Issue of this Rule: In source code, tag the concerned code element with this attribute: [SuppressMessage("NDepend", "ND2105:TypesDeclaredInTheSameNamespaceShouldHaveTheirSourceFilesStoredInTheSameDirectory", Justification="...")] This attribute requires the compilation symbol CODE_ANALYSIS to be set on each Visual Studio project relying on it. Without CODE_ANALYSIS symbol defined, the attribute is not compiled and the issues are not suppressed.
1 namespace matched
-
Formatting: bold means added, underlined means code was changed,
strike-boldmeans removed (since baseline)
| 1 namespace | typesDeclaredOutOfMainDir | mainDir | typesDeclaredInMainDir | Debt | Severity | Full Name |
|---|---|---|---|---|---|---|
| Microsoft.eShopWeb.Web.Services | 1 type | C:\My\NDepend\Tests\On_eShopOnWeb\3Apr2019\src\Web\Services | 3 types | 7min | High | Microsoft.eShopWeb.Web.Services |
 .NET Framework Usage 2320 |
| System 910 |
|
| Rule Violated: Do not raise too general exception types |
• Rule Description:
The following exception types are too general to provide sufficient information to the user:
• System.Exception
• System.ApplicationException
• System.SystemException
If you throw such a general exception type in a library or framework, it forces consumers to catch all exceptions, including unknown exceptions that they do not know how to handle.
This rule matches methods that create an instance of such general exception class.
• How to Fix Issues of this Rule: To fix a violation of this rule, change the type of the thrown exception to either a more derived type that already exists in the framework, or create your own type that derives from System.Exception. The estimated Debt, which means the effort to fix such issue, is equal to 15 minutes per method matched, plus 5 minutes per too general exception types instantiated by the method.
• How to Suppress an Issue of this Rule: In source code, tag the concerned code element with this attribute: [SuppressMessage("NDepend", "ND2207:DoNotRaiseTooGeneralExceptionTypes", Justification="...")] This attribute requires the compilation symbol CODE_ANALYSIS to be set on each Visual Studio project relying on it. Without CODE_ANALYSIS symbol defined, the attribute is not compiled and the issues are not suppressed.
• How to Fix Issues of this Rule: To fix a violation of this rule, change the type of the thrown exception to either a more derived type that already exists in the framework, or create your own type that derives from System.Exception. The estimated Debt, which means the effort to fix such issue, is equal to 15 minutes per method matched, plus 5 minutes per too general exception types instantiated by the method.
• How to Suppress an Issue of this Rule: In source code, tag the concerned code element with this attribute: [SuppressMessage("NDepend", "ND2207:DoNotRaiseTooGeneralExceptionTypes", Justification="...")] This attribute requires the compilation symbol CODE_ANALYSIS to be set on each Visual Studio project relying on it. Without CODE_ANALYSIS symbol defined, the attribute is not compiled and the issues are not suppressed.
21 methods matched
-
Formatting: bold means added, underlined means code was changed,
strike-boldmeans removed (since baseline)
| 21 methods | exceptionsCreated | Debt | Severity | Full Name |
|---|---|---|---|---|
| LoginWith2fa(Boolean,String) | 1 type | 20min | High | Microsoft.eShopWeb.Web.Controllers .AccountController.LoginWith2fa(Boolean ,String) |
| LoginWith2fa(LoginWith2faViewModel ,Boolean,String) | 1 type | 20min | High | Microsoft.eShopWeb.Web.Controllers .AccountController.LoginWith2fa (LoginWith2faViewModel,Boolean,String) |
| ConfirmEmail(String,String) | 1 type | 20min | High | Microsoft.eShopWeb.Web.Controllers .AccountController.ConfirmEmail(String ,String) |
| ResetPassword(String) | 1 type | 20min | High | Microsoft.eShopWeb.Web.Controllers .AccountController.ResetPassword(String) |
| MyAccount() | 1 type | 20min | High | Microsoft.eShopWeb.Web.Controllers .ManageController.MyAccount() |
| Index(IndexViewModel) | 1 type | 20min | High | Microsoft.eShopWeb.Web.Controllers .ManageController.Index(IndexViewModel) |
| SendVerificationEmail(IndexViewModel) | 1 type | 20min | High | Microsoft.eShopWeb.Web.Controllers .ManageController.SendVerificationEmail (IndexViewModel) |
| ChangePassword() | 1 type | 20min | High | Microsoft.eShopWeb.Web.Controllers .ManageController.ChangePassword() |
| ChangePassword(ChangePasswordViewModel) | 1 type | 20min | High | Microsoft.eShopWeb.Web.Controllers .ManageController.ChangePassword (ChangePasswordViewModel) |
| SetPassword() | 1 type | 20min | High | Microsoft.eShopWeb.Web.Controllers .ManageController.SetPassword() |
| SetPassword(SetPasswordViewModel) | 1 type | 20min | High | Microsoft.eShopWeb.Web.Controllers .ManageController.SetPassword (SetPasswordViewModel) |
| ExternalLogins() | 1 type | 20min | High | Microsoft.eShopWeb.Web.Controllers .ManageController.ExternalLogins() |
| LinkLoginCallback() | 1 type | 20min | High | Microsoft.eShopWeb.Web.Controllers .ManageController.LinkLoginCallback() |
| RemoveLogin(RemoveLoginViewModel) | 1 type | 20min | High | Microsoft.eShopWeb.Web.Controllers .ManageController.RemoveLogin (RemoveLoginViewModel) |
| TwoFactorAuthentication() | 1 type | 20min | High | Microsoft.eShopWeb.Web.Controllers .ManageController .TwoFactorAuthentication() |
| Disable2faWarning() | 1 type | 20min | High | Microsoft.eShopWeb.Web.Controllers .ManageController.Disable2faWarning() |
| Disable2fa() | 1 type | 20min | High | Microsoft.eShopWeb.Web.Controllers .ManageController.Disable2fa() |
| EnableAuthenticator() | 1 type | 20min | High | Microsoft.eShopWeb.Web.Controllers .ManageController.EnableAuthenticator() |
| EnableAuthenticator (EnableAuthenticatorViewModel) | 1 type | 20min | High | Microsoft.eShopWeb.Web.Controllers .ManageController.EnableAuthenticator (EnableAuthenticatorViewModel) |
| ResetAuthenticator() | 1 type | 20min | High | Microsoft.eShopWeb.Web.Controllers .ManageController.ResetAuthenticator() |
| GenerateRecoveryCodes() | 1 type | 20min | High | Microsoft.eShopWeb.Web.Controllers .ManageController.GenerateRecoveryCodes( ) |
| System.Collections 010 |
|
| Rule Violated: Collection properties should be read only |
• Rule Description:
A writable collection property allows a user to replace the collection with a completely different collection. A read-only property stops the collection from being replaced but still allows the individual members to be set. If replacing the collection is a goal, the preferred design pattern is to include a method to remove all the elements from the collection and a method to re-populate the collection. See the Clear() and AddRange() methods of the System.Collections.Generic.List<T> class for an example of this pattern.
Both binary and XML serialization support read-only properties that are collections. The System.Xml.Serialization.XmlSerializer class has specific requirements for types that implement ICollection and System.Collections.IEnumerable in order to be serializable.
This rule matches property setter methods that assign a collection object.
• How to Fix Issues of this Rule: To fix a violation of this rule, make the property read-only and, if the design requires it, add methods to clear and re-populate the collection.
• How to Suppress an Issue of this Rule: In source code, tag the concerned code element with this attribute: [SuppressMessage("NDepend", "ND2300:CollectionPropertiesShouldBeReadOnly", Justification="...")] This attribute requires the compilation symbol CODE_ANALYSIS to be set on each Visual Studio project relying on it. Without CODE_ANALYSIS symbol defined, the attribute is not compiled and the issues are not suppressed.
• How to Fix Issues of this Rule: To fix a violation of this rule, make the property read-only and, if the design requires it, add methods to clear and re-populate the collection.
• How to Suppress an Issue of this Rule: In source code, tag the concerned code element with this attribute: [SuppressMessage("NDepend", "ND2300:CollectionPropertiesShouldBeReadOnly", Justification="...")] This attribute requires the compilation symbol CODE_ANALYSIS to be set on each Visual Studio project relying on it. Without CODE_ANALYSIS symbol defined, the attribute is not compiled and the issues are not suppressed.
3 methods matched
-
Formatting: bold means added, underlined means code was changed,
strike-boldmeans removed (since baseline)
| 3 methods | CollectionType | Debt | Severity | Full Name |
|---|---|---|---|---|
| set_ExternalLogins(IList <AuthenticationScheme>) | IList<T> | 10min | Medium | Microsoft.eShopWeb.Web.Areas.Identity .Pages.Account.LoginModel .set_ExternalLogins(IList <AuthenticationScheme>) |
| set_CurrentLogins(IList<UserLoginInfo>) | IList<T> | 10min | Medium | Microsoft.eShopWeb.Web.ViewModels.Manage .ExternalLoginsViewModel .set_CurrentLogins(IList<UserLoginInfo>) |
| set_OtherLogins(IList <AuthenticationScheme>) | IList<T> | 10min | Medium | Microsoft.eShopWeb.Web.ViewModels.Manage .ExternalLoginsViewModel.set_OtherLogins (IList<AuthenticationScheme>) |
Hot Spots
 | Code Query: Types Hot Spots |
• Query Description:
This query lists types with most Debt, or in other words, types with issues that would need the largest effort to get fixed.
Both issues on the type and its members are taken account.
Since untested code often generates a lot of Debt, the type size and percentage coverage is shown (just uncomment t.PercentageCoverage in the query source code once you've imported the coverage data).
The Debt Rating and Debt Ratio are also shown for informational purpose.
--
The amount of Debt is not a measure to prioritize the effort to fix issues, it is an estimation of how far the team is from clean code that abides by the rules set.
For each issue the Annual Interest estimates the annual cost to leave the issues unfixed. The Severity of an issue is estimated through thresholds from the Annual Interest.
The Debt Breaking Point represents the duration from now when the estimated cost to leave the issue unfixed costs as much as the estimated effort to fix it.
Hence the shorter the Debt Breaking Point the largest the Return on Investment for fixing the issue. The Breaking Point is the right metric to prioritize issues fix.
70 types matched
| 70 types | Debt | Issues | Annual Interest | Breaking Point | # lines of code (LOC) | DebtRating | DebtRatio | Full Name |
|---|---|---|---|---|---|---|---|---|
| ManageController | 2d 2h | 47 issues | 1d 0h | 839d | 189 | E | 58.21 | Microsoft.eShopWeb.Web.Controllers .ManageController |
| InitialIdentityModel | 7h 40min | 4 issues | 42min | 3 945d | 115 | D | 44.42 | Microsoft.eShopWeb.Infrastructure .Identity.Migrations .InitialIdentityModel |
| Initial | 7h 37min | 4 issues | 43min | 3 864d | 117 | D | 43.42 | Microsoft.eShopWeb.Infrastructure.Data .Migrations.Initial |
| AccountController | 5h 51min | 18 issues | 2h 30min | 849d | 77 | D | 42.81 | Microsoft.eShopWeb.Web.Controllers .AccountController |
| AddExtraConstraints | 4h 22min | 9 issues | 4h 13min | 377d | 87 | D | 33.07 | Microsoft.eShopWeb.Infrastructure.Data .Migrations.AddExtraConstraints |
| LoginModel | 2h 23min | 10 issues | 2h 32min | 343d | 31 | D | 33.97 | Microsoft.eShopWeb.Web.Areas.Identity .Pages.Account.LoginModel |
| CheckoutModel | 1h 55min | 16 issues | 3h 23min | 208d | 27 | D | 31.89 | Microsoft.eShopWeb.Web.Pages.Basket .CheckoutModel |
| BasketService | 1h 26min | 4 issues | 28min | 1 085d | 44 | C | 18.11 | Microsoft.eShopWeb.ApplicationCore .Services.BasketService |
| OrderController | 1h 23min | 6 issues | 46min | 652d | 15 | D | 48.39 | Microsoft.eShopWeb.Web.Controllers .OrderController |
| BaseSpecification<T> | 1h 21min | 10 issues | 2h 4min | 236d | 25 | C | 17.71 | Microsoft.eShopWeb.ApplicationCore .Specifications.BaseSpecification<T> |
| EfRepository<T> | 1h 16min | 9 issues | 2h 20min | 198d | 14 | D | 35.19 | Microsoft.eShopWeb.Infrastructure.Data .EfRepository<T> |
| ApiHealthCheck | 49min | 5 issues | 1h 45min | 173d | 12 | D | 33.95 | Microsoft.eShopWeb.Web.HealthChecks .ApiHealthCheck |
| CachedCatalogViewModelService | 47min | 9 issues | 1h 52min | 154d | 17 | C | 18.94 | Microsoft.eShopWeb.Web.Services .CachedCatalogViewModelService |
| HomePageHealthCheck | 44min | 5 issues | 1h 44min | 155d | 10 | D | 36.95 | Microsoft.eShopWeb.Web.HealthChecks .HomePageHealthCheck |
| LoginModel+InputModel | 41min | 15 issues | 3h 14min | 78d | 6 | D | 28.45 | Microsoft.eShopWeb.Web.Areas.Identity .Pages.Account.LoginModel+InputModel |
| OrderService | 41min | 3 issues | 6min | 2 352d | 17 | D | 20.67 | Microsoft.eShopWeb.ApplicationCore .Services.OrderService |
| ManageNavPages | 39min | 12 issues | 1h 2min | 230d | 12 | C | 19.14 | Microsoft.eShopWeb.Web.Views.Manage .ManageNavPages |
| SpecificationEvaluator<T> | 38min | 3 issues | 1h 18min | 178d | 14 | D | 26.26 | Microsoft.eShopWeb.Infrastructure.Data .SpecificationEvaluator<T> |
| ExternalLoginsViewModel | 38min | 10 issues | 20min | 700d | 8 | D | 20.19 | Microsoft.eShopWeb.Web.ViewModels.Manage .ExternalLoginsViewModel |
| CustomerOrdersWithItemsSpecification | 36min | 5 issues | 1h 2min | 212d | 3 | E | 84.61 | Microsoft.eShopWeb.ApplicationCore .Specifications .CustomerOrdersWithItemsSpecification |
| Program | 36min | 1 issue | 4min 3s | 3 251d | 13 | D | 24.62 | Microsoft.eShopWeb.Web.Program |
| OrderViewModel | 33min | 14 issues | 26min | 475d | 13 | C | 11.88 | Microsoft.eShopWeb.Web.ViewModels .OrderViewModel |
| ErrorModel | 33min | 10 issues | 2h 34min | 78d | 4 | D | 35.11 | Microsoft.eShopWeb.Web.Pages.ErrorModel |
| BasketItemViewModel | 32min | 8 issues | 2h 8min | 93d | 14 | C | 10.29 | Microsoft.eShopWeb.Web.Pages.Basket .BasketItemViewModel |
| CatalogContextSeed | 32min | 1 issue | 6min | 1 824d | 19 | C | 15.2 | Microsoft.eShopWeb.Infrastructure.Data .CatalogContextSeed |
| IndexModel | 32min | 5 issues | 1h 28min | 133d | 31 | B | 8 | Microsoft.eShopWeb.Web.Pages.Basket .IndexModel |
| OrderItemViewModel | 31min | 13 issues | 24min | 480d | 12 | C | 11.42 | Microsoft.eShopWeb.Web.ViewModels .OrderItemViewModel |
| Basket | 29min | 3 issues | 1h 22min | 132d | 16 | C | 14.99 | Microsoft.eShopWeb.Web.Pages.Shared .Components.BasketComponent.Basket |
| Order | 29min | 4 issues | 1h 34min | 115d | 26 | B | 8.4 | Microsoft.eShopWeb.ApplicationCore .Entities.OrderAggregate.Order |
| Basket | 25min | 3 issues | 40min | 228d | 11 | C | 15.23 | Microsoft.eShopWeb.ApplicationCore .Entities.BasketAggregate.Basket |
| BasketViewModel | 24min | 4 issues | 1h 24min | 105d | 9 | C | 13.39 | Microsoft.eShopWeb.Web.Pages.Basket .BasketViewModel |
| BasketViewModelService | 23min | 3 issues | 40min | 209d | 28 | B | 7.19 | Microsoft.eShopWeb.Web.Services .BasketViewModelService |
| IndexViewModel | 22min | 10 issues | 20min | 419d | 10 | B | 9.85 | Microsoft.eShopWeb.Web.ViewModels.Manage .IndexViewModel |
| ResetPasswordViewModel | 22min | 9 issues | 18min | 448d | 8 | C | 11.78 | Microsoft.eShopWeb.Web.ViewModels .Account.ResetPasswordViewModel |
| Buyer | 21min | 6 issues | 18min | 414d | 8 | C | 15.25 | Microsoft.eShopWeb.ApplicationCore .Entities.BuyerAggregate.Buyer |
| IOrderRepository | 20min | 2 issues | 40min | 182d | N/A | E | 115.74 | Microsoft.eShopWeb.ApplicationCore .Interfaces.IOrderRepository |
| IAggregateRoot | 19min | 1 issue | 2min 0s | 3 467d | N/A | E | 219.91 | Microsoft.eShopWeb.ApplicationCore .Interfaces.IAggregateRoot |
| ChangePasswordViewModel | 18min | 8 issues | 16min | 419d | 8 | B | 9.67 | Microsoft.eShopWeb.Web.ViewModels.Manage .ChangePasswordViewModel |
| LoginWith2faViewModel | 17min | 7 issues | 12min | 541d | 6 | C | 12.11 | Microsoft.eShopWeb.Web.ViewModels .Account.LoginWith2faViewModel |
| RegisterViewModel | 17min | 7 issues | 12min | 541d | 6 | C | 12.11 | Microsoft.eShopWeb.Web.ViewModels .Account.RegisterViewModel |
| PaymentMethod | 15min | 7 issues | 14min | 411d | 6 | C | 10.75 | Microsoft.eShopWeb.ApplicationCore .Entities.BuyerAggregate.PaymentMethod |
| CatalogContext | 15min | 11 issues | 40min | 141d | 48 | A | 2.34 | Microsoft.eShopWeb.Infrastructure.Data .CatalogContext |
| IBasketViewModelService | 15min | 1 issue | 1h 1min | 89d | N/A | E | 86.81 | Microsoft.eShopWeb.Web.Interfaces .IBasketViewModelService |
| EnableAuthenticatorViewModel | 13min | 6 issues | 12min | 419d | 6 | B | 9.39 | Microsoft.eShopWeb.Web.ViewModels.Manage .EnableAuthenticatorViewModel |
| SetPasswordViewModel | 13min | 6 issues | 12min | 419d | 6 | B | 9.39 | Microsoft.eShopWeb.Web.ViewModels.Manage .SetPasswordViewModel |
| TwoFactorAuthenticationViewModel | 13min | 6 issues | 12min | 419d | 6 | B | 9.39 | Microsoft.eShopWeb.Web.ViewModels.Manage .TwoFactorAuthenticationViewModel |
| BasketWithItemsSpecification | 13min | 2 issues | 20min | 237d | 4 | D | 21.49 | Microsoft.eShopWeb.ApplicationCore .Specifications .BasketWithItemsSpecification |
| CatalogFilterSpecification | 13min | 2 issues | 20min | 237d | 1 | E | 50.15 | Microsoft.eShopWeb.ApplicationCore .Specifications .CatalogFilterSpecification |
| Address | 13min | 2 issues | 9min | 527d | 17 | A | 4.3 | Microsoft.eShopWeb.ApplicationCore .Entities.OrderAggregate.Address |
| CatalogItemOrdered | 13min | 2 issues | 9min | 527d | 14 | B | 5.79 | Microsoft.eShopWeb.ApplicationCore .Entities.OrderAggregate .CatalogItemOrdered |
| OrderItem | 13min | 2 issues | 9min | 527d | 11 | B | 6.54 | Microsoft.eShopWeb.ApplicationCore .Entities.OrderAggregate.OrderItem |
| OrderRepository | 13min | 2 issues | 20min | 237d | 2 | D | 30.09 | Microsoft.eShopWeb.Infrastructure.Data .OrderRepository |
| CatalogController | 13min | 2 issues | 20min | 237d | 5 | C | 16.72 | Microsoft.eShopWeb.Web.Controllers.Api .CatalogController |
| IdentityHostingStartup | 13min | 2 issues | 2min 0s | 2 372d | 1 | D | 37.62 | Microsoft.eShopWeb.Web.Areas.Identity .IdentityHostingStartup |
| SlugifyParameterTransformer | 12min | 2 issues | 1h 2min | 76d | 3 | D | 25.05 | Microsoft.eShopWeb.Web .SlugifyParameterTransformer |
| PrivacyModel | 12min | 3 issues | 1h 4min | 71d | 0 | D | 48.23 | Microsoft.eShopWeb.Web.Pages .PrivacyModel |
| IAsyncRepository<T> | 10min | 1 issue | 20min | 182d | N/A | C | 14.47 | Microsoft.eShopWeb.ApplicationCore .Interfaces.IAsyncRepository<T> |
| ISpecification<T> | 10min | 1 issue | 20min | 182d | N/A | C | 12.86 | Microsoft.eShopWeb.ApplicationCore .Interfaces.ISpecification<T> |
| EmailSenderExtensions | 9min | 3 issues | 4min 0s | 848d | 1 | D | 35.87 | Microsoft.eShopWeb.Web.Services .EmailSenderExtensions |
| RemoveLoginViewModel | 9min | 4 issues | 8min | 419d | 4 | B | 8.87 | Microsoft.eShopWeb.Web.ViewModels.Manage .RemoveLoginViewModel |
| CatalogFilterPaginatedSpecification | 9min | 2 issues | 20min | 164d | 2 | D | 26.04 | Microsoft.eShopWeb.ApplicationCore .Specifications .CatalogFilterPaginatedSpecification |
| UrlHelperExtensions | 7min | 3 issues | 6min | 462d | 2 | C | 17.58 | Microsoft.AspNetCore.Mvc .UrlHelperExtensions |
| BasketNotFoundException | 7min | 3 issues | 6min | 433d | 4 | B | 9.16 | Microsoft.eShopWeb.ApplicationCore .Exceptions.BasketNotFoundException |
| BasketGuards | 6min | 2 issues | 4min 12s | 551d | 2 | C | 18.39 | Ardalis.GuardClauses.BasketGuards |
| CatalogSettings | 6min | 2 issues | 2min 0s | 1 095d | 2 | B | 9.92 | Microsoft.eShopWeb.CatalogSettings |
| LoggerAdapter<T> | 4min 35s | 2 issues | 4min 0s | 419d | 4 | B | 5.91 | Microsoft.eShopWeb.Infrastructure .Logging.LoggerAdapter<T> |
| GenerateRecoveryCodesViewModel | 4min 35s | 2 issues | 4min 0s | 419d | 2 | B | 7.6 | Microsoft.eShopWeb.Web.ViewModels.Manage .GenerateRecoveryCodesViewModel |
| EmailSender | 2min 17s | 1 issue | 2min 0s | 419d | 1 | B | 6.65 | Microsoft.eShopWeb.Infrastructure .Services.EmailSender |
| LoginViewModel | 2min 17s | 1 issue | 2min 0s | 419d | 6 | A | 1.56 | Microsoft.eShopWeb.Web.ViewModels .Account.LoginViewModel |
| Constants | 1min 30s | 3 issues | 6min | 91d | 0 | A | 4.34 | Microsoft.eShopWeb.Web.Constants |
Statistics
| Stat | Debt | Issues | Annual Interest | Breaking Point | # lines of code (LOC) | DebtRating | DebtRatio |
|---|---|---|---|---|---|---|---|
| Sum: | 9d 2h | 411 | 7d 7h | 43 461d | 1 242 | - | 1 832 |
| Average: | 1h 3min | 5.87 | 54min | 620d | 19.11 | - | 26.17 |
| Minimum: | 1min 30s | 1 | 2min 0s | 71d | 0 | - | 1.56 |
| Maximum: | 2d 2h | 47 | 1d 0h | 3 945d | 189 | - | 219.91 |
| Standard deviation: | 2h 34min | 6.4 | 1h 15min | 862d | 31.83 | - | 30.98 |
| Variance: | 2 988d | 40.91 | 719d | overflow | 1 013 | - | 959.99 |
| Code Query: Types to Fix Priority |
• Query Description:
This query lists types per increasing Debt Breaking Point.
For each issue the Debt estimates the effort to fix the issue, and the Annual Interest estimates the annual cost to leave the issue unfixed. The Severity of an issue is estimated through thresholds from the Annual Interest of the issue.
The Debt Breaking Point represents the duration from now when the estimated cost to leave the issue unfixed costs as much as the estimated effort to fix it.
Hence the shorter the Debt Breaking Point the largest the Return on Investment for fixing the issues.
Often new and refactored types since baseline will be listed first, because issues on these types get a higher Annual Interest because it is important to focus first on new issues.
--
Both issues on the type and its members are taken account.
Only types with at least 30 minutes of Debt are listed to avoid parasiting the list with the numerous types with small Debt, on which the Breaking Point value makes less sense.
The Annual Interest estimates the cost per year in man-days to leave these issues unfixed.
Since untested code often generates a lot of Debt, the type size and percentage coverage is shown (just uncomment t.PercentageCoverage in the query source code once you've imported the coverage data).
The Debt Rating and Debt Ratio are also shown for informational purpose.
27 types matched
| 27 types | Breaking Point | Debt | Annual Interest | Issues | # lines of code (LOC) | DebtRating | DebtRatio | Full Name |
|---|---|---|---|---|---|---|---|---|
| LoginModel+InputModel | 78d | 41min | 3h 14min | 15 issues | 6 | D | 28.45 | Microsoft.eShopWeb.Web.Areas.Identity .Pages.Account.LoginModel+InputModel |
| ErrorModel | 78d | 33min | 2h 34min | 10 issues | 4 | D | 35.11 | Microsoft.eShopWeb.Web.Pages.ErrorModel |
| BasketItemViewModel | 93d | 32min | 2h 8min | 8 issues | 14 | C | 10.29 | Microsoft.eShopWeb.Web.Pages.Basket .BasketItemViewModel |
| IndexModel | 133d | 32min | 1h 28min | 5 issues | 31 | B | 8 | Microsoft.eShopWeb.Web.Pages.Basket .IndexModel |
| CachedCatalogViewModelService | 154d | 47min | 1h 52min | 9 issues | 17 | C | 18.94 | Microsoft.eShopWeb.Web.Services .CachedCatalogViewModelService |
| HomePageHealthCheck | 155d | 44min | 1h 44min | 5 issues | 10 | D | 36.95 | Microsoft.eShopWeb.Web.HealthChecks .HomePageHealthCheck |
| ApiHealthCheck | 173d | 49min | 1h 45min | 5 issues | 12 | D | 33.95 | Microsoft.eShopWeb.Web.HealthChecks .ApiHealthCheck |
| SpecificationEvaluator<T> | 178d | 38min | 1h 18min | 3 issues | 14 | D | 26.26 | Microsoft.eShopWeb.Infrastructure.Data .SpecificationEvaluator<T> |
| EfRepository<T> | 198d | 1h 16min | 2h 20min | 9 issues | 14 | D | 35.19 | Microsoft.eShopWeb.Infrastructure.Data .EfRepository<T> |
| CheckoutModel | 208d | 1h 55min | 3h 23min | 16 issues | 27 | D | 31.89 | Microsoft.eShopWeb.Web.Pages.Basket .CheckoutModel |
| CustomerOrdersWithItemsSpecification | 212d | 36min | 1h 2min | 5 issues | 3 | E | 84.61 | Microsoft.eShopWeb.ApplicationCore .Specifications .CustomerOrdersWithItemsSpecification |
| ManageNavPages | 230d | 39min | 1h 2min | 12 issues | 12 | C | 19.14 | Microsoft.eShopWeb.Web.Views.Manage .ManageNavPages |
| BaseSpecification<T> | 236d | 1h 21min | 2h 4min | 10 issues | 25 | C | 17.71 | Microsoft.eShopWeb.ApplicationCore .Specifications.BaseSpecification<T> |
| LoginModel | 343d | 2h 23min | 2h 32min | 10 issues | 31 | D | 33.97 | Microsoft.eShopWeb.Web.Areas.Identity .Pages.Account.LoginModel |
| AddExtraConstraints | 377d | 4h 22min | 4h 13min | 9 issues | 87 | D | 33.07 | Microsoft.eShopWeb.Infrastructure.Data .Migrations.AddExtraConstraints |
| OrderViewModel | 475d | 33min | 26min | 14 issues | 13 | C | 11.88 | Microsoft.eShopWeb.Web.ViewModels .OrderViewModel |
| OrderItemViewModel | 480d | 31min | 24min | 13 issues | 12 | C | 11.42 | Microsoft.eShopWeb.Web.ViewModels .OrderItemViewModel |
| OrderController | 652d | 1h 23min | 46min | 6 issues | 15 | D | 48.39 | Microsoft.eShopWeb.Web.Controllers .OrderController |
| ExternalLoginsViewModel | 700d | 38min | 20min | 10 issues | 8 | D | 20.19 | Microsoft.eShopWeb.Web.ViewModels.Manage .ExternalLoginsViewModel |
| ManageController | 839d | 2d 2h | 1d 0h | 47 issues | 189 | E | 58.21 | Microsoft.eShopWeb.Web.Controllers .ManageController |
| AccountController | 849d | 5h 51min | 2h 30min | 18 issues | 77 | D | 42.81 | Microsoft.eShopWeb.Web.Controllers .AccountController |
| BasketService | 1 085d | 1h 26min | 28min | 4 issues | 44 | C | 18.11 | Microsoft.eShopWeb.ApplicationCore .Services.BasketService |
| CatalogContextSeed | 1 824d | 32min | 6min | 1 issue | 19 | C | 15.2 | Microsoft.eShopWeb.Infrastructure.Data .CatalogContextSeed |
| OrderService | 2 352d | 41min | 6min | 3 issues | 17 | D | 20.67 | Microsoft.eShopWeb.ApplicationCore .Services.OrderService |
| Program | 3 251d | 36min | 4min 3s | 1 issue | 13 | D | 24.62 | Microsoft.eShopWeb.Web.Program |
| Initial | 3 864d | 7h 37min | 43min | 4 issues | 117 | D | 43.42 | Microsoft.eShopWeb.Infrastructure.Data .Migrations.Initial |
| InitialIdentityModel | 3 945d | 7h 40min | 42min | 4 issues | 115 | D | 44.42 | Microsoft.eShopWeb.Infrastructure .Identity.Migrations .InitialIdentityModel |
Statistics
| Stat | Breaking Point | Debt | Annual Interest | Issues | # lines of code (LOC) | DebtRating | DebtRatio |
|---|---|---|---|---|---|---|---|
| Sum: | 23 175d | 8d 0h | 5d 7h | 256 | 946 | - | 812.88 |
| Average: | 858d | 2h 22min | 1h 45min | 9.48 | 35.04 | - | 30.11 |
| Minimum: | 78d | 31min | 4min 3s | 1 | 3 | - | 8 |
| Maximum: | 3 945d | 2d 2h | 1d 0h | 47 | 189 | - | 84.61 |
| Standard deviation: | 1 133d | 3h 47min | 1h 38min | 8.62 | 43.44 | - | 16.49 |
| Variance: | overflow | 6 468d | 1 223d | 74.32 | 1 887 | - | 271.84 |
| Code Query: Issues to Fix Priority |
• Query Description:
This query lists issues per increasing Debt Breaking Point.
Double-click an issue to edit its rule and select the issue in the rule result. This way you can view all information concerning the issue.
For each issue the Debt estimates the effort to fix the issue, and the Annual Interest estimates the annual cost to leave the issue unfixed. The Severity of an issue is estimated through thresholds from the Annual Interest of the issue.
The Debt Breaking Point represents the duration from now when the estimated cost to leave the issue unfixed costs as much as the estimated effort to fix it.
Hence the shorter the Debt Breaking Point the largest the Return on Investment for fixing the issue.
Often issues on new and refactored code elements since baseline will be listed first, because such issues get a higher Annual Interest because it is important to focus first on new issues on recent code.
More documentation: https://www.ndepend.com/docs/technical-debt
472 issues matched
| 472 issues | Debt | Annual Interest | Breaking Point | CodeElement | Full Name |
|---|---|---|---|---|---|
| High issue on: Microsoft.eShopWeb .Infrastructure.Data.Migrations .AddExtraConstraints.Up(MigrationBuilder ) | 5min | 1h 0min | 30d | Up(MigrationBuilder) | Rule violated: From now, all methods added should respect basic quality principles |
| High issue on: Microsoft.eShopWeb .Infrastructure.Data.Migrations .AddExtraConstraints.Down (MigrationBuilder) | 5min | 1h 0min | 30d | Down(MigrationBuilder) | Rule violated: From now, all methods added should respect basic quality principles |
| High issue on: Microsoft.eShopWeb .ApplicationCore.Specifications .BaseSpecification<T>.set_OrderBy (Expression<Func<T,Object>>) | 2min 0s | 20min | 36d | set_OrderBy(Expression<Func<T,Object>>) | Rule violated: New Methods should be tested |
| High issue on: Microsoft.eShopWeb .ApplicationCore.Specifications .BaseSpecification<T> .set_OrderByDescending(Expression<Func<T ,Object>>) | 2min 0s | 20min | 36d | set_OrderByDescending(Expression<Func<T,Object>>) | Rule violated: New Methods should be tested |
| High issue on: Microsoft.eShopWeb .ApplicationCore.Specifications .BaseSpecification<T>.ApplyOrderBy (Expression<Func<T,Object>>) | 2min 0s | 20min | 36d | ApplyOrderBy(Expression<Func<T,Object>>) | Rule violated: New Methods should be tested |
| High issue on: Microsoft.eShopWeb .ApplicationCore.Specifications .BaseSpecification<T> .ApplyOrderByDescending(Expression<Func <T,Object>>) | 2min 0s | 20min | 36d | ApplyOrderByDescending(Expression<Func<T,Object>>) | Rule violated: New Methods should be tested |
| High issue on: Microsoft.eShopWeb.Web .Pages.ErrorModel.get_RequestId() | 2min 0s | 20min | 36d | get_RequestId() | Rule violated: New Methods should be tested |
| High issue on: Microsoft.eShopWeb.Web .Pages.ErrorModel.set_RequestId(String) | 2min 0s | 20min | 36d | set_RequestId(String) | Rule violated: New Methods should be tested |
| High issue on: Microsoft.eShopWeb.Web .Pages.ErrorModel.get_ShowRequestId() | 2min 0s | 20min | 36d | get_ShowRequestId() | Rule violated: New Methods should be tested |
| High issue on: Microsoft.eShopWeb.Web .Pages.ErrorModel.OnGet() | 2min 0s | 20min | 36d | OnGet() | Rule violated: New Methods should be tested |
| High issue on: Microsoft.eShopWeb.Web .Pages.Basket.BasketItemViewModel .get_CatalogItemId() | 2min 0s | 20min | 36d | get_CatalogItemId() | Rule violated: New Methods should be tested |
| High issue on: Microsoft.eShopWeb.Web .Pages.Basket.BasketItemViewModel .get_OldUnitPrice() | 2min 0s | 20min | 36d | get_OldUnitPrice() | Rule violated: New Methods should be tested |
| High issue on: Microsoft.eShopWeb.Web .Pages.Basket.BasketItemViewModel .set_OldUnitPrice(Decimal) | 2min 0s | 20min | 36d | set_OldUnitPrice(Decimal) | Rule violated: New Methods should be tested |
| High issue on: Microsoft.eShopWeb.Web .Pages.Basket.BasketViewModel .get_BuyerId() | 2min 0s | 20min | 36d | get_BuyerId() | Rule violated: New Methods should be tested |
| High issue on: Microsoft.eShopWeb.Web .Pages.Basket.CheckoutModel .get_BasketModel() | 2min 0s | 20min | 36d | get_BasketModel() | Rule violated: New Methods should be tested |
| High issue on: Microsoft.eShopWeb.Web .Pages.Basket.CheckoutModel .set_BasketModel(BasketViewModel) | 2min 0s | 20min | 36d | set_BasketModel(BasketViewModel) | Rule violated: New Methods should be tested |
| High issue on: Microsoft.eShopWeb.Web .Areas.Identity.Pages.Account.LoginModel .set_Input(LoginModel+InputModel) | 2min 0s | 20min | 36d | set_Input(LoginModel+InputModel) | Rule violated: New Methods should be tested |
| High issue on: Microsoft.eShopWeb.Web .Areas.Identity.Pages.Account.LoginModel .get_ExternalLogins() | 2min 0s | 20min | 36d | get_ExternalLogins() | Rule violated: New Methods should be tested |
| High issue on: Microsoft.eShopWeb.Web .Areas.Identity.Pages.Account .LoginModel+InputModel.get_Email() | 2min 0s | 20min | 36d | get_Email() | Rule violated: New Methods should be tested |
| High issue on: Microsoft.eShopWeb.Web .Areas.Identity.Pages.Account .LoginModel+InputModel.set_Email(String) | 2min 0s | 20min | 36d | set_Email(String) | Rule violated: New Methods should be tested |
| High issue on: Microsoft.eShopWeb.Web .Areas.Identity.Pages.Account .LoginModel+InputModel.get_Password() | 2min 0s | 20min | 36d | get_Password() | Rule violated: New Methods should be tested |
| High issue on: Microsoft.eShopWeb.Web .Areas.Identity.Pages.Account .LoginModel+InputModel.set_Password (String) | 2min 0s | 20min | 36d | set_Password(String) | Rule violated: New Methods should be tested |
| High issue on: Microsoft.eShopWeb.Web .Areas.Identity.Pages.Account .LoginModel+InputModel.get_RememberMe() | 2min 0s | 20min | 36d | get_RememberMe() | Rule violated: New Methods should be tested |
| High issue on: Microsoft.eShopWeb.Web .Areas.Identity.Pages.Account .LoginModel+InputModel.set_RememberMe (Boolean) | 2min 0s | 20min | 36d | set_RememberMe(Boolean) | Rule violated: New Methods should be tested |
| High issue on: Microsoft.eShopWeb .ApplicationCore.Entities.OrderAggregate .Order | 2min 0s | 20min | 36d | Order | Rule violated: Types almost 100% tested should be 100% tested |
| High issue on: Microsoft.eShopWeb .ApplicationCore.Entities.OrderAggregate | 2min 0s | 20min | 36d | Microsoft.eShopWeb.ApplicationCore.Entities.OrderAggregate | Rule violated: Namespaces almost 100% tested should be 100% tested |
| High issue on: Microsoft.eShopWeb.Web .HealthChecks.HomePageHealthCheck..ctor (IHttpContextAccessor) | 2min 53s | 20min | 52d | .ctor(IHttpContextAccessor) | Rule violated: New Methods should be tested |
| High issue on: Microsoft.eShopWeb.Web .Controllers.AccountController.SignOut() | 2min 53s | 20min | 52d | SignOut() | Rule violated: Methods refactored should be tested |
| High issue on: Microsoft.eShopWeb .Infrastructure.Data.CatalogContext | 2min 56s | 20min | 53d | CatalogContext | Rule violated: Types almost 100% tested should be 100% tested |
| High issue on: Microsoft.eShopWeb.Infrastructure.Data .SpecificationEvaluator<T> | 10min | 1h 0min | 60d | SpecificationEvaluator<T> | Rule violated: From now, all types added should be 100% covered by tests |
| High issue on: Microsoft.eShopWeb .Infrastructure.Data.Migrations .AddExtraConstraints | 10min | 1h 0min | 60d | AddExtraConstraints | Rule violated: From now, all types added should be 100% covered by tests |
| High issue on: Microsoft.eShopWeb.Web .SlugifyParameterTransformer | 10min | 1h 0min | 60d | SlugifyParameterTransformer | Rule violated: From now, all types added should be 100% covered by tests |
| High issue on: Microsoft.eShopWeb.Web .HealthChecks.ApiHealthCheck | 10min | 1h 0min | 60d | ApiHealthCheck | Rule violated: From now, all types added should be 100% covered by tests |
| High issue on: Microsoft.eShopWeb.Web .HealthChecks.HomePageHealthCheck | 10min | 1h 0min | 60d | HomePageHealthCheck | Rule violated: From now, all types added should be 100% covered by tests |
| High issue on: Microsoft.eShopWeb.Web .Services.CachedCatalogViewModelService | 10min | 1h 0min | 60d | CachedCatalogViewModelService | Rule violated: From now, all types added should be 100% covered by tests |
| High issue on: Microsoft.eShopWeb.Web.Pages.ErrorModel | 10min | 1h 0min | 60d | ErrorModel | Rule violated: From now, all types added should be 100% covered by tests |
| High issue on: Microsoft.eShopWeb.Web .Pages.PrivacyModel | 10min | 1h 0min | 60d | PrivacyModel | Rule violated: From now, all types added should be 100% covered by tests |
| High issue on: Microsoft.eShopWeb.Web .Pages.Basket.BasketItemViewModel | 10min | 1h 0min | 60d | BasketItemViewModel | Rule violated: From now, all types added should be 100% covered by tests |
| High issue on: Microsoft.eShopWeb.Web .Pages.Basket.BasketViewModel | 10min | 1h 0min | 60d | BasketViewModel | Rule violated: From now, all types added should be 100% covered by tests |
| High issue on: Microsoft.eShopWeb.Web .Pages.Basket.CheckoutModel | 10min | 1h 0min | 60d | CheckoutModel | Rule violated: From now, all types added should be 100% covered by tests |
| High issue on: Microsoft.eShopWeb.Web .Pages.Basket.IndexModel | 10min | 1h 0min | 60d | IndexModel | Rule violated: From now, all types added should be 100% covered by tests |
| High issue on: Microsoft.eShopWeb.Web .Pages.Shared.Components.BasketComponent .Basket | 10min | 1h 0min | 60d | Basket | Rule violated: From now, all types added should be 100% covered by tests |
| High issue on: Microsoft.eShopWeb.Web .Areas.Identity.Pages.Account.LoginModel | 10min | 1h 0min | 60d | LoginModel | Rule violated: From now, all types added should be 100% covered by tests |
| High issue on: Microsoft.eShopWeb.Web .Areas.Identity.Pages.Account .LoginModel+InputModel | 10min | 1h 0min | 60d | LoginModel+InputModel | Rule violated: From now, all types added should be 100% covered by tests |
| High issue on: Microsoft.eShopWeb.Web .HealthChecks.ApiHealthCheck..ctor (IHttpContextAccessor,LinkGenerator) | 3min 46s | 20min | 68d | .ctor(IHttpContextAccessor,LinkGenerator) | Rule violated: New Methods should be tested |
| High issue on: Microsoft.eShopWeb.Web .Services.CachedCatalogViewModelService .GetBrands() | 3min 46s | 20min | 68d | GetBrands() | Rule violated: New Methods should be tested |
| High issue on: Microsoft.eShopWeb.Web .Services.CachedCatalogViewModelService .GetTypes() | 3min 46s | 20min | 68d | GetTypes() | Rule violated: New Methods should be tested |
| High issue on: Microsoft.eShopWeb.Web .Pages.Basket.IndexModel.OnPostUpdate (Dictionary<String,Int32>) | 3min 46s | 20min | 68d | OnPostUpdate(Dictionary<String,Int32>) | Rule violated: New Methods should be tested |
| High issue on: Microsoft.eShopWeb .ApplicationCore.Specifications .CustomerOrdersWithItemsSpecification. .ctor(String) | 3min 46s | 20min | 68d | .ctor(String) | Rule violated: Methods refactored should be tested |
| High issue on: Microsoft.eShopWeb.Web .Pages.Basket.CheckoutModel .SetBasketModelAsync() | 4min 40s | 20min | 85d | SetBasketModelAsync() | Rule violated: New Methods should be tested |
| High issue on: Microsoft.eShopWeb.Web .Interfaces.IBasketViewModelService | 15min | 1h 1min | 89d | IBasketViewModelService | Rule violated: Avoid namespaces mutually dependent |
| High issue on: Microsoft.eShopWeb .ApplicationCore.Entities.OrderAggregate .Order | 15min | 1h 1min | 89d | Order | Rule violated: Avoid namespaces mutually dependent |
| Medium issue on: Microsoft.eShopWeb.Web .Pages.PrivacyModel.OnGet() | 0min 30s | 2min 0s | 91d | OnGet() | Rule violated: Methods should be declared static if possible |
| Medium issue on: Microsoft.eShopWeb.Web .Pages.Basket.CheckoutModel.OnGet() | 0min 30s | 2min 0s | 91d | OnGet() | Rule violated: Methods should be declared static if possible |
| Medium issue on: Microsoft.eShopWeb.Web .Constants.BASKET_COOKIENAME | 0min 30s | 2min 0s | 91d | BASKET_COOKIENAME | Rule violated: Avoid publicly visible constant fields |
| Medium issue on: Microsoft.eShopWeb.Web .Constants.ITEMS_PER_PAGE | 0min 30s | 2min 0s | 91d | ITEMS_PER_PAGE | Rule violated: Avoid publicly visible constant fields |
| Medium issue on: Microsoft.eShopWeb.Web .Constants.DEFAULT_USERNAME | 0min 30s | 2min 0s | 91d | DEFAULT_USERNAME | Rule violated: Avoid publicly visible constant fields |
| High issue on: Microsoft.eShopWeb.Web .Pages.Basket.CheckoutModel.OnPost (Dictionary<String,Int32>) | 5min | 20min | 101d | OnPost(Dictionary<String,Int32>) | Rule violated: New Methods should be tested |
| High issue on: Microsoft.eShopWeb.Web .Controllers.ManageController.MyAccount( ) | 5min | 20min | 101d | MyAccount() | Rule violated: New Methods should be tested |
| High issue on: Microsoft.eShopWeb.Web .Controllers.OrderController.MyOrders() | 5min | 20min | 101d | MyOrders() | Rule violated: New Methods should be tested |
| Medium issue on: Microsoft.eShopWeb .ApplicationCore.Specifications .BaseSpecification<T>.set_OrderBy (Expression<Func<T,Object>>) | 2min 45s | 9min | 107d | set_OrderBy(Expression<Func<T,Object>>) | Rule violated: Code should be tested |
| Medium issue on: Microsoft.eShopWeb .ApplicationCore.Specifications .BaseSpecification<T> .set_OrderByDescending(Expression<Func<T ,Object>>) | 2min 45s | 9min | 107d | set_OrderByDescending(Expression<Func<T,Object>>) | Rule violated: Code should be tested |
| High issue on: Microsoft.eShopWeb .ApplicationCore.Specifications .CatalogFilterPaginatedSpecification. .ctor(Int32,Int32,Nullable<Int32> ,Nullable<Int32>) | 6min | 20min | 109d | .ctor(Int32,Int32,Nullable<Int32>,Nullable<Int32>) | Rule violated: Constructor should not call a virtual method |
| High issue on: Microsoft.eShopWeb .Infrastructure.Data.Migrations .AddExtraConstraints.Up(MigrationBuilder ) | 6min | 20min | 117d | Up(MigrationBuilder) | Rule violated: New Methods should be tested |
| High issue on: Microsoft.eShopWeb .Infrastructure.Data.Migrations .AddExtraConstraints.Down (MigrationBuilder) | 6min | 20min | 117d | Down(MigrationBuilder) | Rule violated: New Methods should be tested |
| High issue on: Ardalis.GuardClauses | 7min | 20min | 127d | Ardalis.GuardClauses | Rule violated: Types with source files stored in the same directory, should be declared in the same namespace |
| High issue on: Microsoft.AspNetCore.Mvc | 7min | 20min | 127d | Microsoft.AspNetCore.Mvc | Rule violated: Types with source files stored in the same directory, should be declared in the same namespace |
| High issue on: Microsoft.eShopWeb.Web.Services | 7min | 20min | 127d | Microsoft.eShopWeb.Web.Services | Rule violated: Types declared in the same namespace, should have their source files stored in the same directory |
| Medium issue on: Microsoft.eShopWeb.Web .Views.Manage.ManageNavPages .get_ActivePageKey() | 2min 17s | 6min | 128d | get_ActivePageKey() | Rule violated: Code should be tested |
| Medium issue on: Microsoft.eShopWeb.Web .Views.Manage.ManageNavPages.get_Index() | 2min 17s | 6min | 128d | get_Index() | Rule violated: Code should be tested |
| Medium issue on: Microsoft.eShopWeb.Web .Views.Manage.ManageNavPages .get_ChangePassword() | 2min 17s | 6min | 128d | get_ChangePassword() | Rule violated: Code should be tested |
| Medium issue on: Microsoft.eShopWeb.Web .Views.Manage.ManageNavPages .get_ExternalLogins() | 2min 17s | 6min | 128d | get_ExternalLogins() | Rule violated: Code should be tested |
| Medium issue on: Microsoft.eShopWeb.Web .Views.Manage.ManageNavPages .get_TwoFactorAuthentication() | 2min 17s | 6min | 128d | get_TwoFactorAuthentication() | Rule violated: Code should be tested |
| Medium issue on: Microsoft.eShopWeb.Web .Pages.ErrorModel.get_RequestId() | 2min 17s | 6min | 128d | get_RequestId() | Rule violated: Code should be tested |
| High issue on: Microsoft.eShopWeb.Web .Controllers.AccountController .ConfirmEmail(String,String) | 7min | 20min | 133d | ConfirmEmail(String,String) | Rule violated: Methods refactored should be tested |
| Medium issue on: Microsoft.eShopWeb.Web .Views.Manage.ManageNavPages .PageNavClass(ViewContext,String) | 6min | 18min | 135d | PageNavClass(ViewContext,String) | Rule violated: Code should be tested |
| High issue on: Microsoft.eShopWeb.Web .HealthChecks.HomePageHealthCheck .CheckHealthAsync(HealthCheckContext ,CancellationToken) | 8min | 20min | 150d | CheckHealthAsync(HealthCheckContext,CancellationToken) | Rule violated: New Methods should be tested |
| High issue on: Microsoft.eShopWeb.Web .Pages.Basket.CheckoutModel..ctor (IBasketService,IBasketViewModelService ,IUriComposer,SignInManager <ApplicationUser>,IOrderService) | 8min | 20min | 150d | .ctor(IBasketService,IBasketViewModelService,IUriComposer,SignInManager<ApplicationUser>,IOrderService) | Rule violated: New Methods should be tested |
| High issue on: Microsoft.eShopWeb.Web .Pages.Basket.CheckoutModel .GetOrSetBasketCookieAndUserName() | 8min | 20min | 150d | GetOrSetBasketCookieAndUserName() | Rule violated: New Methods should be tested |
| High issue on: Microsoft.eShopWeb.Web .HealthChecks.ApiHealthCheck .CheckHealthAsync(HealthCheckContext ,CancellationToken) | 9min | 20min | 166d | CheckHealthAsync(HealthCheckContext,CancellationToken) | Rule violated: New Methods should be tested |
| High issue on: Microsoft.eShopWeb .ApplicationCore.Specifications .BasketWithItemsSpecification | 10min | 20min | 182d | BasketWithItemsSpecification | Rule violated: Avoid transforming an immutable type into a mutable one |
| High issue on: Microsoft.eShopWeb .ApplicationCore.Specifications .CatalogFilterSpecification | 10min | 20min | 182d | CatalogFilterSpecification | Rule violated: Avoid transforming an immutable type into a mutable one |
| High issue on: Microsoft.eShopWeb .ApplicationCore.Specifications .CustomerOrdersWithItemsSpecification | 10min | 20min | 182d | CustomerOrdersWithItemsSpecification | Rule violated: Avoid transforming an immutable type into a mutable one |
| Medium issue on: Microsoft.eShopWeb .Infrastructure.Data.CatalogContext .ConfigurateCatalogItemOrdered (EntityTypeBuilder<CatalogItemOrdered>) | 1min 0s | 2min 0s | 182d | ConfigurateCatalogItemOrdered(EntityTypeBuilder<CatalogItemOrdered>) | Rule violated: Methods should be declared static if possible |
| Medium issue on: Microsoft.eShopWeb .Infrastructure.Data.CatalogContext .ConfigureAddress(EntityTypeBuilder <Address>) | 1min 0s | 2min 0s | 182d | ConfigureAddress(EntityTypeBuilder<Address>) | Rule violated: Methods should be declared static if possible |
| Medium issue on: Microsoft.eShopWeb .Infrastructure.Data.CatalogContext .ConfigureBasket(EntityTypeBuilder <Basket>) | 1min 0s | 2min 0s | 182d | ConfigureBasket(EntityTypeBuilder<Basket>) | Rule violated: Methods should be declared static if possible |
| Medium issue on: Microsoft.eShopWeb .Infrastructure.Data.CatalogContext .ConfigureCatalogItem(EntityTypeBuilder <CatalogItem>) | 1min 0s | 2min 0s | 182d | ConfigureCatalogItem(EntityTypeBuilder<CatalogItem>) | Rule violated: Methods should be declared static if possible |
| Medium issue on: Microsoft.eShopWeb .Infrastructure.Data.CatalogContext .ConfigureCatalogBrand(EntityTypeBuilder <CatalogBrand>) | 1min 0s | 2min 0s | 182d | ConfigureCatalogBrand(EntityTypeBuilder<CatalogBrand>) | Rule violated: Methods should be declared static if possible |
| Medium issue on: Microsoft.eShopWeb .Infrastructure.Data.CatalogContext .ConfigureCatalogType(EntityTypeBuilder <CatalogType>) | 1min 0s | 2min 0s | 182d | ConfigureCatalogType(EntityTypeBuilder<CatalogType>) | Rule violated: Methods should be declared static if possible |
| Medium issue on: Microsoft.eShopWeb .Infrastructure.Data.CatalogContext .ConfigureOrder(EntityTypeBuilder<Order> ) | 1min 0s | 2min 0s | 182d | ConfigureOrder(EntityTypeBuilder<Order>) | Rule violated: Methods should be declared static if possible |
| Medium issue on: Microsoft.eShopWeb .Infrastructure.Data.CatalogContext .ConfigureOrderItem(EntityTypeBuilder <OrderItem>) | 1min 0s | 2min 0s | 182d | ConfigureOrderItem(EntityTypeBuilder<OrderItem>) | Rule violated: Methods should be declared static if possible |
| High issue on: Microsoft.eShopWeb .ApplicationCore.Services.BasketService. .ctor(IAsyncRepository<Basket> ,IRepository<CatalogItem>,IUriComposer ,IAppLogger<BasketService>) | 10min | 20min | 182d | BasketService | Rule violated: API Breaking Changes: Methods |
| High issue on: Microsoft.eShopWeb .ApplicationCore.Interfaces .IOrderRepository.GetByIdWithItems(Int32 ) | 10min | 20min | 182d | IOrderRepository | Rule violated: API Breaking Changes: Methods |
| High issue on: Microsoft.eShopWeb .Infrastructure.Data.EfRepository<T> .GetById(Int32) | 10min | 20min | 182d | EfRepository<T> | Rule violated: API Breaking Changes: Methods |
| High issue on: Microsoft.eShopWeb .Infrastructure.Data.EfRepository<T> .GetSingleBySpec(ISpecification<T>) | 10min | 20min | 182d | EfRepository<T> | Rule violated: API Breaking Changes: Methods |
| High issue on: Microsoft.eShopWeb .Infrastructure.Data.EfRepository<T> .ListAll() | 10min | 20min | 182d | EfRepository<T> | Rule violated: API Breaking Changes: Methods |
| High issue on: Microsoft.eShopWeb .Infrastructure.Data.EfRepository<T> .List(ISpecification<T>) | 10min | 20min | 182d | EfRepository<T> | Rule violated: API Breaking Changes: Methods |
| High issue on: Microsoft.eShopWeb .Infrastructure.Data.EfRepository<T>.Add (T) | 10min | 20min | 182d | EfRepository<T> | Rule violated: API Breaking Changes: Methods |
| High issue on: Microsoft.eShopWeb .Infrastructure.Data.EfRepository<T> .Update(T) | 10min | 20min | 182d | EfRepository<T> | Rule violated: API Breaking Changes: Methods |
| High issue on: Microsoft.eShopWeb .Infrastructure.Data.EfRepository<T> .Delete(T) | 10min | 20min | 182d | EfRepository<T> | Rule violated: API Breaking Changes: Methods |
Statistics
| Stat | Debt | Annual Interest | Breaking Point | CodeElement |
|---|---|---|---|---|
| Sum: | 11d 4h | 8d 6h | 352 543d | - |
| Average: | 11min | 8min | 746d | - |
| Minimum: | 0min 30s | 0min 0s | 00:00:00 | - |
| Maximum: | 3h 46min | 1h 1min | 7 775d | - |
| Standard deviation: | 27min | 13min | 1 365d | - |
| Variance: | 95d | 21d | overflow | - |
| Code Query: Debt and Issues per Rule |
• Query Description:
This query lists violated rules with most Debt first.
A rule violated has issues. For each issue the Debt estimates the effort to fix the issue.
--
The amount of Debt is not a measure to prioritize the effort to fix issues, it is an estimation of how far the team is from clean code that abides by the rules set.
For each issue the Annual Interest estimates the annual cost to leave the issues unfixed. The Severity of an issue is estimated through thresholds from the Annual Interest.
The Debt Breaking Point represents the duration from now when the estimated cost to leave the issue unfixed costs as much as the estimated effort to fix it.
Hence the shorter the Debt Breaking Point the largest the Return on Investment for fixing the issue. The Breaking Point is the right metric to prioritize issues fix.
--
Notice that rules can be grouped in Rule Category. This way you'll see categories that generate most Debt.
Typically the rules that generate most Debt are the ones related to Code Coverage by Tests, Architecture and Code Smells.
More documentation: https://www.ndepend.com/docs/technical-debt
38 rules matched
| 38 rules | Issues | Debt | Annual Interest | Breaking Point | Category | Full Name |
|---|---|---|---|---|---|---|
| Code should be tested | 238 issues | 7d 0h | 1d 3h | 1 808d | Project Rules \ Code Coverage | Rule |
| Do not raise too general exception types | 21 issues | 7h 0min | 7h 0min | 365d | Project Rules \ .NET Framework Usage \ System | Rule |
| Avoid namespaces dependency cycles | 2 issues | 4h 0min | 40min | 2 190d | Project Rules \ Architecture | Rule |
| API Breaking Changes: Types | 9 issues | 3h 0min | 3h 0min | 365d | Project Rules \ API Breaking Changes | Rule |
| New Methods should be tested | 40 issues | 2h 40min | 1d 5h | 73d | Project Rules \ Code Coverage | Rule |
| From now, all types added should be 100% covered by tests | 15 issues | 2h 30min | 1d 7h | 60d | Project Rules \ Code Smells Regression | Rule |
| API Breaking Changes: Methods | 15 issues | 2h 30min | 5h 0min | 182d | Project Rules \ API Breaking Changes | Rule |
| Avoid transforming an immutable type into a mutable one | 4 issues | 1h 30min | 1h 20min | 410d | Project Rules \ Code Smells Regression | Rule |
| Assemblies Namespaces and Types should be tested | 21 issues | 1h 24min | 0min 0s | 00:00:00 | Project Rules \ Code Coverage | Rule |
| Types 100% covered should be tagged with FullCoveredAttribute | 27 issues | 1h 21min | 0min 0s | 00:00:00 | Project Rules \ Code Coverage | Rule |
| Methods should have a low C.R.A.P score | 4 issues | 1h 6min | 1h 20min | 302d | Project Rules \ Code Coverage | Rule |
| Avoid types with too many methods | 1 issue | 1h 6min | 3min 18s | 7 275d | Project Rules \ Code Smells | Rule |
| Avoid namespaces with few types | 13 issues | 1h 5min | 0min 0s | 00:00:00 | Project Rules \ Design | Rule |
| Potentially Dead Methods | 4 issues | 40min | 38min | 384d | Project Rules \ Dead Code | Rule |
| Avoid prefixing type name with parent namespace name | 4 issues | 40min | 8min | 1 825d | Project Rules \ Naming Conventions | Rule |
| Avoid namespaces mutually dependent | 2 issues | 30min | 2h 2min | 89d | Project Rules \ Architecture | Rule |
| API Breaking Changes: Interfaces and Abstract Classes | 3 issues | 30min | 1h 0min | 182d | Project Rules \ API Breaking Changes | Rule |
| Collection properties should be read only | 3 issues | 30min | 6min | 1 825d | Project Rules \ .NET Framework Usage \ System.Collections | Rule |
| Methods refactored should be tested | 4 issues | 24min | 1h 20min | 109d | Project Rules \ Code Coverage | Rule |
| Avoid naming types and namespaces with the same identifier | 2 issues | 24min | 40min | 219d | Project Rules \ Naming Conventions | Rule |
| Avoid empty interfaces | 1 issue | 19min | 2min 0s | 3 467d | Project Rules \ Object Oriented Design | Rule |
| Constructor should not call a virtual method | 2 issues | 18min | 40min | 164d | Project Rules \ Object Oriented Design | Rule |
| Types with source files stored in the same directory, should be declared in the same namespace | 2 issues | 14min | 40min | 127d | Project Rules \ Source Files Organization | Rule |
| Static fields naming convention | 4 issues | 12min | 8min | 547d | Project Rules \ Naming Conventions | Rule |
| Namespace name should correspond to file location | 4 issues | 12min | 8min | 547d | Project Rules \ Source Files Organization | Rule |
| From now, all methods added should respect basic quality principles | 2 issues | 10min | 2h 0min | 30d | Project Rules \ Code Smells Regression | Rule |
| Assemblies with poor cohesion (RelationalCohesion) | 1 issue | 10min | 0min 0s | 00:00:00 | Project Rules \ Architecture | Rule |
| API Breaking Changes: Fields | 1 issue | 10min | 20min | 182d | Project Rules \ API Breaking Changes | Rule |
| Avoid having different types with same name | 1 issue | 10min | 20min | 182d | Project Rules \ Naming Conventions | Rule |
| Methods should be declared static if possible | 10 issues | 9min | 20min | 164d | Project Rules \ Object Oriented Design | Rule |
| Types declared in the same namespace, should have their source files stored in the same directory | 1 issue | 7min | 20min | 127d | Project Rules \ Source Files Organization | Rule |
| Fields should be marked as ReadOnly when possible | 1 issue | 5min | 2min 0s | 912d | Project Rules \ Immutability | Rule |
| Types almost 100% tested should be 100% tested | 2 issues | 4min 56s | 40min | 45d | Project Rules \ Code Coverage | Rule |
| Non-static classes should be instantiated or turned to static | 2 issues | 4min 0s | 4min 0s | 365d | Project Rules \ Object Oriented Design | Rule |
| Do not declare read only mutable reference types | 1 issue | 3min 0s | 0min 0s | 00:00:00 | Project Rules \ Immutability | Rule |
| Nested types should not be visible | 1 issue | 2min 0s | 2min 0s | 365d | Project Rules \ Design | Rule |
| Namespaces almost 100% tested should be 100% tested | 1 issue | 2min 0s | 20min | 36d | Project Rules \ Code Coverage | Rule |
| Avoid publicly visible constant fields | 3 issues | 1min 30s | 6min | 91d | Project Rules \ Visibility | Rule |
Statistics
| Stat | Issues | Debt | Annual Interest | Breaking Point | Category |
|---|---|---|---|---|---|
| Sum: | 472 | 11d 4h | 8d 6h | 25 025d | - |
| Average: | 12.42 | 2h 25min | 1h 51min | 658d | - |
| Minimum: | 1 | 1min 30s | 0min 0s | 00:00:00 | - |
| Maximum: | 238 | 7d 0h | 1d 7h | 7 275d | - |
| Standard deviation: | 38.04 | 1d 1h | 3h 38min | 1 316d | - |
| Variance: | 1 447 | 36 891d | 5 982d | overflow | - |
| Code Query: New Debt and Issues per Rule |
• Query Description:
This query lists violated rules that have new issues since baseline, with most new Debt first.
A rule violated has issues. For each issue the Debt estimates the effort to fix the issue.
--
New issues since the baseline are consequence of recent code refactoring sessions. They represent good opportunities of fix because the code recently refactored is fresh in the developers mind, which means fixing now costs less than fixing later.
Fixing issues on recently touched code is also a good way to foster practices that will lead to higher code quality and maintainability, including writing unit-tests and avoiding unnecessary complex code.
--
Notice that rules can be grouped in Rule Category. This way you'll see categories that generate most Debt.
Typically the rules that generate most Debt are the ones related to Code Coverage by Tests, Architecture and Code Smells.
More documentation: https://www.ndepend.com/docs/technical-debt
28 rules matched
| 28 rules | IssuesAdded | IssuesFixed | Issues | Debt | DebtDiff | Category | Full Name |
|---|---|---|---|---|---|---|---|
| Do not raise too general exception types | 21 issues | no issue | 21 issues | 7h 0min | 7h 0min | Project Rules \ .NET Framework Usage \ System | Rule |
| API Breaking Changes: Types | 9 issues | no issue | 9 issues | 3h 0min | 3h 0min | Project Rules \ API Breaking Changes | Rule |
| New Methods should be tested | 40 issues | no issue | 40 issues | 2h 40min | 2h 40min | Project Rules \ Code Coverage | Rule |
| From now, all types added should be 100% covered by tests | 15 issues | no issue | 15 issues | 2h 30min | 2h 30min | Project Rules \ Code Smells Regression | Rule |
| API Breaking Changes: Methods | 15 issues | no issue | 15 issues | 2h 30min | 2h 30min | Project Rules \ API Breaking Changes | Rule |
| Avoid namespaces dependency cycles | 1 issue | no issue | 2 issues | 4h 0min | 2h 0min | Project Rules \ Architecture | Rule |
| Avoid transforming an immutable type into a mutable one | 4 issues | no issue | 4 issues | 1h 30min | 1h 30min | Project Rules \ Code Smells Regression | Rule |
| Types 100% covered should be tagged with FullCoveredAttribute | 14 issues | 1 issue | 27 issues | 1h 21min | 39min | Project Rules \ Code Coverage | Rule |
| API Breaking Changes: Interfaces and Abstract Classes | 3 issues | no issue | 3 issues | 30min | 30min | Project Rules \ API Breaking Changes | Rule |
| Methods refactored should be tested | 4 issues | no issue | 4 issues | 24min | 24min | Project Rules \ Code Coverage | Rule |
| Avoid prefixing type name with parent namespace name | 3 issues | 1 issue | 4 issues | 40min | 20min | Project Rules \ Naming Conventions | Rule |
| Avoid namespaces mutually dependent | 1 issue | no issue | 2 issues | 30min | 15min | Project Rules \ Architecture | Rule |
| From now, all methods added should respect basic quality principles | 2 issues | no issue | 2 issues | 10min | 10min | Project Rules \ Code Smells Regression | Rule |
| Avoid namespaces with few types | 5 issues | 3 issues | 13 issues | 1h 5min | 10min | Project Rules \ Design | Rule |
| API Breaking Changes: Fields | 1 issue | no issue | 1 issue | 10min | 10min | Project Rules \ API Breaking Changes | Rule |
| Collection properties should be read only | 1 issue | no issue | 3 issues | 30min | 10min | Project Rules \ .NET Framework Usage \ System.Collections | Rule |
| Constructor should not call a virtual method | 1 issue | no issue | 2 issues | 18min | 6min | Project Rules \ Object Oriented Design | Rule |
| Non-static classes should be instantiated or turned to static | 1 issue | no issue | 2 issues | 4min 0s | 2min 0s | Project Rules \ Object Oriented Design | Rule |
| Types almost 100% tested should be 100% tested | 1 issue | no issue | 2 issues | 4min 56s | 2min 0s | Project Rules \ Code Coverage | Rule |
| Namespaces almost 100% tested should be 100% tested | 1 issue | no issue | 1 issue | 2min 0s | 2min 0s | Project Rules \ Code Coverage | Rule |
| Methods should be declared static if possible | 4 issues | 2 issues | 10 issues | 9min | 1min 30s | Project Rules \ Object Oriented Design | Rule |
| Assemblies Namespaces and Types should be tested | 7 issues | 7 issues | 21 issues | 1h 24min | 0min 0s | Project Rules \ Code Coverage | Rule |
| Avoid publicly visible constant fields | 2 issues | 3 issues | 3 issues | 1min 30s | -(0min 30s) | Project Rules \ Visibility | Rule |
| Static fields naming convention | 4 issues | 8 issues | 4 issues | 12min | -(12min) | Project Rules \ Naming Conventions | Rule |
| Nested types should not be visible | 1 issue | 12 issues | 1 issue | 2min 0s | -(22min) | Project Rules \ Design | Rule |
| Methods should have a low C.R.A.P score | 1 issue | 3 issues | 4 issues | 1h 6min | -(22min) | Project Rules \ Code Coverage | Rule |
| Avoid naming types and namespaces with the same identifier | 1 issue | 3 issues | 2 issues | 24min | -(24min) | Project Rules \ Naming Conventions | Rule |
| Code should be tested | 50 issues | 350 issues | 238 issues | 7d 0h | -(3d 7h) | Project Rules \ Code Coverage | Rule |
Statistics
| Stat | IssuesAdded | IssuesFixed | Issues | Debt | DebtDiff | Category |
|---|---|---|---|---|---|---|
| Sum: | 213 | 393 | 455 | 11d 1h | -(1d 0h) | - |
| Average: | 7.61 | 14.04 | 16.25 | 3h 11min | -(17min) | - |
| Minimum: | 1 | 0 | 1 | 1min 30s | -(3d 7h) | - |
| Maximum: | 50 | 350 | 238 | 7d 0h | 7h 0min | - |
| Standard deviation: | 11.68 | 64.72 | 43.67 | 1d 2h | 6h 7min | - |
| Variance: | 136.52 | 4 189 | 1 907 | 49 072d | 16 912d | - |
| Code Query: Debt and Issues per Code Element |
• Query Description:
This query lists code elements that have issues, with most Debt first.
For each code element the Debt estimates the effort to fix the element issues.
The amount of Debt is not a measure to prioritize the effort to fix issues, it is an estimation of how far the team is from clean code that abides by the rules set.
For each element the Annual Interest estimates the annual cost to leave the elements issues unfixed. The Severity of an issue is estimated through thresholds from the Annual Interest of the issue.
The Debt Breaking Point represents the duration from now when the estimated cost to leave the issues unfixed costs as much as the estimated effort to fix it.
Hence the shorter the Debt Breaking Point the largest the Return on Investment for fixing the issue. The Breaking Point is the right metric to prioritize issues fix.
352 code elements matched
| 352 code elements | Issues | Debt | Annual Interest | Breaking Point | Full Name |
|---|---|---|---|---|---|
| Up(MigrationBuilder) | 2 issues | 4h 8min | 30min | 2 959d | Microsoft.eShopWeb.Infrastructure .Identity.Migrations .InitialIdentityModel.Up (MigrationBuilder) |
| Up(MigrationBuilder) | 2 issues | 4h 1min | 30min | 2 909d | Microsoft.eShopWeb.Infrastructure.Data .Migrations.Initial.Up(MigrationBuilder) |
| BuildTargetModel(ModelBuilder) | 2 issues | 3h 32min | 29min | 2 626d | Microsoft.eShopWeb.Infrastructure.Data .Migrations.AddExtraConstraints .BuildTargetModel(ModelBuilder) |
| BuildModel(ModelBuilder) | 2 issues | 3h 32min | 29min | 2 626d | Microsoft.eShopWeb.Infrastructure.Data .Migrations.CatalogContextModelSnapshot .BuildModel(ModelBuilder) |
| BuildTargetModel(ModelBuilder) | 1 issue | 3h 22min | 9min | 7 775d | Microsoft.eShopWeb.Infrastructure .Identity.Migrations .InitialIdentityModel.BuildTargetModel (ModelBuilder) |
| BuildModel(ModelBuilder) | 1 issue | 3h 22min | 9min | 7 775d | Microsoft.eShopWeb.Infrastructure .Identity.Migrations .AppIdentityDbContextModelSnapshot .BuildModel(ModelBuilder) |
| BuildTargetModel(ModelBuilder) | 1 issue | 3h 22min | 9min | 7 775d | Microsoft.eShopWeb.Infrastructure.Data .Migrations.Initial.BuildTargetModel (ModelBuilder) |
| Microsoft.eShopWeb.ApplicationCore .Interfaces | 2 issues | 2h 20min | 40min | 1 277d | Microsoft.eShopWeb.ApplicationCore .Interfaces |
| Index(IndexViewModel) | 3 issues | 2h 0min | 45min | 966d | Microsoft.eShopWeb.Web.Controllers .ManageController.Index(IndexViewModel) |
| Microsoft.eShopWeb.Web.Interfaces | 1 issue | 2h 0min | 20min | 2 190d | Microsoft.eShopWeb.Web.Interfaces |
| OnPostAsync(String) | 3 issues | 1h 46min | 44min | 872d | Microsoft.eShopWeb.Web.Areas.Identity .Pages.Account.LoginModel.OnPostAsync (String) |
| LoginWith2fa(LoginWith2faViewModel ,Boolean,String) | 2 issues | 1h 45min | 25min | 1 522d | Microsoft.eShopWeb.Web.Controllers .AccountController.LoginWith2fa (LoginWith2faViewModel,Boolean,String) |
| EnableAuthenticator (EnableAuthenticatorViewModel) | 2 issues | 1h 20min | 24min | 1 206d | Microsoft.eShopWeb.Web.Controllers .ManageController.EnableAuthenticator (EnableAuthenticatorViewModel) |
| ManageController | 3 issues | 1h 20min | 23min | 1 252d | Microsoft.eShopWeb.Web.Controllers .ManageController |
| LinkLoginCallback() | 2 issues | 1h 16min | 24min | 1 156d | Microsoft.eShopWeb.Web.Controllers .ManageController.LinkLoginCallback() |
| EfRepository<T> | 8 issues | 1h 13min | 2h 20min | 190d | Microsoft.eShopWeb.Infrastructure.Data .EfRepository<T> |
| Microsoft.eShopWeb.Web.Services | 4 issues | 1h 7min | 1h 20min | 305d | Microsoft.eShopWeb.Web.Services |
| ChangePassword(ChangePasswordViewModel) | 2 issues | 1h 6min | 24min | 996d | Microsoft.eShopWeb.Web.Controllers .ManageController.ChangePassword (ChangePasswordViewModel) |
| SetPassword(SetPasswordViewModel) | 2 issues | 1h 3min | 24min | 959d | Microsoft.eShopWeb.Web.Controllers .ManageController.SetPassword (SetPasswordViewModel) |
| ExternalLogins() | 2 issues | 1h 2min | 23min | 974d | Microsoft.eShopWeb.Web.Controllers .ManageController.ExternalLogins() |
| BaseSpecification<T> | 1 issue | 1h 0min | 20min | 1 095d | Microsoft.eShopWeb.ApplicationCore .Specifications.BaseSpecification<T> |
| ConfirmEmail(String,String) | 3 issues | 58min | 42min | 500d | Microsoft.eShopWeb.Web.Controllers .AccountController.ConfirmEmail(String ,String) |
| SendVerificationEmail(IndexViewModel) | 2 issues | 53min | 23min | 820d | Microsoft.eShopWeb.Web.Controllers .ManageController.SendVerificationEmail (IndexViewModel) |
| ListAllRegisteredServices (IApplicationBuilder,LinkGenerator) | 2 issues | 48min | 24min | 709d | Microsoft.eShopWeb.Web.Startup .ListAllRegisteredServices (IApplicationBuilder,LinkGenerator) |
| RemoveLogin(RemoveLoginViewModel) | 2 issues | 47min | 23min | 754d | Microsoft.eShopWeb.Web.Controllers .ManageController.RemoveLogin (RemoveLoginViewModel) |
| EnableAuthenticator() | 2 issues | 47min | 23min | 754d | Microsoft.eShopWeb.Web.Controllers .ManageController.EnableAuthenticator() |
| GenerateRecoveryCodes() | 2 issues | 47min | 23min | 754d | Microsoft.eShopWeb.Web.Controllers .ManageController.GenerateRecoveryCodes( ) |
| ChangePassword() | 2 issues | 45min | 22min | 720d | Microsoft.eShopWeb.Web.Controllers .ManageController.ChangePassword() |
| SetPassword() | 2 issues | 45min | 22min | 720d | Microsoft.eShopWeb.Web.Controllers .ManageController.SetPassword() |
| Disable2fa() | 2 issues | 45min | 22min | 720d | Microsoft.eShopWeb.Web.Controllers .ManageController.Disable2fa() |
| Microsoft.eShopWeb.Web.ViewModels | 2 issues | 40min | 40min | 365d | Microsoft.eShopWeb.Web.ViewModels |
| Microsoft.eShopWeb.Web.Controllers | 2 issues | 40min | 40min | 365d | Microsoft.eShopWeb.Web.Controllers |
| Disable2faWarning() | 2 issues | 39min | 22min | 649d | Microsoft.eShopWeb.Web.Controllers .ManageController.Disable2faWarning() |
| MyAccount() | 3 issues | 38min | 42min | 338d | Microsoft.eShopWeb.Web.Controllers .ManageController.MyAccount() |
| Detail(Int32) | 1 issue | 38min | 2min 48s | 5 054d | Microsoft.eShopWeb.Web.Controllers .OrderController.Detail(Int32) |
| GetOrSetBasketCookieAndUserName() | 2 issues | 38min | 26min | 526d | Microsoft.eShopWeb.Web.Pages.Basket .CheckoutModel .GetOrSetBasketCookieAndUserName() |
| ResetAuthenticator() | 2 issues | 37min | 22min | 614d | Microsoft.eShopWeb.Web.Controllers .ManageController.ResetAuthenticator() |
| SignIn(LoginViewModel,String) | 1 issue | 37min | 2min 20s | 5 881d | Microsoft.eShopWeb.Web.Controllers .AccountController.SignIn(LoginViewModel ,String) |
| Main(String[]) | 1 issue | 36min | 4min 3s | 3 251d | Microsoft.eShopWeb.Web.Program.Main (String[]) |
| LoginWith2fa(Boolean,String) | 2 issues | 35min | 22min | 586d | Microsoft.eShopWeb.Web.Controllers .AccountController.LoginWith2fa(Boolean ,String) |
| TwoFactorAuthentication() | 2 issues | 33min | 22min | 554d | Microsoft.eShopWeb.Web.Controllers .ManageController .TwoFactorAuthentication() |
| SeedAsync(CatalogContext,ILoggerFactory ,Nullable<Int32>) | 1 issue | 32min | 6min | 1 824d | Microsoft.eShopWeb.Infrastructure.Data .CatalogContextSeed.SeedAsync (CatalogContext,ILoggerFactory,Nullable <Int32>) |
| CheckHealthAsync(HealthCheckContext ,CancellationToken) | 2 issues | 31min | 23min | 497d | Microsoft.eShopWeb.Web.HealthChecks .ApiHealthCheck.CheckHealthAsync (HealthCheckContext,CancellationToken) |
| CreateOrderAsync(Int32,Address) | 1 issue | 31min | 4min 22s | 2 615d | Microsoft.eShopWeb.ApplicationCore .Services.OrderService.CreateOrderAsync (Int32,Address) |
| ResetPassword(String) | 2 issues | 31min | 22min | 517d | Microsoft.eShopWeb.Web.Controllers .AccountController.ResetPassword(String) |
| GetBasketItemCountAsync(String) | 1 issue | 30min | 3min 26s | 3 251d | Microsoft.eShopWeb.ApplicationCore .Services.BasketService .GetBasketItemCountAsync(String) |
| SetQuantities(Int32,Dictionary<String ,Int32>) | 1 issue | 30min | 3min 24s | 3 251d | Microsoft.eShopWeb.ApplicationCore .Services.BasketService.SetQuantities (Int32,Dictionary<String,Int32>) |
| FormatKey(String) | 1 issue | 30min | 5min | 1 869d | Microsoft.eShopWeb.Web.Controllers .ManageController.FormatKey(String) |
| Web | 2 issues | 30min | 20min | 547d | Web |
| CheckHealthAsync(HealthCheckContext ,CancellationToken) | 2 issues | 28min | 22min | 453d | Microsoft.eShopWeb.Web.HealthChecks .HomePageHealthCheck.CheckHealthAsync (HealthCheckContext,CancellationToken) |
| MyOrders() | 2 issues | 27min | 22min | 452d | Microsoft.eShopWeb.Web.Controllers .OrderController.MyOrders() |
| GetQuery(IQueryable<T>,ISpecification<T> ) | 1 issue | 26min | 16min | 578d | Microsoft.eShopWeb.Infrastructure.Data .SpecificationEvaluator<T>.GetQuery (IQueryable<T>,ISpecification<T>) |
| AddErrors(IdentityResult) | 1 issue | 26min | 5min | 1 858d | Microsoft.eShopWeb.Web.Controllers .ManageController.AddErrors (IdentityResult) |
| Register(RegisterViewModel,String) | 1 issue | 25min | 2min 48s | 3 251d | Microsoft.eShopWeb.Web.Controllers .AccountController.Register (RegisterViewModel,String) |
| Basket | 3 issues | 25min | 40min | 228d | Microsoft.eShopWeb.ApplicationCore .Entities.BasketAggregate.Basket |
| .ctor(String) | 3 issues | 22min | 42min | 192d | Microsoft.eShopWeb.ApplicationCore .Specifications .CustomerOrdersWithItemsSpecification. .ctor(String) |
| Basket | 2 issues | 22min | 1h 20min | 100d | Microsoft.eShopWeb.Web.Pages.Shared .Components.BasketComponent.Basket |
| SignIn(String) | 1 issue | 21min | 2min 0s | 3 960d | Microsoft.eShopWeb.Web.Controllers .AccountController.SignIn(String) |
| Up(MigrationBuilder) | 3 issues | 20min | 1h 22min | 90d | Microsoft.eShopWeb.Infrastructure.Data .Migrations.AddExtraConstraints.Up (MigrationBuilder) |
| Down(MigrationBuilder) | 3 issues | 20min | 1h 22min | 90d | Microsoft.eShopWeb.Infrastructure.Data .Migrations.AddExtraConstraints.Down (MigrationBuilder) |
| AddErrors(IdentityResult) | 1 issue | 20min | 3min 46s | 1 939d | Microsoft.eShopWeb.Web.Controllers .AccountController.AddErrors (IdentityResult) |
| IOrderRepository | 2 issues | 20min | 40min | 182d | Microsoft.eShopWeb.ApplicationCore .Interfaces.IOrderRepository |
| BasketItemViewModel | 2 issues | 20min | 1h 2min | 117d | Microsoft.eShopWeb.Web.Pages.Basket .BasketItemViewModel |
| BasketViewModel | 2 issues | 20min | 1h 2min | 117d | Microsoft.eShopWeb.Web.Pages.Basket .BasketViewModel |
| IAggregateRoot | 1 issue | 19min | 2min 0s | 3 467d | Microsoft.eShopWeb.ApplicationCore .Interfaces.IAggregateRoot |
| .ctor(IBasketService ,IBasketViewModelService,IUriComposer ,SignInManager<ApplicationUser> ,IOrderService) | 2 issues | 18min | 22min | 297d | Microsoft.eShopWeb.Web.Pages.Basket .CheckoutModel..ctor(IBasketService ,IBasketViewModelService,IUriComposer ,SignInManager<ApplicationUser> ,IOrderService) |
| SetBasketModelAsync() | 2 issues | 18min | 23min | 278d | Microsoft.eShopWeb.Web.Pages.Basket .CheckoutModel.SetBasketModelAsync() |
| Order | 2 issues | 17min | 1h 21min | 76d | Microsoft.eShopWeb.ApplicationCore .Entities.OrderAggregate.Order |
| Microsoft.AspNetCore.Mvc | 3 issues | 16min | 20min | 292d | Microsoft.AspNetCore.Mvc |
| LoginModel+InputModel | 3 issues | 16min | 1h 2min | 94d | Microsoft.eShopWeb.Web.Areas.Identity .Pages.Account.LoginModel+InputModel |
| OnPost(Dictionary<String,Int32>) | 2 issues | 15min | 22min | 260d | Microsoft.eShopWeb.Web.Pages.Basket .CheckoutModel.OnPost(Dictionary<String ,Int32>) |
| TransferBasketAsync(String,String) | 1 issue | 15min | 2min 6s | 2 615d | Microsoft.eShopWeb.ApplicationCore .Services.BasketService .TransferBasketAsync(String,String) |
| IBasketViewModelService | 1 issue | 15min | 1h 1min | 89d | Microsoft.eShopWeb.Web.Interfaces .IBasketViewModelService |
| CustomerOrdersWithItemsSpecification | 2 issues | 14min | 20min | 255d | Microsoft.eShopWeb.ApplicationCore .Specifications .CustomerOrdersWithItemsSpecification |
| ErrorModel | 2 issues | 14min | 1h 0min | 85d | Microsoft.eShopWeb.Web.Pages.ErrorModel |
| CheckoutModel | 2 issues | 14min | 1h 0min | 85d | Microsoft.eShopWeb.Web.Pages.Basket .CheckoutModel |
| OrderController | 2 issues | 14min | 20min | 255d | Microsoft.eShopWeb.Web.Controllers .OrderController |
| Down(MigrationBuilder) | 1 issue | 13min | 3min 26s | 1 477d | Microsoft.eShopWeb.Infrastructure.Data .Migrations.Initial.Down (MigrationBuilder) |
| BasketWithItemsSpecification | 2 issues | 13min | 20min | 237d | Microsoft.eShopWeb.ApplicationCore .Specifications .BasketWithItemsSpecification |
| CatalogFilterSpecification | 2 issues | 13min | 20min | 237d | Microsoft.eShopWeb.ApplicationCore .Specifications .CatalogFilterSpecification |
| OrderRepository | 2 issues | 13min | 20min | 237d | Microsoft.eShopWeb.Infrastructure.Data .OrderRepository |
| BasketViewModelService | 2 issues | 13min | 20min | 237d | Microsoft.eShopWeb.Web.Services .BasketViewModelService |
| CatalogController | 2 issues | 13min | 20min | 237d | Microsoft.eShopWeb.Web.Controllers.Api .CatalogController |
| IdentityHostingStartup | 2 issues | 13min | 2min 0s | 2 372d | Microsoft.eShopWeb.Web.Areas.Identity .IdentityHostingStartup |
| Configure(IApplicationBuilder ,IHostingEnvironment,LinkGenerator) | 1 issue | 12min | 2min 0s | 2 363d | Microsoft.eShopWeb.Web.Startup.Configure (IApplicationBuilder,IHostingEnvironment ,LinkGenerator) |
| GetBrands() | 2 issues | 12min | 22min | 211d | Microsoft.eShopWeb.Web.Services .CachedCatalogViewModelService.GetBrands () |
| GetTypes() | 2 issues | 12min | 22min | 211d | Microsoft.eShopWeb.Web.Services .CachedCatalogViewModelService.GetTypes( ) |
| set_CurrentLogins(IList<UserLoginInfo>) | 2 issues | 12min | 4min 0s | 1 122d | Microsoft.eShopWeb.Web.ViewModels.Manage .ExternalLoginsViewModel .set_CurrentLogins(IList<UserLoginInfo>) |
| set_OtherLogins(IList <AuthenticationScheme>) | 2 issues | 12min | 4min 0s | 1 122d | Microsoft.eShopWeb.Web.ViewModels.Manage .ExternalLoginsViewModel.set_OtherLogins (IList<AuthenticationScheme>) |
| Ardalis.GuardClauses | 2 issues | 12min | 20min | 219d | Ardalis.GuardClauses |
| SpecificationEvaluator<T> | 2 issues | 12min | 1h 2min | 70d | Microsoft.eShopWeb.Infrastructure.Data .SpecificationEvaluator<T> |
| LinkLogin(String) | 1 issue | 11min | 2min 0s | 2 008d | Microsoft.eShopWeb.Web.Controllers .ManageController.LinkLogin(String) |
| OnPostUpdate(Dictionary<String,Int32>) | 2 issues | 10min | 22min | 175d | Microsoft.eShopWeb.Web.Pages.Basket .IndexModel.OnPostUpdate(Dictionary <String,Int32>) |
| Down(MigrationBuilder) | 1 issue | 10min | 2min 29s | 1 477d | Microsoft.eShopWeb.Infrastructure .Identity.Migrations .InitialIdentityModel.Down (MigrationBuilder) |
| BasketService | 1 issue | 10min | 20min | 182d | Microsoft.eShopWeb.ApplicationCore .Services.BasketService |
| IAsyncRepository<T> | 1 issue | 10min | 20min | 182d | Microsoft.eShopWeb.ApplicationCore .Interfaces.IAsyncRepository<T> |
| ISpecification<T> | 1 issue | 10min | 20min | 182d | Microsoft.eShopWeb.ApplicationCore .Interfaces.ISpecification<T> |
| .ctor() | 1 issue | 10min | 9min | 405d | Microsoft.eShopWeb.ApplicationCore .Entities.OrderAggregate.Address..ctor() |
| .ctor() | 1 issue | 10min | 9min | 405d | Microsoft.eShopWeb.ApplicationCore .Entities.OrderAggregate .CatalogItemOrdered..ctor() |
| .ctor() | 1 issue | 10min | 11min | 331d | Microsoft.eShopWeb.ApplicationCore .Entities.OrderAggregate.Order..ctor() |
Statistics
| Stat | Issues | Debt | Annual Interest | Breaking Point |
|---|---|---|---|---|
| Sum: | 472 | 11d 4h | 8d 6h | 208 048d |
| Average: | 1.34 | 15min | 11min | 591d |
| Minimum: | 1 | 0min 30s | 0min 0s | 00:00:00 |
| Maximum: | 8 | 4h 8min | 2h 20min | 7 775d |
| Standard deviation: | 0.65 | 34min | 18min | 991d |
| Variance: | 0.42 | 150d | 41d | overflow |
| Code Query: New Debt and Issues per Code Element |
• Query Description:
This query lists code elements that have new issues since baseline, with most new Debt first.
For each code element the Debt estimates the effort to fix the element issues.
New issues since the baseline are consequence of recent code refactoring sessions. They represent good opportunities of fix because the code recently refactored is fresh in the developers mind, which means fixing now costs less than fixing later.
Fixing issues on recently touched code is also a good way to foster practices that will lead to higher code quality and maintainability, including writing unit-tests and avoiding unnecessary complex code.
141 code elements matched
| 141 code elements | IssuesAdded | IssuesFixed | Issues | Debt | DebtDiff | Full Name |
|---|---|---|---|---|---|---|
| BuildTargetModel(ModelBuilder) | 2 issues | no issue | 2 issues | 3h 32min | 3h 32min | Microsoft.eShopWeb.Infrastructure.Data .Migrations.AddExtraConstraints .BuildTargetModel(ModelBuilder) |
| Microsoft.eShopWeb.Web.Interfaces | 1 issue | no issue | 1 issue | 2h 0min | 2h 0min | Microsoft.eShopWeb.Web.Interfaces |
| OnPostAsync(String) | 3 issues | no issue | 3 issues | 1h 46min | 1h 46min | Microsoft.eShopWeb.Web.Areas.Identity .Pages.Account.LoginModel.OnPostAsync (String) |
| EfRepository<T> | 8 issues | 1 issue | 8 issues | 1h 13min | 1h 6min | Microsoft.eShopWeb.Infrastructure.Data .EfRepository<T> |
| Microsoft.eShopWeb.Web.Services | 3 issues | no issue | 4 issues | 1h 7min | 1h 0min | Microsoft.eShopWeb.Web.Services |
| BaseSpecification<T> | 1 issue | 1 issue | 1 issue | 1h 0min | 55min | Microsoft.eShopWeb.ApplicationCore .Specifications.BaseSpecification<T> |
| ListAllRegisteredServices (IApplicationBuilder,LinkGenerator) | 2 issues | no issue | 2 issues | 48min | 48min | Microsoft.eShopWeb.Web.Startup .ListAllRegisteredServices (IApplicationBuilder,LinkGenerator) |
| Microsoft.eShopWeb.Web.ViewModels | 2 issues | no issue | 2 issues | 40min | 40min | Microsoft.eShopWeb.Web.ViewModels |
| Microsoft.eShopWeb.Web.Controllers | 2 issues | no issue | 2 issues | 40min | 40min | Microsoft.eShopWeb.Web.Controllers |
| MyAccount() | 3 issues | no issue | 3 issues | 38min | 38min | Microsoft.eShopWeb.Web.Controllers .ManageController.MyAccount() |
| GetOrSetBasketCookieAndUserName() | 2 issues | no issue | 2 issues | 38min | 38min | Microsoft.eShopWeb.Web.Pages.Basket .CheckoutModel .GetOrSetBasketCookieAndUserName() |
| CheckHealthAsync(HealthCheckContext ,CancellationToken) | 2 issues | no issue | 2 issues | 31min | 31min | Microsoft.eShopWeb.Web.HealthChecks .ApiHealthCheck.CheckHealthAsync (HealthCheckContext,CancellationToken) |
| CheckHealthAsync(HealthCheckContext ,CancellationToken) | 2 issues | no issue | 2 issues | 28min | 28min | Microsoft.eShopWeb.Web.HealthChecks .HomePageHealthCheck.CheckHealthAsync (HealthCheckContext,CancellationToken) |
| ConfirmEmail(String,String) | 2 issues | no issue | 3 issues | 58min | 27min | Microsoft.eShopWeb.Web.Controllers .AccountController.ConfirmEmail(String ,String) |
| MyOrders() | 2 issues | no issue | 2 issues | 27min | 27min | Microsoft.eShopWeb.Web.Controllers .OrderController.MyOrders() |
| GetQuery(IQueryable<T>,ISpecification<T> ) | 1 issue | no issue | 1 issue | 26min | 26min | Microsoft.eShopWeb.Infrastructure.Data .SpecificationEvaluator<T>.GetQuery (IQueryable<T>,ISpecification<T>) |
| Basket | 2 issues | no issue | 2 issues | 22min | 22min | Microsoft.eShopWeb.Web.Pages.Shared .Components.BasketComponent.Basket |
| Up(MigrationBuilder) | 3 issues | no issue | 3 issues | 20min | 20min | Microsoft.eShopWeb.Infrastructure.Data .Migrations.AddExtraConstraints.Up (MigrationBuilder) |
| Down(MigrationBuilder) | 3 issues | no issue | 3 issues | 20min | 20min | Microsoft.eShopWeb.Infrastructure.Data .Migrations.AddExtraConstraints.Down (MigrationBuilder) |
| Microsoft.eShopWeb.ApplicationCore .Interfaces | 1 issue | no issue | 2 issues | 2h 20min | 20min | Microsoft.eShopWeb.ApplicationCore .Interfaces |
| IOrderRepository | 2 issues | no issue | 2 issues | 20min | 20min | Microsoft.eShopWeb.ApplicationCore .Interfaces.IOrderRepository |
| Web | 1 issue | no issue | 2 issues | 30min | 20min | Web |
| BasketItemViewModel | 2 issues | no issue | 2 issues | 20min | 20min | Microsoft.eShopWeb.Web.Pages.Basket .BasketItemViewModel |
| BasketViewModel | 2 issues | no issue | 2 issues | 20min | 20min | Microsoft.eShopWeb.Web.Pages.Basket .BasketViewModel |
| LoginWith2fa(Boolean,String) | 1 issue | no issue | 2 issues | 35min | 20min | Microsoft.eShopWeb.Web.Controllers .AccountController.LoginWith2fa(Boolean ,String) |
| LoginWith2fa(LoginWith2faViewModel ,Boolean,String) | 1 issue | no issue | 2 issues | 1h 45min | 20min | Microsoft.eShopWeb.Web.Controllers .AccountController.LoginWith2fa (LoginWith2faViewModel,Boolean,String) |
| ResetPassword(String) | 1 issue | no issue | 2 issues | 31min | 20min | Microsoft.eShopWeb.Web.Controllers .AccountController.ResetPassword(String) |
| Index(IndexViewModel) | 1 issue | no issue | 3 issues | 2h 0min | 20min | Microsoft.eShopWeb.Web.Controllers .ManageController.Index(IndexViewModel) |
| SendVerificationEmail(IndexViewModel) | 1 issue | no issue | 2 issues | 53min | 20min | Microsoft.eShopWeb.Web.Controllers .ManageController.SendVerificationEmail (IndexViewModel) |
| ChangePassword() | 1 issue | no issue | 2 issues | 45min | 20min | Microsoft.eShopWeb.Web.Controllers .ManageController.ChangePassword() |
| ChangePassword(ChangePasswordViewModel) | 1 issue | no issue | 2 issues | 1h 6min | 20min | Microsoft.eShopWeb.Web.Controllers .ManageController.ChangePassword (ChangePasswordViewModel) |
| SetPassword() | 1 issue | no issue | 2 issues | 45min | 20min | Microsoft.eShopWeb.Web.Controllers .ManageController.SetPassword() |
| SetPassword(SetPasswordViewModel) | 1 issue | no issue | 2 issues | 1h 3min | 20min | Microsoft.eShopWeb.Web.Controllers .ManageController.SetPassword (SetPasswordViewModel) |
| ExternalLogins() | 1 issue | no issue | 2 issues | 1h 2min | 20min | Microsoft.eShopWeb.Web.Controllers .ManageController.ExternalLogins() |
| LinkLoginCallback() | 1 issue | no issue | 2 issues | 1h 16min | 20min | Microsoft.eShopWeb.Web.Controllers .ManageController.LinkLoginCallback() |
| RemoveLogin(RemoveLoginViewModel) | 1 issue | no issue | 2 issues | 47min | 20min | Microsoft.eShopWeb.Web.Controllers .ManageController.RemoveLogin (RemoveLoginViewModel) |
| TwoFactorAuthentication() | 1 issue | no issue | 2 issues | 33min | 20min | Microsoft.eShopWeb.Web.Controllers .ManageController .TwoFactorAuthentication() |
| Disable2faWarning() | 1 issue | no issue | 2 issues | 39min | 20min | Microsoft.eShopWeb.Web.Controllers .ManageController.Disable2faWarning() |
| Disable2fa() | 1 issue | no issue | 2 issues | 45min | 20min | Microsoft.eShopWeb.Web.Controllers .ManageController.Disable2fa() |
| EnableAuthenticator() | 1 issue | no issue | 2 issues | 47min | 20min | Microsoft.eShopWeb.Web.Controllers .ManageController.EnableAuthenticator() |
| EnableAuthenticator (EnableAuthenticatorViewModel) | 1 issue | no issue | 2 issues | 1h 20min | 20min | Microsoft.eShopWeb.Web.Controllers .ManageController.EnableAuthenticator (EnableAuthenticatorViewModel) |
| ResetAuthenticator() | 1 issue | no issue | 2 issues | 37min | 20min | Microsoft.eShopWeb.Web.Controllers .ManageController.ResetAuthenticator() |
| GenerateRecoveryCodes() | 1 issue | no issue | 2 issues | 47min | 20min | Microsoft.eShopWeb.Web.Controllers .ManageController.GenerateRecoveryCodes( ) |
| .ctor(IBasketService ,IBasketViewModelService,IUriComposer ,SignInManager<ApplicationUser> ,IOrderService) | 2 issues | no issue | 2 issues | 18min | 18min | Microsoft.eShopWeb.Web.Pages.Basket .CheckoutModel..ctor(IBasketService ,IBasketViewModelService,IUriComposer ,SignInManager<ApplicationUser> ,IOrderService) |
| SetBasketModelAsync() | 2 issues | no issue | 2 issues | 18min | 18min | Microsoft.eShopWeb.Web.Pages.Basket .CheckoutModel.SetBasketModelAsync() |
| LoginModel+InputModel | 3 issues | no issue | 3 issues | 16min | 16min | Microsoft.eShopWeb.Web.Areas.Identity .Pages.Account.LoginModel+InputModel |
| OnPost(Dictionary<String,Int32>) | 2 issues | no issue | 2 issues | 15min | 15min | Microsoft.eShopWeb.Web.Pages.Basket .CheckoutModel.OnPost(Dictionary<String ,Int32>) |
| IBasketViewModelService | 1 issue | no issue | 1 issue | 15min | 15min | Microsoft.eShopWeb.Web.Interfaces .IBasketViewModelService |
| ErrorModel | 2 issues | no issue | 2 issues | 14min | 14min | Microsoft.eShopWeb.Web.Pages.ErrorModel |
| CheckoutModel | 2 issues | no issue | 2 issues | 14min | 14min | Microsoft.eShopWeb.Web.Pages.Basket .CheckoutModel |
| BasketWithItemsSpecification | 2 issues | no issue | 2 issues | 13min | 13min | Microsoft.eShopWeb.ApplicationCore .Specifications .BasketWithItemsSpecification |
| OrderRepository | 2 issues | no issue | 2 issues | 13min | 13min | Microsoft.eShopWeb.Infrastructure.Data .OrderRepository |
| BasketViewModelService | 2 issues | no issue | 2 issues | 13min | 13min | Microsoft.eShopWeb.Web.Services .BasketViewModelService |
| IdentityHostingStartup | 2 issues | no issue | 2 issues | 13min | 13min | Microsoft.eShopWeb.Web.Areas.Identity .IdentityHostingStartup |
| Configure(IApplicationBuilder ,IHostingEnvironment,LinkGenerator) | 1 issue | no issue | 1 issue | 12min | 12min | Microsoft.eShopWeb.Web.Startup.Configure (IApplicationBuilder,IHostingEnvironment ,LinkGenerator) |
| GetBrands() | 2 issues | no issue | 2 issues | 12min | 12min | Microsoft.eShopWeb.Web.Services .CachedCatalogViewModelService.GetBrands () |
| GetTypes() | 2 issues | no issue | 2 issues | 12min | 12min | Microsoft.eShopWeb.Web.Services .CachedCatalogViewModelService.GetTypes( ) |
| SpecificationEvaluator<T> | 2 issues | no issue | 2 issues | 12min | 12min | Microsoft.eShopWeb.Infrastructure.Data .SpecificationEvaluator<T> |
| OnPostUpdate(Dictionary<String,Int32>) | 2 issues | no issue | 2 issues | 10min | 10min | Microsoft.eShopWeb.Web.Pages.Basket .IndexModel.OnPostUpdate(Dictionary <String,Int32>) |
| CatalogFilterSpecification | 1 issue | no issue | 2 issues | 13min | 10min | Microsoft.eShopWeb.ApplicationCore .Specifications .CatalogFilterSpecification |
| CustomerOrdersWithItemsSpecification | 1 issue | no issue | 2 issues | 14min | 10min | Microsoft.eShopWeb.ApplicationCore .Specifications .CustomerOrdersWithItemsSpecification |
| BasketService | 1 issue | no issue | 1 issue | 10min | 10min | Microsoft.eShopWeb.ApplicationCore .Services.BasketService |
| IAsyncRepository<T> | 1 issue | no issue | 1 issue | 10min | 10min | Microsoft.eShopWeb.ApplicationCore .Interfaces.IAsyncRepository<T> |
| ISpecification<T> | 1 issue | no issue | 1 issue | 10min | 10min | Microsoft.eShopWeb.ApplicationCore .Interfaces.ISpecification<T> |
| AddExtraConstraints | 1 issue | no issue | 1 issue | 10min | 10min | Microsoft.eShopWeb.Infrastructure.Data .Migrations.AddExtraConstraints |
| BuildModel(ModelBuilder) | 1 issue | no issue | 2 issues | 3h 32min | 10min | Microsoft.eShopWeb.Infrastructure.Data .Migrations.CatalogContextModelSnapshot .BuildModel(ModelBuilder) |
| SlugifyParameterTransformer | 1 issue | no issue | 1 issue | 10min | 10min | Microsoft.eShopWeb.Web .SlugifyParameterTransformer |
| Startup | 1 issue | no issue | 1 issue | 10min | 10min | Microsoft.eShopWeb.Web.Startup |
| ApiHealthCheck | 1 issue | no issue | 1 issue | 10min | 10min | Microsoft.eShopWeb.Web.HealthChecks .ApiHealthCheck |
| HomePageHealthCheck | 1 issue | no issue | 1 issue | 10min | 10min | Microsoft.eShopWeb.Web.HealthChecks .HomePageHealthCheck |
| _itemRepository | 1 issue | no issue | 1 issue | 10min | 10min | Microsoft.eShopWeb.Web.Services .BasketViewModelService._itemRepository |
| CachedCatalogViewModelService | 1 issue | no issue | 1 issue | 10min | 10min | Microsoft.eShopWeb.Web.Services .CachedCatalogViewModelService |
| PrivacyModel | 1 issue | no issue | 1 issue | 10min | 10min | Microsoft.eShopWeb.Web.Pages .PrivacyModel |
| IndexModel | 1 issue | no issue | 1 issue | 10min | 10min | Microsoft.eShopWeb.Web.Pages.Basket .IndexModel |
| ManageController | 1 issue | no issue | 3 issues | 1h 20min | 10min | Microsoft.eShopWeb.Web.Controllers .ManageController |
| OrderController | 1 issue | no issue | 2 issues | 14min | 10min | Microsoft.eShopWeb.Web.Controllers .OrderController |
| CatalogController | 1 issue | no issue | 2 issues | 13min | 10min | Microsoft.eShopWeb.Web.Controllers.Api .CatalogController |
| LoginModel | 1 issue | no issue | 1 issue | 10min | 10min | Microsoft.eShopWeb.Web.Areas.Identity .Pages.Account.LoginModel |
| set_ExternalLogins(IList <AuthenticationScheme>) | 1 issue | no issue | 1 issue | 10min | 10min | Microsoft.eShopWeb.Web.Areas.Identity .Pages.Account.LoginModel .set_ExternalLogins(IList <AuthenticationScheme>) |
| Microsoft.eShopWeb.Web.HealthChecks | 2 issues | no issue | 2 issues | 9min | 9min | Microsoft.eShopWeb.Web.HealthChecks |
| OnGetAsync(String) | 1 issue | no issue | 1 issue | 8min | 8min | Microsoft.eShopWeb.Web.Areas.Identity .Pages.Account.LoginModel.OnGetAsync (String) |
| .ctor(IHttpContextAccessor,LinkGenerator ) | 2 issues | no issue | 2 issues | 8min | 8min | Microsoft.eShopWeb.Web.HealthChecks .ApiHealthCheck..ctor (IHttpContextAccessor,LinkGenerator) |
| GetBasketViewModelAsync() | 1 issue | no issue | 1 issue | 7min | 7min | Microsoft.eShopWeb.Web.Pages.Shared .Components.BasketComponent.Basket .GetBasketViewModelAsync() |
| SetBasketModelAsync() | 1 issue | no issue | 1 issue | 6min | 6min | Microsoft.eShopWeb.Web.Pages.Basket .IndexModel.SetBasketModelAsync() |
| OnGet() | 2 issues | no issue | 2 issues | 6min | 6min | Microsoft.eShopWeb.Web.Pages.ErrorModel .OnGet() |
| .ctor(IHttpContextAccessor) | 2 issues | no issue | 2 issues | 6min | 6min | Microsoft.eShopWeb.Web.HealthChecks .HomePageHealthCheck..ctor (IHttpContextAccessor) |
| .ctor(Int32,Int32,Nullable<Int32> ,Nullable<Int32>) | 1 issue | no issue | 1 issue | 6min | 6min | Microsoft.eShopWeb.ApplicationCore .Specifications .CatalogFilterPaginatedSpecification. .ctor(Int32,Int32,Nullable<Int32> ,Nullable<Int32>) |
| OnPost(CatalogItemViewModel) | 1 issue | no issue | 1 issue | 5min | 5min | Microsoft.eShopWeb.Web.Pages.Basket .IndexModel.OnPost(CatalogItemViewModel) |
| Microsoft.eShopWeb.Web.Pages | 1 issue | no issue | 1 issue | 5min | 5min | Microsoft.eShopWeb.Web.Pages |
| Microsoft.eShopWeb.Web.Pages.Basket | 1 issue | no issue | 1 issue | 5min | 5min | Microsoft.eShopWeb.Web.Pages.Basket |
| Microsoft.eShopWeb.Web.Pages.Shared .Components.BasketComponent | 1 issue | no issue | 1 issue | 5min | 5min | Microsoft.eShopWeb.Web.Pages.Shared .Components.BasketComponent |
| Microsoft.eShopWeb.Web.Areas.Identity .Pages.Account | 1 issue | no issue | 1 issue | 5min | 5min | Microsoft.eShopWeb.Web.Areas.Identity .Pages.Account |
| set_OrderBy(Expression<Func<T,Object>>) | 2 issues | no issue | 2 issues | 4min 45s | 4min 45s | Microsoft.eShopWeb.ApplicationCore .Specifications.BaseSpecification<T> .set_OrderBy(Expression<Func<T,Object>>) |
| set_OrderByDescending(Expression<Func<T ,Object>>) | 2 issues | no issue | 2 issues | 4min 45s | 4min 45s | Microsoft.eShopWeb.ApplicationCore .Specifications.BaseSpecification<T> .set_OrderByDescending(Expression<Func<T ,Object>>) |
| ApplyOrderBy(Expression<Func<T,Object>>) | 2 issues | no issue | 2 issues | 4min 31s | 4min 31s | Microsoft.eShopWeb.ApplicationCore .Specifications.BaseSpecification<T> .ApplyOrderBy(Expression<Func<T,Object>> ) |
| ApplyOrderByDescending(Expression<Func<T ,Object>>) | 2 issues | no issue | 2 issues | 4min 31s | 4min 31s | Microsoft.eShopWeb.ApplicationCore .Specifications.BaseSpecification<T> .ApplyOrderByDescending(Expression<Func <T,Object>>) |
| get_RequestId() | 2 issues | no issue | 2 issues | 4min 17s | 4min 17s | Microsoft.eShopWeb.Web.Pages.ErrorModel .get_RequestId() |
| set_RequestId(String) | 2 issues | no issue | 2 issues | 4min 17s | 4min 17s | Microsoft.eShopWeb.Web.Pages.ErrorModel .set_RequestId(String) |
| get_ShowRequestId() | 2 issues | no issue | 2 issues | 4min 17s | 4min 17s | Microsoft.eShopWeb.Web.Pages.ErrorModel .get_ShowRequestId() |
| get_CatalogItemId() | 2 issues | no issue | 2 issues | 4min 17s | 4min 17s | Microsoft.eShopWeb.Web.Pages.Basket .BasketItemViewModel.get_CatalogItemId() |
Statistics
| Stat | IssuesAdded | IssuesFixed | Issues | Debt | DebtDiff |
|---|---|---|---|---|---|
| Sum: | 213 | 5 | 251 | 7d 1h | 4d 4h |
| Average: | 1.51 | 0.035 | 1.78 | 24min | 15min |
| Minimum: | 1 | 0 | 1 | 0min 30s | -(10min) |
| Maximum: | 8 | 2 | 8 | 3h 32min | 3h 32min |
| Standard deviation: | 0.8 | 0.22 | 0.81 | 34min | 23min |
| Variance: | 0.63 | 0.048 | 0.65 | 151d | 69d |
Object Oriented Design
| Validated Rule: Avoid interfaces too big |
• Rule Description:
This rule matches interfaces with more than 10 methods. Interfaces are abstractions and are meant to simplify the code structure. An interface should represent a single responsibility. Making an interface too large, too complex, necessarily means that the interface has too many responsibilities.
A property with getter or setter or both count as one method. An event count as one method.
• How to Fix Issues of this Rule: Typically to fix such issue, the interface must be refactored in a grape of smaller single-responsibility interfaces. A classic example is a ISession large interface, responsible for holding states, run commands and offer various accesses and facilities. The classic problem for a large public interface is that it has many clients that consume it. As a consequence splitting it in smaller interfaces has an important impact and it is not always feasible. The estimated Debt, which means the effort to fix such issue, varies linearly from 20 minutes for an interface with 10 methods, up to 7 hours for an interface with 100 or more methods. The Debt is divided by two if the interface is not publicly visible, because in such situation only the current project is impacted by the refactoring.
• How to Suppress an Issue of this Rule: In source code, tag the concerned code element with this attribute: [SuppressMessage("NDepend", "ND1200:AvoidInterfacesTooBig", Justification="...")] This attribute requires the compilation symbol CODE_ANALYSIS to be set on each Visual Studio project relying on it. Without CODE_ANALYSIS symbol defined, the attribute is not compiled and the issues are not suppressed.
• How to Fix Issues of this Rule: Typically to fix such issue, the interface must be refactored in a grape of smaller single-responsibility interfaces. A classic example is a ISession large interface, responsible for holding states, run commands and offer various accesses and facilities. The classic problem for a large public interface is that it has many clients that consume it. As a consequence splitting it in smaller interfaces has an important impact and it is not always feasible. The estimated Debt, which means the effort to fix such issue, varies linearly from 20 minutes for an interface with 10 methods, up to 7 hours for an interface with 100 or more methods. The Debt is divided by two if the interface is not publicly visible, because in such situation only the current project is impacted by the refactoring.
• How to Suppress an Issue of this Rule: In source code, tag the concerned code element with this attribute: [SuppressMessage("NDepend", "ND1200:AvoidInterfacesTooBig", Justification="...")] This attribute requires the compilation symbol CODE_ANALYSIS to be set on each Visual Studio project relying on it. Without CODE_ANALYSIS symbol defined, the attribute is not compiled and the issues are not suppressed.
No type matched
| Validated Rule: Base class should not use derivatives |
• Rule Description:
In Object-Oriented Programming, the open/closed principle states: software entities (components, classes, methods, etc.) should be open for extension, but closed for modification. http://en.wikipedia.org/wiki/Open/closed_principle
Hence a base class should be designed properly to make it easy to derive from, this is extension. But creating a new derived class, or modifying an existing one, shouldn't provoke any modification in the base class. And if a base class is using some derivative classes somehow, there are good chances that such modification will be needed.
Extending the base class is not anymore a simple operation, this is not good design.
Note that this rule doesn't warn when a base class is using a derived class that is nested in the base class and declared as private. In such situation we consider that the derived class is an encapsulated implementation detail of the base class.
• How to Fix Issues of this Rule: Understand the need for using derivatives, then imagine a new design, and then refactor. Typically an algorithm in the base class needs to access something from derived classes. You can try to encapsulate this access behind an abstract or a virtual method. If you see in the base class some conditions on typeof(DerivedClass) not only urgent refactoring is needed. Such condition can easily be replaced through an abstract or a virtual method. Sometime you'll see a base class that creates instance of some derived classes. In such situation, certainly using the factory method pattern http://en.wikipedia.org/wiki/Factory_method_pattern or the abstract factory pattern http://en.wikipedia.org/wiki/Abstract_factory_pattern will improve the design. The estimated Debt, which means the effort to fix such issue, is equal to 3 minutes per derived class used by the base class + 3 minutes per member of a derived class used by the base class.
• How to Suppress an Issue of this Rule: In source code, tag the concerned code element with this attribute: [SuppressMessage("NDepend", "ND1201:BaseClassShouldNotUseDerivatives", Justification="...")] This attribute requires the compilation symbol CODE_ANALYSIS to be set on each Visual Studio project relying on it. Without CODE_ANALYSIS symbol defined, the attribute is not compiled and the issues are not suppressed.
• How to Fix Issues of this Rule: Understand the need for using derivatives, then imagine a new design, and then refactor. Typically an algorithm in the base class needs to access something from derived classes. You can try to encapsulate this access behind an abstract or a virtual method. If you see in the base class some conditions on typeof(DerivedClass) not only urgent refactoring is needed. Such condition can easily be replaced through an abstract or a virtual method. Sometime you'll see a base class that creates instance of some derived classes. In such situation, certainly using the factory method pattern http://en.wikipedia.org/wiki/Factory_method_pattern or the abstract factory pattern http://en.wikipedia.org/wiki/Abstract_factory_pattern will improve the design. The estimated Debt, which means the effort to fix such issue, is equal to 3 minutes per derived class used by the base class + 3 minutes per member of a derived class used by the base class.
• How to Suppress an Issue of this Rule: In source code, tag the concerned code element with this attribute: [SuppressMessage("NDepend", "ND1201:BaseClassShouldNotUseDerivatives", Justification="...")] This attribute requires the compilation symbol CODE_ANALYSIS to be set on each Visual Studio project relying on it. Without CODE_ANALYSIS symbol defined, the attribute is not compiled and the issues are not suppressed.
No type matched
| Validated Rule: Class shouldn't be too deep in inheritance tree |
• Rule Description:
This rule warns about classes having 3 or more base classes. Notice that third-party base classes are not counted because this rule is about your code design, not third-party libraries consumed design.
In theory, there is nothing wrong having a long inheritance chain, if the modelization has been well thought out, if each base class is a well-designed refinement of the domain.
In practice, modeling properly a domain demands a lot of effort and experience and more often than not, a long inheritance chain is a sign of confused design, that will be hard to work with and maintain.
• How to Fix Issues of this Rule: In Object-Oriented Programming, a well-known motto is Favor Composition over Inheritance. This is because inheritance comes with pitfalls. In general, the implementation of a derived class is very bound up with the base class implementation. Also a base class exposes implementation details to its derived classes, that's why it's often said that inheritance breaks encapsulation. On the other hands, Composition favors binding with interfaces over binding with implementations. Hence, not only the encapsulation is preserved, but the design is clearer, because interfaces make it explicit and less coupled. Hence, to break a long inheritance chain, Composition is often a powerful way to enhance the design of the refactored underlying logic. You can also read: http://en.wikipedia.org/wiki/Composition_over_inheritance and http://stackoverflow.com/questions/49002/prefer-composition-over-inheritance The estimated Debt, which means the effort to fix such issue, depends linearly upon the depth of inheritance.
• How to Suppress an Issue of this Rule: In source code, tag the concerned code element with this attribute: [SuppressMessage("NDepend", "ND1202:ClassShouldntBeTooDeepInInheritanceTree", Justification="...")] This attribute requires the compilation symbol CODE_ANALYSIS to be set on each Visual Studio project relying on it. Without CODE_ANALYSIS symbol defined, the attribute is not compiled and the issues are not suppressed.
• How to Fix Issues of this Rule: In Object-Oriented Programming, a well-known motto is Favor Composition over Inheritance. This is because inheritance comes with pitfalls. In general, the implementation of a derived class is very bound up with the base class implementation. Also a base class exposes implementation details to its derived classes, that's why it's often said that inheritance breaks encapsulation. On the other hands, Composition favors binding with interfaces over binding with implementations. Hence, not only the encapsulation is preserved, but the design is clearer, because interfaces make it explicit and less coupled. Hence, to break a long inheritance chain, Composition is often a powerful way to enhance the design of the refactored underlying logic. You can also read: http://en.wikipedia.org/wiki/Composition_over_inheritance and http://stackoverflow.com/questions/49002/prefer-composition-over-inheritance The estimated Debt, which means the effort to fix such issue, depends linearly upon the depth of inheritance.
• How to Suppress an Issue of this Rule: In source code, tag the concerned code element with this attribute: [SuppressMessage("NDepend", "ND1202:ClassShouldntBeTooDeepInInheritanceTree", Justification="...")] This attribute requires the compilation symbol CODE_ANALYSIS to be set on each Visual Studio project relying on it. Without CODE_ANALYSIS symbol defined, the attribute is not compiled and the issues are not suppressed.
No type matched
| Validated Rule: Class with no descendant should be sealed if possible |
• Rule Description:
If a non-static class isn't declared with the keyword sealed, it means that it can be subclassed everywhere the non-sealed class is visible.
Making a class a base class requires significant design effort. Subclassing a non-sealed class, not initially designed to be subclassed, will lead to unanticipated design issue.
Most classes are non-sealed because developers don't care about the keyword sealed, not because the primary intention was to write a class that can be subclassed.
There are minor performance gain in declaring a class as sealed. But the real benefit of doing so, is actually to express the intention: this class has not be designed to be a base class, hence it is not allowed to subclass it.
Notice that by default this rule doesn't match public class to avoid matching classes that are intended to be sub-classed by third-party code using your library. If you are developing an application and not a library, just uncomment the clause !t.IsPubliclyVisible.
• How to Fix Issues of this Rule: For each matched class, take the time to assess if it is really meant to be subclassed. Certainly most matched class will end up being declared as sealed.
• How to Suppress an Issue of this Rule: In source code, tag the concerned code element with this attribute: [SuppressMessage("NDepend", "ND1203:ClassWithNoDescendantShouldBeSealedIfPossible", Justification="...")] This attribute requires the compilation symbol CODE_ANALYSIS to be set on each Visual Studio project relying on it. Without CODE_ANALYSIS symbol defined, the attribute is not compiled and the issues are not suppressed.
• How to Fix Issues of this Rule: For each matched class, take the time to assess if it is really meant to be subclassed. Certainly most matched class will end up being declared as sealed.
• How to Suppress an Issue of this Rule: In source code, tag the concerned code element with this attribute: [SuppressMessage("NDepend", "ND1203:ClassWithNoDescendantShouldBeSealedIfPossible", Justification="...")] This attribute requires the compilation symbol CODE_ANALYSIS to be set on each Visual Studio project relying on it. Without CODE_ANALYSIS symbol defined, the attribute is not compiled and the issues are not suppressed.
No type matched
| Validated Rule: Overrides of Method() should call base.Method() |
• Rule Description:
Typically overrides of a base method, should refine or complete the behavior of the base method. If the base method is not called, the base behavior is not refined but it is replaced.
Violations of this rule are a sign of design flaw, especially if the actual design provides valid reasons that advocates that the base behavior must be replaced and not refined.
• How to Fix Issues of this Rule: You should investigate if inheritance is the right choice to bind the base class implementation with the derived classes implementations. Does presenting the method with polymorphic behavior through an interface, would be a better design choice? In such situation, often using the design pattern template method http://en.wikipedia.org/wiki/Template_method_pattern might help improving the design.
• How to Suppress an Issue of this Rule: In source code, tag the concerned code element with this attribute: [SuppressMessage("NDepend", "ND1204:OverridesOfMethodShouldCallBaseMethod", Justification="...")] This attribute requires the compilation symbol CODE_ANALYSIS to be set on each Visual Studio project relying on it. Without CODE_ANALYSIS symbol defined, the attribute is not compiled and the issues are not suppressed.
• How to Fix Issues of this Rule: You should investigate if inheritance is the right choice to bind the base class implementation with the derived classes implementations. Does presenting the method with polymorphic behavior through an interface, would be a better design choice? In such situation, often using the design pattern template method http://en.wikipedia.org/wiki/Template_method_pattern might help improving the design.
• How to Suppress an Issue of this Rule: In source code, tag the concerned code element with this attribute: [SuppressMessage("NDepend", "ND1204:OverridesOfMethodShouldCallBaseMethod", Justification="...")] This attribute requires the compilation symbol CODE_ANALYSIS to be set on each Visual Studio project relying on it. Without CODE_ANALYSIS symbol defined, the attribute is not compiled and the issues are not suppressed.
No method matched
| Validated Rule: Do not hide base class methods |
• Rule Description:
Method hiding is when a base class has a non-virtual method M(), and a derived class has also a method M() with the same signature. In such situation, calling base.M() does something different than calling derived.M().
Notice that this is not polymorphic behavior. With polymorphic behavior, calling both base.M() and derived.M() on an instance object of derived, invoke the same implementation.
This situation should be avoided because it obviously leads to confusion. This rule warns about all method hiding cases in the code base.
• How to Fix Issues of this Rule: To fix a violation of this rule, remove or rename the method, or change the parameter signature so that the method does not hide the base method. However method hiding is for those times when you need to have two things to have the same name but different behavior. This is a very rare situations, described here: http://blogs.msdn.com/b/ericlippert/archive/2008/05/21/method-hiding-apologia.aspx
• How to Suppress an Issue of this Rule: In source code, tag the concerned code element with this attribute: [SuppressMessage("NDepend", "ND1205:DoNotHideBaseClassMethods", Justification="...")] This attribute requires the compilation symbol CODE_ANALYSIS to be set on each Visual Studio project relying on it. Without CODE_ANALYSIS symbol defined, the attribute is not compiled and the issues are not suppressed.
• How to Fix Issues of this Rule: To fix a violation of this rule, remove or rename the method, or change the parameter signature so that the method does not hide the base method. However method hiding is for those times when you need to have two things to have the same name but different behavior. This is a very rare situations, described here: http://blogs.msdn.com/b/ericlippert/archive/2008/05/21/method-hiding-apologia.aspx
• How to Suppress an Issue of this Rule: In source code, tag the concerned code element with this attribute: [SuppressMessage("NDepend", "ND1205:DoNotHideBaseClassMethods", Justification="...")] This attribute requires the compilation symbol CODE_ANALYSIS to be set on each Visual Studio project relying on it. Without CODE_ANALYSIS symbol defined, the attribute is not compiled and the issues are not suppressed.
No method matched
| Validated Rule: A stateless class or structure might be turned into a static type |
• Rule Description:
This rule matches classes and structures that are not static, nor generic, that doesn't have any instance fields, that doesn't implement any interface nor has a base class (different than System.Object).
Such class or structure is a stateless collection of pure functions, that doesn't act on any this object data. Such collection of pure functions is better hosted in a static class. Doing so simplifies the client code that doesn't have to create an object anymore to invoke the pure functions.
• How to Fix Issues of this Rule: Declare all methods as static and transform the class or structure into a static class. By default issues of this rule have a Low severity because they reflect more an advice than a problem.
• How to Suppress an Issue of this Rule: In source code, tag the concerned code element with this attribute: [SuppressMessage("NDepend", "ND1206:AStatelessClassOrStructureMightBeTurnedIntoAStaticType", Justification="...")] This attribute requires the compilation symbol CODE_ANALYSIS to be set on each Visual Studio project relying on it. Without CODE_ANALYSIS symbol defined, the attribute is not compiled and the issues are not suppressed.
• How to Fix Issues of this Rule: Declare all methods as static and transform the class or structure into a static class. By default issues of this rule have a Low severity because they reflect more an advice than a problem.
• How to Suppress an Issue of this Rule: In source code, tag the concerned code element with this attribute: [SuppressMessage("NDepend", "ND1206:AStatelessClassOrStructureMightBeTurnedIntoAStaticType", Justification="...")] This attribute requires the compilation symbol CODE_ANALYSIS to be set on each Visual Studio project relying on it. Without CODE_ANALYSIS symbol defined, the attribute is not compiled and the issues are not suppressed.
No type matched
| Rule Violated: Non-static classes should be instantiated or turned to static |
• Rule Description:
If the constructors of a class are never called, the class is never instantiated, and should be defined as a static class.
However this rule doesn't match instantiation through reflection. As a consequence, plug-in root classes, instantiated through reflection via IoC frameworks, can be false positives for this rule.
This rule doesn't match also classes instantiated by the ASP.NET infrastructure, ASP.NET view model classes and Entity Framework ModelSnapshot, DbContext and Migration classes.
Notice that by default this rule matches also public class. If you are developing a framework with classes that are intended to be instantiated by your clients, just uncomment the line !t.IsPublic.
• How to Fix Issues of this Rule: First it is important to investigate why the class is never instantiated. If the reason is the class hosts only static methods then the class can be safely declared as static. Others reasons like, the class is meant to be instantiated via reflection, or is meant to be instantiated only by client code should lead to adapt this rule code to avoid these matches.
• How to Suppress an Issue of this Rule: In source code, tag the concerned code element with this attribute: [SuppressMessage("NDepend", "ND1207:NonStaticClassesShouldBeInstantiatedOrTurnedToStatic", Justification="...")] This attribute requires the compilation symbol CODE_ANALYSIS to be set on each Visual Studio project relying on it. Without CODE_ANALYSIS symbol defined, the attribute is not compiled and the issues are not suppressed.
• How to Fix Issues of this Rule: First it is important to investigate why the class is never instantiated. If the reason is the class hosts only static methods then the class can be safely declared as static. Others reasons like, the class is meant to be instantiated via reflection, or is meant to be instantiated only by client code should lead to adapt this rule code to avoid these matches.
• How to Suppress an Issue of this Rule: In source code, tag the concerned code element with this attribute: [SuppressMessage("NDepend", "ND1207:NonStaticClassesShouldBeInstantiatedOrTurnedToStatic", Justification="...")] This attribute requires the compilation symbol CODE_ANALYSIS to be set on each Visual Studio project relying on it. Without CODE_ANALYSIS symbol defined, the attribute is not compiled and the issues are not suppressed.
2 types matched
-
Formatting: bold means added, underlined means code was changed,
strike-boldmeans removed (since baseline)
| 2 types | Visibility | Debt | Severity | Full Name |
|---|---|---|---|---|
| PaymentMethod | Public | 2min 0s | Medium | Microsoft.eShopWeb.ApplicationCore .Entities.BuyerAggregate.PaymentMethod |
| SpecificationEvaluator<T> | Public | 2min 0s | Medium | Microsoft.eShopWeb.Infrastructure.Data .SpecificationEvaluator<T> |
| Rule Violated: Methods should be declared static if possible |
• Rule Description:
When an instance method can be safely declared as static you should declare it as static.
Whenever you write a method, you fulfill a contract in a given scope. The narrower the scope is, the smaller the chance is that you write a bug.
When a method is static, you can't access non-static members; hence, your scope is narrower. So, if you don't need and will never need (even in subclasses) instance fields to fulfill your contract, why give access to these fields to your method? Declaring the method static in this case will let the compiler check that you don't use members that you do not intend to use.
Declaring a method as static if possible is also good practice because clients can tell from the method signature that calling the method can't alter the object's state.
Doing so, is also a micro performance optimization, since a static method is a bit cheaper to invoke than an instance method, because the this reference* doesn't need anymore to be passed.
Notice that if a matched method is a handler, bound to an event through code generated by a designer, declaring it as static might break the designer generated code, if the generated code use the this invocation syntax, (like this.Method()).
• How to Fix Issues of this Rule: Declare matched methods as static. Since such method doesn't use any instance fields and methods of its type and base-types, you should consider if it makes sense, to move such a method to a static utility class.
• How to Suppress an Issue of this Rule: In source code, tag the concerned code element with this attribute: [SuppressMessage("NDepend", "ND1208:MethodsShouldBeDeclaredStaticIfPossible", Justification="...")] This attribute requires the compilation symbol CODE_ANALYSIS to be set on each Visual Studio project relying on it. Without CODE_ANALYSIS symbol defined, the attribute is not compiled and the issues are not suppressed.
• How to Fix Issues of this Rule: Declare matched methods as static. Since such method doesn't use any instance fields and methods of its type and base-types, you should consider if it makes sense, to move such a method to a static utility class.
• How to Suppress an Issue of this Rule: In source code, tag the concerned code element with this attribute: [SuppressMessage("NDepend", "ND1208:MethodsShouldBeDeclaredStaticIfPossible", Justification="...")] This attribute requires the compilation symbol CODE_ANALYSIS to be set on each Visual Studio project relying on it. Without CODE_ANALYSIS symbol defined, the attribute is not compiled and the issues are not suppressed.
10 methods matched
-
Formatting: bold means added, underlined means code was changed,
strike-boldmeans removed (since baseline)
| 10 methods | staticFieldsUsed | methodsCallingMe | Debt | Severity | Full Name |
|---|---|---|---|---|---|
| ConfigurateCatalogItemOrdered (EntityTypeBuilder<CatalogItemOrdered>) | no field | 1 method | 1min 0s | Medium | Microsoft.eShopWeb.Infrastructure.Data .CatalogContext .ConfigurateCatalogItemOrdered (EntityTypeBuilder<CatalogItemOrdered>) |
| ConfigureAddress(EntityTypeBuilder <Address>) | no field | 1 method | 1min 0s | Medium | Microsoft.eShopWeb.Infrastructure.Data .CatalogContext.ConfigureAddress (EntityTypeBuilder<Address>) |
| ConfigureBasket(EntityTypeBuilder<Basket >) | no field | 1 method | 1min 0s | Medium | Microsoft.eShopWeb.Infrastructure.Data .CatalogContext.ConfigureBasket (EntityTypeBuilder<Basket>) |
| ConfigureCatalogItem(EntityTypeBuilder <CatalogItem>) | no field | 1 method | 1min 0s | Medium | Microsoft.eShopWeb.Infrastructure.Data .CatalogContext.ConfigureCatalogItem (EntityTypeBuilder<CatalogItem>) |
| ConfigureCatalogBrand(EntityTypeBuilder <CatalogBrand>) | no field | 1 method | 1min 0s | Medium | Microsoft.eShopWeb.Infrastructure.Data .CatalogContext.ConfigureCatalogBrand (EntityTypeBuilder<CatalogBrand>) |
| ConfigureCatalogType(EntityTypeBuilder <CatalogType>) | no field | 1 method | 1min 0s | Medium | Microsoft.eShopWeb.Infrastructure.Data .CatalogContext.ConfigureCatalogType (EntityTypeBuilder<CatalogType>) |
| ConfigureOrder(EntityTypeBuilder<Order>) | no field | 1 method | 1min 0s | Medium | Microsoft.eShopWeb.Infrastructure.Data .CatalogContext.ConfigureOrder (EntityTypeBuilder<Order>) |
| ConfigureOrderItem(EntityTypeBuilder <OrderItem>) | no field | 1 method | 1min 0s | Medium | Microsoft.eShopWeb.Infrastructure.Data .CatalogContext.ConfigureOrderItem (EntityTypeBuilder<OrderItem>) |
| OnGet() | no field | no method | 0min 30s | Medium | Microsoft.eShopWeb.Web.Pages .PrivacyModel.OnGet() |
| OnGet() | no field | no method | 0min 30s | Medium | Microsoft.eShopWeb.Web.Pages.Basket .CheckoutModel.OnGet() |
| Rule Violated: Constructor should not call a virtual method |
• Rule Description:
This rule matches constructors of a non-sealed class that call one or several virtual methods.
When an object written in C# is constructed, what happens is that constructors run in order from the base class to the most derived class.
Also objects do not change type as they are constructed, but start out as the most derived type, with the method table being for the most derived type. This means that virtual method calls always run on the most derived type, even when calls are made from the constructor.
When you combine these two facts you are left with the problem that if you make a virtual method call in a constructor, and it is not the most derived type in its inheritance hierarchy, then it will be called on a class whose constructor has not been run, and therefore may not be in a suitable state to have that method called.
Hence this situation makes the class fragile to derive from.
• How to Fix Issues of this Rule: Violations reported can be solved by re-designing object initialisation or by declaring the parent class as sealed, if possible.
• How to Suppress an Issue of this Rule: In source code, tag the concerned code element with this attribute: [SuppressMessage("NDepend", "ND1209:ConstructorShouldNotCallAVirtualMethod", Justification="...")] This attribute requires the compilation symbol CODE_ANALYSIS to be set on each Visual Studio project relying on it. Without CODE_ANALYSIS symbol defined, the attribute is not compiled and the issues are not suppressed.
• How to Fix Issues of this Rule: Violations reported can be solved by re-designing object initialisation or by declaring the parent class as sealed, if possible.
• How to Suppress an Issue of this Rule: In source code, tag the concerned code element with this attribute: [SuppressMessage("NDepend", "ND1209:ConstructorShouldNotCallAVirtualMethod", Justification="...")] This attribute requires the compilation symbol CODE_ANALYSIS to be set on each Visual Studio project relying on it. Without CODE_ANALYSIS symbol defined, the attribute is not compiled and the issues are not suppressed.
2 methods matched
-
Formatting: bold means added, underlined means code was changed,
strike-boldmeans removed (since baseline)
| 2 methods | virtualMethodsCalled | DerivedTypes | Debt | Severity | Full Name |
|---|---|---|---|---|---|
| .ctor(Int32,Int32,Nullable<Int32> ,Nullable<Int32>) | 1 method | no type | 6min | High | Microsoft.eShopWeb.ApplicationCore .Specifications .CatalogFilterPaginatedSpecification. .ctor(Int32,Int32,Nullable<Int32> ,Nullable<Int32>) |
| .ctor(String) | 2 methods | no type | 12min | High | Microsoft.eShopWeb.ApplicationCore .Specifications .CustomerOrdersWithItemsSpecification. .ctor(String) |
| Validated Rule: Avoid the Singleton pattern |
• Rule Description:
The singleton pattern consists in enforcing that a class has just a single instance: http://en.wikipedia.org/wiki/Singleton_pattern At first glance, this pattern looks appealing, it is simple to implement, it adresses a common situation, and as a consequence it is widely used.
However, we discourage you from using singleton classes because experience shows that singleton often results in less testable and less maintainable code. Singleton is by-design, not testable. Each unit test should use their own objects while singleton forces multiple unit-tests to use the same instance object.
Also the singleton static GetInstance() method allows magic access to that single object and its state from wherever developers want! This potentially attractive facility unfortunatly ends up into unorganized/messy code that will require effort to be refactored.
Notice that this rule matches only singleton types with mutable instance fields because singleton pitfalls result from anarchical access and modification of instance data.
More details available in these discussions: http://codebetter.com/patricksmacchia/2011/05/04/back-to-basics-usage-of-static-members/ http://adamschepis.com/blog/2011/05/02/im-adam-and-im-a-recovering-singleton-addict/
• How to Fix Issues of this Rule: This rule matches the classic syntax of singletons, where one static field hold the single instance of the parent class. We underline that the problem is this particular syntax, that plays against testability. The problem is not the fact that a single instance of the class lives at runtime. Hence to fix matches fo this rule, creates the single instance at the startup of the program, and pass it to all classes and methods that need to access it. If multiple singletons are identified, they actually form together a program execution context. Such context can be unified in a unique singleton context. Doing so will make it easier to propagate the context across the various program units. The estimated Debt, which means the effort to fix such issue, is equal to 3 minutes per method relying on the singleton. It is not rare that hundreds of methods rely on the singleton and that it takes hours to get rid of a singleton, refactoring the way just explained above. The severity of each singleton issue is Critical because as explained, using a the singleton pattern can really prevent the whole program to be testable.
• How to Suppress an Issue of this Rule: In source code, tag the concerned code element with this attribute: [SuppressMessage("NDepend", "ND1210:AvoidTheSingletonPattern", Justification="...")] This attribute requires the compilation symbol CODE_ANALYSIS to be set on each Visual Studio project relying on it. Without CODE_ANALYSIS symbol defined, the attribute is not compiled and the issues are not suppressed.
• How to Fix Issues of this Rule: This rule matches the classic syntax of singletons, where one static field hold the single instance of the parent class. We underline that the problem is this particular syntax, that plays against testability. The problem is not the fact that a single instance of the class lives at runtime. Hence to fix matches fo this rule, creates the single instance at the startup of the program, and pass it to all classes and methods that need to access it. If multiple singletons are identified, they actually form together a program execution context. Such context can be unified in a unique singleton context. Doing so will make it easier to propagate the context across the various program units. The estimated Debt, which means the effort to fix such issue, is equal to 3 minutes per method relying on the singleton. It is not rare that hundreds of methods rely on the singleton and that it takes hours to get rid of a singleton, refactoring the way just explained above. The severity of each singleton issue is Critical because as explained, using a the singleton pattern can really prevent the whole program to be testable.
• How to Suppress an Issue of this Rule: In source code, tag the concerned code element with this attribute: [SuppressMessage("NDepend", "ND1210:AvoidTheSingletonPattern", Justification="...")] This attribute requires the compilation symbol CODE_ANALYSIS to be set on each Visual Studio project relying on it. Without CODE_ANALYSIS symbol defined, the attribute is not compiled and the issues are not suppressed.
No type matched
| Validated Rule: Don't assign static fields from instance methods |
• Rule Description:
Assigning static fields from instance methods leads to poorly maintainable and non-thread-safe code.
More discussion on the topic can be found here: http://codebetter.com/patricksmacchia/2011/05/04/back-to-basics-usage-of-static-members/
• How to Fix Issues of this Rule: If the static field is just assigned once in the program lifetime, make sure to declare it as readonly and assign it inline, or from the static constructor. In Object-Oriented-Programming the natural artifact to hold states that can be modified is instance fields. Hence to fix violations of this rule, make sure to hold assignable states through instance fields, not through static fields.
• How to Suppress an Issue of this Rule: In source code, tag the concerned code element with this attribute: [SuppressMessage("NDepend", "ND1211:DontAssignStaticFieldsFromInstanceMethods", Justification="...")] This attribute requires the compilation symbol CODE_ANALYSIS to be set on each Visual Studio project relying on it. Without CODE_ANALYSIS symbol defined, the attribute is not compiled and the issues are not suppressed.
• How to Fix Issues of this Rule: If the static field is just assigned once in the program lifetime, make sure to declare it as readonly and assign it inline, or from the static constructor. In Object-Oriented-Programming the natural artifact to hold states that can be modified is instance fields. Hence to fix violations of this rule, make sure to hold assignable states through instance fields, not through static fields.
• How to Suppress an Issue of this Rule: In source code, tag the concerned code element with this attribute: [SuppressMessage("NDepend", "ND1211:DontAssignStaticFieldsFromInstanceMethods", Justification="...")] This attribute requires the compilation symbol CODE_ANALYSIS to be set on each Visual Studio project relying on it. Without CODE_ANALYSIS symbol defined, the attribute is not compiled and the issues are not suppressed.
No field matched
| Rule Violated: Avoid empty interfaces |
• Rule Description:
Interfaces define members that provide a behavior or usage contract. The functionality that is described by the interface can be adopted by any type, regardless of where the type appears in the inheritance hierarchy. A type implements an interface by providing implementations for the members of the interface. An empty interface does not define any members. Therefore, it does not define a contract that can be implemented.
If your design includes empty interfaces that types are expected to implement, you are probably using an interface as a marker or a way to identify a group of types. If this identification will occur at run time, the correct way to accomplish this is to use a custom attribute. Use the presence or absence of the attribute, or the properties of the attribute, to identify the target types. If the identification must occur at compile time, then it is acceptable to use an empty interface.
Note that if an interface is empty but implements at least one other interface, it won't be matched by this rule. Such interface can be considered as not empty, since implementing it means that sub-interfaces members must be implemented.
• How to Fix Issues of this Rule: Remove the interface or add members to it. If the empty interface is being used to label a set of types, replace the interface with a custom attribute. The estimated Debt, which means the effort to fix such issue, is equal to 10 minutes to discard an empty interface plus 3 minutes per type implementing an empty interface.
• How to Suppress an Issue of this Rule: In source code, tag the concerned code element with this attribute: [SuppressMessage("NDepend", "ND1212:AvoidEmptyInterfaces", Justification="...")] This attribute requires the compilation symbol CODE_ANALYSIS to be set on each Visual Studio project relying on it. Without CODE_ANALYSIS symbol defined, the attribute is not compiled and the issues are not suppressed.
• How to Fix Issues of this Rule: Remove the interface or add members to it. If the empty interface is being used to label a set of types, replace the interface with a custom attribute. The estimated Debt, which means the effort to fix such issue, is equal to 10 minutes to discard an empty interface plus 3 minutes per type implementing an empty interface.
• How to Suppress an Issue of this Rule: In source code, tag the concerned code element with this attribute: [SuppressMessage("NDepend", "ND1212:AvoidEmptyInterfaces", Justification="...")] This attribute requires the compilation symbol CODE_ANALYSIS to be set on each Visual Studio project relying on it. Without CODE_ANALYSIS symbol defined, the attribute is not compiled and the issues are not suppressed.
1 type matched
-
Formatting: bold means added, underlined means code was changed,
strike-boldmeans removed (since baseline)
| 1 type | TypesThatImplementMe | Debt | Severity | Full Name |
|---|---|---|---|---|
| IAggregateRoot | 3 types | 19min | Medium | Microsoft.eShopWeb.ApplicationCore .Interfaces.IAggregateRoot |
| Validated Rule: Avoid types initialization cycles |
• Rule Description:
The class constructor (also called static constructor, and named cctor in IL code) of a type, if any, is executed by the CLR at runtime, the first time the type is used. A cctor doesn't need to be explicitly declared in C# or VB.NET, to exist in compiled IL code. Having a static field inline initialization is enough to have the cctor implicitly declared in the parent class or structure.
If the cctor of a type t1 is using the type t2 and if the cctor of t2 is using t1, some type initialization unexpected and hard-to-diagnose buggy behavior can occur. Such a cyclic chain of initialization is not necessarily limited to two types and can embrace N types in the general case. More information on types initialization cycles can be found here: http://codeblog.jonskeet.uk/2012/04/07/type-initializer-circular-dependencies/
The present code rule enumerates types initialization cycles. Some false positives can appear if some lambda expressions are defined in cctors or in methods called by cctors. In such situation, this rule considers these lambda expressions as executed at type initialization time, while it is not necessarily the case.
• How to Fix Issues of this Rule: Types initialization cycles create confusion and unexpected behaviors. If several states hold by several classes must be initialized during the first access of any of those classes, a better design option is to create a dedicated class whose responsibility is to initialize and hold all these states. The estimated Debt, which means the effort to fix such issue, is equal to 20 minutes per cycle plus 10 minutes per type class constructor involved in the cycle.
• How to Suppress an Issue of this Rule: In source code, tag the concerned code element with this attribute: [SuppressMessage("NDepend", "ND1213:AvoidTypesInitializationCycles", Justification="...")] This attribute requires the compilation symbol CODE_ANALYSIS to be set on each Visual Studio project relying on it. Without CODE_ANALYSIS symbol defined, the attribute is not compiled and the issues are not suppressed.
• How to Fix Issues of this Rule: Types initialization cycles create confusion and unexpected behaviors. If several states hold by several classes must be initialized during the first access of any of those classes, a better design option is to create a dedicated class whose responsibility is to initialize and hold all these states. The estimated Debt, which means the effort to fix such issue, is equal to 20 minutes per cycle plus 10 minutes per type class constructor involved in the cycle.
• How to Suppress an Issue of this Rule: In source code, tag the concerned code element with this attribute: [SuppressMessage("NDepend", "ND1213:AvoidTypesInitializationCycles", Justification="...")] This attribute requires the compilation symbol CODE_ANALYSIS to be set on each Visual Studio project relying on it. Without CODE_ANALYSIS symbol defined, the attribute is not compiled and the issues are not suppressed.
No method matched
API Breaking Changes
| Critical Rule Violated: API Breaking Changes: Types |
• Rule Description:
This rule is executed only if a baseline for comparison is defined (diff mode).
This rule warns if a type publicly visible in the baseline, is not publicly visible anymore or if it has been removed. Clients code using such type will be broken.
• How to Fix Issues of this Rule: Make sure that public types that used to be presented to clients, still remain public now, and in the future. If a public type must really be removed, you can tag it with System.ObsoleteAttribute with a workaround message during a few public releases, until it gets removed definitely. Notice that this rule doesn't match types removed that were tagged as obsolete. Issues of this rule have a severity equal to High because an API Breaking change can provoque significant friction with consumers of the API.
• How to Suppress an Issue of this Rule: In source code, tag the concerned code element with this attribute: [SuppressMessage("NDepend", "ND1500:APIBreakingChangesTypes", Justification="...")] This attribute requires the compilation symbol CODE_ANALYSIS to be set on each Visual Studio project relying on it. Without CODE_ANALYSIS symbol defined, the attribute is not compiled and the issues are not suppressed.
• How to Fix Issues of this Rule: Make sure that public types that used to be presented to clients, still remain public now, and in the future. If a public type must really be removed, you can tag it with System.ObsoleteAttribute with a workaround message during a few public releases, until it gets removed definitely. Notice that this rule doesn't match types removed that were tagged as obsolete. Issues of this rule have a severity equal to High because an API Breaking change can provoque significant friction with consumers of the API.
• How to Suppress an Issue of this Rule: In source code, tag the concerned code element with this attribute: [SuppressMessage("NDepend", "ND1500:APIBreakingChangesTypes", Justification="...")] This attribute requires the compilation symbol CODE_ANALYSIS to be set on each Visual Studio project relying on it. Without CODE_ANALYSIS symbol defined, the attribute is not compiled and the issues are not suppressed.
9 types matched
-
Formatting: bold means added, underlined means code was changed,
strike-boldmeans removed (since baseline)
| 9 types | NewVisibility | Debt | Severity | Full Name |
|---|---|---|---|---|
| 20min | High | Microsoft.eShopWeb.ApplicationCore .Interfaces.IRepository<T> | ||
| 20min | High | Microsoft.eShopWeb.Web.ViewComponents .Basket | ||
| 20min | High | Microsoft.eShopWeb.Web.Services .ICatalogService | ||
| 20min | High | Microsoft.eShopWeb.Web.Services .CachedCatalogService | ||
| 20min | High | Microsoft.eShopWeb.Web.Services .CatalogService | ||
| 20min | High | Microsoft.eShopWeb.Web.ViewModels .BasketItemViewModel | ||
| 20min | High | Microsoft.eShopWeb.Web.ViewModels .BasketViewModel | ||
| 20min | High | Microsoft.eShopWeb.Web.Controllers .BasketController | ||
| 20min | High | Microsoft.eShopWeb.Web.Controllers .CatalogController |
| Critical Rule Violated: API Breaking Changes: Methods |
• Rule Description:
This rule is executed only if a baseline for comparison is defined (diff mode).
This rule warns if a method publicly visible in the baseline, is not publicly visible anymore or if it has been removed. Clients code using such method will be broken.
• How to Fix Issues of this Rule: Make sure that public methods that used to be presented to clients, still remain public now, and in the future. If a public method must really be removed, you can tag it with System.ObsoleteAttribute with a workaround message during a few public releases, until it gets removed definitely. Notice that this rule doesn't match methods removed that were tagged as obsolete. Issues of this rule have a severity equal to High because an API Breaking change can provoque significant friction with consumers of the API.
• How to Suppress an Issue of this Rule: In source code, tag the concerned code element with this attribute: [SuppressMessage("NDepend", "ND1501:APIBreakingChangesMethods", Justification="...")] This attribute requires the compilation symbol CODE_ANALYSIS to be set on each Visual Studio project relying on it. Without CODE_ANALYSIS symbol defined, the attribute is not compiled and the issues are not suppressed.
• How to Fix Issues of this Rule: Make sure that public methods that used to be presented to clients, still remain public now, and in the future. If a public method must really be removed, you can tag it with System.ObsoleteAttribute with a workaround message during a few public releases, until it gets removed definitely. Notice that this rule doesn't match methods removed that were tagged as obsolete. Issues of this rule have a severity equal to High because an API Breaking change can provoque significant friction with consumers of the API.
• How to Suppress an Issue of this Rule: In source code, tag the concerned code element with this attribute: [SuppressMessage("NDepend", "ND1501:APIBreakingChangesMethods", Justification="...")] This attribute requires the compilation symbol CODE_ANALYSIS to be set on each Visual Studio project relying on it. Without CODE_ANALYSIS symbol defined, the attribute is not compiled and the issues are not suppressed.
15 methods matched
-
Formatting: bold means added, underlined means code was changed,
strike-boldmeans removed (since baseline)
| 15 methods | NewVisibility | Debt | Severity | Full Name |
|---|---|---|---|---|
| 10min | High | Microsoft.eShopWeb.ApplicationCore .Services.BasketService..ctor (IAsyncRepository<Basket>,IRepository <CatalogItem>,IUriComposer,IAppLogger <BasketService>) | ||
| 10min | High | Microsoft.eShopWeb.ApplicationCore .Interfaces.IOrderRepository .GetByIdWithItems(Int32) | ||
| 10min | High | Microsoft.eShopWeb.Infrastructure.Data .EfRepository<T>.GetById(Int32) | ||
| 10min | High | Microsoft.eShopWeb.Infrastructure.Data .EfRepository<T>.GetSingleBySpec (ISpecification<T>) | ||
| 10min | High | Microsoft.eShopWeb.Infrastructure.Data .EfRepository<T>.ListAll() | ||
| 10min | High | Microsoft.eShopWeb.Infrastructure.Data .EfRepository<T>.List(ISpecification<T>) | ||
| 10min | High | Microsoft.eShopWeb.Infrastructure.Data .EfRepository<T>.Add(T) | ||
| 10min | High | Microsoft.eShopWeb.Infrastructure.Data .EfRepository<T>.Update(T) | ||
| 10min | High | Microsoft.eShopWeb.Infrastructure.Data .EfRepository<T>.Delete(T) | ||
| 10min | High | Microsoft.eShopWeb.Infrastructure.Data .OrderRepository.GetByIdWithItems(Int32) | ||
| 10min | High | Microsoft.eShopWeb.Web.Startup.Configure (IApplicationBuilder,IHostingEnvironment ) | ||
| 10min | High | Microsoft.eShopWeb.Web.Services .BasketViewModelService..ctor (IAsyncRepository<Basket>,IRepository <CatalogItem>,IUriComposer) | ||
| 10min | High | Microsoft.eShopWeb.Web.Controllers .ManageController.Index() | ||
| 10min | High | Microsoft.eShopWeb.Web.Controllers .OrderController.Index() | ||
| 10min | High | Microsoft.eShopWeb.Web.Controllers.Api .CatalogController..ctor(ICatalogService ) |
| Critical Rule Violated: API Breaking Changes: Fields |
• Rule Description:
This rule is executed only if a baseline for comparison is defined (diff mode).
This rule warns if a field publicly visible in the baseline, is not publicly visible anymore or if it has been removed. Clients code using such field will be broken.
• How to Fix Issues of this Rule: Make sure that public fields that used to be presented to clients, still remain public now, and in the future. If a public field must really be removed, you can tag it with System.ObsoleteAttribute with a workaround message during a few public releases, until it gets removed definitely. Notice that this rule doesn't match fields removed that were tagged as obsolete. Issues of this rule have a severity equal to High because an API Breaking change can provoque significant friction with consumers of the API.
• How to Suppress an Issue of this Rule: In source code, tag the concerned code element with this attribute: [SuppressMessage("NDepend", "ND1502:APIBreakingChangesFields", Justification="...")] This attribute requires the compilation symbol CODE_ANALYSIS to be set on each Visual Studio project relying on it. Without CODE_ANALYSIS symbol defined, the attribute is not compiled and the issues are not suppressed.
• How to Fix Issues of this Rule: Make sure that public fields that used to be presented to clients, still remain public now, and in the future. If a public field must really be removed, you can tag it with System.ObsoleteAttribute with a workaround message during a few public releases, until it gets removed definitely. Notice that this rule doesn't match fields removed that were tagged as obsolete. Issues of this rule have a severity equal to High because an API Breaking change can provoque significant friction with consumers of the API.
• How to Suppress an Issue of this Rule: In source code, tag the concerned code element with this attribute: [SuppressMessage("NDepend", "ND1502:APIBreakingChangesFields", Justification="...")] This attribute requires the compilation symbol CODE_ANALYSIS to be set on each Visual Studio project relying on it. Without CODE_ANALYSIS symbol defined, the attribute is not compiled and the issues are not suppressed.
1 field matched
-
Formatting: bold means added, underlined means code was changed,
strike-boldmeans removed (since baseline)
| 1 field | NewVisibility | Debt | Severity | Full Name |
|---|---|---|---|---|
| _itemRepository | Private | 10min | High | Microsoft.eShopWeb.Web.Services .BasketViewModelService._itemRepository |
| Critical Rule Violated: API Breaking Changes: Interfaces and Abstract Classes |
• Rule Description:
This rule is executed only if a baseline for comparison is defined (diff mode).
This rule warns if a publicly visible interface or abstract class has been changed and contains new abstract methods or if some abstract methods have been removed.
Clients code that implement such interface or derive from such abstract class will be broken.
• How to Fix Issues of this Rule: Make sure that the public contracts of interfaces and abstract classes that used to be presented to clients, remain stable now, and in the future. If a public contract must really be changed, you can tag abstract methods that will be removed with System.ObsoleteAttribute with a workaround message during a few public releases, until it gets removed definitely. Issues of this rule have a severity equal to High because an API Breaking change can provoque significant friction with consummers of the API. The severity is not set to Critical because an interface is not necessarily meant to be implemented by the consummer of the API.
• How to Suppress an Issue of this Rule: In source code, tag the concerned code element with this attribute: [SuppressMessage("NDepend", "ND1503:APIBreakingChangesInterfacesAndAbstractClasses", Justification="...")] This attribute requires the compilation symbol CODE_ANALYSIS to be set on each Visual Studio project relying on it. Without CODE_ANALYSIS symbol defined, the attribute is not compiled and the issues are not suppressed.
• How to Fix Issues of this Rule: Make sure that the public contracts of interfaces and abstract classes that used to be presented to clients, remain stable now, and in the future. If a public contract must really be changed, you can tag abstract methods that will be removed with System.ObsoleteAttribute with a workaround message during a few public releases, until it gets removed definitely. Issues of this rule have a severity equal to High because an API Breaking change can provoque significant friction with consummers of the API. The severity is not set to Critical because an interface is not necessarily meant to be implemented by the consummer of the API.
• How to Suppress an Issue of this Rule: In source code, tag the concerned code element with this attribute: [SuppressMessage("NDepend", "ND1503:APIBreakingChangesInterfacesAndAbstractClasses", Justification="...")] This attribute requires the compilation symbol CODE_ANALYSIS to be set on each Visual Studio project relying on it. Without CODE_ANALYSIS symbol defined, the attribute is not compiled and the issues are not suppressed.
3 types matched
-
Formatting: bold means added, underlined means code was changed,
strike-boldmeans removed (since baseline)
| 3 types | methodsAdded | methodsRemoved | Debt | Severity | Full Name |
|---|---|---|---|---|---|
| IAsyncRepository<T> | 1 method | no method | 10min | High | Microsoft.eShopWeb.ApplicationCore .Interfaces.IAsyncRepository<T> |
| IOrderRepository | no method | 1 method | 10min | High | Microsoft.eShopWeb.ApplicationCore .Interfaces.IOrderRepository |
| ISpecification<T> | 5 methods | no method | 10min | High | Microsoft.eShopWeb.ApplicationCore .Interfaces.ISpecification<T> |
| Validated Rule: Broken serializable types |
• Rule Description:
This rule is executed only if a baseline for comparison is defined (diff mode).
This rule warns about breaking changes in types tagged with SerializableAttribute.
To do so, this rule searches for serializable type with serializable instance fields added or removed. Notice that it doesn't take account of fields tagged with NonSerializedAttribute.
From http://msdn.microsoft.com/library/system.serializableattribute.aspx : "All the public and private fields in a type that are marked by the SerializableAttribute are serialized by default, unless the type implements the ISerializable interface to override the serialization process. The default serialization process excludes fields that are marked with the NonSerializedAttribute attribute."
• How to Fix Issues of this Rule: Make sure that the serialization process of serializable types remains stable now, and in the future. Else you'll have to deal with Version Tolerant Serialization that is explained here: https://msdn.microsoft.com/en-us/library/ms229752(v=vs.110).aspx Issues of this rule have a severity equal to High because an API Breaking change can provoque significant friction with consummers of the API.
• How to Suppress an Issue of this Rule: In source code, tag the concerned code element with this attribute: [SuppressMessage("NDepend", "ND1504:BrokenSerializableTypes", Justification="...")] This attribute requires the compilation symbol CODE_ANALYSIS to be set on each Visual Studio project relying on it. Without CODE_ANALYSIS symbol defined, the attribute is not compiled and the issues are not suppressed.
• How to Fix Issues of this Rule: Make sure that the serialization process of serializable types remains stable now, and in the future. Else you'll have to deal with Version Tolerant Serialization that is explained here: https://msdn.microsoft.com/en-us/library/ms229752(v=vs.110).aspx Issues of this rule have a severity equal to High because an API Breaking change can provoque significant friction with consummers of the API.
• How to Suppress an Issue of this Rule: In source code, tag the concerned code element with this attribute: [SuppressMessage("NDepend", "ND1504:BrokenSerializableTypes", Justification="...")] This attribute requires the compilation symbol CODE_ANALYSIS to be set on each Visual Studio project relying on it. Without CODE_ANALYSIS symbol defined, the attribute is not compiled and the issues are not suppressed.
No type matched
| Validated Rule: Avoid changing enumerations Flags status |
• Rule Description:
This rule is executed only if a baseline for comparison is defined (diff mode).
This rule matches enumeration types that used to be tagged with FlagsAttribute in the baseline, and not anymore. It also matches the opposite, enumeration types that are now tagged with FlagsAttribute, and were not tagged in the baseline.
Being tagged with FlagsAttribute is a strong property for an enumeration. Not so much in terms of behavior (only the enum.ToString() method behavior changes when an enumeration is tagged with FlagsAttribute) but in terms of meaning: is the enumeration a range of values or a range of flags?
As a consequence, changing the FlagsAttributes status of an enumeration can have significant impact for its clients.
• How to Fix Issues of this Rule: Make sure the FlagsAttribute status of each enumeration remains stable now, and in the future.
• How to Suppress an Issue of this Rule: In source code, tag the concerned code element with this attribute: [SuppressMessage("NDepend", "ND1505:AvoidChangingEnumerationsFlagsStatus", Justification="...")] This attribute requires the compilation symbol CODE_ANALYSIS to be set on each Visual Studio project relying on it. Without CODE_ANALYSIS symbol defined, the attribute is not compiled and the issues are not suppressed.
• How to Fix Issues of this Rule: Make sure the FlagsAttribute status of each enumeration remains stable now, and in the future.
• How to Suppress an Issue of this Rule: In source code, tag the concerned code element with this attribute: [SuppressMessage("NDepend", "ND1505:AvoidChangingEnumerationsFlagsStatus", Justification="...")] This attribute requires the compilation symbol CODE_ANALYSIS to be set on each Visual Studio project relying on it. Without CODE_ANALYSIS symbol defined, the attribute is not compiled and the issues are not suppressed.
No type matched
Code Coverage
| Rule Violated: Code should be tested |
• Rule Description:
This rule lists methods not covered at all by test or partially covered by tests.
For each match, the rules estimates the technical debt, i.e the effort to write unit and integration tests for the method. The estimation is based on the effort to develop the code element multiplied by factors in the range ]0,1.3] based on
• the method code size and complexity
• the actual percentage coverage
• the abstractness of types used, because relying on classes instead of interfaces makes the code more difficult to test
• the method visibility because testing private or protected methods is more difficult than testing public and internal ones
• the fields used by the method, because is is more complicated to write tests for methods that read mutable static fields whose changing state is shared across tests executions.
• whether the method is considered JustMyCode or not because NotMyCode is often generated easier to get tested since tests can be generated as well.
This rule is necessarily a large source of technical debt, since the code left untested is by definition part of the technical debt.
This rule also estimates the annual interest, i.e the annual cost to let the code uncovered, based on the effort to develop the code element, multiplied by factors based on usage of the code element.
• How to Fix Issues of this Rule: Write unit tests to test and cover the methods and their parent classes matched by this rule.
• How to Suppress an Issue of this Rule: In source code, tag the concerned code element with this attribute: [SuppressMessage("NDepend", "ND1600:CodeShouldBeTested", Justification="...")] This attribute requires the compilation symbol CODE_ANALYSIS to be set on each Visual Studio project relying on it. Without CODE_ANALYSIS symbol defined, the attribute is not compiled and the issues are not suppressed.
• How to Fix Issues of this Rule: Write unit tests to test and cover the methods and their parent classes matched by this rule.
• How to Suppress an Issue of this Rule: In source code, tag the concerned code element with this attribute: [SuppressMessage("NDepend", "ND1600:CodeShouldBeTested", Justification="...")] This attribute requires the compilation symbol CODE_ANALYSIS to be set on each Visual Studio project relying on it. Without CODE_ANALYSIS symbol defined, the attribute is not compiled and the issues are not suppressed.
238 methods matched
- The following list of methods is truncated and contains only the first 100 methods of the 238 methods matched.
-
Formatting: bold means added, underlined means code was changed,
strike-boldmeans removed (since baseline)
| 238 methods | Percentage Coverage | # lines of code (LOC) | # lines of code not covered | Cyclomatic Complexity (CC) | Debt | Annual Interest | Full Name |
|---|---|---|---|---|---|---|---|
| PageNavClass(ViewContext,String) | 0% | 2 | 2 | 2 | 6min | 18min | Microsoft.eShopWeb.Web.Views.Manage .ManageNavPages.PageNavClass(ViewContext ,String) |
| GetQuery(IQueryable<T>,ISpecification<T> ) | 64.29% | 14 | 5 | 7 | 26min | 16min | Microsoft.eShopWeb.Infrastructure.Data .SpecificationEvaluator<T>.GetQuery (IQueryable<T>,ISpecification<T>) |
| Up(MigrationBuilder) | 0% | 33 | 33 | 15 | 3h 46min | 10min | Microsoft.eShopWeb.Infrastructure .Identity.Migrations .InitialIdentityModel.Up (MigrationBuilder) |
| Up(MigrationBuilder) | 0% | 32 | 32 | 15 | 3h 39min | 10min | Microsoft.eShopWeb.Infrastructure.Data .Migrations.Initial.Up(MigrationBuilder) |
| BuildTargetModel(ModelBuilder) | 0% | 75 | 75 | 12 | 3h 22min | 9min | Microsoft.eShopWeb.Infrastructure .Identity.Migrations .InitialIdentityModel.BuildTargetModel (ModelBuilder) |
| BuildModel(ModelBuilder) | 0% | 75 | 75 | 12 | 3h 22min | 9min | Microsoft.eShopWeb.Infrastructure .Identity.Migrations .AppIdentityDbContextModelSnapshot .BuildModel(ModelBuilder) |
| BuildTargetModel(ModelBuilder) | 0% | 75 | 75 | 14 | 3h 22min | 9min | Microsoft.eShopWeb.Infrastructure.Data .Migrations.Initial.BuildTargetModel (ModelBuilder) |
| BuildTargetModel(ModelBuilder) | 0% | 75 | 75 | 14 | 3h 22min | 9min | Microsoft.eShopWeb.Infrastructure.Data .Migrations.AddExtraConstraints .BuildTargetModel(ModelBuilder) |
| BuildModel(ModelBuilder) | 0% | 75 | 75 | 14 | 3h 22min | 9min | Microsoft.eShopWeb.Infrastructure.Data .Migrations.CatalogContextModelSnapshot .BuildModel(ModelBuilder) |
| set_OrderBy(Expression<Func<T,Object>>) | 0% | 1 | 1 | 1 | 2min 45s | 9min | Microsoft.eShopWeb.ApplicationCore .Specifications.BaseSpecification<T> .set_OrderBy(Expression<Func<T,Object>>) |
| set_OrderByDescending(Expression<Func<T ,Object>>) | 0% | 1 | 1 | 1 | 2min 45s | 9min | Microsoft.eShopWeb.ApplicationCore .Specifications.BaseSpecification<T> .set_OrderByDescending(Expression<Func<T ,Object>>) |
| SeedAsync(CatalogContext,ILoggerFactory ,Nullable<Int32>) | 56.25% | 16 | 7 | 6 | 32min | 6min | Microsoft.eShopWeb.Infrastructure.Data .CatalogContextSeed.SeedAsync (CatalogContext,ILoggerFactory,Nullable <Int32>) |
| get_ActivePageKey() | 0% | 1 | 1 | 1 | 2min 17s | 6min | Microsoft.eShopWeb.Web.Views.Manage .ManageNavPages.get_ActivePageKey() |
| get_Index() | 0% | 1 | 1 | 1 | 2min 17s | 6min | Microsoft.eShopWeb.Web.Views.Manage .ManageNavPages.get_Index() |
| get_ChangePassword() | 0% | 1 | 1 | 1 | 2min 17s | 6min | Microsoft.eShopWeb.Web.Views.Manage .ManageNavPages.get_ChangePassword() |
| get_ExternalLogins() | 0% | 1 | 1 | 1 | 2min 17s | 6min | Microsoft.eShopWeb.Web.Views.Manage .ManageNavPages.get_ExternalLogins() |
| get_TwoFactorAuthentication() | 0% | 1 | 1 | 1 | 2min 17s | 6min | Microsoft.eShopWeb.Web.Views.Manage .ManageNavPages .get_TwoFactorAuthentication() |
| get_RequestId() | 0% | 1 | 1 | 1 | 2min 17s | 6min | Microsoft.eShopWeb.Web.Pages.ErrorModel .get_RequestId() |
| GetOrSetBasketCookieAndUserName() | 0% | 8 | 8 | 3 | 30min | 6min | Microsoft.eShopWeb.Web.Pages.Basket .CheckoutModel .GetOrSetBasketCookieAndUserName() |
| .ctor() | 0% | 2 | 2 | 1 | 4min 8s | 6min | Microsoft.eShopWeb.ApplicationCore .Entities.BuyerAggregate.Buyer..ctor() |
| FormatKey(String) | 0% | 8 | 8 | 3 | 30min | 5min | Microsoft.eShopWeb.Web.Controllers .ManageController.FormatKey(String) |
| Index(IndexViewModel) | 0% | 17 | 17 | 7 | 1h 29min | 5min | Microsoft.eShopWeb.Web.Controllers .ManageController.Index(IndexViewModel) |
| LoginWith2fa(LoginWith2faViewModel ,Boolean,String) | 0% | 16 | 16 | 5 | 1h 25min | 5min | Microsoft.eShopWeb.Web.Controllers .AccountController.LoginWith2fa (LoginWith2faViewModel,Boolean,String) |
| AddErrors(IdentityResult) | 0% | 5 | 5 | 2 | 26min | 5min | Microsoft.eShopWeb.Web.Controllers .ManageController.AddErrors (IdentityResult) |
| ListAllRegisteredServices (IApplicationBuilder,LinkGenerator) | 11.54% | 26 | 23 | 4 | 38min | 4min 46s | Microsoft.eShopWeb.Web.Startup .ListAllRegisteredServices (IApplicationBuilder,LinkGenerator) |
| SetBasketModelAsync() | 50% | 4 | 2 | 2 | 6min | 4min 42s | Microsoft.eShopWeb.Web.Pages.Basket .IndexModel.SetBasketModelAsync() |
| OnPostAsync(String) | 0% | 14 | 14 | 6 | 1h 26min | 4min 41s | Microsoft.eShopWeb.Web.Areas.Identity .Pages.Account.LoginModel.OnPostAsync (String) |
| ConfigureInMemoryDatabases (IServiceCollection) | 60% | 5 | 2 | 3 | 3min 12s | 4min 29s | Microsoft.eShopWeb.Web.Startup .ConfigureInMemoryDatabases (IServiceCollection) |
| CreateOrderAsync(Int32,Address) | 0% | 13 | 13 | 2 | 31min | 4min 22s | Microsoft.eShopWeb.ApplicationCore .Services.OrderService.CreateOrderAsync (Int32,Address) |
| ChangePassword(ChangePasswordViewModel) | 0% | 13 | 13 | 4 | 46min | 4min 22s | Microsoft.eShopWeb.Web.Controllers .ManageController.ChangePassword (ChangePasswordViewModel) |
| EnableAuthenticator (EnableAuthenticatorViewModel) | 0% | 13 | 13 | 4 | 1h 0min | 4min 22s | Microsoft.eShopWeb.Web.Controllers .ManageController.EnableAuthenticator (EnableAuthenticatorViewModel) |
| set_IdentityGuid(String) | 0% | 1 | 1 | 1 | 2min 45s | 4min 13s | Microsoft.eShopWeb.ApplicationCore .Entities.BuyerAggregate.Buyer .set_IdentityGuid(String) |
| set_Code(String) | 0% | 1 | 1 | 1 | 2min 17s | 4min 13s | Microsoft.eShopWeb.Web.ViewModels .Account.ResetPasswordViewModel.set_Code (String) |
| Main(String[]) | 0% | 12 | 12 | 2 | 36min | 4min 3s | Microsoft.eShopWeb.Web.Program.Main (String[]) |
| SetPassword(SetPasswordViewModel) | 0% | 12 | 12 | 4 | 43min | 4min 3s | Microsoft.eShopWeb.Web.Controllers .ManageController.SetPassword (SetPasswordViewModel) |
| LinkLoginCallback() | 0% | 12 | 12 | 4 | 56min | 4min 3s | Microsoft.eShopWeb.Web.Controllers .ManageController.LinkLoginCallback() |
| AddErrors(IdentityResult) | 0% | 5 | 5 | 2 | 20min | 3min 46s | Microsoft.eShopWeb.Web.Controllers .AccountController.AddErrors (IdentityResult) |
| SendVerificationEmail(IndexViewModel) | 0% | 11 | 11 | 3 | 33min | 3min 44s | Microsoft.eShopWeb.Web.Controllers .ManageController.SendVerificationEmail (IndexViewModel) |
| SetBasketModelAsync() | 0% | 4 | 4 | 2 | 13min | 3min 44s | Microsoft.eShopWeb.Web.Pages.Basket .CheckoutModel.SetBasketModelAsync() |
| set_RequestId(String) | 0% | 1 | 1 | 1 | 2min 17s | 3min 38s | Microsoft.eShopWeb.Web.Pages.ErrorModel .set_RequestId(String) |
| set_StatusMessage(String) | 0% | 1 | 1 | 1 | 2min 17s | 3min 35s | Microsoft.eShopWeb.Web.Controllers .ManageController.set_StatusMessage (String) |
| GetBasketItemCountAsync(String) | 0% | 10 | 10 | 3 | 30min | 3min 26s | Microsoft.eShopWeb.ApplicationCore .Services.BasketService .GetBasketItemCountAsync(String) |
| Down(MigrationBuilder) | 0% | 10 | 10 | 1 | 13min | 3min 26s | Microsoft.eShopWeb.Infrastructure.Data .Migrations.Initial.Down (MigrationBuilder) |
| ExternalLogins() | 0% | 10 | 10 | 5 | 42min | 3min 26s | Microsoft.eShopWeb.Web.Controllers .ManageController.ExternalLogins() |
| SetQuantities(Int32,Dictionary<String ,Int32>) | 9.09% | 11 | 10 | 3 | 30min | 3min 24s | Microsoft.eShopWeb.ApplicationCore .Services.BasketService.SetQuantities (Int32,Dictionary<String,Int32>) |
| CheckHealthAsync(HealthCheckContext ,CancellationToken) | 0% | 9 | 9 | 2 | 22min | 3min 7s | Microsoft.eShopWeb.Web.HealthChecks .ApiHealthCheck.CheckHealthAsync (HealthCheckContext,CancellationToken) |
| RemoveLogin(RemoveLoginViewModel) | 0% | 9 | 9 | 3 | 27min | 3min 7s | Microsoft.eShopWeb.Web.Controllers .ManageController.RemoveLogin (RemoveLoginViewModel) |
| EnableAuthenticator() | 0% | 9 | 9 | 3 | 27min | 3min 7s | Microsoft.eShopWeb.Web.Controllers .ManageController.EnableAuthenticator() |
| GenerateRecoveryCodes() | 0% | 9 | 9 | 3 | 27min | 3min 7s | Microsoft.eShopWeb.Web.Controllers .ManageController.GenerateRecoveryCodes( ) |
| get_StatusMessage() | 0% | 1 | 1 | 1 | 2min 17s | 3min 3s | Microsoft.eShopWeb.Web.Controllers .ManageController.get_StatusMessage() |
| CheckHealthAsync(HealthCheckContext ,CancellationToken) | 0% | 8 | 8 | 2 | 20min | 2min 48s | Microsoft.eShopWeb.Web.HealthChecks .HomePageHealthCheck.CheckHealthAsync (HealthCheckContext,CancellationToken) |
| .ctor(IBasketService ,IBasketViewModelService,IUriComposer ,SignInManager<ApplicationUser> ,IOrderService) | 0% | 8 | 8 | 1 | 10min | 2min 48s | Microsoft.eShopWeb.Web.Pages.Basket .CheckoutModel..ctor(IBasketService ,IBasketViewModelService,IUriComposer ,SignInManager<ApplicationUser> ,IOrderService) |
| Register(RegisterViewModel,String) | 0% | 8 | 8 | 3 | 25min | 2min 48s | Microsoft.eShopWeb.Web.Controllers .AccountController.Register (RegisterViewModel,String) |
| ChangePassword() | 0% | 8 | 8 | 3 | 25min | 2min 48s | Microsoft.eShopWeb.Web.Controllers .ManageController.ChangePassword() |
| SetPassword() | 0% | 8 | 8 | 3 | 25min | 2min 48s | Microsoft.eShopWeb.Web.Controllers .ManageController.SetPassword() |
| Disable2fa() | 0% | 8 | 8 | 3 | 25min | 2min 48s | Microsoft.eShopWeb.Web.Controllers .ManageController.Disable2fa() |
| Detail(Int32) | 0% | 8 | 8 | 4 | 38min | 2min 48s | Microsoft.eShopWeb.Web.Controllers .OrderController.Detail(Int32) |
| .ctor(String) | 0% | 3 | 3 | 1 | 6min | 2min 44s | Microsoft.eShopWeb.ApplicationCore .Specifications .CustomerOrdersWithItemsSpecification. .ctor(String) |
| Down(MigrationBuilder) | 0% | 7 | 7 | 1 | 10min | 2min 29s | Microsoft.eShopWeb.Infrastructure .Identity.Migrations .InitialIdentityModel.Down (MigrationBuilder) |
| ConfirmEmail(String,String) | 0% | 7 | 7 | 5 | 30min | 2min 29s | Microsoft.eShopWeb.Web.Controllers .AccountController.ConfirmEmail(String ,String) |
| ResetAuthenticator() | 0% | 7 | 7 | 2 | 17min | 2min 29s | Microsoft.eShopWeb.Web.Controllers .ManageController.ResetAuthenticator() |
| SignIn(LoginViewModel,String) | 50% | 14 | 7 | 5 | 37min | 2min 20s | Microsoft.eShopWeb.Web.Controllers .AccountController.SignIn(LoginViewModel ,String) |
| NullBasket(IGuardClause,Int32,Basket) | 50% | 2 | 1 | 2 | 3min 21s | 2min 12s | Ardalis.GuardClauses.BasketGuards .NullBasket(IGuardClause,Int32,Basket) |
| AddInclude(String) | 0% | 1 | 1 | 1 | 2min 31s | 2min 11s | Microsoft.eShopWeb.ApplicationCore .Specifications.BaseSpecification<T> .AddInclude(String) |
| Up(MigrationBuilder) | 0% | 6 | 6 | 1 | 8min | 2min 11s | Microsoft.eShopWeb.Infrastructure.Data .Migrations.AddExtraConstraints.Up (MigrationBuilder) |
| Down(MigrationBuilder) | 0% | 6 | 6 | 1 | 8min | 2min 11s | Microsoft.eShopWeb.Infrastructure.Data .Migrations.AddExtraConstraints.Down (MigrationBuilder) |
| LoginWith2fa(Boolean,String) | 0% | 6 | 6 | 2 | 15min | 2min 11s | Microsoft.eShopWeb.Web.Controllers .AccountController.LoginWith2fa(Boolean ,String) |
| .ctor(UserManager<ApplicationUser> ,SignInManager<ApplicationUser> ,IEmailSender,IAppLogger <ManageController>,UrlEncoder) | 0% | 6 | 6 | 1 | 8min | 2min 11s | Microsoft.eShopWeb.Web.Controllers .ManageController..ctor(UserManager <ApplicationUser>,SignInManager <ApplicationUser>,IEmailSender ,IAppLogger<ManageController>,UrlEncoder ) |
| Disable2faWarning() | 0% | 6 | 6 | 3 | 19min | 2min 11s | Microsoft.eShopWeb.Web.Controllers .ManageController.Disable2faWarning() |
| TransferBasketAsync(String,String) | 25% | 8 | 6 | 2 | 15min | 2min 6s | Microsoft.eShopWeb.ApplicationCore .Services.BasketService .TransferBasketAsync(String,String) |
| ApplyOrderBy(Expression<Func<T,Object>>) | 0% | 1 | 1 | 1 | 2min 31s | 2min 0s | Microsoft.eShopWeb.ApplicationCore .Specifications.BaseSpecification<T> .ApplyOrderBy(Expression<Func<T,Object>> ) |
| ApplyOrderByDescending(Expression<Func<T ,Object>>) | 0% | 1 | 1 | 1 | 2min 31s | 2min 0s | Microsoft.eShopWeb.ApplicationCore .Specifications.BaseSpecification<T> .ApplyOrderByDescending(Expression<Func <T,Object>>) |
| .ctor(IAsyncRepository<Basket> ,IAsyncRepository<CatalogItem> ,IAsyncRepository<Order>) | 0% | 4 | 4 | 1 | 5min | 2min 0s | Microsoft.eShopWeb.ApplicationCore .Services.OrderService..ctor (IAsyncRepository<Basket> ,IAsyncRepository<CatalogItem> ,IAsyncRepository<Order>) |
| .ctor(SerializationInfo,StreamingContext ) | 0% | 1 | 1 | 1 | 2min 31s | 2min 0s | Microsoft.eShopWeb.ApplicationCore .Exceptions.BasketNotFoundException. .ctor(SerializationInfo,StreamingContext ) |
| .ctor(String) | 0% | 1 | 1 | 1 | 2min 17s | 2min 0s | Microsoft.eShopWeb.ApplicationCore .Exceptions.BasketNotFoundException. .ctor(String) |
| .ctor(String,Exception) | 0% | 1 | 1 | 1 | 2min 17s | 2min 0s | Microsoft.eShopWeb.ApplicationCore .Exceptions.BasketNotFoundException. .ctor(String,Exception) |
| set_OrderDate(DateTimeOffset) | 0% | 1 | 1 | 1 | 2min 45s | 2min 0s | Microsoft.eShopWeb.ApplicationCore .Entities.OrderAggregate.Order .set_OrderDate(DateTimeOffset) |
| get_IdentityGuid() | 0% | 1 | 1 | 1 | 2min 17s | 2min 0s | Microsoft.eShopWeb.ApplicationCore .Entities.BuyerAggregate.Buyer .get_IdentityGuid() |
| get_PaymentMethods() | 0% | 1 | 1 | 1 | 2min 17s | 2min 0s | Microsoft.eShopWeb.ApplicationCore .Entities.BuyerAggregate.Buyer .get_PaymentMethods() |
| .ctor(String) | 0% | 3 | 3 | 1 | 4min 35s | 2min 0s | Microsoft.eShopWeb.ApplicationCore .Entities.BuyerAggregate.Buyer..ctor (String) |
| get_Alias() | 0% | 1 | 1 | 1 | 2min 17s | 2min 0s | Microsoft.eShopWeb.ApplicationCore .Entities.BuyerAggregate.PaymentMethod .get_Alias() |
| set_Alias(String) | 0% | 1 | 1 | 1 | 2min 17s | 2min 0s | Microsoft.eShopWeb.ApplicationCore .Entities.BuyerAggregate.PaymentMethod .set_Alias(String) |
| get_CardId() | 0% | 1 | 1 | 1 | 2min 17s | 2min 0s | Microsoft.eShopWeb.ApplicationCore .Entities.BuyerAggregate.PaymentMethod .get_CardId() |
| set_CardId(String) | 0% | 1 | 1 | 1 | 2min 17s | 2min 0s | Microsoft.eShopWeb.ApplicationCore .Entities.BuyerAggregate.PaymentMethod .set_CardId(String) |
| get_Last4() | 0% | 1 | 1 | 1 | 2min 17s | 2min 0s | Microsoft.eShopWeb.ApplicationCore .Entities.BuyerAggregate.PaymentMethod .get_Last4() |
| set_Last4(String) | 0% | 1 | 1 | 1 | 2min 17s | 2min 0s | Microsoft.eShopWeb.ApplicationCore .Entities.BuyerAggregate.PaymentMethod .set_Last4(String) |
| SendEmailAsync(String,String,String) | 0% | 1 | 1 | 1 | 2min 17s | 2min 0s | Microsoft.eShopWeb.Infrastructure .Services.EmailSender.SendEmailAsync (String,String,String) |
| LogWarning(String,Object[]) | 0% | 1 | 1 | 1 | 2min 17s | 2min 0s | Microsoft.eShopWeb.Infrastructure .Logging.LoggerAdapter<T>.LogWarning (String,Object[]) |
| LogInformation(String,Object[]) | 0% | 1 | 1 | 1 | 2min 17s | 2min 0s | Microsoft.eShopWeb.Infrastructure .Logging.LoggerAdapter<T>.LogInformation (String,Object[]) |
| get_Baskets() | 0% | 1 | 1 | 1 | 2min 17s | 2min 0s | Microsoft.eShopWeb.Infrastructure.Data .CatalogContext.get_Baskets() |
| get_OrderItems() | 0% | 1 | 1 | 1 | 2min 17s | 2min 0s | Microsoft.eShopWeb.Infrastructure.Data .CatalogContext.get_OrderItems() |
| EmailConfirmationLink(IUrlHelper,String ,String,String) | 0% | 1 | 1 | 1 | 2min 17s | 2min 0s | Microsoft.AspNetCore.Mvc .UrlHelperExtensions .EmailConfirmationLink(IUrlHelper,String ,String,String) |
| ResetPasswordCallbackLink(IUrlHelper ,String,String,String) | 0% | 1 | 1 | 1 | 2min 17s | 2min 0s | Microsoft.AspNetCore.Mvc .UrlHelperExtensions .ResetPasswordCallbackLink(IUrlHelper ,String,String,String) |
| TransformOutbound(Object) | 66.67% | 3 | 1 | 2 | 2min 59s | 2min 0s | Microsoft.eShopWeb.Web .SlugifyParameterTransformer .TransformOutbound(Object) |
| ConfigureProductionServices (IServiceCollection) | 0% | 5 | 5 | 3 | 6min | 2min 0s | Microsoft.eShopWeb.Web.Startup .ConfigureProductionServices (IServiceCollection) |
| CreateIdentityIfNotCreated (IServiceCollection) | 60% | 5 | 2 | 2 | 3min 12s | 2min 0s | Microsoft.eShopWeb.Web.Startup .CreateIdentityIfNotCreated (IServiceCollection) |
| Configure(IApplicationBuilder ,IHostingEnvironment,LinkGenerator) | 66.67% | 21 | 7 | 6 | 12min | 2min 0s | Microsoft.eShopWeb.Web.Startup.Configure (IApplicationBuilder,IHostingEnvironment ,LinkGenerator) |
| .ctor(IHttpContextAccessor,LinkGenerator ) | 0% | 3 | 3 | 1 | 4min 35s | 2min 0s | Microsoft.eShopWeb.Web.HealthChecks .ApiHealthCheck..ctor (IHttpContextAccessor,LinkGenerator) |
| .ctor(IHttpContextAccessor) | 0% | 2 | 2 | 1 | 3min 26s | 2min 0s | Microsoft.eShopWeb.Web.HealthChecks .HomePageHealthCheck..ctor (IHttpContextAccessor) |
| SendEmailConfirmationAsync(IEmailSender ,String,String) | 0% | 1 | 1 | 1 | 2min 17s | 2min 0s | Microsoft.eShopWeb.Web.Services .EmailSenderExtensions .SendEmailConfirmationAsync(IEmailSender ,String,String) |
Statistics
| Stat | Percentage Coverage | # lines of code (LOC) | # lines of code not covered | Cyclomatic Complexity (CC) | Debt | Annual Interest |
|---|---|---|---|---|---|---|
| Sum: | 836.17 | 1 152 | 1 082 | 449 | 7d 0h | 1d 3h |
| Average: | 3.51 | 4.84 | 4.55 | 1.89 | 14min | 2min 53s |
| Minimum: | 0 | 0 | 0 | 1 | 2min 0s | 2min 0s |
| Maximum: | 66.67 | 75 | 75 | 15 | 3h 46min | 18min |
| Standard deviation: | 13.99 | 11.34 | 11.23 | 2.35 | 36min | 2min 12s |
| Variance: | 195.66 | 128.7 | 126.07 | 5.54 | 166d | 4h 51min |
| Rule Violated: New Methods should be tested |
• Rule Description:
This rule is executed only if a baseline for comparison is defined (diff mode). This rule operates only on methods added or refactored since the baseline.
This rule is executed only if some code coverage data is imported from some code coverage files.
It is important to write code mostly covered by tests to achieve maintainable and non-error-prone code.
In real-world, many code bases are poorly covered by tests. However it is not practicable to stop the development for months to refactor and write tests to achieve high code coverage ratio.
Hence it is recommended that each time a method (or a type) gets added, the developer takes the time to write associated unit-tests to cover it.
Doing so will help to increase significantly the maintainability of the code base. You'll notice that quickly, refactoring will also be driven by testability, and as a consequence, the overall code structure and design will increase as well.
Issues of this rule have a High severity because they reflect an actual trend to not care about writing tests on refactored code.
• How to Fix Issues of this Rule: Write unit-tests to cover the code of most methods and classes added.
• How to Suppress an Issue of this Rule: In source code, tag the concerned code element with this attribute: [SuppressMessage("NDepend", "ND1601:NewMethodsShouldBeTested", Justification="...")] This attribute requires the compilation symbol CODE_ANALYSIS to be set on each Visual Studio project relying on it. Without CODE_ANALYSIS symbol defined, the attribute is not compiled and the issues are not suppressed.
• How to Fix Issues of this Rule: Write unit-tests to cover the code of most methods and classes added.
• How to Suppress an Issue of this Rule: In source code, tag the concerned code element with this attribute: [SuppressMessage("NDepend", "ND1601:NewMethodsShouldBeTested", Justification="...")] This attribute requires the compilation symbol CODE_ANALYSIS to be set on each Visual Studio project relying on it. Without CODE_ANALYSIS symbol defined, the attribute is not compiled and the issues are not suppressed.
40 methods matched
-
Formatting: bold means added, underlined means code was changed,
strike-boldmeans removed (since baseline)
| 40 methods | Percentage Coverage | # lines of code (LOC) | # lines of code not covered | Debt | Severity | Full Name |
|---|---|---|---|---|---|---|
| BuildTargetModel(ModelBuilder) | 0% | 75 | 75 | 10min | High | Microsoft.eShopWeb.Infrastructure.Data .Migrations.AddExtraConstraints .BuildTargetModel(ModelBuilder) |
| ListAllRegisteredServices (IApplicationBuilder,LinkGenerator) | 11.54% | 26 | 23 | 10min | High | Microsoft.eShopWeb.Web.Startup .ListAllRegisteredServices (IApplicationBuilder,LinkGenerator) |
| OnPostAsync(String) | 0% | 14 | 14 | 10min | High | Microsoft.eShopWeb.Web.Areas.Identity .Pages.Account.LoginModel.OnPostAsync (String) |
| CheckHealthAsync(HealthCheckContext ,CancellationToken) | 0% | 9 | 9 | 9min | High | Microsoft.eShopWeb.Web.HealthChecks .ApiHealthCheck.CheckHealthAsync (HealthCheckContext,CancellationToken) |
| CheckHealthAsync(HealthCheckContext ,CancellationToken) | 0% | 8 | 8 | 8min | High | Microsoft.eShopWeb.Web.HealthChecks .HomePageHealthCheck.CheckHealthAsync (HealthCheckContext,CancellationToken) |
| .ctor(IBasketService ,IBasketViewModelService,IUriComposer ,SignInManager<ApplicationUser> ,IOrderService) | 0% | 8 | 8 | 8min | High | Microsoft.eShopWeb.Web.Pages.Basket .CheckoutModel..ctor(IBasketService ,IBasketViewModelService,IUriComposer ,SignInManager<ApplicationUser> ,IOrderService) |
| GetOrSetBasketCookieAndUserName() | 0% | 8 | 8 | 8min | High | Microsoft.eShopWeb.Web.Pages.Basket .CheckoutModel .GetOrSetBasketCookieAndUserName() |
| Up(MigrationBuilder) | 0% | 6 | 6 | 6min | High | Microsoft.eShopWeb.Infrastructure.Data .Migrations.AddExtraConstraints.Up (MigrationBuilder) |
| Down(MigrationBuilder) | 0% | 6 | 6 | 6min | High | Microsoft.eShopWeb.Infrastructure.Data .Migrations.AddExtraConstraints.Down (MigrationBuilder) |
| OnPost(Dictionary<String,Int32>) | 0% | 5 | 5 | 5min | High | Microsoft.eShopWeb.Web.Pages.Basket .CheckoutModel.OnPost(Dictionary<String ,Int32>) |
| MyAccount() | 0% | 5 | 5 | 5min | High | Microsoft.eShopWeb.Web.Controllers .ManageController.MyAccount() |
| MyOrders() | 0% | 5 | 5 | 5min | High | Microsoft.eShopWeb.Web.Controllers .OrderController.MyOrders() |
| SetBasketModelAsync() | 0% | 4 | 4 | 4min 40s | High | Microsoft.eShopWeb.Web.Pages.Basket .CheckoutModel.SetBasketModelAsync() |
| .ctor(IHttpContextAccessor,LinkGenerator ) | 0% | 3 | 3 | 3min 46s | High | Microsoft.eShopWeb.Web.HealthChecks .ApiHealthCheck..ctor (IHttpContextAccessor,LinkGenerator) |
| GetBrands() | 0% | 3 | 3 | 3min 46s | High | Microsoft.eShopWeb.Web.Services .CachedCatalogViewModelService.GetBrands () |
| GetTypes() | 0% | 3 | 3 | 3min 46s | High | Microsoft.eShopWeb.Web.Services .CachedCatalogViewModelService.GetTypes( ) |
| OnPostUpdate(Dictionary<String,Int32>) | 0% | 3 | 3 | 3min 46s | High | Microsoft.eShopWeb.Web.Pages.Basket .IndexModel.OnPostUpdate(Dictionary <String,Int32>) |
| .ctor(IHttpContextAccessor) | 0% | 2 | 2 | 2min 53s | High | Microsoft.eShopWeb.Web.HealthChecks .HomePageHealthCheck..ctor (IHttpContextAccessor) |
| set_OrderBy(Expression<Func<T,Object>>) | 0% | 1 | 1 | 2min 0s | High | Microsoft.eShopWeb.ApplicationCore .Specifications.BaseSpecification<T> .set_OrderBy(Expression<Func<T,Object>>) |
| set_OrderByDescending(Expression<Func<T ,Object>>) | 0% | 1 | 1 | 2min 0s | High | Microsoft.eShopWeb.ApplicationCore .Specifications.BaseSpecification<T> .set_OrderByDescending(Expression<Func<T ,Object>>) |
| ApplyOrderBy(Expression<Func<T,Object>>) | 0% | 1 | 1 | 2min 0s | High | Microsoft.eShopWeb.ApplicationCore .Specifications.BaseSpecification<T> .ApplyOrderBy(Expression<Func<T,Object>> ) |
| ApplyOrderByDescending(Expression<Func<T ,Object>>) | 0% | 1 | 1 | 2min 0s | High | Microsoft.eShopWeb.ApplicationCore .Specifications.BaseSpecification<T> .ApplyOrderByDescending(Expression<Func <T,Object>>) |
| get_RequestId() | 0% | 1 | 1 | 2min 0s | High | Microsoft.eShopWeb.Web.Pages.ErrorModel .get_RequestId() |
| set_RequestId(String) | 0% | 1 | 1 | 2min 0s | High | Microsoft.eShopWeb.Web.Pages.ErrorModel .set_RequestId(String) |
| get_ShowRequestId() | 0% | 1 | 1 | 2min 0s | High | Microsoft.eShopWeb.Web.Pages.ErrorModel .get_ShowRequestId() |
| OnGet() | 0% | 1 | 1 | 2min 0s | High | Microsoft.eShopWeb.Web.Pages.ErrorModel .OnGet() |
| get_CatalogItemId() | 0% | 1 | 1 | 2min 0s | High | Microsoft.eShopWeb.Web.Pages.Basket .BasketItemViewModel.get_CatalogItemId() |
| get_OldUnitPrice() | 0% | 1 | 1 | 2min 0s | High | Microsoft.eShopWeb.Web.Pages.Basket .BasketItemViewModel.get_OldUnitPrice() |
| set_OldUnitPrice(Decimal) | 0% | 1 | 1 | 2min 0s | High | Microsoft.eShopWeb.Web.Pages.Basket .BasketItemViewModel.set_OldUnitPrice (Decimal) |
| get_BuyerId() | 0% | 1 | 1 | 2min 0s | High | Microsoft.eShopWeb.Web.Pages.Basket .BasketViewModel.get_BuyerId() |
| get_BasketModel() | 0% | 1 | 1 | 2min 0s | High | Microsoft.eShopWeb.Web.Pages.Basket .CheckoutModel.get_BasketModel() |
| set_BasketModel(BasketViewModel) | 0% | 1 | 1 | 2min 0s | High | Microsoft.eShopWeb.Web.Pages.Basket .CheckoutModel.set_BasketModel (BasketViewModel) |
| set_Input(LoginModel+InputModel) | 0% | 1 | 1 | 2min 0s | High | Microsoft.eShopWeb.Web.Areas.Identity .Pages.Account.LoginModel.set_Input (LoginModel+InputModel) |
| get_ExternalLogins() | 0% | 1 | 1 | 2min 0s | High | Microsoft.eShopWeb.Web.Areas.Identity .Pages.Account.LoginModel .get_ExternalLogins() |
| get_Email() | 0% | 1 | 1 | 2min 0s | High | Microsoft.eShopWeb.Web.Areas.Identity .Pages.Account.LoginModel+InputModel .get_Email() |
| set_Email(String) | 0% | 1 | 1 | 2min 0s | High | Microsoft.eShopWeb.Web.Areas.Identity .Pages.Account.LoginModel+InputModel .set_Email(String) |
| get_Password() | 0% | 1 | 1 | 2min 0s | High | Microsoft.eShopWeb.Web.Areas.Identity .Pages.Account.LoginModel+InputModel .get_Password() |
| set_Password(String) | 0% | 1 | 1 | 2min 0s | High | Microsoft.eShopWeb.Web.Areas.Identity .Pages.Account.LoginModel+InputModel .set_Password(String) |
| get_RememberMe() | 0% | 1 | 1 | 2min 0s | High | Microsoft.eShopWeb.Web.Areas.Identity .Pages.Account.LoginModel+InputModel .get_RememberMe() |
| set_RememberMe(Boolean) | 0% | 1 | 1 | 2min 0s | High | Microsoft.eShopWeb.Web.Areas.Identity .Pages.Account.LoginModel+InputModel .set_RememberMe(Boolean) |
| Rule Violated: Methods refactored should be tested |
• Rule Description:
This rule is executed only if a baseline for comparison is defined (diff mode). This rule operates only on methods added or refactored since the baseline.
This rule is executed only if some code coverage data is imported from some code coverage files.
It is important to write code mostly covered by tests to achieve maintainable and non-error-prone code.
In real-world, many code bases are poorly covered by tests. However it is not practicable to stop the development for months to refactor and write tests to achieve high code coverage ratio.
Hence it is recommended that each time a method (or a type) gets refactored, the developer takes the time to write associated unit-tests to cover it.
Doing so will help to increase significantly the maintainability of the code base. You'll notice that quickly, refactoring will also be driven by testability, and as a consequence, the overall code structure and design will increase as well.
Issues of this rule have a High severity because they reflect an actual trend to not care about writing tests on refactored code.
• How to Fix Issues of this Rule: Write unit-tests to cover the code of most methods and classes refactored.
• How to Suppress an Issue of this Rule: In source code, tag the concerned code element with this attribute: [SuppressMessage("NDepend", "ND1602:MethodsRefactoredShouldBeTested", Justification="...")] This attribute requires the compilation symbol CODE_ANALYSIS to be set on each Visual Studio project relying on it. Without CODE_ANALYSIS symbol defined, the attribute is not compiled and the issues are not suppressed.
• How to Fix Issues of this Rule: Write unit-tests to cover the code of most methods and classes refactored.
• How to Suppress an Issue of this Rule: In source code, tag the concerned code element with this attribute: [SuppressMessage("NDepend", "ND1602:MethodsRefactoredShouldBeTested", Justification="...")] This attribute requires the compilation symbol CODE_ANALYSIS to be set on each Visual Studio project relying on it. Without CODE_ANALYSIS symbol defined, the attribute is not compiled and the issues are not suppressed.
4 methods matched
-
Formatting: bold means added, underlined means code was changed,
strike-boldmeans removed (since baseline)
| 4 methods | Percentage Coverage | # lines of code (LOC) | # lines of code not covered | Debt | Severity | Full Name |
|---|---|---|---|---|---|---|
| BuildModel(ModelBuilder) | 0% | 75 | 75 | 10min | High | Microsoft.eShopWeb.Infrastructure.Data .Migrations.CatalogContextModelSnapshot .BuildModel(ModelBuilder) |
| ConfirmEmail(String,String) | 0% | 7 | 7 | 7min | High | Microsoft.eShopWeb.Web.Controllers .AccountController.ConfirmEmail(String ,String) |
| .ctor(String) | 0% | 3 | 3 | 3min 46s | High | Microsoft.eShopWeb.ApplicationCore .Specifications .CustomerOrdersWithItemsSpecification. .ctor(String) |
| SignOut() | 0% | 2 | 2 | 2min 53s | High | Microsoft.eShopWeb.Web.Controllers .AccountController.SignOut() |
| Rule Violated: Assemblies Namespaces and Types should be tested |
• Rule Description:
This rule lists assemblies, namespaces and types that are not covered at all by unit tests.
If a parent is matched its children are not matched. For example if a namespace is matched, its child types are not matched.
This rule goal is not to collide with the Code should be tested rule that lists uncovered code for each method and infer the effort to write unit tests (the Debt) and the annual cost to let the code untested (the Annual Interest).
This rule goal is to inform of large code elements left untested. As a consequence the Debt per issue is only 4 minutes and the severity of the issues is Low.
• How to Fix Issues of this Rule: Write unit and integration tests to cover, even partially, code elements matched by this rule. Then use issues of the rules Code should be tested, New Methods should be tested and Methods refactored should be tested to write more tests where it matters most, and eventually refactor some code to make it more testable.
• How to Suppress an Issue of this Rule: In source code, tag the concerned code element with this attribute: [SuppressMessage("NDepend", "ND1603:AssembliesNamespacesAndTypesShouldBeTested", Justification="...")] This attribute requires the compilation symbol CODE_ANALYSIS to be set on each Visual Studio project relying on it. Without CODE_ANALYSIS symbol defined, the attribute is not compiled and the issues are not suppressed.
• How to Fix Issues of this Rule: Write unit and integration tests to cover, even partially, code elements matched by this rule. Then use issues of the rules Code should be tested, New Methods should be tested and Methods refactored should be tested to write more tests where it matters most, and eventually refactor some code to make it more testable.
• How to Suppress an Issue of this Rule: In source code, tag the concerned code element with this attribute: [SuppressMessage("NDepend", "ND1603:AssembliesNamespacesAndTypesShouldBeTested", Justification="...")] This attribute requires the compilation symbol CODE_ANALYSIS to be set on each Visual Studio project relying on it. Without CODE_ANALYSIS symbol defined, the attribute is not compiled and the issues are not suppressed.
21 code elements parent matched
-
Formatting: bold means added, underlined means code was changed,
strike-boldmeans removed (since baseline)
| 21 code elements parent | # lines of code not covered | Debt | Severity | Full Name |
|---|---|---|---|---|
| Microsoft.eShopWeb.Infrastructure.Data .Migrations | 279 | 4min 0s | Low | Microsoft.eShopWeb.Infrastructure.Data .Migrations |
| Microsoft.eShopWeb.Infrastructure .Identity.Migrations | 190 | 4min 0s | Low | Microsoft.eShopWeb.Infrastructure .Identity.Migrations |
| ManageController | 189 | 4min 0s | Low | Microsoft.eShopWeb.Web.Controllers .ManageController |
| Microsoft.eShopWeb.Web.ViewModels.Manage | 50 | 4min 0s | Low | Microsoft.eShopWeb.Web.ViewModels.Manage |
| CheckoutModel | 27 | 4min 0s | Low | Microsoft.eShopWeb.Web.Pages.Basket .CheckoutModel |
| Microsoft.eShopWeb.Web.HealthChecks | 22 | 4min 0s | Low | Microsoft.eShopWeb.Web.HealthChecks |
| OrderService | 17 | 4min 0s | Low | Microsoft.eShopWeb.ApplicationCore .Services.OrderService |
| OrderController | 15 | 4min 0s | Low | Microsoft.eShopWeb.Web.Controllers .OrderController |
| Microsoft.eShopWeb.ApplicationCore .Entities.BuyerAggregate | 14 | 4min 0s | Low | Microsoft.eShopWeb.ApplicationCore .Entities.BuyerAggregate |
| OrderViewModel | 13 | 4min 0s | Low | Microsoft.eShopWeb.Web.ViewModels .OrderViewModel |
| Microsoft.eShopWeb.Web.Views.Manage | 12 | 4min 0s | Low | Microsoft.eShopWeb.Web.Views.Manage |
| OrderItemViewModel |