OrchardCoreBuilder.cs

SA1629: Documentation text should end with a period
Estimated effort to fix the issue moreDebt:1min  0sIssue severity moreHighRule categoryStyleCop.CSharp.DocumentationRules
Documentation text should end with a period
        public OrchardCoreBuilder Configure(Func<IApplicationBuilder, IEndpointRouteBuilder, IServiceProvider, ValueTask> configureAsync, int order = 0)
 
using System;
using System.Collections.Generic;
using System.Threading.Tasks;
using Microsoft.AspNetCore.Builder;
using Microsoft.AspNetCore.Routing;
using OrchardCore.Environment.Shell.Builders;
using OrchardCore.Environment.Shell.Descriptor.Models;
using OrchardCore.Modules;
​ND1305: Avoid namespaces with few types
Estimated effort to fix the issue moreDebt:5minIssue severity moreLowRule categoryDesign
The namespace Microsoft.Extensions.DependencyInjection contains only the 3 types OrchardCoreBuilder, StartupActions and ServiceCollectionExtensions. To prevent an excessive number of using clauses in client code, refrain from segregating classes into numerous small namespaces.
ND1401: Avoid namespaces dependency cycles
Estimated effort to fix the issue moreDebt:2h  0minIssue severity moreHighRule categoryArchitecture
The 8 namespaces OrchardCore.Modules, OrchardCore.Environment.Cache, OrchardCore.Environment.Shell, OrchardCore.Environment.Shell.Scope, OrchardCore.Environment.Shell.Removing, OrchardCore.Environment.Shell.Builders, OrchardCore.Environment.Shell.Builders.Models and Microsoft.Extensions.DependencyInjection form a dependency cycle: they all depend on each other. This cycle prevents clean layered architecture and reduces maintainability. To fix it, first address all issues stemming from the rule Avoid mutually dependent namespaces. Then read this rule documentation that explains how to use the Dependency Inversion Principle to fix cycles involving 3 or more namespaces.
ND2103: Namespace name should correspond to file location
Estimated effort to fix the issue moreDebt:3min  0sIssue severity moreMediumRule categorySource Files Organization
The source file containing the declaration of the namespace Microsoft.Extensions.DependencyInjection is located in the directory C:/My/NDepend/WebSite/SampleReport/OrchadCore/1.8.0/src/OrchardCore/OrchardCore.Abstractions/Shell/Builders/Extensions that does not align with the namespace name.
ND2104: Types with source files stored in the same directory, should be declared in the same namespace
Estimated effort to fix the issue moreDebt:7minIssue severity moreHighRule categorySource Files Organization
The source files that contain the declarations of the namespace Microsoft.Extensions.DependencyInjection are located in a directory that also contains the class StartupActionsStartup declared in a different namespace. Concerning this type, either change its namespace or its source file's directory.
ND2105: Types declared in the same namespace, should have their source files stored in the same directory
Estimated effort to fix the issue moreDebt:7minIssue severity moreHighRule categorySource Files Organization
The namespace Microsoft.Extensions.DependencyInjection declarations are present in source files spread across multiple directories. class ServiceCollectionExtensions is declared in source files out of C:/My/NDepend/WebSite/SampleReport/OrchadCore/1.8.0/src/OrchardCore/OrchardCore.Abstractions/Modules/Builder.
R#: Namespace does not correspond to file location
Estimated effort to fix the issue moreDebt:1min  0sIssue severity moreMediumRule categoryConstraintViolation
Namespace does not correspond to file location, must be: 'OrchardCore.Modules.Builder'
namespace Microsoft.Extensions.DependencyInjection
{
    public class OrchardCoreBuilder
    {R#: Use preferred style of 'new' expression when created type is evident
Estimated effort to fix the issue moreDebt:1min  0sIssue severity moreLowRule categoryCodeStyleIssues
Redundant type specification
R#: Inconsistent Naming
Estimated effort to fix the issue moreDebt:1min  0sIssue severity moreLowRule categoryConstraintViolation
Name '_actions' does not match rule 'Properties'. Suggested name is 'Actions'.
        private Dictionary<int, StartupActions> _actions { get; } = new Dictionary<int, StartupActions>();
​R#: Convert constructor into primary constructor
New issue introduced since the baselineNewEstimated effort to fix the issue moreDebt:1min  0sIssue severity moreLowRule categoryLanguageUsage
Convert into primary constructor
        public OrchardCoreBuilder(IServiceCollection services)
        {
            ApplicationServices = services;