Don't use System.Reflection in performance critical messages
System.Reflection is slow: don't use it in performance critical messages like Update, FixedUpdate, LateUpdate, or OnGUI.
How to fix
Don't use reflection in matched methods.
CQLinq source
This rule is written in CQLinq, C# LINQ over the NDepend code model. It ships with every new NDepend project: you can read it, adapt it, or use it as a starting point for your own custom rules.
// <Name>Don't use System.Reflection in performance critical messages</Name>
// <Id>ND3208:DontUseSystemReflectionInPerformanceCriticalMessages</Id>
warnif count > 0
let reflectionMembers = Namespaces.WithName("System.Reflection").ChildMembers()
from m in Application.Methods.UsingAny(reflectionMembers) where
m.ParentType.DeriveFrom("UnityEngine.MonoBehaviour".AllowNoMatch()) &&
m.SimpleNameEqualsAny("Update", "FixedUpdate", "LateUpdate", "OnGUI")
let shouldntUse = m.MembersUsed.Intersect(reflectionMembers)
select new {
m,
shouldntUse,
Debt = (5 + 5*shouldntUse.Count()).ToMinutes().ToDebt(),
Severity = Severity.Medium
}
//<Expl>
// The *{0}* shouldn't use *{1}* because
// *Reflection* shouldn't be used in performance critical messages.
//</Expl>
//<Desc>
// *System.Reflection* is slow: don't use it in performance critical
// messages like *Update*, *FixedUpdate*, *LateUpdate*, or *OnGUI*.
//</Desc>
//<HowToFix>
// Don't use reflection in matched methods.
//</HowToFix>
Open in the interactive Rules Explorer · All default rules
API Usage / Unity: all 9 items
- Classes tagged with InitializeOnLoad should have a static constructor ND3200
- Avoid using non-generic GetComponent ND3201
- Avoid empty Unity message ND3202
- Avoid using Time.fixedDeltaTime with Update ND3203
- Use CreateInstance to create a scriptable object ND3204
- The SerializeField attribute is redundant on public fields ND3205
- InitializeOnLoadMethod should tag only static and parameterless methods ND3206
- Prefer using SetPixels32() over SetPixels() ND3207
- Don't use System.Reflection in performance critical messages ND3208